On Thu, 7 Aug 2014 17:10:50 +0800
Jisheng Zhang wrote:
> 2. only one netdev in the system: eth0.
There should also be lo (loopback) at least.
> 4. But NET_RX seems abnormal
> ~ # cat /proc/softirqs
> CPU0 CPU1 CPU2 CPU3
> NET_RX: 445587
from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
Signed-off-by: Dmitry Popov
---
net/ipv4/tcp_ipv4.c | 36 +---
net/ipv6/tcp_ipv6.c | 25 +++--
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
On Wed, 06 Aug 2014 14:52:18 -0700 (PDT)
David Miller wrote:
> From: Dmitry Popov
> Date: Thu, 7 Aug 2014 01:49:53 +0400
>
> > Since a8afca032 (tcp: md5: protects md5sig_info with RCU) tcp_md5_do_lookup
> > doesn't require socket lock, rcu_read_lock is enough. The
from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
Signed-off-by: Dmitry Popov
---
net/ipv4/tcp_ipv4.c | 36 +---
net/ipv6/tcp_ipv6.c | 25 +++--
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
On Tue, 05 Aug 2014 16:27:03 -0700 (PDT)
David Miller wrote:
> > +#ifdef CONFIG_TCP_MD5SIG
> > + /*
> > +* We really want to reject the packet as early as possible
> > +* if:
> > +* o We're expecting an MD5'd packet and this is no MD5 tcp option
> > +* o There is an MD5 option
_{,un}lock_sock:
from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
Signed-off-by: Dmitry Popov
---
net/ipv4/tcp_ipv4.c | 36 +---
net/ipv6/tcp_ipv6.c | 25 +++--
2 files changed, 44 insertions(+), 17 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp
On Wed, 30 Jul 2014 16:21:26 +0800
Zhouyi Zhou wrote:
> I think it is useful to add ttl option for pktgen, for example
> if a some ISP want to test its network quality, it could set
> ttl so that the tested links get the packet while end users won't
> get it.
It seems you're missing
--- a/ne
On Tue, 08 Jul 2014 15:12:10 -0700 (PDT)
David Miller wrote:
> From: Dmitry Popov
> Date: Sat, 5 Jul 2014 02:26:37 +0400
>
> > @@ -205,6 +207,8 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net
> > *itn,
> >
> > hlist_for_each_entry_rcu(t, head
mode gre dev eth0
wouldn't be ever matched if it was created before explicit tunnel like above.
All this stuff happened because while looking for a wildcard tunnel we didn't
check that matched tunnel is a wildcard one. Fixed.
Signed-off-by: Dmitry Popov
---
net/ipv4/ip_tunnel.c | 12 +
On Wed, 11 Jun 2014 15:09:14 +0400
Dmitry Popov wrote:
>
> Since VTI_ISVTI is always used with ip_tunnel_parm->i_flags (which is __be16),
> we can __force cast VTI_ISVTI to __be16 in header file.
>
If this patch is okay I will submit it to iproute2 too. if_tunnel.h has to b
ip_tunnel_parm->i_flags (which is __be16),
we can __force cast VTI_ISVTI to __be16 in header file.
Signed-off-by: Dmitry Popov
---
include/uapi/linux/if_tunnel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux/if_tunnel.h
index aee7
ms' i_keys.
Example bug:
ip link add type vti ikey 1 local 1.0.0.1 remote 2.0.0.2
ip link add type vti ikey 2 local 1.0.0.1 remote 2.0.0.2
spawned two tunnels, although it doesn't make sense.
Signed-off-by: Dmitry Popov
---
net/ipv4/ip_tunnel.c | 5 +++--
1 file changed, 3 insertions(+),
o think about [io]_mark
field for ip_tunnel_parm in the future.
Signed-off-by: Dmitry Popov
---
net/ipv4/ip_tunnel.c | 10 ++
net/ipv4/ip_vti.c| 8 +++-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 2acc233..0
On Sun, 08 Jun 2014 01:55:22 +0400
Sergei Shtylyov wrote:
> Please surround & with spaces for consistency; this also would follow the
> general kernel coding style.
> WBR, Sergei
>
Okay, original code was without spaces, didn't want to break this, I will
resend.
--
To unsubscribe from th
o think about [io]_mark
field for ip_tunnel_parm in the future.
Signed-off-by: Dmitry Popov
---
net/ipv4/ip_tunnel.c | 10 ++
net/ipv4/ip_vti.c| 8 +++-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 2acc233..0
On Sat, 7 Jun 2014 19:54:12 +0400
Dmitry Popov wrote:
> 3) gre:
> ipgre is a framework for subprotos which doesn't work with tunnel devices by
> itself (see net/ipv4/gre_demux.c:gre_cisco_err). Although it uses
> skb->dev->ifindex for ipv4_{update_pmtu,redirect} w
On Fri, 6 Jun 2014 17:45:44 -0700
Cong Wang wrote:
> I think vti (v4 and v6) tunnel needs to fix as well?
1) vti:
Well, probably it needs a fix, but:
a) I don't know a scenario when vti4_err would be called, ah4/esp4/ipcomp4
should handle icmp errors. vti_err was removed in aba826958830 but (don
ipv4_{update_pmtu,redirect} were called with tunnel's ifindex (t->dev is a
tunnel netdevice). It caused wrong route lookup and failure of pmtu update or
redirect. We should use the same ifindex that we use in ip_route_output_* in
*tunnel_xmit code. It is t->parms.link .
Signed-off
On Fri, 6 Jun 2014 22:51:17 +0400
Dmitry Popov wrote:
> ipv4_{update_pmtu,redirect) were called with tunnel's ifindex (t->dev is a
Should be read as
ipv4_{update_pmtu,redirect} ...
I will resubmit the patch, sorry. :(
--
To unsubscribe from this list: send the line "unsubscr
ipv4_{update_pmtu,redirect) were called with tunnel's ifindex (t->dev is a
tunnel netdevice). It caused wrong route lookup and failure of pmtu update or
redirect. We should use the same ifindex that we use in ip_route_output_* in
*tunnel_xmit code. It is t->parms.link .
Signed-off
ip_rt_put(rt) is always called in "error" branches above, but was missed in
skb_cow_head branch. As rt is not yet bound to skb here we have to release it
by
hand.
Signed-off-by: Dmitry Popov
---
net/ipv4/ip_tunnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_
Remove declaration, 4 defines and confusing comment that are no longer used
since 1a2c6181c4 ("tcp: Remove TCPCT").
Signed-off-by: Dmitry Popov
---
include/linux/tcp.h | 1 -
include/net/tcp.h | 4
net/ipv4/tcp.c | 4
3 files changed, 9 deletions(-)
diff --git a/inc
ts may take the wrong path.
Signed-off-by: Dmitry Popov
---
net/ipv4/syncookies.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index ef54377..397e0f6 100644
--- a/net/ipv4/syncookies.c
+++ b/net/ipv4/syncookies.c
@@ -349,8
ts may take the wrong path.
Signed-off-by: Dmitry Popov
---
net/ipv4/syncookies.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index ef54377..397e0f6 100644
--- a/net/ipv4/syncookies.c
+++ b/net/ipv4/syncookies.c
@@ -349,8
ackets may take wrong path. There is no such bug
in ipv6 code and non-cookie code (usual case). Bugfix below.
Signed-off-by: Dmitry Popov
---
net/ipv4/syncookies.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index ef54377..397
25 matches
Mail list logo
