RE: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-04-15 Thread Don.Brace
-Original Message- From: Martin K. Petersen Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide > Some of the structs contain `atomic_t` values and are not intended to > be sent to IO controller as is. > > The change adds __packed to every struct and

RE: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-24 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gentoo.org] Subject: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment) The failure initially observed as boot failure on rx3600 ia64 machine with RAID bus controller: Hewlett-Packard Company Smart Array P600: kernel

RE: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-17 Thread Don.Brace
-Original Message- From: David Laight [mailto:david.lai...@aculab.com] Subject: RE: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment) From: Martin K. Petersen > Sent: 17 March 2021 02:26 > > Arnd, > > > Actually that still feels wrong: the annotation of the struct is to > > pack every

RE: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-16 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gentoo.org] Subject: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment) The failure initially observed as boot failure on rx3600 ia64 machine with RAID bus controller: Hewlett-Packard Company Smart Array P600: kernel

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-05 Thread Don.Brace
-Original Message- From: Arnd Bergmann [mailto:a...@kernel.org] Sent: Friday, March 5, 2021 7:32 AM Subject: Re: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600 On Fri, Mar 5, 2021 at 10:24 AM Geert Uytterhoeven wrote: >

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-04 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gmail.com] Sent: Wednesday, March 3, 2021 4:04 PM To: Don Brace - C33706 Cc: glaub...@physik.fu-berlin.de; storagedev ; linux-s...@vger.kernel.org; linux-i...@vger.kernel.org; linux-kernel@vger.kernel.org; jszcz...@redhat.com;

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-03 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gmail.com] Sent: Wednesday, March 3, 2021 2:56 AM To: John Paul Adrian Glaubitz ; Don Brace - C33706 ; storagedev ; linux-s...@vger.kernel.org Cc: linux-i...@vger.kernel.org; linux-kernel@vger.kernel.org; Joe Szczypek ; Scott

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-03 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gmail.com] Sent: Tuesday, March 2, 2021 6:23 PM To: John Paul Adrian Glaubitz ; Don Brace - C33706 Cc: linux-i...@vger.kernel.org; linux-kernel@vger.kernel.org; Joe Szczypek ; Scott Benesh - C33703 ; Scott Teel - C33730 ;

RE: [PATCH v4 20/29] scsi: hpsa: use generic power management

2020-11-04 Thread Don.Brace
-Original Message- Switch to the new generic framework by updating function signatures and define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove unnecessary calls to the PCI Helper functions along with the legacy .suspend & .resume bindings. Signed-off-by: Vaibhav

RE: [PATCH v3 19/28] scsi: hpsa: use generic power management

2020-10-27 Thread Don.Brace
-Original Message- From: Vaibhav Gupta [mailto:vaibhavgupt...@gmail.com] Sent: Thursday, October 1, 2020 7:25 AM To: Bjorn Helgaas ; Bjorn Helgaas ; Bjorn Helgaas ; Vaibhav Gupta ; Adam Radford ; James E.J. Bottomley ; Martin K. Petersen ; Adaptec OEM Raid Solutions ; Hannes Reinecke

RE: [PATCH v3] scsi: hpsa: fix memory leak in hpsa_init_one

2020-10-27 Thread Don.Brace
-Original Message- From: Keita Suzuki [mailto:keitasuzuki.p...@sslab.ics.keio.ac.jp] Sent: Tuesday, October 27, 2020 2:31 AM Cc: keitasuzuki.p...@sslab.ics.keio.ac.jp; takaf...@sslab.ics.keio.ac.jp; Don Brace ; James E.J. Bottomley ; Martin K. Petersen ; esc.storage...@microsemi.com;

RE: Linux 5.9: smartpqi: controller is offline: status code 0x6100c

2020-10-16 Thread Don.Brace
The 6100C lockup is the result of the controller running out of commands to process new incoming requests from the driver. We are actively looking into this issue. We will keep you posted, Thanks, Don -Original Message- From: Paul Menzel [mailto:pmen...@molgen.mpg.de] Sent: Wednesday,

RE: [PATCH v8 00/18] blk-mq/scsi: Provide hostwide shared tags for SCSI HBAs

2020-09-21 Thread Don.Brace
Subject: Re: [PATCH v8 00/18] blk-mq/scsi: Provide hostwide shared tags for SCSI HBAs >>Hi Jens, >>I'm waiting on the hpsa and smartpqi patches >>update, so please kindly merge >>only those >>patches, above. >>Thanks! John, the hpsa driver crashes, the or more patches to allow internal

RE: [PATCH v2 11/15] scsi: hpsa: use generic power management

2020-07-20 Thread Don.Brace
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers. With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs. Change function parameter in both

RE: [PATCHES] uaccess hpsa

2020-06-03 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Al Viro Sent: Friday, May 29, 2020 6:39 PM To: Linus Torvalds Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; Don Brace ; linux-s...@vger.kernel.org Subject:

RE: UBSAN: array-index-out-of-bounds in drivers/scsi/hpsa.c:4421:7

2020-05-28 Thread Don.Brace
Working on this. Can you send your configuration? ssacli controller all show config detail -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Qian Cai Sent: Tuesday, May 26, 2020 10:19 AM To: Don Brace Cc: Martin K. Petersen

RE: [PATCH] scsi: smartpqi: properly set both the DMA mask and the coherent DMA mask in pqi_pci_init()

2019-05-23 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Lendacky, Thomas Sent: Thursday, May 23, 2019 9:45 AM To: Lianbo Jiang ; linux-kernel@vger.kernel.org Cc: don.br...@microsemi.com; j...@linux.ibm.com;

RE: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev

2019-05-23 Thread Don.Brace
Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Colin King Sent: Wednesday, May 22, 2019 3:39 AM To: Don Brace ; James E . J . Bottomley ; Martin K . Petersen ; esc.storage...@microsemi.com; linux-s...@vger.kernel.org Cc:

RE: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-03-05 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Erwan Velu Sent: Friday, March 1, 2019 10:08 AM Cc: Erwan Velu ; Don Brace ; James E.J. Bottomley ; Martin K. Petersen ; open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER

RE: [PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-28 Thread Don.Brace
Clang warns several times in the scsi subsystem (trimmed for brevity): drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to switch condition type (2147762695 to 18446744071562347015) [-Wswitch] case CCISS_GETBUSTYPES: ^ drivers/scsi/hpsa.c:6208:7:

RE: [PATCH] scsi: hpsa: clean up two indentation issues

2019-01-28 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Colin King Sent: Tuesday, January 22, 2019 9:19 AM To: Don Brace ; James E . J . Bottomley ; Martin K . Petersen ; esc.storage...@microsemi.com; linux-s...@vger.kernel.org

RE: [PATCH] scsi: smartpqi_init: fix boolean expression in pqi_device_remove_start

2019-01-03 Thread Don.Brace
-Original Message- From: Gustavo A. R. Silva [mailto:gust...@embeddedor.com] Sent: Thursday, January 3, 2019 10:48 AM To: Mahesh Rajashekhara ; Don Brace ; James E.J. Bottomley ; Martin K. Petersen Cc: esc.storage...@microsemi.com; linux-s...@vger.kernel.org;

RE: [PATCH] scsi: smartpqi: call pqi_free_interrupts() in pqi_shutdown()

2018-12-20 Thread Don.Brace
-Original Message- From: Yanjiang Jin [mailto:yanjiang@hxt-semitech.com] Sent: Thursday, December 20, 2018 2:33 AM To: don.br...@microsemi.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; yanjiang@hxt-semitech.com Cc: yu.zh...@hxt-semitech.com; jinyanji...@gmail.com;

RE: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

2018-12-17 Thread Don.Brace
-Original Message- From: Ivan Mironov [mailto:mironov.i...@gmail.com] Sent: Friday, December 14, 2018 2:30 PM To: Don Brace - C33706 ; linux-s...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; don.br...@microsemi.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com;

RE: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

2018-12-14 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Ivan Mironov Sent: Friday, December 14, 2018 7:21 AM To: linux-s...@vger.kernel.org; mironov.i...@gmail.com Cc: linux-kernel@vger.kernel.org; Don Brace ; James E.J. Bottomley

RE: [PATCH v2] scsi: Use vmemdup_user to replace the open code

2018-08-13 Thread Don.Brace
> -Original Message- > From: zhong jiang [mailto:zhongji...@huawei.com] > Sent: Monday, August 13, 2018 7:43 AM > To: don.br...@microsemi.com; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH v2] scsi: Use vmemdup_user to replace

RE: [PATCH v2] scsi: Use vmemdup_user to replace the open code

2018-08-13 Thread Don.Brace
> -Original Message- > From: zhong jiang [mailto:zhongji...@huawei.com] > Sent: Monday, August 13, 2018 7:43 AM > To: don.br...@microsemi.com; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH v2] scsi: Use vmemdup_user to replace