[PATCH] net/ipv4: fix the conditions of entering TCP_CA_Disorder state

2013-08-05 Thread Dong Fang
. */ if (tp->lost_out) return true; //... } when it return true, the following condition will be failed: //... if (!tcp_time_to_recover(sk, flag)) { tcp_try_to_open(sk, flag, prior_unsacked); return; } //... Signed-off-by: Dong Fang --- net/ipv4/tcp_inpu

[PATCH] net/ipv4: fix the conditions of entering TCP_CA_Disorder state

2013-08-05 Thread Dong Fang
. */ if (tp-lost_out) return true; //... } when it return true, the following condition will be failed: //... if (!tcp_time_to_recover(sk, flag)) { tcp_try_to_open(sk, flag, prior_unsacked); return; } //... Signed-off-by: Dong Fang yp.fangd...@gmail.com --- net

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-30 Thread Dong Fang
On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non-native English speakers the patch submitter thought his patch was dropped. Also mailing lists

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-30 Thread Dong Fang
On 07/30/2013 01:01 AM, Jeff Liu wrote: Hi Dong, On 07/31/2013 12:00 AM, Dong Fang wrote: On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-30 Thread Dong Fang
On 07/30/2013 01:01 AM, Jeff Liu wrote: Hi Dong, On 07/31/2013 12:00 AM, Dong Fang wrote: On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-30 Thread Dong Fang
On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non-native English speakers the patch submitter thought his patch was dropped. Also mailing lists

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-29 Thread Dong Fang
On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non-native English speakers the patch submitter thought his patch was dropped. Also mailing lists

Re: [PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-29 Thread Dong Fang
On 07/29/2013 04:06 AM, Dan Carpenter wrote: Oh. It appears that nothing changed between v1 and v2. Only the CC list. It's probably that the list moderation on ocfs2-devel was confusing for non-native English speakers the patch submitter thought his patch was dropped. Also mailing lists

[PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-26 Thread Dong Fang
Signed-off-by: Dong Fang --- fs/ocfs2/cluster/heartbeat.c | 14 +- fs/ocfs2/dlm/dlmast.c|8 +++- fs/ocfs2/dlm/dlmcommon.h |4 +--- fs/ocfs2/dlm/dlmconvert.c| 11 +++ fs/ocfs2/dlm/dlmdebug.c | 15 --- fs/ocfs2/dlm/dlmdomain.c

[PATCH] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-26 Thread Dong Fang
Signed-off-by: Dong Fang --- fs/ocfs2/cluster/heartbeat.c | 14 +- fs/ocfs2/dlm/dlmast.c|8 +++- fs/ocfs2/dlm/dlmcommon.h |4 +--- fs/ocfs2/dlm/dlmconvert.c| 11 +++ fs/ocfs2/dlm/dlmdebug.c | 15 --- fs/ocfs2/dlm/dlmdomain.c

[PATCH] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-26 Thread Dong Fang
Signed-off-by: Dong Fang yp.fangd...@gmail.com --- fs/ocfs2/cluster/heartbeat.c | 14 +- fs/ocfs2/dlm/dlmast.c|8 +++- fs/ocfs2/dlm/dlmcommon.h |4 +--- fs/ocfs2/dlm/dlmconvert.c| 11 +++ fs/ocfs2/dlm/dlmdebug.c | 15 --- fs

[PATCH v2] fs/ocfs2: use list_for_each_entry() instead of list_for_each()

2013-07-26 Thread Dong Fang
Signed-off-by: Dong Fang yp.fangd...@gmail.com --- fs/ocfs2/cluster/heartbeat.c | 14 +- fs/ocfs2/dlm/dlmast.c|8 +++- fs/ocfs2/dlm/dlmcommon.h |4 +--- fs/ocfs2/dlm/dlmconvert.c| 11 +++ fs/ocfs2/dlm/dlmdebug.c | 15 --- fs

Re: [PATCH v2] kprobes: fix compiler warning

2013-07-13 Thread Dong Fang
On 07/01/2013 10:46 AM, Dong Fang wrote: Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function 'register_kprobe': kernel/kprobes.c:1493: warning: 'probed_mod' may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel/kprobes.c

Re: [PATCH v2] kprobes: fix compiler warning

2013-07-13 Thread Dong Fang
On 07/01/2013 10:46 AM, Dong Fang wrote: Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function 'register_kprobe': kernel/kprobes.c:1493: warning: 'probed_mod' may be used uninitialized in this function Signed-off-by: Dong Fang yp.fangd...@gmail.com

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 02:11 AM, Dong Fang wrote: On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. NAK. These functions exist

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 12:15 AM, Gu Zheng wrote: On 07/01/2013 08:19 PM, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. Maybe the title "[PATCH] vfs: r

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 12:15 AM, Gu Zheng wrote: On 07/01/2013 08:19 PM, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. Maybe the title [PATCH] vfs: remove

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. NAK. These functions exist

Re: [PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-02 Thread Dong Fang
On 07/02/2013 02:11 AM, Dong Fang wrote: On 07/02/2013 12:41 AM, Al Viro wrote: On Mon, Jul 01, 2013 at 08:19:03AM -0400, Dong Fang wrote: These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have

Re: [PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
On 07/01/2013 10:33 AM, Dong Fang wrote: Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel

[PATCH v2] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function 'register_kprobe': kernel/kprobes.c:1493: warning: 'probed_mod' may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel/kprobes.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang --- kernel/kprobes.c |2 +- 1 files changed, 1 insertions

Re: [PATCH] seq_file:update file->f_pos when lseek() to m->read_pos

2013-07-01 Thread Dong Fang
On 06/29/2013 05:11 AM, Jiaxing Wang wrote: After pread(), file->f_pos and m->read_pos get different, and lseek() to m->read_pos did not update file->f_pos, then a subsequent read may read from a wrong position, the following program shows the problem: char str1[32] = { 0 }; char

[PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Dong Fang
These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. Signed-off-by: Dong Fang --- fs/inode.c | 134 1 files changed

[PATCH] vfs: remove the unnecessrary code of fs/inode.c

2013-07-01 Thread Dong Fang
These functions, such as find_inode_fast() and find_inode(), iget_lock() and iget5_lock(), insert_inode_locked() and insert_inode_locked4(), almost have the same code. Signed-off-by: Dong Fang yp.fangd...@gmail.com --- fs/inode.c | 134

Re: [PATCH] seq_file:update file-f_pos when lseek() to m-read_pos

2013-07-01 Thread Dong Fang
On 06/29/2013 05:11 AM, Jiaxing Wang wrote: After pread(), file-f_pos and m-read_pos get different, and lseek() to m-read_pos did not update file-f_pos, then a subsequent read may read from a wrong position, the following program shows the problem: char str1[32] = { 0 }; char str2[32]

[PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang yp.fangd...@gmail.com --- kernel/kprobes.c |2 +- 1 files

[PATCH v2] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function 'register_kprobe': kernel/kprobes.c:1493: warning: 'probed_mod' may be used uninitialized in this function Signed-off-by: Dong Fang yp.fangd...@gmail.com --- kernel/kprobes.c |2 +- 1 files changed

Re: [PATCH] kprobes: fix compiler warning

2013-07-01 Thread Dong Fang
On 07/01/2013 10:33 AM, Dong Fang wrote: Fix the following compiler warning of uninitialized variable kernel/kprobes.c: In function ‘register_kprobe’: kernel/kprobes.c:1493: warning: ‘probed_mod’ may be used uninitialized in this function Signed-off-by: Dong Fang yp.fangd...@gmail.com