Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Dongchun Zhu
Hi Andy, On Thu, 2020-12-03 at 20:10 +0200, Andy Shevchenko wrote: > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > wrote: > > > Static analysis on linux-next with Coverity has detected an issue with > > the following commit: > > If you want to fix it properly, see my comments below... > >

Re: [PATCH] media: i2c: fix an uninitialized error code

2020-12-03 Thread Dongchun Zhu
Hi Arnd, Thanks for the patch. On Thu, 2020-12-03 at 23:29 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Clang points out that the error handling in ov02a10_s_stream() is > broken, and just returns a random error code: > > drivers/media/i2c/ov02a10.c:537:6: warning: variable 'ret' is

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Dongchun Zhu
Hi Sakari, On Tue, 2020-11-24 at 10:43 +0200, Sakari Ailus wrote: > Hi Dongchun, > > On Tue, Nov 24, 2020 at 03:40:51PM +0800, Dongchun Zhu wrote: > > > static const struct ov8856_mode supported_modes[] = { > > > - { > > > - .width =

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-23 Thread Dongchun Zhu
Hi Robert, Thanks for the patch. On Mon, 2020-11-16 at 16:50 +0100, Robert Foss wrote: > Remove the 3280x2464 mode as it can't be reproduced and yields > an output resolution of 3264x2448 instead of the desired one. > > Furthermore the 3264x2448 resolution is the highest resolution > that the

Re: [PATCH v10 1/3] media: dt-bindings: ov8856: Document YAML bindings

2020-05-05 Thread Dongchun Zhu
Hi Robert, Thanks for the update. On Tue, 2020-05-05 at 12:01 +0200, Robert Foss wrote: > From: Dongchun Zhu > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu > Signed-off-by: Robert Foss