Re: [jet.c...@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!]

2014-05-28 Thread Dongsu Park
Hi, On 27.05.2014 13:24, Maurizio Lombardi wrote: On Tue, May 27, 2014 at 10:43:59AM +0200, Maurizio Lombardi wrote: But now I'm suspicious of this part of commit 3979ef4dcf: failed: bvec-bv_page = NULL; bvec-bv_len = 0; bvec-bv_offset = 0;

[PATCH] bio: decrease bi_iter.bi_size by len in the fail path

2014-05-28 Thread Dongsu Park
From: Dongsu Park dongsu.p...@profitbricks.com Commit 3979ef4dcf3d1de55a560a3a4016c30a835df44d (bio-modify- __bio_add_page-to-accept-pages-that-dont-start-a-new-segment-v3) introduced a regression as reported by Jet Chen. That results in a kernel BUG at drivers/block/virtio_blk.c:166. To fix

Re: [RFC] Tux3 for review

2014-05-22 Thread Dongsu Park
Hi, On 19.05.2014 17:55, Daniel Phillips wrote: > On 05/18/2014 04:55 PM, Dave Chinner wrote: > >On Fri, May 16, 2014 at 05:50:59PM -0700, Daniel Phillips wrote: > >>We would like to offer Tux3 for review for mainline merge. We have > >>prepared a new repository suitable for pulling: > >> >

Re: [RFC] Tux3 for review

2014-05-22 Thread Dongsu Park
Hi, On 19.05.2014 17:55, Daniel Phillips wrote: On 05/18/2014 04:55 PM, Dave Chinner wrote: On Fri, May 16, 2014 at 05:50:59PM -0700, Daniel Phillips wrote: We would like to offer Tux3 for review for mainline merge. We have prepared a new repository suitable for pulling:

Re: [PATCH v5 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-02-19 Thread Dongsu Park
> + return -EINVAL; > + > + /* Its safe to start updating extents */ .. Apart from that, the whole patchset seems to work without error, both on xfs and on ext4. Of course I had to remove Lukas' patches before testing collapse-range. So it would be excellent if t

Re: [PATCH v5 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-02-19 Thread Dongsu Park
... Apart from that, the whole patchset seems to work without error, both on xfs and on ext4. Of course I had to remove Lukas' patches before testing collapse-range. So it would be excellent if two patch series could get somehow merged. Tested-by: Dongsu Park dongsu.p...@profitbricks.com Regards, Dongsu

[PATCH] perf: define LIBLOCKDEP_LIBS to fix linker errors

2013-02-21 Thread Dongsu Park
in-sched.o: In function `liblockdep_pthread_mutex_unlock': /linux/tools/perf/../lib/lockdep/include/liblockdep/mutex.h:48: undefined reference to `lock_release' Signed-off-by: Dongsu Park Cc: Sasha Levin --- tools/perf/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/per

[PATCH] perf: define LIBLOCKDEP_LIBS to fix linker errors

2013-02-21 Thread Dongsu Park
`liblockdep_pthread_mutex_unlock': /linux/tools/perf/../lib/lockdep/include/liblockdep/mutex.h:48: undefined reference to `lock_release' Signed-off-by: Dongsu Park dongsu.p...@profitbricks.com Cc: Sasha Levin sasha.le...@oracle.com --- tools/perf/Makefile | 3 ++- 1 file changed, 2 insertions

[PATCH 1/5] ib_srp: free memory correctly in srp_free_iu()

2012-08-31 Thread dongsu . park
From: Dongsu Park As a potential fix for a race condition in srp_free_iu(), hold a mutex in srp_free_target_ib() before calling srp_free_iu(). In addition, also clear rx/tx ring after freeing memory. Both rx_ring[] and tx_ring[] should be reinitialized to NULL, to prevent other tasks from

[PATCH 2/5] ib_srp: removed superfluous warning in send timeout case

2012-08-31 Thread dongsu . park
From: Dongsu Park Signed-off-By: Sebastian Riemer --- drivers/infiniband/ulp/srp/ib_srp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index a0d0ca2..1b274484 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b

[PATCH 5/5] ib_srp: fix an error accessing invalid memory in rport_dev_loss_timedout

2012-08-31 Thread dongsu . park
From: Bart Van Assche In rport_dev_loss_timedout(), rport must be obtained by accessing the member entry dev_loss_work, not fast_io_fail_work. Signed-off-By: Bart Van Assche --- drivers/scsi/scsi_transport_srp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/5] ib_srp: check if rport->lld_data is NULL before removing rport

2012-08-31 Thread dongsu . park
From: Dongsu Park After removing rport_delete(), rport->lld_data has to be set to NULL. In addition to that, both srp_rport_delete() and rport_dev_loss_timedout() must check if rport->lld_data is NULL, before accessing to rport->lld_data or any rport's target area. Without t

[PATCH 3/5] ib_srp: hold a mutex when adding a new target port

2012-08-31 Thread dongsu . park
From: Dongsu Park Unter circumstances, srp_rport_add() can make conflicts with srp_rport_delete(), dumping the call trace written below. That does not always occur. But its possible reason is adding sysfs entries for the SRP target too fast, even before the deletion hasn't finished yet

[PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

2012-08-31 Thread dongsu . park
From: Dongsu Park Hi Bart, This patchset aims at fixing bugs that have been discovered in our own SRP test environment so far. These patches are based on your patchset v4, "Make ib_srp better suited for H.A. purposes",(09 Aug 2012). The 5th patch, "fix an error accessing

[PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

2012-08-31 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com Hi Bart, This patchset aims at fixing bugs that have been discovered in our own SRP test environment so far. These patches are based on your patchset v4, Make ib_srp better suited for H.A. purposes,(09 Aug 2012). The 5th patch, fix an error

[PATCH 3/5] ib_srp: hold a mutex when adding a new target port

2012-08-31 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com Unter circumstances, srp_rport_add() can make conflicts with srp_rport_delete(), dumping the call trace written below. That does not always occur. But its possible reason is adding sysfs entries for the SRP target too fast, even before the deletion

[PATCH 4/5] ib_srp: check if rport-lld_data is NULL before removing rport

2012-08-31 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com After removing rport_delete(), rport-lld_data has to be set to NULL. In addition to that, both srp_rport_delete() and rport_dev_loss_timedout() must check if rport-lld_data is NULL, before accessing to rport-lld_data or any rport's target area

[PATCH 5/5] ib_srp: fix an error accessing invalid memory in rport_dev_loss_timedout

2012-08-31 Thread dongsu . park
From: Bart Van Assche bvanass...@acm.org In rport_dev_loss_timedout(), rport must be obtained by accessing the member entry dev_loss_work, not fast_io_fail_work. Signed-off-By: Bart Van Assche bvanass...@acm.org --- drivers/scsi/scsi_transport_srp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/5] ib_srp: removed superfluous warning in send timeout case

2012-08-31 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com Signed-off-By: Sebastian Riemer sebastian.rie...@profitbricks.com --- drivers/infiniband/ulp/srp/ib_srp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index a0d0ca2

[PATCH 1/5] ib_srp: free memory correctly in srp_free_iu()

2012-08-31 Thread dongsu . park
From: Dongsu Park dongsu.p...@profitbricks.com As a potential fix for a race condition in srp_free_iu(), hold a mutex in srp_free_target_ib() before calling srp_free_iu(). In addition, also clear rx/tx ring after freeing memory. Both rx_ring[] and tx_ring[] should be reinitialized to NULL

<    1   2   3