RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-10 Thread Du, Wenkai
> -Original Message- > From: Westerberg, Mika > Sent: Thursday, April 10, 2014 2:08 AM > To: Du, Wenkai > Cc: One Thousand Gnomes; linux-...@vger.kernel.org; Wolfram Sang; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c

[PATCH V2] i2c-designware: Mask all interrupts during i2c controller enable

2014-04-10 Thread Du, Wenkai
Hi all, Updated problem descriptions from Mika's feedback and new test data: There have been "i2c_designware 80860F41:00: controller timed out" errors on a number of Baytrail platforms. The issue is caused by incorrect value in Interrupt Mask Register (DW_IC_INTR_MASK) when i2c core is being en

RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-09 Thread Du, Wenkai
> -Original Message- > From: Westerberg, Mika > Sent: Tuesday, April 08, 2014 3:30 AM > To: Du, Wenkai > Cc: One Thousand Gnomes; linux-...@vger.kernel.org; Wolfram Sang; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c

RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-07 Thread Du, Wenkai
> -Original Message- > From: Westerberg, Mika > Sent: Monday, April 07, 2014 8:11 AM > To: One Thousand Gnomes > Cc: Du, Wenkai; linux-...@vger.kernel.org; Wolfram Sang; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c

RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-04 Thread Du, Wenkai
>Interrupt masking is done already after each transaction. At end of transfer, the code uses __i2c_dw_enable(dev, false) to disable adapter. This function doesn't mask interrupts. There is another function i2c_dw_disable that masks and clears interrupts. This could be used, but that means we ne

RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-04 Thread Du, Wenkai
, Mika Sent: Friday, April 04, 2014 11:16 AM To: Du, Wenkai Cc: linux-...@vger.kernel.org; Wolfram Sang; linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable On Fri, Apr 04, 2014 at 08:05:23PM +0300, Du, Wenkai wrote: > diff --git a/drivers

[PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-04 Thread Du, Wenkai
Hi all, There were "i2c_designware 80860F41:00: controller timed out" errors on a number of Baytrail platforms. They typically occurred during suspend resume where some short i2c transfers were exchanged with devices. And they mostly occurred when using fast mode, not standard mode. The cause of