Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec

2016-04-18 Thread Dylan Reid
> > This seems like it's only half the job and worryingly close to Linux > internals. In particular the fact that the binding is specific to > simple-card and the fact that it's being placed on the CODEC (rather > than a separate object that the CODEC references) so that we can't >

Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec

2016-04-18 Thread Dylan Reid
nly half the job and worryingly close to Linux > internals. In particular the fact that the binding is specific to > simple-card and the fact that it's being placed on the CODEC (rather > than a separate object that the CODEC references) so that we can't > combine multiple de

Re: [alsa-devel] [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-19 Thread Dylan Reid
On Tue, May 19, 2015 at 4:16 AM, Mark Brown wrote: > On Fri, May 15, 2015 at 10:40:59PM +0200, Lars-Peter Clausen wrote: > >> I think the proper way to support this is come up with the concept of jack >> detection providers and consumers. A component can register a jack detection >> provider just

Re: [alsa-devel] [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-19 Thread Dylan Reid
On Tue, May 19, 2015 at 4:16 AM, Mark Brown broo...@kernel.org wrote: On Fri, May 15, 2015 at 10:40:59PM +0200, Lars-Peter Clausen wrote: I think the proper way to support this is come up with the concept of jack detection providers and consumers. A component can register a jack detection

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-13 Thread Dylan Reid
On Wed, May 13, 2015 at 10:21 AM, Dylan Reid wrote: > On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: >> On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: >>> On 2015年05月13日 03:22, Mark Brown wrote: >> >>> >Is it not possible to extend simple card

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-13 Thread Dylan Reid
On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: > On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: >> On 2015年05月13日 03:22, Mark Brown wrote: > >> >Is it not possible to extend simple card to handle your use cases? >> >Given the very generic naming and the fact that things like jack

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-13 Thread Dylan Reid
On Wed, May 13, 2015 at 10:21 AM, Dylan Reid dgr...@chromium.org wrote: On Wed, May 13, 2015 at 9:42 AM, Mark Brown broo...@kernel.org wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote: Is it not possible to extend simple card to handle

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

2015-05-13 Thread Dylan Reid
On Wed, May 13, 2015 at 9:42 AM, Mark Brown broo...@kernel.org wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote: Is it not possible to extend simple card to handle your use cases? Given the very generic naming and the fact that things

Re: [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone switch

2015-01-28 Thread Dylan Reid
On Wed, Jan 28, 2015 at 3:02 AM, Mark Brown wrote: > On Wed, Jan 28, 2015 at 11:51:04AM +0100, Tomeu Vizoso wrote: > >> To be used by userspace when the headphones jack is plugged in. > >> static const struct snd_kcontrol_new tegra_max98090_controls[] = { >> +

Re: [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone switch

2015-01-28 Thread Dylan Reid
On Wed, Jan 28, 2015 at 3:02 AM, Mark Brown broo...@kernel.org wrote: On Wed, Jan 28, 2015 at 11:51:04AM +0100, Tomeu Vizoso wrote: To be used by userspace when the headphones jack is plugged in. static const struct snd_kcontrol_new tegra_max98090_controls[] = { +

Re: [PATCH v2 03/11] ARM: tegra: Set the sound card model that alsaucm expects

2015-01-20 Thread Dylan Reid
On Mon, Jan 19, 2015 at 9:11 AM, Tomeu Vizoso wrote: > On 19 January 2015 at 18:10, Stephen Warren wrote: >> On 01/16/2015 02:01 AM, Tomeu Vizoso wrote: >>> >>> On 16 January 2015 at 09:50, Tomeu Vizoso >>> wrote: On 15 January 2015 at 18:22, Stephen Warren wrote: > > On

Re: [PATCH v2 03/11] ARM: tegra: Set the sound card model that alsaucm expects

2015-01-20 Thread Dylan Reid
On Mon, Jan 19, 2015 at 9:11 AM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 19 January 2015 at 18:10, Stephen Warren swar...@wwwdotorg.org wrote: On 01/16/2015 02:01 AM, Tomeu Vizoso wrote: On 16 January 2015 at 09:50, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 15 January 2015

Re: [PATCH v2 00/11] Improvements to Tegra-based Chromebook support

2015-01-15 Thread Dylan Reid
On Thu, Jan 15, 2015 at 8:12 AM, Tomeu Vizoso wrote: > Hi, > > this started as adding support for the Nyan Blaze, but the Big is so similar > to it that I thought it would be better to have both in the same series. > > With these changes, I get wifi, trackpad, audio playback and recording (with

Re: [PATCH v2 00/11] Improvements to Tegra-based Chromebook support

2015-01-15 Thread Dylan Reid
On Thu, Jan 15, 2015 at 8:12 AM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: Hi, this started as adding support for the Nyan Blaze, but the Big is so similar to it that I thought it would be better to have both in the same series. With these changes, I get wifi, trackpad, audio playback

Re: [alsa-devel] [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits

2014-12-23 Thread Dylan Reid
On Tue, Dec 23, 2014 at 1:08 AM, Jianqun Xu wrote: > Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 bits. > Without this setting, the TDL is default to be 0x00 (means 1 bit), > and the RDL is default to be 0x1f (means 16 bits). My impression from the TRM was that TDL and RDL were

Re: [alsa-devel] [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits

2014-12-23 Thread Dylan Reid
On Tue, Dec 23, 2014 at 1:08 AM, Jianqun Xu jay...@rock-chips.com wrote: Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 bits. Without this setting, the TDL is default to be 0x00 (means 1 bit), and the RDL is default to be 0x1f (means 16 bits). My impression from the TRM was

Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Dylan Reid
On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao wrote: > On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown wrote: >> On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: >>> On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown wrote: >> >>> > I would expect that the clock for the CODEC should be managed by

Re: [alsa-devel] [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-03 Thread Dylan Reid
On Wed, Dec 3, 2014 at 3:03 PM, Sonny Rao sonny...@chromium.org wrote: On Wed, Dec 3, 2014 at 12:03 PM, Mark Brown broo...@kernel.org wrote: On Wed, Dec 03, 2014 at 11:38:13AM -0800, Sonny Rao wrote: On Wed, Dec 3, 2014 at 11:20 AM, Mark Brown broo...@kernel.org wrote: I would expect that

[PATCH] ALSA: hda - Use runtime helper to check active state.

2014-04-08 Thread Dylan Reid
>From azx_interrupt, use the helper to check if the device is active instead of checking the state. This will do the right thing if runtime pm is disabled in addition to if the device is suspended. Signed-off-by: Dylan Reid --- sound/pci/hda/hda_controller.c | 2 +- 1 file changed, 1 insert

[PATCH] ALSA: hda - Use runtime helper to check active state.

2014-04-08 Thread Dylan Reid
From azx_interrupt, use the helper to check if the device is active instead of checking the state. This will do the right thing if runtime pm is disabled in addition to if the device is suspended. Signed-off-by: Dylan Reid dgr...@chromium.org --- sound/pci/hda/hda_controller.c | 2 +- 1 file

[PATCH 2/2] regmap: cache: Don't attempt to sync non-writeable registers.

2014-03-18 Thread Dylan Reid
In the regcache_default_sync, if a register isn't writeable, then _regmap_write will return an error and the rest of the sync will be aborted. Avoid this by checking if a register is writeable before trying to sync it. Signed-off-by: Dylan Reid --- drivers/base/regmap/regcache.c | 3 ++- 1

[PATCH 1/2] regmap: cache: Step by stride in default sync.

2014-03-18 Thread Dylan Reid
The default sync operation was still assuming a stride of one, fix it to respect the reg_stride set in the map. Signed-off-by: Dylan Reid --- drivers/base/regmap/regcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap

[PATCH 1/2] regmap: cache: Step by stride in default sync.

2014-03-18 Thread Dylan Reid
The default sync operation was still assuming a stride of one, fix it to respect the reg_stride set in the map. Signed-off-by: Dylan Reid dgr...@chromium.org --- drivers/base/regmap/regcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache.c b

[PATCH 2/2] regmap: cache: Don't attempt to sync non-writeable registers.

2014-03-18 Thread Dylan Reid
In the regcache_default_sync, if a register isn't writeable, then _regmap_write will return an error and the rest of the sync will be aborted. Avoid this by checking if a register is writeable before trying to sync it. Signed-off-by: Dylan Reid dgr...@chromium.org --- drivers/base/regmap

[PATCH] regmap: cache: Handle stride > 1 in sync_block_raw_flush

2014-01-24 Thread Dylan Reid
r than one, registers past the end might be synced or the writeable_reg callback at the beginning of _regmap_raw_write will fail and nothing will be written. Signed-off-by: Dylan Reid --- drivers/base/regmap/regcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH] regmap: cache: Handle stride 1 in sync_block_raw_flush

2014-01-24 Thread Dylan Reid
, registers past the end might be synced or the writeable_reg callback at the beginning of _regmap_raw_write will fail and nothing will be written. Signed-off-by: Dylan Reid dgr...@chromium.org --- drivers/base/regmap/regcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git