Re: [PATCH 04/22] block: Abstract out bvec iterator

2013-08-13 Thread Ed L Cashin
On Tue, Aug 13, 2013 at 11:51:58AM -0700, Kent Overstreet wrote: > On Tue, Aug 13, 2013 at 10:03:04AM -0400, Ed Cashin wrote: > > On Aug 9, 2013, Ed Cashin wrote: > > > On Aug 8, 2013, at 9:05 PM, Kent Overstreet wrote: > > > ... > > > > It's in the for-jens branch now. > > > > > > > > > Just exa

Re: [2.6 patch] #if 0 aoedev_isbusy()

2008-02-13 Thread Ed L. Cashin
a maintainer wants to have such a function deleted instead that's > fine with me. Hello. That function can go away. I have some changes pending, but none of them use aoedev_isbusy. Thanks for Cc-ing me. -- Ed L Cashin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send t

Re: [PATCH] Documentation: Add 00-INDEX file for AoE

2008-01-14 Thread Ed L. Cashin
ned-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff --git a/Documentation/aoe/00-INDEX b/Documentation/aoe/00-INDEX index 8188b22..d087df6 100644 --- a/Documentation/aoe/00-INDEX +++ b/Documentation/aoe/00-INDEX @@ -5,9 +5,10 @@ aoe.txt autoload.sh - script for making the AoE driver

[PATCH] aoe: document the behavior of /dev/etherd/err

2007-12-26 Thread Ed L. Cashin
Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index 2620073..871f284 100644 --- a/drivers/block/aoe/aoechr.c +++ b/drivers

[PATCH] aoe: initialize locking structures before registering char devices

2007-12-26 Thread Ed L. Cashin
compile time, but that would leave aoe as the only user of __DECLARE_SEMAPHORE_GENERIC. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/ao

Re: [PATCH 09/13] remove race between use and initialization of locks

2007-12-26 Thread Ed L. Cashin
On Fri, Dec 21, 2007 at 10:00:40PM -0800, Andrew Morton wrote: > On Thu, 20 Dec 2007 17:15:57 -0500 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: ... > > +static __DECLARE_SEMAPHORE_GENERIC(emsgs_sema, 0); ... > > - sema_init(&emsgs_sema, 0); > > - spin_

[PATCH 13/13] update copyright date

2007-12-20 Thread Ed L. Cashin
Update the year in the copyright notices. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h |2 +- drivers/block/aoe/aoeblk.c |2 +- drivers/block/aoe/aoechr.c |2 +- drivers/block/aoe/aoecmd.c |2 +- drivers/block/aoe/aoedev.c |2 +- d

[PATCH 12/13] make error messages more specific

2007-12-20 Thread Ed L. Cashin
Andrew Morton pointed out that the "too many targets" message in patch 2 could be printed for failing GFP_ATOMIC allocations. This patch makes the messages more specific. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoecmd.c | 15 +++ 1

[PATCH 10/13] add module parameter for users who need more outstanding I/O

2007-12-20 Thread Ed L. Cashin
discovers a problem with a large setting, this parameter provides a way for us to work with them to debug the problem. We expect to improve the dynamic window sizing algorithm and drop this parameter. For the time being, it is a debugging aid. Signed-off-by: Ed L. Cashin <[EMAIL PROTEC

[PATCH 11/13] the aoeminor doesn't need a long format

2007-12-20 Thread Ed L. Cashin
The aoedev aoeminor member doesn't need a long format. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoeblk.c |7 --- drivers/block/aoe/aoecmd.c |5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/dr

[PATCH 08/13] only install new AoE device once

2007-12-20 Thread Ed L. Cashin
responses were returning from that single device. This patch eliminates a race condition so that aoe always informs the block layer of a new AoE device once in the presence of multiple incoming ATA device identify responses. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/ao

[PATCH 09/13] remove race between use and initialization of locks

2007-12-20 Thread Ed L. Cashin
Alexey Dobriyan noticed a race in the initialization of the dynamic locks in ... Message-ID: <[EMAIL PROTECTED]> Andrew Morton commented that these locks should be initialized at compile time, so this patch does that. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drive

[PATCH 06/13] user can ask driver to forget previously detected devices

2007-12-20 Thread Ed L. Cashin
thout this patch, software like GPFS and LVM may attempt to read from AoE devices that were discovered earlier but are no longer present, blocking until the I/O attempt times out. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/mkdevs.sh |2 + Documentation/aoe/

[PATCH 07/13] dynamically allocate a capped number of skbs when necessary

2007-12-20 Thread Ed L. Cashin
fast callback that could recognize write command completion responses. But I don't think the current problems with the receive side of the situation are a justification for exacerbating the problem on the transmit side. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/blo

[PATCH 04/13] clean up udev configuration example

2007-12-20 Thread Ed L. Cashin
This patch adds a known default location for the udev configuration file and uses the more recent "==" syntax for SUBSYSTEM and KERNEL. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/udev-install.sh |5 - Documentation/aoe/udev.txt| 15 ++

[PATCH 05/13] eliminate goto and improve readability

2007-12-20 Thread Ed L. Cashin
Adam Richter suggested eliminating this goto. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c | 69 +-- 1 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/blo

[PATCH 03/13] mac_addr: avoid 64-bit arch compiler warnings

2007-12-20 Thread Ed L. Cashin
By returning unsigned long long, mac_addr does not generate compiler warnings on 64-bit architectures. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h|2 +- drivers/block/aoe/aoeblk.c |3 +-- drivers/block/aoe/aoecmd.c | 10 +- drivers/blo

[PATCH 02/13] handle multiple network paths to AoE device

2007-12-20 Thread Ed L. Cashin
added right now, we can try again in a minute when then next AoE config query broadcast goes out. Andrew Morton pointed out that the "too many targets" message could be printed for failing GFP_ATOMIC allocations. The last patch in this series makes the messages more specific. Signed-off-b

[PATCH 01/13] bring driver version number to 47

2007-12-20 Thread Ed L. Cashin
was obsoleted by a patch in the 2.6.24-rc5-mm1 tree, gregkh-driver-block-device.patch, and has been omitted. The last patch in this series is new but straightforward. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions

Re: [Patch 3/8] Enhanced partition statistics: aoe fix

2007-12-13 Thread Ed L. Cashin
On Thu, Dec 13, 2007 at 05:17:45PM +0100, Jerome Marchand wrote: > Updates the enhanced partition statistics in ATA over Ethernet driver (not > tested). Acked-by: Ed L. Cashin <[EMAIL PROTECTED]> > Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]> > --- > aoecmd.

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-10 Thread Ed L. Cashin
ack from Ed yet. I'll sit on this for a few more days. Sorry, yes, the second patch works well for me in testing. I had some initial concerns that were unfounded. -- Ed L Cashin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[PATCH 13/13] make error messages more specific

2007-12-07 Thread Ed L. Cashin
Andrew Morton pointed out that the "too many targets" message in patch 2 could be printed for failing GFP_ATOMIC allocations. This patch makes the messages more specific. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoecmd.c | 15 +++ 1

[PATCH 12/13] the aoeminor doesn't need a long format

2007-12-07 Thread Ed L. Cashin
The aoedev aoeminor member doesn't need a long format. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoeblk.c |7 --- drivers/block/aoe/aoecmd.c |5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/dr

[PATCH 11/13] remove extra space in prototypes for consistency

2007-12-07 Thread Ed L. Cashin
Remove extra space in prototypes for consistency. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoeblk.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index 7168d3d..98ab170

[PATCH 10/13] add module parameter for users who need more outstanding I/O

2007-12-07 Thread Ed L. Cashin
discovers a problem with a large setting, this parameter provides a way for us to work with them to debug the problem. We expect to improve the dynamic window sizing algorithm and drop this parameter. For the time being, it is a debugging aid. Signed-off-by: Ed L. Cashin <[EMAIL PROTEC

[PATCH 09/13] remove race between use and initialization of locks

2007-12-07 Thread Ed L. Cashin
Alexey Dobriyan noticed a race in the initialization of the dynamic locks in ... Message-ID: <[EMAIL PROTECTED]> Andrew Morton commented that these locks should be initialized at compile time, so this patch does that. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drive

[PATCH 08/13] only install new AoE device once

2007-12-07 Thread Ed L. Cashin
responses were returning from that single device. This patch eliminates a race condition so that aoe always informs the block layer of a new AoE device once in the presence of multiple incoming ATA device identify responses. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/ao

[PATCH 07/13] dynamically allocate a capped number of skbs when necessary

2007-12-07 Thread Ed L. Cashin
fast callback that could recognize write command completion responses. But I don't think the current problems with the receive side of the situation are a justification for exacerbating the problem on the transmit side. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/blo

[PATCH 06/13] user can ask driver to forget previously detected devices

2007-12-07 Thread Ed L. Cashin
thout this patch, software like GPFS and LVM may attempt to read from AoE devices that were discovered earlier but are no longer present, blocking until the I/O attempt times out. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/mkdevs.sh |2 + Documentation/aoe/

[PATCH 05/13] eliminate goto and improve readability

2007-12-07 Thread Ed L. Cashin
Adam Richter suggested eliminating this goto. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c | 69 +-- 1 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/blo

[PATCH 04/13] clean up udev configuration example

2007-12-07 Thread Ed L. Cashin
This patch adds a known default location for the udev configuration file and uses the more recent "==" syntax for SUBSYSTEM and KERNEL. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/udev-install.sh |5 - Documentation/aoe/udev.txt| 15 ++

[PATCH 03/13] mac_addr: avoid 64-bit arch compiler warnings

2007-12-07 Thread Ed L. Cashin
By returning unsigned long long, mac_addr does not generate compiler warnings on 64-bit architectures. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h|2 +- drivers/block/aoe/aoeblk.c |3 +-- drivers/block/aoe/aoecmd.c | 10 +- drivers/blo

[PATCH 02/13] handle multiple network paths to AoE device

2007-12-07 Thread Ed L. Cashin
added right now, we can try again in a minute when then next AoE config query broadcast goes out. Andrew Morton pointed out that the "too many targets" message could be printed for failing GFP_ATOMIC allocations. The last patch in this series makes the messages more specific. Signed-off-b

[PATCH 01/13] bring driver version number to 47

2007-12-07 Thread Ed L. Cashin
These patches were made against kernel 2.6.23-rc4 kernel with the aoe-properly-initialise-the-request_queues-backing_dev_info patch (currently in mm) applied. They were submitted earlier and have been modified to incorporate feedback from the kernel development community. Signed-off-by: Ed L

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-03 Thread Ed L. Cashin
can complete, and with it I have seen many writes complete without any trouble. Thank you for looking into this. I will look more closely at this patch tomorrow. -- Ed L Cashin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-03 Thread Ed L. Cashin
On Mon, Dec 03, 2007 at 02:47:22PM -0800, Andrew Morton wrote: > On Mon, 3 Dec 2007 16:38:37 -0500 > "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: ... > > It appears that the fbc->counters pointer is NULL. > > Does this fix? > > --- a/drivers/block/aoe/ao

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-03 Thread Ed L. Cashin
On Mon, Dec 03, 2007 at 04:00:05PM -0500, Ed L. Cashin wrote: ... > I'll keep looking at this, but at a glance it looks like the cpu > number is valid, because I don't trip a BUG_ON when I make the change > below (the badval variable is noise, sorry). > > --- lx/lib/

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-03 Thread Ed L. Cashin
rite_nolock+0x358/0x3c2 [] filemap_fault+0x1c4/0x320 [] unlock_page+0x2d/0x31 [] generic_file_aio_write_nolock+0x3b/0x8d [] do_sync_write+0xe2/0x126 [] autoremove_wake_function+0x0/0x38 [] do_page_fault+0x3f8/0x7bb [] fd_install+0x5f/0x68 [] vfs_write+0xae/0x137 [] sys_write+0x47/0x70 [] system_call

Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)

2007-12-03 Thread Ed L. Cashin
x0/0x38 [] do_page_fault+0x3f8/0x7bb [] fd_install+0x5f/0x68 [] vfs_write+0xae/0x137 [] sys_write+0x47/0x70 [] system_call+0x7e/0x83 -- Ed L Cashin <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [

Re: [PATCH] [73/2many] MAINTAINERS - ATA OVER ETHERNET DRIVER

2007-08-13 Thread Ed L. Cashin
AINERS > @@ -740,6 +740,8 @@ P:Ed L. Cashin > M: [EMAIL PROTECTED] > W: http://www.coraid.com/support/linux > S: Supported > +F: Documentation/aoe/ > +F: drivers/block/aoe/ > > ATL1 ETHERNET DRIVER > P: Jay Cliburn That looks fine to me. -- E

[PATCH] aoe: remove unecessary wrapper function

2007-08-06 Thread Ed L. Cashin
We can just use skb_mac_header now, and we don't need a wrapper function to perform the cast. Instead of requiring the reader to check aoe.h to look up what an aoe_hdr function does, I'd rather do without it. --- drivers/block/aoe/aoe.h|9 - drivers/block/aoe/aoecmd.c | 14 +

Re: ATA over ethernet swapping and obfuscated code

2007-07-31 Thread Ed L. Cashin
write responses would be dropped just as they are already, but dirty pages would be flushed. The mechanism would only take effect when free pages were scarce. It is easy to chat, though. Maybe someday I will test and submit a patch that implements this mechanism, but I'm hoping that s

Re: ATA over ethernet swapping and obfuscated code

2007-07-31 Thread Ed L. Cashin
return NULL; > ~~~~~~~~~ here I don't see what you mean. There's an unlock two lines before the return. > } > d->sysminor = sysminor; > d->aoemajor = AOEMAJOR(sysminor); > d->aoeminor = AOEMINOR(sysminor); > } > > spin_unlock_irqrestore(&devlist_lock, flags); > return d; > } > -- Ed L Cashin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] stacked ifs (was Re: [PATCH 02/12] handle multiple network paths to AoE device)

2007-07-16 Thread Ed L. Cashin
On Mon, Jul 02, 2007 at 09:29:49PM -0700, Andrew Morton wrote: > On Tue, 26 Jun 2007 14:50:10 -0400 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: ... > > +static struct frame * > > +freeframe(struct aoedev *d) > > { > > + struct frame *f, *e;

Re: [PATCH 02/12] handle multiple network paths to AoE device

2007-07-11 Thread Ed L. Cashin
On Mon, Jul 02, 2007 at 09:29:49PM -0700, Andrew Morton wrote: > On Tue, 26 Jun 2007 14:50:10 -0400 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: ... > > +loop: > > + skb = aoecmd_ata_id(d); > > spin_unlock_irqrestore(&d->lock, flags); &

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-06 Thread Ed L. Cashin
erbating the problem on the transmit side. -- Support - http://www.coraid.com/support/howto.html Ed L Cashin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

[PATCH 1/1] docs: static initialization of spinlocks is OK

2007-07-03 Thread Ed L. Cashin
Static initialization of spinlocks is preferable to dynamic initialization when it is practical. This patch updates documentation for consistency with comments in spinlock_types.h. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/spinlocks.txt | 20 +++--

Re: [PATCH 12/12] the aoeminor doesn't need a long format

2007-06-26 Thread Ed L. Cashin
On Tue, Jun 26, 2007 at 12:51:07PM -0700, Randy Dunlap wrote: > On Tue, 26 Jun 2007 14:50:12 -0400 Ed L. Cashin wrote: > > > The aoedev aoeminor member doesn't need a long format. > > Was there a patch that changed aoeminor to an int? > Last I see is: > ulon

[PATCH 02/12] handle multiple network paths to AoE device

2007-06-26 Thread Ed L. Cashin
Handle multiple network paths to AoE device. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h| 58 +++-- drivers/block/aoe/aoeblk.c | 63 - drivers/block/aoe/aoechr.c | 14 +- drivers/block/aoe/aoecmd.c

[PATCH 01/12] bring driver version number to 47

2007-06-26 Thread Ed L. Cashin
These patches were made against kernel 2.6.22-rc4. Bring driver version number to 47. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h

[PATCH 12/12] the aoeminor doesn't need a long format

2007-06-26 Thread Ed L. Cashin
The aoedev aoeminor member doesn't need a long format. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoeblk.c |6 +++--- drivers/block/aoe/aoecmd.c |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/dr

[PATCH 09/12] remove race between use and initialization of locks

2007-06-26 Thread Ed L. Cashin
e, the patch below makes the code correct and in keeping with the existing documentation. If the existing docs are wrong, I'd be happy to follow up with a patch that corrects them and makes these aoechr.c locks static. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Ed L. C

[PATCH 11/12] remove extra space in prototypes for consistency

2007-06-26 Thread Ed L. Cashin
Remove extra space in prototypes for consistency. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoeblk.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index c9cf576..ccadd9a

[PATCH 10/12] add module parameter for users who need more outstanding I/O

2007-06-26 Thread Ed L. Cashin
Add module parameter for users who need more outstanding I/O. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoecmd.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 8

[PATCH 08/12] only schedule work once

2007-06-26 Thread Ed L. Cashin
Only schedule work once. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoecmd.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 89df9de..8d6540b 100644 --- a/drivers/block/aoe/ao

[PATCH 06/12] user can ask driver to forget previously detected devices

2007-06-26 Thread Ed L. Cashin
ned-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/mkdevs.sh |2 + Documentation/aoe/udev.txt |1 + drivers/block/aoe/aoe.h |1 + drivers/block/aoe/aoechr.c |5 ++ drivers/block/aoe/aoedev.c | 87 +- 5 files change

[PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-06-26 Thread Ed L. Cashin
Use a dynamic pool of sk_buffs to keep up with fast targets. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h|5 ++ drivers/block/aoe/aoecmd.c | 129 +--- drivers/block/aoe/aoedev.c | 51 +++--- 3

[PATCH 03/12] mac_addr: avoid 64-bit arch compiler warnings

2007-06-26 Thread Ed L. Cashin
By returning unsigned long long, mac_addr does not generate compiler warnings on 64-bit architectures. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoe.h|2 +- drivers/block/aoe/aoeblk.c |3 +-- drivers/block/aoe/aoecmd.c | 10 +- drivers/blo

[PATCH 04/12] clean up udev configuration example

2007-06-26 Thread Ed L. Cashin
This patch adds a known default location for the udev configuration file and uses the more recent "==" syntax for SUBSYSTEM and KERNEL. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- Documentation/aoe/udev-install.sh |5 - Documentation/aoe/udev.txt| 15 ++

[PATCH 05/12] eliminate goto and improve readability

2007-06-26 Thread Ed L. Cashin
Adam Richter suggested eliminating this goto. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c | 69 +-- 1 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/blo

PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Ed L. Cashin
candidates are in mm/internal.h and are presumably intended to be used exclusively by mm/*.c. Signed-off-by: "Ed L. Cashin" <[EMAIL PROTECTED]> diff -upr -X linux-2.6.21-rc1.dontdiff linux-2.6.21-rc1.orig/drivers/block/aoe/aoe.h linux-2.6.21-rc1/drivers/block/aoe/aoe.h --- linux-

Re: Re: bio pages with zero page reference count

2007-01-19 Thread Ed L. Cashin
On Mon, Dec 18, 2006 at 10:53:43PM +, Christoph Hellwig wrote: > On Mon, Dec 18, 2006 at 05:21:09PM -0500, Ed L. Cashin wrote: ... > > If anyone has a better reference, I'd like to see it. > > I searched around a little bit and found these: > > > http:

bio pages with zero page reference count

2006-12-18 Thread Ed L. Cashin
(This email is a followup to "Re: [PATCH 2.6.19.1] fix aoe without scatter-gather [Bug 7662]".) On Mon, Dec 18, 2006 at 12:53:00PM -0500, Ed L. Cashin wrote: ... > This patch eliminates the offset data on cards that don't support > scatter-gather or have had scatter-gath

[PATCH 2.6.19.1] fix aoe without scatter-gather [Bug 7662]

2006-12-18 Thread Ed L. Cashin
cards that don't support scatter-gather or have had scatter-gather turned off. There remains an unrelated issue that I'll address in a separate email. Signed-off-by: "Ed L. Cashin" <[EMAIL PROTECTED]> diff -uprN linux-2.6.19.orig/drivers/block/aoe/aoecmd.c linux-2.

Re: [PATCH] aoe: Add forgotten NULL at end of attribute list in aoeblk.c

2006-11-16 Thread Ed L. Cashin
--- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = { > &disk_attr_mac.attr, > &disk_attr_netif.attr, > &disk_attr_fwver.attr, > + NULL > }; > > static const

Re: aoe fails on sparc64

2005-09-09 Thread Ed L Cashin
Ed L Cashin <[EMAIL PROTECTED]> writes: ... > Let's take this discussion off the lkml, because I doubt there's a > problem with the aoe driver in the kernel, and I can easily follow up > to the lkml with a synopsis if it turns out I'm wrong. It looks like I was prob

Re: aoe fails on sparc64

2005-09-06 Thread Ed L Cashin
Jim MacBaine <[EMAIL PROTECTED]> writes: > On 9/1/05, Ed L Cashin <[EMAIL PROTECTED]> wrote: > >> The aoe driver looks OK, but it turns out there's a byte swapping bug >> in the vblade that could be related if he's running the vblade on a >> big endia

Re: aoe fails on sparc64

2005-09-01 Thread Ed L Cashin
"David S. Miller" <[EMAIL PROTECTED]> writes: > From: Ed L Cashin <[EMAIL PROTECTED]> ... >> OK. 67553994410557440 is 61440 byte swapped in 64 bits, and 30MB is >> 61440 sectors, so this should be a simple byte order fix. > > More strangely, the uppe

Re: aoe fails on sparc64

2005-08-31 Thread Ed L Cashin
2. e0.0 is exported on a x86 system using vblade-5, and has a > size of 30 MB. Thanks for the report. -- Ed L Cashin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 2.6.13-rc6] aoe [2/2]: update driver version number to twelve

2005-08-19 Thread Ed L Cashin
Update driver version number to twelve. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> Index: 2.6.13-rc6-aoe/drivers/block/aoe/aoe.h === --- 2.6.13-rc6-aoe.orig/drivers/block/aoe/aoe.h 2005-08-19 11:57:04.0

[PATCH 2.6.13-rc6] aoe [1/2]: support 16 AoE slot addresses per AoE shelf

2005-08-19 Thread Ed L Cashin
Change the number of supported AoE slot addresses per AoE shelf address to 16. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> Index: 2.6.13-rc6-aoe/Documentation/aoe/mkshelf.sh === --- 2.6.13-rc6-aoe.orig/Documentati

/sys/module (was Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration)

2005-04-21 Thread Ed L Cashin
or where to put it, so I procrastinated. Then I created the module parameter and was pleased to see it show up in sysfs. I had read about module parameters before, but I had forgotten about that feature, or maybe it's newer than the docs I read. Thanks for working so hard to make sysfs useful. -

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
Greg KH <[EMAIL PROTECTED]> writes: > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote: >> "Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: >> >> > Ed L Cashin <[EMAIL PROTECTED]> wrote: >> > >> >

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-21 Thread Ed L Cashin
"Bodo Eggert <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> writes: > Ed L Cashin <[EMAIL PROTECTED]> wrote: > >> +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 > >> + When the aoe driver is a module, use > > Is ther

Re: [PATCH 2.6.12-rc2] aoe [5/6]: add firmware version to info in sysfs

2005-04-20 Thread Ed L Cashin
quot;netif"); - sysfs_remove_link(&d->gd->kobj, "fwver"); + sysfs_remove_link(&d->gd->kobj, "firmware-version"); } static int -- Ed L Cashin <[EMAIL PROTECTED]>

Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
"Randy.Dunlap" <[EMAIL PROTECTED]> writes: > On Wed, 20 Apr 2005 13:02:12 -0400 Ed L Cashin wrote: > > Just a nit/typo: > > | +modprobe aoe_iflist="eth1 eth3" > > | static char aoe_iflist[IFLISTSZ]; > | +module_param_string(aoe_iflist,

[PATCH 2.6.12-rc2] aoe [4/6]: allow multiple aoe devices to have the same mac

2005-04-20 Thread Ed L Cashin
allow multiple aoe devices to have the same mac Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -u b/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c --- b/drivers/block/aoe/aoedev.c2005-04-20 11:42:18.0 -0400 +++ b/drivers/block/aoe/aoedev.c2005-04-20

[PATCH 2.6.12-rc2] aoe [6/6]: update version number to 10

2005-04-20 Thread Ed L Cashin
update version number to 10 Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- b/drivers/block/aoe/aoe.h 2005-04-20 11:42:19.0 -0400 +++ b/drivers/block/aoe/aoe.h 2005-04-20 11:42:22.0 -0400 @@ -1,5 +1,5 @@ /* Copyright (c) 2004 Coraid, Inc. See COPYING for GPL

[PATCH 2.6.12-rc2] aoe [5/6]: add firmware version to info in sysfs

2005-04-20 Thread Ed L Cashin
add firmware version to info in sysfs Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c --- a/drivers/block/aoe/aoeblk.c2005-04-20 11:41:18.0 -0400 +++ b/drivers/block/aoe/aoeblk.c2005-04-20

[PATCH 2.6.12-rc2] aoe [3/6]: update the documentation to mention aoetools

2005-04-20 Thread Ed L Cashin
update the documentation to mention aoetools Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/Documentation/aoe/aoe.txt b/Documentation/aoe/aoe.txt --- a/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0 -0400 +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:21.0

[PATCH 2.6.12-rc2] aoe [2/6]: aoe-stat should work for built-in as well as module

2005-04-20 Thread Ed L Cashin
aoe-stat should work for built-in as well as module Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/Documentation/aoe/status.sh b/Documentation/aoe/status.sh --- a/Documentation/aoe/status.sh 2005-04-20 11:40:55.0 -0400 +++ b/Documentation/aoe/status.sh 2

[PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

2005-04-20 Thread Ed L Cashin
improve allowed interfaces configuration Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/Documentation/aoe/aoe.txt b/Documentation/aoe/aoe.txt --- a/Documentation/aoe/aoe.txt 2005-04-20 11:40:55.0 -0400 +++ b/Documentation/aoe/aoe.txt 2005-04-20 11:42:20.0

Re: AOE and large filesystems?

2005-04-12 Thread Ed L Cashin
2? Yes, most AoE users use md. Many use LVM2, but a couple have had trouble with striped volume groups. > 3) Is anyone on the list using AOE on a 64 bit platform? People are using AoE on 64 bit platforms and not reading the lkml. :) -- Ed L Cashin <[EMAIL PROTECTED]> - To unsubscri

Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

2005-04-08 Thread Ed L Cashin
Greg KH <[EMAIL PROTECTED]> writes: > On Thu, Apr 07, 2005 at 02:56:39PM -0400, Ed L Cashin wrote: ... >> Just aoe-AOE_PARTITIONS.patch, the seventh of the twelve, should be >> dropped. > > Ok, dropped. > >> Then later I'll send a batch of patches that w

Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

2005-04-07 Thread Ed L Cashin
regkh/gregkh-2.6/patches/driver/aoe-AOE_PARTITIONS.patch > ? > Or some other one too? Just aoe-AOE_PARTITIONS.patch, the seventh of the twelve, should be dropped. Then later I'll send a batch of patches that will include a change to make aoe disks non-partitionable by default. -- Ed

Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

2005-04-07 Thread Ed L Cashin
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Tue, Mar 29, 2005 at 11:48:48AM -0500, Ed L Cashin wrote: >> I don't know if it matters now that we have udev. When udev manages >> the device nodes it all just works, > > But most peopel still don't use udev

Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

2005-03-29 Thread Ed L Cashin
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Tue, Mar 29, 2005 at 11:06:16AM -0500, Ed L Cashin wrote: >> > >> > NACK. this changes devices nodes based on a compile-time option. >> >> I'm not sure I follow. This configuration option sets t

Re: [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig

2005-03-29 Thread Ed L Cashin
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Thu, Mar 24, 2005 at 07:21:28AM -0800, [EMAIL PROTECTED] wrote: >> >> support configuration of AOE_PARTITIONS from Kconfig >> >> Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> >> >> diff -u

[PATCH 2.6.11] aoe [4/12]: handle distros that have a udev rules file instead of dir

2005-03-18 Thread Ed L. Cashin
handle distros that have a udev rules file instead of dir Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN a/Documentation/aoe/udev-install.sh b/Documentation/aoe/udev-install.sh --- a/Documentation/aoe/udev-install.sh 2005-03-10 11:59:55.0 -0500 +++ b/Documentation/ao

Re: [PATCH 2.6.11] aoe [1/12]: remove too-low cap on minor number

2005-03-18 Thread Ed L Cashin
et in touch with the lkml admins, but gmane should work.) -- Ed L Cashin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] aoe: fix printk warning (sparc64)

2005-03-02 Thread Ed L Cashin
ed int format, u64 > arg (arg 4) > > cross-compile results: > https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_id=4239 Thanks. I have a few patches I'll be sending along soon (today, I hope) in a batch, including Alexey Dobriyan's recent sparse cleanups, and I

Re: [PATCH] aoe: fix abuse of arrays and sparse warnings

2005-02-24 Thread Ed L Cashin
y your patch does, the original author of the patch changed it back. But you've figured out how to make sparse happy, and for that I'm grateful! :) -- Ed L Cashin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [2.6 patch] drivers/block/aoe/aoechr.c cleanups

2005-01-31 Thread Ed L Cashin
but since this function is just for debugging, it seems better to just take both prototype and definition out. remove aoechr_hdump make aoe_fops static Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -urNp aa/drivers/block/aoe/aoe.h bb/drivers/block/aoe/aoe.h --- aa/drivers/block/aoe/ao

[PATCH block-2.6] aoe status.sh: handle sysfs not in /etc/mtab

2005-01-26 Thread Ed L Cashin
Suse 9.1 Pro doesn't put /sys in /etc/mtab. This patch makes the example aoe status.sh script work when sysfs is mounted but `mount` doesn't mention sysfs. aoe status.sh: handle sysfs not in /etc/mtab Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- a/Documentation/aoe

[PATCH block-2.6] aoe: fail IO on disk errors

2005-01-25 Thread Ed L Cashin
This patch makes disk errors fail the IO instead of getting logged and ignored. Fail IO on disk errors Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN block-2.6-aa/drivers/block/aoe/aoecmd.c block-2.6-bb/drivers/block/aoe/aoecmd.c --- block-2.6-aa/drivers/block/aoe/aoecmd.c

Re: [PATCH] aoe: add documentation for udev users

2005-01-20 Thread Ed L Cashin
Bodo Eggert <[EMAIL PROTECTED]> writes: > Ed L Cashin <[EMAIL PROTECTED]> wrote: > >> +if test -z "$conf"; then >> +conf="`find /etc -type f -name udev.conf 2> /dev/null`" >> +fi >> +if test -z "$conf" || test ! -r

Re: [PATCH] AOE: fix up the block device registration so that it actually works now.

2005-01-20 Thread Ed L Cashin
Greg KH <[EMAIL PROTECTED]> writes: > On Wed, Jan 19, 2005 at 09:08:14AM -0500, Ed L Cashin wrote: >> > diff -Nru a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c >> > --- a/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00 >> > +++ b/drivers/b

[PATCH] aoe: add documentation for udev users

2005-01-19 Thread Ed L Cashin
Hi. This patch was generated against block-2.6 but should apply easily in other trees, since it touches only documentation. add documentation for udev users Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- block-2.6-export-b/Documentation/aoe/aoe.txt2005-01-19 14:29:15.000

Re: [PATCH] AOE: fix up the block device registration so that it actually works now.

2005-01-19 Thread Ed L Cashin
rectifies the omission. Remove allow aoeblk_exit to be called from __init code, and move register_blkdev into aoe_init. Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> diff -uprN block-2.6-export-a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c --- block-2.6-export-a/drivers/bloc

Re: [PATCH] AOE: fix up the block device registration so that it actually works now.

2005-01-19 Thread Ed L Cashin
printk(KERN_ERR "aoe: aoeblk_init: can't register major\n"); > - goto blkreg_fail; > - } > > printk(KERN_INFO > "aoe: aoe_init: AoE v2.6-%s initialised.\n", Hmm. I'll try to send a patch against usb, since I can pull fr

  1   2   >