to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Eddie-Kovsky/module-verify-address-is-read-only/20170407-004322
> config: i386-randconfig-x010-201714 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>
to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Eddie-Kovsky/module-verify-address-is-read-only/20170407-004322
> config: i386-randconfig-x010-201714 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>
, and
reject structures not marked ro_after_init in vmbus_register()
Suggested-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v4:
- Rename function __module_ro_address() to __module_rodata_address()
- Move module_rodata_address(
ro_after_init in vmbus_register()
Suggested-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v5:
- Replace __start_data_ro_after_init with __start_ro_after_init
- Replace __end_data_ro_after_init with __end_ro_after_init
Changes in v
ro_after_init in vmbus_register()
Suggested-by: Kees Cook
Signed-off-by: Eddie Kovsky
---
Changes in v5:
- Replace __start_data_ro_after_init with __start_ro_after_init
- Replace __end_data_ro_after_init with __end_ro_after_init
Changes in v4:
- Rename function core_kernel_ro_data
, and
reject structures not marked ro_after_init in vmbus_register()
Suggested-by: Kees Cook
Signed-off-by: Eddie Kovsky
---
Changes in v4:
- Rename function __module_ro_address() to __module_rodata_address()
- Move module_rodata_address() stub below is_module_address()
- Minor comment fixes
se features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
Eddie Kovsky (2):
module: verify address is read-only
extable: verify address is read-only
include/linux/kernel.h | 2 ++
include
se features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
Eddie Kovsky (2):
module: verify address is read-only
extable: verify address is read-only
include/linux/kernel.h | 2 ++
include
On 03/30/17, Kees Cook wrote:
> On Wed, Mar 29, 2017 at 8:27 PM, Jessica Yu <j...@redhat.com> wrote:
> > +++ Eddie Kovsky [28/03/17 21:28 -0600]:
> >
> >> On 03/27/17, Kees Cook wrote:
> >>>
> >>> On Mon, Mar 27, 2017 at 1:43 AM, kbui
On 03/30/17, Kees Cook wrote:
> On Wed, Mar 29, 2017 at 8:27 PM, Jessica Yu wrote:
> > +++ Eddie Kovsky [28/03/17 21:28 -0600]:
> >
> >> On 03/27/17, Kees Cook wrote:
> >>>
> >>> On Mon, Mar 27, 2017 at 1:43 AM, kbuild test robot wrote:
> >
v4.9-rc6 v4.11-rc4]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
> >
> > url:
> > https://github.com/0day-ci/linux/commits/Eddie-Kovsky/module-verify-address-is-read-only/20170327-142922
> > co
c4]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
> >
> > url:
> > https://github.com/0day-ci/linux/commits/Eddie-Kovsky/module-verify-address-is-read-only/20170327-142922
> > config: blackfin-BF561-EZK
section.
I have dropped the third patch that uses these features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
I have test compiled this series on next-20170324 for x86.
Eddie Kovsky (2):
module
section.
I have dropped the third patch that uses these features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
I have test compiled this series on next-20170324 for x86.
Eddie Kovsky (2):
module
, and
reject structures not marked ro_after_init in vmbus_register()
Suggested-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v4:
- Rename function __module_ro_address() to __module_rodata_address()
- Move module_rodata_address(
ro_after_init in vmbus_register()
Suggested-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v4:
- Rename function core_kernel_ro_data() to core_kernel_rodata().
Changes in v3:
- Fix missing declaration of is_module_rodata_address()
, and
reject structures not marked ro_after_init in vmbus_register()
Suggested-by: Kees Cook
Signed-off-by: Eddie Kovsky
---
Changes in v4:
- Rename function __module_ro_address() to __module_rodata_address()
- Move module_rodata_address() stub below is_module_address()
- Minor comment fixes
ro_after_init in vmbus_register()
Suggested-by: Kees Cook
Signed-off-by: Eddie Kovsky
---
Changes in v4:
- Rename function core_kernel_ro_data() to core_kernel_rodata().
Changes in v3:
- Fix missing declaration of is_module_rodata_address()
---
include/linux/kernel.h | 2 ++
kernel/extable.c
On 03/24/17, Jessica Yu wrote:
> +++ Eddie Kovsky [22/03/17 20:55 -0600]:
> > Implement a mechanism to check if a module's address is in
> > the rodata or ro_after_init sections. It mimics the exsiting functions
> > that test if an address is inside a module's text sectio
On 03/24/17, Jessica Yu wrote:
> +++ Eddie Kovsky [22/03/17 20:55 -0600]:
> > Implement a mechanism to check if a module's address is in
> > the rodata or ro_after_init sections. It mimics the exsiting functions
> > that test if an address is inside a module's text sectio
.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v3:
- Change function name is_module_ro_address() to
is_module_rodata_address().
- Improve comments on is_module_rodata_address().
- Add a !CONFIG_MODULES stub for is_module_rodata_address.
- Correct and simplify the
-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Changes in v3:
- Fix missing declaration of is_module_rodata_address()
include/linux/kernel.h | 2 ++
kernel/extable.c | 29 +
2 files changed, 31 insertions(+)
diff --git a/include/linux/kernel.h b/include
.
Signed-off-by: Eddie Kovsky
---
Changes in v3:
- Change function name is_module_ro_address() to
is_module_rodata_address().
- Improve comments on is_module_rodata_address().
- Add a !CONFIG_MODULES stub for is_module_rodata_address.
- Correct and simplify the check for the read-only memory
-off-by: Eddie Kovsky
---
Changes in v3:
- Fix missing declaration of is_module_rodata_address()
include/linux/kernel.h | 2 ++
kernel/extable.c | 29 +
2 files changed, 31 insertions(+)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index
section.
I have dropped the third patch that uses these features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
I have test compiled this series on next-20170321 for x86.
Eddie Kovsky (2):
module
section.
I have dropped the third patch that uses these features to check the
arguments to vmbus_register() because the maintainers have not been
receptive to using it. My goal right now is to get the API right.
I have test compiled this series on next-20170321 for x86.
Eddie Kovsky (2):
module
tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Eddie-Kovsky/provide-check-for-ro_after_init-memory-sections/20170218-141040
> :: branch date: 2 hours ago
> :: commit date: 2 hours ago
>
> >> dr
.org
> In-Reply-To: <20170218055844.1457-4-...@edkovsky.org>
>
> Hi Eddie,
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.10-rc8 next-20170217]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the syste
Use the new RO check functions introduced in this series to make the
vmbus register functions verify that the address of their arguments are
read-only. Addresses that fail the verification are rejected.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
drivers/hv/vmbus_drv.c | 10 +++
Use the new RO check functions introduced in this series to make the
vmbus register functions verify that the address of their arguments are
read-only. Addresses that fail the verification are rejected.
Signed-off-by: Eddie Kovsky
---
drivers/hv/vmbus_drv.c | 10 ++
1 file changed, 10
to check for ro_after_init memory areas, and
reject structures not marked ro_after_init in vmbus_register()
http://www.openwall.com/lists/kernel-hardening/2017/02/04/1
I have successfully compiled this series on next-20170215 for x86.
Eddie Kovsky (3):
module: verify address is read-only
to check for ro_after_init memory areas, and
reject structures not marked ro_after_init in vmbus_register()
http://www.openwall.com/lists/kernel-hardening/2017/02/04/1
I have successfully compiled this series on next-20170215 for x86.
Eddie Kovsky (3):
module: verify address is read-only
Implement a mechanism to check if a module's address is in
the rodata or ro_after_init sections. It mimics the exsiting functions
that test if an address is inside a module's text section.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
include/linux/module.h | 7 +++
kernel/mo
Provide a mechanism to check if the address of a variable is
const or ro_after_init. It mimics the existing functions that test if an
address is inside the kernel's text section.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
include/linux/kernel.h | 2 ++
kernel/extable.c
Implement a mechanism to check if a module's address is in
the rodata or ro_after_init sections. It mimics the exsiting functions
that test if an address is inside a module's text section.
Signed-off-by: Eddie Kovsky
---
include/linux/module.h | 7 +++
kernel/module.c| 44
Provide a mechanism to check if the address of a variable is
const or ro_after_init. It mimics the existing functions that test if an
address is inside the kernel's text section.
Signed-off-by: Eddie Kovsky
---
include/linux/kernel.h | 2 ++
kernel/extable.c | 29
This patch provides a minimal configuration to set up Mutt for
submitting plain text patches using Gmail.
Signed-off-by: Eddie Kovsky
---
Documentation/email-clients.txt | 32
1 file changed, 32 insertions(+)
diff --git a/Documentation/email-clients.txt b
Clarify that Gmail can be used to send patches, provided you use Gmail
as a server and avoid the Web UI.
Signed-off-by: Eddie Kovsky
---
Documentation/email-clients.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/email-clients.txt b/Documentation/email
Like 'git send-email', Mutt can also be used to send patches generated
with 'git format-patch'. This works regardless of the editor the
contributor has set up to use with Mutt.
Signed-off-by: Eddie Kovsky
---
Documentation/email-clients.txt | 4
1 file changed, 4 insertions(+)
diff --git
editor.
* Add a minimal Mutt configuration to use Gmail's IMAP servers to send
text email.
I tested this configuration using a mockup local user and my own Gmail
account.
Thanks
Eddie
Eddie Kovsky (3):
Clarify use of Gmail for emailing patches
Add note on sending files directly with Mutt
editor.
* Add a minimal Mutt configuration to use Gmail's IMAP servers to send
text email.
I tested this configuration using a mockup local user and my own Gmail
account.
Thanks
Eddie
Eddie Kovsky (3):
Clarify use of Gmail for emailing patches
Add note on sending files directly with Mutt
Clarify that Gmail can be used to send patches, provided you use Gmail
as a server and avoid the Web UI.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Documentation/email-clients.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/email-clients
This patch provides a minimal configuration to set up Mutt for
submitting plain text patches using Gmail.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Documentation/email-clients.txt | 32
1 file changed, 32 insertions(+)
diff --git a/Documentation
Like 'git send-email', Mutt can also be used to send patches generated
with 'git format-patch'. This works regardless of the editor the
contributor has set up to use with Mutt.
Signed-off-by: Eddie Kovsky <e...@edkovsky.org>
---
Documentation/email-clients.txt | 4
1 file chan
Using checkpatch.pl with Perl 5.22.0 generates the following warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes the warnings by escaping occurrences of the left brace
inside the regular expression.
Signed-off-by: Eddie Kovsky
---
scripts
Using checkpatch.pl with Perl 5.22.0 generates the following warning:
Unescaped left brace in regex is deprecated, passed through in regex;
This patch fixes the warnings by escaping occurrences of the left brace
inside the regular expression.
Signed-off-by: Eddie Kovsky e...@edkovsky.org
return int. This fixes the build warnings:
warning: ‘return’ with a value, in function returning void
return -EINVAL
Signed-off-by: Eddie Kovsky
---
drivers/gpu/drm/drm_context.c | 12 +---
drivers/gpu/drm/drm_legacy.h | 6 +++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git
. This fixes the build warnings:
warning: ‘return’ with a value, in function returning void
return -EINVAL
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
drivers/gpu/drm/drm_context.c | 12 +---
drivers/gpu/drm/drm_legacy.h | 6 +++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff
istent||
Signed-off-by: Eddie Kovsky
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index eb27b2a74492..b0f98b5b8985 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6391,7 +6391,7 @@ static int update_array_info(
||
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index eb27b2a74492..b0f98b5b8985 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6391,7 +6391,7 @@ static int
On Wed, Apr 01, 2015 at 09:09:26AM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
> > Changing function definition to static fixes the
> > following warning generated by sparse:
> >
> > drivers/staging/rtl8192u/ieee80211
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol
'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky
---
drivers/staging
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
> On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
> > Change function definition to static, move the function further up in
> > the file, and delete the function prototype.
> >
> > This
On Wed, Apr 01, 2015 at 09:09:26AM +0530, Sudip Mukherjee wrote:
On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
Change function definition to static, move the function further up in
the file, and delete the function prototype.
This fixes the following warning generated
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol
'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky e...@edkovsky.org
it be static?
Signed-off-by: Eddie Kovsky
---
drivers/staging/rtl8192u/r8192U_core.c | 87 +-
1 file changed, 44 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 8834c23d67fc..f16a0a45611f
it be static?
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
drivers/staging/rtl8192u/r8192U_core.c | 87 +-
1 file changed, 44 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 8834c23d67fc
On Thu, Mar 26, 2015 at 11:37:45AM +0300, Dan Carpenter wrote:
> Huh. Weird. Please, could you just move it forward instead so we don't
> have to have the prototype declaration?
>
> regars,
> dan carpenter
>
Dan
You're right. That's a better solution. But I already got a message from
Greg
On Thu, Mar 26, 2015 at 11:37:45AM +0300, Dan Carpenter wrote:
Huh. Weird. Please, could you just move it forward instead so we don't
have to have the prototype declaration?
regars,
dan carpenter
Dan
You're right. That's a better solution. But I already got a message from
Greg that he
Change function definition to match its prototype declaration. This
fixes the following warning generated by sparse:
drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
'rtl8192_update_ratr_table' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky
---
drivers/staging
Change function definition to match its prototype declaration. This
fixes the following warning generated by sparse:
drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
'rtl8192_update_ratr_table' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky e...@edkovsky.org
]
*dwIoBase
Compile tested on next-20141219.
Signed-off-by: Eddie Kovsky
---
drivers/staging/vt6655/baseband.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 86c72ba0a0cd..f8c5fc371c4c 100644
]
asn:2*dwIoBase
Compile tested on next-20141219.
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
drivers/staging/vt6655/baseband.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 86c72ba0a0cd
nction.
Also uses the preferred pointer syntax for passing the size of a struct.
Tested on next-20141119.
Signed-off-by: Eddie Kovsky
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5
uses the preferred pointer syntax for passing the size of a struct.
Tested on next-20141119.
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index
Silence checkpatch warning:
WARNING: type 'long long unsigned' should be specified in
[[un]signed] [short|int|long|long long] order
Signed-off-by: Eddie Kovsky
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Silence checkpatch warning:
WARNING: type 'long long unsigned' should be specified in
[[un]signed] [short|int|long|long long] order
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
68 matches
Mail list logo
