Re: [PATCH bpf-next v3 1/2] bpf: verifier: Support eliding map lookup nullness

2024-09-24 Thread Eduard Zingerman
to use a map type that still requires null checks, as it's > exercising verifier tracking logic w.r.t iterators. > > Signed-off-by: Daniel Xu > --- Acked-by: Eduard Zingerman [...] > +/* Returns constant key value if possible, else -1 */ > +static long get_constant

Re: [PATCH] selftests/bpf: Add missing va_end.

2024-09-24 Thread Eduard Zingerman
On Tue, 2024-09-24 at 12:55 +0800, zhangjiao2 wrote: > From: zhang jiao > > There is no va_end after va_copy, just add it. > > Signed-off-by: zhang jiao > --- My bad, thank you for fixing this. Acked-by: Eduard Zingerman

Re: [PATCH bpf-next v2 2/2] bpf: selftests: verifier: Add nullness elision tests

2024-09-20 Thread Eduard Zingerman
up. And obviously some bound checks. > > Signed-off-by: Daniel Xu > --- Acked-by: Eduard Zingerman [...]

Re: [PATCH bpf-next v2 1/2] bpf: verifier: Support eliding map lookup nullness

2024-09-20 Thread Eduard Zingerman
On Sun, 2024-09-15 at 21:45 -0600, Daniel Xu wrote: > This commit allows progs to elide a null check on statically known map > lookup keys. In other words, if the verifier can statically prove that > the lookup will be in-bounds, allow the prog to drop the null check. > > This is useful for two re

Re: [PATCH bpf,v2,0/2] bpf: fix incorrect name check pass logic in btf_name_valid_section

2024-09-04 Thread Eduard Zingerman
On Sat, 2024-08-31 at 14:45 +0900, Jeongjun Park wrote: > This patch was written to fix an issue where btf_name_valid_section() would > not properly check names with certain conditions and would throw an OOB vuln. > And selftest was added to verify this patch. Acked-by: Eduard Zingerman [...]