Re: [Xen-devel] [PATCHv2] xen-netfront: remove warning when unloading module

2018-02-02 Thread Eduardo Otubo
e I assumed it was true I started to write code based on that and all the behaviors that followed were correct according to my assumptions (and discussions). But if you find something else weird, please let me know and we can fix it. > > On 11/23/2017 04:18 PM, Eduardo Otubo wrote: > &g

[PATCH] xen-netfront: enable device after manual module load

2018-01-05 Thread Eduardo Otubo
ff-by: Eduardo Otubo --- drivers/net/xen-netfront.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index c5a34671abda..9bd7ddeeb6a5 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1326,6 +1326,7 @@ static s

Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread Eduardo Otubo
On Fri, Dec 08, 2017 at 12:33:38PM +0100, Olaf Hering wrote: > On Fri, Dec 08, Eduardo Otubo wrote: > > > tools/hv/hv_set_ifconfig.sh | 45 > > +++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > +#

[PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip

2017-12-08 Thread Eduardo Otubo
checks the interface before trying anything. Signed-off-by: Eduardo Otubo --- v2: wrap the interface configuration inside a safe wAY to avoid interaction with network script. tools/hv/hv_set_ifconfig.sh | 45 +++-- 1 file changed, 43 insertions(+), 2

[PATCHv2] xen-netfront: remove warning when unloading module

2017-11-23 Thread Eduardo Otubo
tinue to cleanup for the module removal, and this is done by manipulating both device states. Signed-off-by: Eduardo Otubo --- drivers/net/xen-netfront.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 8b8689

Re: [PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread Eduardo Otubo
On Mon, Nov 20, 2017 at 12:17:11PM +0100, Juergen Gross wrote: > On 20/11/17 11:49, Wei Liu wrote: > > CC netfront maintainers. > > > > On Mon, Nov 20, 2017 at 11:41:09AM +0100, Eduardo Otubo wrote: > >> When unloading module xen_netfront from guest, dmesg would out

Re: [PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread 'Eduardo Otubo'
On Mon, Nov 20, 2017 at 10:55:55AM +, Paul Durrant wrote: > > -Original Message- > > From: Eduardo Otubo [mailto:ot...@redhat.com] > > Sent: 20 November 2017 10:41 > > To: xen-de...@lists.xenproject.org > > Cc: net...@vger.kernel.org; Paul Durran

[PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread Eduardo Otubo
ing both device states. Signed-off-by: Eduardo Otubo --- drivers/net/xen-netfront.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 8b8689c6d887..b948e2a1ce40 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net

Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Eduardo Otubo
xenbus_device *dev) > netdev->features |= netdev->hw_features; > > netdev->ethtool_ops = &xennet_ethtool_ops; > - netdev->min_mtu = 0; > + netdev->min_mtu = ETH_MIN_MTU; > netdev->max_mtu = XEN_NETIF_MAX_TX_SIZE; > SET_NETDEV_DEV(netdev, &dev->dev); > > -- > 1.8.3.1 > Acked-by: Eduardo Otubo -- Eduardo Otubo Senior Software Engineer @ RedHat

Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

2017-08-31 Thread Eduardo Otubo
On Mon, Aug 28, 2017 at 04:48:32PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Haiyang Zhang > > Sent: Monday, August 28, 2017 8:57 AM > > To: Stephen Hemminger ; Eduardo Otubo > > ; KY Srinivasan > > Cc: linux-kernel@vge

Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

2017-08-28 Thread Eduardo Otubo
On Mon, Aug 28, 2017 at 03:56:44PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, August 28, 2017 11:16 AM > > To: Eduardo Otubo > > Cc: linux-kernel@vger.kern

[PATCHv2] hv_set_ifconfig.sh double check before setting ip

2017-08-28 Thread Eduardo Otubo
n, in this case hv_set_ifconfig causes "RTNETLINK: file exists error"; in order to avoid this error this patch makes sure double checks the interface before trying anything. Signed-off-by: Eduardo Otubo --- tools/hv/hv_set_ifconfig.sh | 44

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-10 Thread Eduardo Otubo
On 08/09/2017 11:02 AM, Eduardo Otubo wrote: On 08/09/2017 06:11 AM, David Miller wrote: From: Eduardo Otubo Date: Tue, 8 Aug 2017 15:53:45 +0200 This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-09 Thread Eduardo Otubo
On 08/09/2017 06:11 AM, David Miller wrote: From: Eduardo Otubo Date: Tue, 8 Aug 2017 15:53:45 +0200 This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by network daemon, in this case hv_set_ifconfig

[PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-08 Thread Eduardo Otubo
checks the interface before trying anything. Signed-off-by: Eduardo Otubo --- tools/hv/hv_set_ifconfig.sh | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/tools/hv/hv_set_ifconfig.sh b/tools/hv/hv_set_ifconfig.sh index 735aafd64a3f..ba5e4aa4e