Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

2020-11-19 Thread Edwin Peer
rkqueue("bnxt_pf_wq"); > if (!bnxt_pf_wq) { > dev_err(&pdev->dev, "Unable to create > workqueue.\n"); > + rc = -ENOMEM; > goto init_err_pci_clean; >

Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()

2020-11-19 Thread Edwin Peer
amp; > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) { > dev_err(&pdev->dev, "System does not support DMA, > aborting\n"); > + rc = -EIO; > goto init_err_disable; > } > > -- > 2.9.5 Reviewed-by: Edwin Peer Regards, Edwin Peer smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 4.19 34/88] bnxt_en: fix HWRM error when querying VF temperature

2020-09-08 Thread Edwin Peer
if (len) > > + return len; > > + > > + return sprintf(buf, "unknown\n"); > > } > > We normally just do return -EIO (or other error code) in such cases. That does seem more appropriate. I will fix it, thank you. Regards, Edwin Peer

Hello.

2020-07-26 Thread Edwin Clark
Hello, there is a pressing message. Please contact me as soon as possible.

Re: PROBLEM: XFS in-memory corruption with reflinks and duperemove: XFS (dm-4): Internal error xfs_trans_cancel at line 1048 of file fs/xfs/xfs_trans.c. Caller xfs_reflink_remap_extent+0x100/0x560

2020-05-06 Thread Edwin Török
On Wed, 2020-05-06 at 15:47 -0700, Darrick J. Wong wrote: > On Wed, May 06, 2020 at 12:07:12AM +0100, Edwin Török wrote: > > > > On 5 May 2020 01:58:11 BST, "Darrick J. Wong" < > > darrick.w...@oracle.com> wrote: > > > On Mon, May 04, 2020 at 11:54

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-06 Thread Edwin Peer
On Tue, May 5, 2020 at 11:46 PM Bartosz Golaszewski wrote: > Re the last bit in priv_flags: is this really a problem though? It's > not like struct net_device must remain stable - e.g. we can make > priv_flags a bitmap. Fair enough. Regards, Edwin Peer

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Edwin Peer
; + > + return 0; > +} > +EXPORT_SYMBOL(devm_register_netdev); > + > int netdev_refcnt_read(const struct net_device *dev) > { > int i, refcnt = 0; > diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c > index c8b903302ff2..ce9b5e576f20 100644 > --- a/net/ethernet/eth.c > +++ b/net/ethernet/eth.c > @@ -423,6 +423,7 @@ struct net_device *devm_alloc_etherdev_mqs(struct device > *dev, int sizeof_priv, > > *dr = netdev; > devres_add(dev, dr); > + netdev->priv_flags |= IFF_IS_DEVRES; > > return netdev; > } > -- > 2.25.0 > Regards, Edwin Peer

Pagefault in fuse_do_ioctl

2019-03-23 Thread Edwin Zimmerman
On 5.0.0-rc4+, I encountered a pagefault in fuse_do_ioctl when fuzzing with trinity on a ntfs filesystem mounted with fuse. I have not been able to reproduce it on other filesystem types. The following python script will reproduce this bug when run on a fuse-mounted ntfs path. >import fcntl >f

RE: [PATCH 06/10] security: fix documentation for the path_chmod hook

2019-02-07 Thread Edwin Zimmerman
On Thursday, February 07, 2019 8:50 AM Al Viro wrote: > On Thu, Feb 07, 2019 at 03:44:54PM +0300, Denis Efremov wrote: > > The path_chmod hook was changed in the commit > > "switch security_path_chmod() to struct path *" (cdcf116d44e7). > > The argument @mnt was removed from the hook, @dentry was c

RE: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Edwin Zimmerman
nings like this: > > fs/fcntl.c: In function ‘send_sigio_to_task’: > fs/fcntl.c:738:13: warning: statement will never be executed > [-Wswitch-unreachable] >siginfo_t si; > ^~ > > Signed-off-by: Kees Cook Reviewed by: Edwin Zimmerman > --- > arch/

RE: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Edwin Zimmerman
ough to do without forcing them to watch for variable declarations in switch statements. Automating this prohibition, should it be accepted, seems like a good idea to me. -Edwin Zimmerman

[PATCH] dlm: avoid double-free on error path in dlm_device_{register,unregister}

2017-08-03 Thread Edwin Török
3 rip [] kmem_cache_alloc+0x7a/0x140 rsp cr2: 0001 --[ end trace 70cb9fd1b164a0e8 ]-- CC: sta...@vger.kernel.org Signed-off-by: Edwin Török --- fs/dlm/user.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/dlm/user.c b/fs/dlm/user.c index 7ff4985..9703ac9 100644 --- a/fs/

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-22 Thread Török Edwin
On 2016-08-18 02:28, Darrick J. Wong wrote: > On Wed, Aug 17, 2016 at 05:27:25PM +0300, Török Edwin wrote: >> On 2016-08-08 09:28, Darrick J. Wong wrote: >>> On Sun, Aug 07, 2016 at 11:56:34PM -0400, Theodore Ts'o wrote: >>>> On Fri, Aug 05, 2016 at 12:1

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-18 Thread Török Edwin
pplied > the patch to 4.7.0, and I stressed it a bit with repo syncs, > AOSP builds, rsync backups etc. Same here: I've been using 4.7.0+patch daily, and everything is working fine. Best regards, --Edwin

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-17 Thread Török Edwin
is patch be backported to >> -stable. Darrick, what do you think? > > Seems like an excellent idea. Hi, I see 4.7.1. was released, however before testing it in the changelog I can't see the inode.c commit with the checksum fix. Is there another commit that would provide an equivalent fix, or is the fix not part of 4.7.1? Best regards, --Edwin

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-09 Thread Török Edwin
On 2016-08-09 05:37, Darrick J. Wong wrote: > On Tue, Aug 09, 2016 at 12:13:01AM +0300, Török Edwin wrote: >> On 2016-08-08 19:55, Darrick J. Wong wrote: >>> On Mon, Aug 08, 2016 at 12:08:18PM -0400, Theodore Ts'o wrote: >>>> On Sun, Aug 07, 2016 at 11:2

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-08 Thread Török Edwin
On 2016-08-08 19:55, Darrick J. Wong wrote: > On Mon, Aug 08, 2016 at 12:08:18PM -0400, Theodore Ts'o wrote: >> On Sun, Aug 07, 2016 at 11:28:10PM -0700, Darrick J. Wong wrote: >>> >>> I have one lingering concern -- is it a bug that two processes could be >>> computing the checksum of a buffer sim

Re: 4.7.0-rc7 ext4 error in dx_probe

2016-08-03 Thread Török Edwin
ge. Prior to 4.7 I was on 4.6.1 -> 4.6.2 -> 4.6.3 -> 4.6.4. The kernel is from gentoo-sources + a patch for enabling AMD LWP (I had that patch since 4.6.3 and its not related to I/O). If I see this message again what should I do to obtain more information to trace down the root cause?

[PATCH 1/2] HID: Create header for Logitech HID++ driver

2015-11-21 Thread Edwin Velds
Renamed the hid-logitech-hidpp.c file and created a header. This prepares for building the driver from multiple sources. Signed-off-by: Edwin Velds --- drivers/hid/Makefile |2 + drivers/hid/hid-logitech-hidpp-base.c | 1831 +++ drivers/hid/hid

[PATCH 0/2] HID: Force feedback support for the Logitech G920 Wheel

2015-11-21 Thread Edwin Velds
implementation was not made optional because the G920 (like all Logitech wheels) can't function without it due to very stiff to default springs. Edwin Velds (1): HID: Create header for Logitech HID++ driver HID: Force feedback support for the Logitech G920 drivers/hid/Makefile |

[PATCH 2/2] HID: Force feedback support for the Logitech G920

2015-11-21 Thread Edwin Velds
G920 (like previous Logitech wheels) starts with a heavy default spring enabled. Unlike previous wheels, there is no command to disable this spring and it will only release when other forces are downloaded into the device. Signed-off-by: Edwin Velds --- drivers/hid/Makefile

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Edwin
you'll put it in a clean branch off 4.3 I'd pull it and then get more > changes on top. > > Can we also change the subject as it is not about adding a minimal > support. Something like "Input: xpad - switch Logitech G920 Wheel into HID > mode" Will spin a 'v

03/20/2015 From Mrs. Alivia Edwin Attn: Your Ref View Attached File Please For More Details.

2015-03-20 Thread Mrs. Alivia Edwin
Dear Alivia Edwin.docx Description: MS-Word 2007 document

[no subject]

2014-02-26 Thread Mrs. Alivia Edwin
I am Mrs. Alivia Edwin the wife of Engr David Edwin a Syrian Industrialist and member of a Syrian businessman in council Damascus. Please kindly view attache for more details. From Mrs. Alivia Edwin.doc Description: MS

Re: xfsaild causing 30+ wakeups/s on an idle system since 2.6.25-rcX

2008-02-18 Thread Török Edwin
David Chinner wrote: > On Sun, Feb 17, 2008 at 05:51:08PM +0100, Oliver Pinter wrote: > >> On 2/17/08, Török Edwin <[EMAIL PROTECTED]> wrote: >> >>> Hi, >>> >>> xfsaild is causing many wakeups, a quick investigation shows >>>

xfsaild causing 30+ wakeups/s on an idle system since 2.6.25-rcX

2008-02-17 Thread Török Edwin
original report to the powerTOP mailing list. Best regards, --Edwin --- Begin Message --- Török Edwin wrote: Török Edwin wrote: Hi, On latest -git of 2.6.25 I am getting lots of wakeups from xfsaild. 23.5% ( 33.3) xfsaild : schedule_timeout (process_timeout) [Should I Cc: xfs

LatencyTOP: sync_page description

2008-02-15 Thread Török Edwin
_sync_read autoremove_wake_function cfq_idle_slice_timer security_file_permission Thanks, --Edwin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

Re: Strange interaction between latencytop and the scheduler

2008-01-24 Thread Török Edwin
Török Edwin wrote: > >> The performance aspect... collecting the data isn't cheap (which is >> why it's made a sysctl), >> I still plan to look at optimizing it but it won't ever be free. >> > > Yes, I understand that. Is there a way latency

Re: Strange interaction between latencytop and the scheduler

2008-01-22 Thread Török Edwin
Arjan van de Ven wrote: > Török Edwin wrote: >> Is this normal? (is overhead really 40msec?) > > I'm seeing similar, I would not rule out that this is actual scheduler > behavior ;( > at least it seems consistent. Ok, it is good that we are seeing same behaviour. >

Strange interaction between latencytop and the scheduler

2008-01-22 Thread Török Edwin
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 7008 edwin 20 0 38764 472 356 R 58.4 0.0 0:05.94 a.out 5613 edwin 20 0 179m 10m 7452 R 17.3 0.5 1:45.19 gkrellm 5920 edwin 20 0 565m 90m 25m R 17.3 4.

Re: [PATCH] LatencyTop: make reason (blk_execute_rq+0x7a/0xd) known

2008-01-19 Thread Török Edwin
Arjan van de Ven wrote: > Török Edwin wrote: >> >> Cause Maximum >> Average >> SCSI device ioctl 34.2 msec >> 14.4 msec > > great! I'll put this into m

[PATCH] LatencyTop: make reason (blk_execute_rq+0x7a/0xd) known

2008-01-19 Thread Török Edwin
e () } delete start[tid()] } P.S.: LatencyTop could have a feature to ask for more details on unknown latency reasons, and it would generate a systemtap script itself, that would show the backtraces to help figure out whats going on. Best regards, --Edwin diff --git a/dr

Re: Improve hackbench

2008-01-04 Thread Török Edwin
32== possibly lost: 10,608 bytes in 39 blocks. ==27332==still reachable: 792 bytes in 21 blocks. ==27332== suppressed: 0 bytes in 0 blocks. ==27332== Rerun with --leak-check=full to see details of leaked memory. Segmentation fault Best regards, --Edwin -- To unsubscribe

Re: [RFT] Port 0x80 I/O speed

2007-12-12 Thread Török Edwin
2 Dell Inspiron 6400, Intel Core Duo (ICH7 chipset) thunder:/home/edwin# ./port80 cycles: out 2480, in 1867 thunder:/home/edwin# ./port80 cycles: out 2482, in 1865 thunder:/home/edwin# ./port80 cycles: out 2968, in 1893 thunder:/home/edwin# ./port80 cycles: out 1991, in 1372 thunder:/hom

Re: [RFT] Port 0x80 I/O speed

2007-12-12 Thread Edwin de Caluwé
Exactly constant timing in every iteration: cycles: out 667, in 305 processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 8 model name : Celeron (Coppermine) stepping: 3 cpu MHz : 497.582 cache size : 128 KB fdiv_bug: no hlt_bug

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Török Edwin
permail/power/2007-June/000573.html And there is also another slightly different approach: http://mjg59.livejournal.com/76062.html Best regards, --Edwin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/