Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

rkqueue("bnxt_pf_wq"); > if (!bnxt_pf_wq) { > dev_err(>dev, "Unable to create > workqueue.\n"); > + rc = -ENOMEM; > goto init_err_pci_clean; >

Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()

;& > dma_set_mask_and_coherent(>dev, DMA_BIT_MASK(32)) != 0) { > dev_err(>dev, "System does not support DMA, > aborting\n"); > + rc = -EIO; > goto init_err_disable; > } > > -- > 2.9.5 Reviewed-by: Edwin Peer Regards, Edwin Peer smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH 4.19 34/88] bnxt_en: fix HWRM error when querying VF temperature

if (len) > > + return len; > > + > > + return sprintf(buf, "unknown\n"); > > } > > We normally just do return -EIO (or other error code) in such cases. That does seem more appropriate. I will fix it, thank you. Regards, Edwin Peer

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

On Tue, May 5, 2020 at 11:46 PM Bartosz Golaszewski wrote: > Re the last bit in priv_flags: is this really a problem though? It's > not like struct net_device must remain stable - e.g. we can make > priv_flags a bitmap. Fair enough. Regards, Edwin Peer

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

gt; + return 0; > +} > +EXPORT_SYMBOL(devm_register_netdev); > + > int netdev_refcnt_read(const struct net_device *dev) > { > int i, refcnt = 0; > diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c > index c8b903302ff2..ce9b5e576f20 100644 > --- a/net/ethernet/eth.c > +++ b/net/ethernet/eth.c > @@ -423,6 +423,7 @@ struct net_device *devm_alloc_etherdev_mqs(struct device > *dev, int sizeof_priv, > > *dr = netdev; > devres_add(dev, dr); > + netdev->priv_flags |= IFF_IS_DEVRES; > > return netdev; > } > -- > 2.25.0 > Regards, Edwin Peer