Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer

2020-09-05 Thread Elie Morisse
Acked-by: Elie Morisse Le ven. 4 sept. 2020 à 20:06, a écrit : > > From: Tom Rix > > clang static analyzer reports this problem > > i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates > to a garbage value > return err ? err : num; >

[PATCH v17] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2019-03-05 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add dependency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

Re: [PATCH v16] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2019-02-26 Thread Elie Morisse
Morisse Le mar. 26 févr. 2019 à 13:12, Elie Morisse a écrit : > > MP2 controllers have two separate busses, so may accommodate up to two I2C > adapters. Those adapters are listed in the ACPI namespace with the > "AMDI0011" HID, and probed by a platform driver. > > Comm

[PATCH v16] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2019-02-26 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add dependency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

Re: [PATCH v15] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-28 Thread Elie Morisse
Hi, Nehal isn't responding, while the end of the merge window is closing in. I addressed his last requests, will this get merged? Elie Le mer. 26 déc. 2018 à 20:23, Elie Morisse a écrit : > > MP2 controllers have two separate busses, so may accommodate up to two I2C > adapters. Those

[PATCH v15] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-26 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add dependency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

[PATCH v14] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-22 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add dependency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

Re: [PATCH v13] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-14 Thread Elie Morisse
me know if I still have to change something to get it merged. Elie Morisse Le mar. 11 déc. 2018 à 18:02, Wolfram Sang a écrit : > > On Sun, Dec 09, 2018 at 12:56:02PM -0300, Elie Morisse wrote: > > MP2 controllers have two separate busses, so may accommodate up to two I2C > &g

[PATCH v13] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-09 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add dependency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

[PATCH v12] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-08 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

[PATCH v12] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-08 Thread Elie Morisse
many other improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

[PATCH v11] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-03 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

[PATCH v11] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-12-03 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for

Re: [PATCH v10] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-27 Thread Elie Morisse
lly an issue for now? Btw I'll submit a v11 version of the patch which definitely fixes the timeouts on Lenovo Ideapad 530s soon (already fixed in https://github.com/Syniurge/i2c-amd-mp2). Elie Le lun. 26 nov. 2018 à 15:52, Shah, Nehal-bakulchandra a écrit : > > > Hi Elie Morisse, > >

Re: [PATCH v10] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-27 Thread Elie Morisse
lly an issue for now? Btw I'll submit a v11 version of the patch which definitely fixes the timeouts on Lenovo Ideapad 530s soon (already fixed in https://github.com/Syniurge/i2c-amd-mp2). Elie Le lun. 26 nov. 2018 à 15:52, Shah, Nehal-bakulchandra a écrit : > > > Hi Elie Morisse, > >

[PATCH v10] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-14 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for review co

[PATCH v10] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-14 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1 (https://www.spinics.net/lists/linux-i2c/msg34650.html): -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2 (https://patchwork.ozlabs.org/patch/961270/): -> fix for review co

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-11 Thread Elie Morisse
17:56, Bjorn Helgaas a écrit : > > [+cc Rafael, Len, linux-acpi] > > On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > > This contains two drivers: > > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > > the two busses of the MP2)

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-11 Thread Elie Morisse
17:56, Bjorn Helgaas a écrit : > > [+cc Rafael, Len, linux-acpi] > > On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > > This contains two drivers: > > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > > the two busses of the MP2)

[PATCH v9] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-11 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2:(https://patchwork.ozlabs.org/patch/961270/) -> fix for review comment

[PATCH v9] i2c: Add drivers for the AMD PCIe MP2 I2C controller

2018-11-11 Thread Elie Morisse
many more improvements. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2:(https://patchwork.ozlabs.org/patch/961270/) -> fix for review comment

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-04 Thread Elie Morisse
The errors on module exit and the hang after a read/write timeout should be fixed in v8, someone else reported the same issue here: https://github.com/Syniurge/i2c-amd-mp2/issues/1 Weird that despite a lot of trying by doing random stuff with my touchpad and touchscreen neither never ever timed

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-04 Thread Elie Morisse
The errors on module exit and the hang after a read/write timeout should be fixed in v8, someone else reported the same issue here: https://github.com/Syniurge/i2c-amd-mp2/issues/1 Weird that despite a lot of trying by doing random stuff with my touchpad and touchscreen neither never ever timed

[PATCH v8] i2c: Add driver for the AMD PCIe MP2 I2C controller

2018-11-04 Thread Elie Morisse
Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2:(https://patchwork.ozlabs.org/patch/961270/) -> fix for review comments -> fix for more

[PATCH v8] i2c: Add driver for the AMD PCIe MP2 I2C controller

2018-11-04 Thread Elie Morisse
Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add depedency of ACPI -> Add locks to avoid the crash Changes since v2:(https://patchwork.ozlabs.org/patch/961270/) -> fix for review comments -> fix for more

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

[PATCH v6] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-26 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

[PATCH v6] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-26 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

2018-10-24 Thread Elie Morisse
Tomorrow I'll submit an updated patch that takes Bjorn's remarks that still apply to my version into account. Elie Morisse Le mer. 24 oct. 2018 à 16:16, Bjorn Helgaas a écrit : > > On Thu, Oct 25, 2018 at 01:26:51AM +0800, Kai Heng Feng wrote: > > > On Sep 17, 2018, at 16:19, Kai-Heng Fen

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

2018-10-24 Thread Elie Morisse
Tomorrow I'll submit an updated patch that takes Bjorn's remarks that still apply to my version into account. Elie Morisse Le mer. 24 oct. 2018 à 16:16, Bjorn Helgaas a écrit : > > On Thu, Oct 25, 2018 at 01:26:51AM +0800, Kai Heng Feng wrote: > > > On Sep 17, 2018, at 16:19, Kai-Heng Fen

[v5] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-24 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

[v5] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-24 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -> Add dep

[v4] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-23 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -&g

[v4] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-23 Thread Elie Morisse
in the patch changelog. With those changes both the touchpad and the touchscreen of the Ryzen-based Lenovo Yoga 530 which lie in separate busses work beautifully. Signed-off-by: Elie Morisse --- Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) -> Add fix for IOMMU -&g