Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

>>> More code changes may land in near future, so removing functions isn't >>> good at all at this moment. We need to wait until the all things are >>> settled down. IOW, forget about this for a while :) Hi Richard, Takashi, In principle I don't object to this patch (thanks for the work Richard

Re: [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

the new code. > > Then I obviously send a new Patch! > Will be busy few days, but then I send a new one. > > Kind regards > Rickard Strandqvist > > > 2014-12-21 23:32 GMT+01:00 Eliot Blennerhassett : >> On 22/12/14 05:50, Rickard Strandqvist wrote: >>> Remove

Re: [PATCH] sound: pci: asihpi: hpifunc.c: Remove some unused functions

On 22/12/14 05:50, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: NAK - because hpi_adapter_set_property() is now used in for-next branch of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Otherwise I have no problem with the patch. -- To unsubscri

Q: volatile vs barriers to access memory data changed by device DMA

[device reads interface->cmd by dma] Is the wmb() a guarantee that the command will be in memory visible to the device when the driver informs it of a new command? Is it even needed? I.e. does iowrite() effectively form a barrier? regards -- Eliot Blennerhassett www.audioscience.com -- To uns