This driver no longer has any pr_{level} messages. Remove the pr_fmt().
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
b/drivers/platform/chrome
Adopt the SPDX license identifier headers to ease license compliance
management. Also fix the module license mismatch and change the
description for a more descriptive phrase.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_i2c.c | 22
Adopt the SPDX license identifier headers to ease license compliance
management. Also change the description for one more appropriate.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_sysfs.c | 24 +---
1 file changed, 5
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_proto.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/platform
Adopt the SPDX license identifier headers to ease license compliance
management. Also remove the license boiler-plate and redundant driver
description.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_lpc.c | 34 ---
drivers
Adopt the SPDX license identifier headers to ease license compliance
management. Also change the description for one more appropriate.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/platform/chrome/cros_ec_spi.c | 20 +---
1 file changed, 5 insertions
of preproduction models, where some wiring (on the soc
or board) may have gone wrong.
It is also not clear why this is a hardware-description or a DT
property, so, as noboby seems to care of this just drop reading that
property.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Heiko Stuebner
---
Hi
99")
Signed-off-by: Enric Balletbo i Serra
---
Hi all,
This patch was send for the first time within these series [1], but
might have more sense sent alone as doesn't depends on the rest of
the series, so, remove from these series and send a second version
that can be applied independently.
Bes
of preproduction models, where some wiring (on the soc
or board) may have gone wrong.
It is also not clear why this is a hardware-description or a DT
property, so, as noboby seems to care of this just drop reading that
property.
Signed-off-by: Enric Balletbo i Serra
---
Hi all,
This patch was send
ber 'dev' not described in
'rockchip_usb2phy'
:234: warning: Function parameter or member 'clk480m_hw' not described in
'rockchip_usb2phy'
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Heiko Stuebner
---
Hi all,
This patch was send for the first time within these series [1], but
might h
Hi Lee,
On 9/1/19 8:25, Lee Jones wrote:
> On Tue, 08 Jan 2019, Enric Balletbo Serra wrote:
>> Missatge de Lee Jones del dia dv., 21 de des.
>> 2018 a les 16:39:
>>>
>>> On Wed, 12 Dec 2018, Enric Balletbo i Serra wrote:
>>>
>>>> Hi,
>
None of these are required at the moment.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_sysfs.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
b/drivers/platform/chrome/cros_ec_sysfs.c
index 0ff5aa30c070
None of these are required at the moment.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_lightbar.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b/drivers/platform/chrome/cros_ec_lightbar.c
index c3e4e6e5211d
None of these are required at the moment.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_vbc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_vbc.c
b/drivers/platform/chrome/cros_ec_vbc.c
index af9bfe6f385c..86903bc31b27 100644
This driver no longer has any pr_{level} messages. Remove the pr_fmt().
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_lightbar.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b/drivers/platform/chrome
This driver no longer has any pr_{level} messages. Remove the pr_fmt().
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
b/drivers/platform/chrome/cros_ec_sysfs.c
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_vbc.c | 24 +---
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_vbc.c
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_sysfs.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_lightbar.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/chrome
Adopt the SPDX license identifier headers to ease license compliance
management.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_debugfs.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/platform/chrome
None of these are required at the moment.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_debugfs.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c
b/drivers/platform/chrome/cros_ec_debugfs.c
index 6cacac53dfce
://lkml.org/lkml/2018/12/12/679
Enric Balletbo i Serra (10):
platform/chrome: cros_ec_debugfs: remove unused includes
platform/chrome: cros_ec_lightbar: remove unused includes
platform/chrome: cros_ec_sysfs: remove unused includes
platform/chrome: cros_ec_vbc: remove unused includes
Hi,
On 8/1/19 15:34, Guenter Roeck wrote:
> On Tue, Jan 8, 2019 at 6:28 AM Enric Balletbo i Serra
> wrote:
>>
>> Hi Moritz,
>>
>> Many thanks for the patch,I've one concern on this, and I'd be also
>> interested
>> on Benson and Guenter opinion ...
Hi Moritz,
Many thanks for the patch,I've one concern on this, and I'd be also interested
on Benson and Guenter opinion ...
On 8/1/19 4:56, Moritz Fischer wrote:
> From: Moritz Fischer
>
> Add cros_ec_readmem() based helpers for I2C/SPI based ECs.
> Unlike the LPC based ECs the I2C/SPI based
seful, and it is
> what current input limit should have been, in the first place...
>
> Thanks,
> Pavel
>
>> Signed-off-by: Enric Balletbo i Serra
>> Reviewed-by: Guenter Roeck
>> ---
>&g
There are multiple ChromeOS EC sub-drivers spread in different
subsystems, as all of them are related to the Chrome stuff add
Benson and myself as a maintainers for all these sub-drivers.
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Benson Leung
Acked-by: Wolfram Sang
Acked-by: Chanwoo
On 14/12/18 12:48, Enric Balletbo i Serra wrote:
> There are multiple ChromeOS EC sub-drivers spread in different
> subsystems, as all of them are related to the Chrome stuff add
> Benson and myself as a maintainers for all these sub-drivers.
>
> Signed-off-by: Enric Balletbo i
There are multiple ChromeOS EC sub-drivers spread in different
subsystems, as all of them are related to the Chrome stuff add
Benson and myself as a maintainers for all these sub-drivers.
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Benson Leung
Acked-by: Wolfram Sang
Acked-by: Chanwoo
knowledge or user input.
By default there is no limit, this is reported as a -1 when reading from
userspace. Writing a value will set the current or voltage limit in uA
or uV, and writing any negative value will remove that limit.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes
power for thermal or other reasons.
This patch exposes a new property, similar to input current limit, to
re-configure the maximum voltage from the external supply at runtime
based on system-level knowledge or user input.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
On 13/12/18 10:50, Alexandre Belloni wrote:
> On 13/12/2018 10:30:16+0100, Enric Balletbo i Serra wrote:
>>> However, you should probably indicate which tree do you expect that to
>>> go through ;)
>>>
>>
>> Well, these are sub-drivers for different
Hi Alexandre,
On 12/12/18 23:29, Alexandre Belloni wrote:
> On 11/12/2018 20:09:52+0100, Enric Balletbo i Serra wrote:
>> There are multiple ChromeOS EC sub-drivers spread in different
>> subsystems, as all of them are related to the Chrome stuff add
>> Benson and myself as
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
reduces the need of remove callback from platform/chrome for removing the
MFD child devices.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v5: None
Changes in v4:
- Added Reviewed
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v5: None
Changes in v4:
- Use instead in documentation.
Changes in v3:
- Removed unneded check for ec_dev.
Changes in v2:
- Removed the two exported functions to attach/detach
The entire way how cros debugfs attibutes are created is broken.
cros_ec_debugfs should be its own driver and its attributes should be
associated with a debugfs driver not the mfd driver.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
Acked-for-MFD-by: Lee Jones
---
Changes
documentation.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
Acked-for-MFD-by: Lee Jones
---
Changes in v5: None
Changes in v4:
- Use instead of in documentation.
Changes in v3:
- Fixed build error as reported by the kbuild test robot.
Changes in v2:
- Removed unneeded check
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the
empty folder is not created, so, the folder is only created if the vbc
is set.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
a comment that no longer applies.
- Create the attributes directly instead of use the attach/detach callbacks.
- Remove unnecessary IS_ENABLED.
- Remove dev_err message telling that VBC is found.
- Use dev_warn instead of dev_err as the error is ignored.
- Removed ec_with_lightbar variable.
Enric Balletbo
The entire way how cros debugfs attibutes are created is broken.
cros_ec_sysfs should be its own driver and its attributes should be
associated with the sysfs driver not the mfd driver.
The patch also adds the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v5: None
Changes in v4:
- Get rid of the cros_ec_has_lightbar function.
Changes in v3: None
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 53
There are multiple ChromeOS EC sub-drivers spread in different
subsystems, as all of them are related to the Chrome stuff add
Benson and myself as a maintainers for all these sub-drivers.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Fix typo in Benson email address.
MAINTAINERS
On 11/12/18 20:00, Enric Balletbo i Serra wrote:
> There are multiple ChromeOS EC sub-drivers spread in different
> subsystems, as all of them are related to the Chrome stuff add
> Benson and myself as a maintainers for all these sub-drivers.
>
> Signed-off-by: Enric B
There are multiple ChromeOS EC sub-drivers spread in different
subsystems, as all of them are related to the Chrome stuff add
Benson and myself as a maintainers for all these sub-drivers.
Signed-off-by: Enric Balletbo i Serra
---
MAINTAINERS | 24
1 file changed, 24
documentation.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
Acked-for-MFD-by: Lee Jones
---
Changes in v4:
- Use instead of in documentation.
Changes in v3:
- Fixed build error as reported by the kbuild test robot.
Changes in v2:
- Removed unneeded check of ec_dev.
.../sysfs
The entire way how cros debugfs attibutes are created is broken.
cros_ec_debugfs should be its own driver and its attributes should be
associated with a debugfs driver not the mfd driver.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
Acked-for-MFD-by: Lee Jones
---
Changes
.
- Create the attributes directly instead of use the attach/detach callbacks.
- Remove unnecessary IS_ENABLED.
- Remove dev_err message telling that VBC is found.
- Use dev_warn instead of dev_err as the error is ignored.
- Removed ec_with_lightbar variable.
Enric Balletbo i Serra (7):
mfd / platfor
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v4:
- Use instead in documentation.
Changes in v3:
- Removed unneded check for ec_dev.
Changes in v2:
- Removed the two exported functions to attach/detach to the cros_class.
- Use dev_warn
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the
empty folder is not created, so, the folder is only created if the vbc
is set.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v4:
- get rid of the cros_ec_has_lightbar function.
Changes in v3: None
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 51 --
1 file changed
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
reduces the need of remove callback from platform/chrome for removing the
MFD child devices.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Guenter Roeck
---
Changes in v4:
- Added Reviewed-by tags.
- Moved
The entire way how cros debugfs attibutes are created is broken.
cros_ec_sysfs should be its own driver and its attributes should be
associated with the sysfs driver not the mfd driver.
The patch also adds the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
Acked-for-MFD-by: Lee
On 10/12/18 19:20, Guenter Roeck wrote:
> On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra
> wrote:
>>
>> Due to the way attribute groups visibility work, the function
>> cros_ec_lightbar_attrs_are_visible is called multiple times, once per
>> attribute,
Hi Lee,
On 11/12/18 7:12, Lee Jones wrote:
> On Mon, 10 Dec 2018, Enric Balletbo i Serra wrote:
>
>> The driver adds different MFD child devices via mfd_add_devices() and
>> hence it is required to call mfd_remove_devices() to remove MFD child
>> devices.
>>
&g
Hi Guenter,
On 10/12/18 19:13, Guenter Roeck wrote:
> On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra
> wrote:
>>
>> The entire way how cros debugfs attibutes are created is broken.
>> cros_ec_sysfs should be its own driver and its attributes should be
>> as
The driver adds different MFD child devices via mfd_add_devices() and
hence it is required to call mfd_remove_devices() to remove MFD child
devices.
Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd")
Cc: sta...@vger.kernel.org
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra
Tested-by: Robert Jarzmik
Acked-by: Daniel Thompson
---
Changes in v3:
- Fixed some typos in commit message.
- Removed ' in Fixes tag.
Changes in v2:
- Rebase on top of mainline
- Add Tested-by and Acked-by tags.
drivers/video/bac
]
__arm64_sys_delete_module+0x16c/0x1f8
el0_svc_common+0x84/0xd8
el0_svc_handler+0x2c/0x80
el0_svc+0x8/0xc
---[ end trace a57c4625f3c60ae8 ]---
Cc: sta...@vger.kernel.org
Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")
Signed-off-by: Enric Balletbo i Serra
---
d
]
__arm64_sys_delete_module+0x16c/0x1f8
el0_svc_common+0x84/0xd8
el0_svc_handler+0x2c/0x80
el0_svc+0x8/0xc
---[ end trace a57c4625f3c60ae8 ]---
Cc: sta...@vger.kernel.org
Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")
Signed-off-by: Enric Balletbo i Serra
---
d
Hi Lee,
On 4/12/18 10:21, Lee Jones wrote:
> On Mon, 03 Dec 2018, Enric Balletbo i Serra wrote:
>> On 3/12/18 11:36, Lee Jones wrote:
>>> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>>>
>>>> The entire way how cros sysfs attibutes are created is brok
Hi Lee,
On 4/12/18 10:21, Lee Jones wrote:
> On Mon, 03 Dec 2018, Enric Balletbo i Serra wrote:
>> On 3/12/18 11:36, Lee Jones wrote:
>>> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>>>
>>>> The entire way how cros sysfs attibutes are created is brok
Hi Lee,
On 3/12/18 11:36, Lee Jones wrote:
> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>
>> The entire way how cros sysfs attibutes are created is broken.
>> cros_ec_lightbar should be its own driver and its attributes should be
>> associated with a lightbar d
Hi Lee,
On 3/12/18 11:36, Lee Jones wrote:
> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>
>> The entire way how cros sysfs attibutes are created is broken.
>> cros_ec_lightbar should be its own driver and its attributes should be
>> associated with a lightbar d
Hi Lee,
On 3/12/18 11:32, Lee Jones wrote:
> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>
>> Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
>> reduces the need of remove callback from platform/chrome for removing the
>> MFD child d
Hi Lee,
On 3/12/18 11:32, Lee Jones wrote:
> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:
>
>> Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
>> reduces the need of remove callback from platform/chrome for removing the
>> MFD child d
Hi Pavel,
Thanks for the feedback.
On 24/11/18 0:22, Pavel Machek wrote:
> Hi!
>
>> We have a problem with USBPD chargers which under certain conditions
>> can result in system overheating if the voltage provided by the USBPD
>> port is too high. While the preferred means to control this would
Hi Pavel,
Thanks for the feedback.
On 24/11/18 0:22, Pavel Machek wrote:
> Hi!
>
>> We have a problem with USBPD chargers which under certain conditions
>> can result in system overheating if the voltage provided by the USBPD
>> port is too high. While the preferred means to control this would
Roeck wrote:
>>>> Hi Enric,
>>>>
>>>> On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra
>>>> wrote:
>>>>>
>>>>> Devices are required to provide a release method. This patch fixes the
>>>>> follo
Roeck wrote:
>>>> Hi Enric,
>>>>
>>>> On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra
>>>> wrote:
>>>>>
>>>>> Devices are required to provide a release method. This patch fixes the
>>>>> follo
Hi Dan,
On 29/11/18 12:21, Dan Carpenter wrote:
> Hi Enric,
>
> I love your patch! Perhaps something to improve:
>
> url:
> https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/mfd-cros_ec-use-devm_mfd_add_devices/20181123-025253
>
> smatch warnings:
&
Hi Dan,
On 29/11/18 12:21, Dan Carpenter wrote:
> Hi Enric,
>
> I love your patch! Perhaps something to improve:
>
> url:
> https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/mfd-cros_ec-use-devm_mfd_add_devices/20181123-025253
>
> smatch warnings:
&
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
reduces the need of remove callback from platform/chrome for removing the
MFD child devices.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Removed cros_ec_remove from include file.
Changes in v2:
- Use devm
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This
reduces the need of remove callback from platform/chrome for removing the
MFD child devices.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Removed cros_ec_remove from include file.
Changes in v2:
- Use devm
documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Fixed build error as reported by the kbuild test robot.
Changes in v2:
- Removed unneeded check of ec_dev.
.../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++
drivers/mfd/cros_ec_dev.c | 2 +-
drivers
documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Fixed build error as reported by the kbuild test robot.
Changes in v2:
- Removed unneeded check of ec_dev.
.../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++
drivers/mfd/cros_ec_dev.c | 2 +-
drivers
es.
Enric Balletbo i Serra (8):
mfd / platform: cros_ec: use devm_mfd_add_devices.
mfd / platform: cros_ec: move lightbar attributes to its own driver.
mfd / platform: cros_ec: move vbc attributes to its own driver.
mfd / platform: cros_ec: move debugfs attributes to its own driver.
mfd
-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Fix WARN when unloading. This is new in these series.
drivers/mfd/cros_ec_dev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 1ba98a32715e..cdb941c6db98
es.
Enric Balletbo i Serra (8):
mfd / platform: cros_ec: use devm_mfd_add_devices.
mfd / platform: cros_ec: move lightbar attributes to its own driver.
mfd / platform: cros_ec: move vbc attributes to its own driver.
mfd / platform: cros_ec: move debugfs attributes to its own driver.
mfd
-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Fix WARN when unloading. This is new in these series.
drivers/mfd/cros_ec_dev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 1ba98a32715e..cdb941c6db98
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the empty
folder is not created, so, the folder is only created if the vbc is set.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Fixed
The entire way how cros debugfs attibutes are created is broken.
cros_ec_sysfs should be its own driver and its attributes should be
associated with the sysfs driver not the mfd driver.
The patch also adds the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Do
The entire way how cros debugfs attibutes are created is broken.
cros_ec_debugfs should be its own driver and its attributes should be
associated with a debugfs driver not the mfd driver.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Add a "de
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Removed unneded check for ec_dev.
Changes in v2:
- Removed the two exported functions to attach/detach to the cros_class.
- Use dev_warn instead of dev_err when adding the lightbar.
...sfs-class-chromeos-driver
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the empty
folder is not created, so, the folder is only created if the vbc is set.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Fixed
The entire way how cros debugfs attibutes are created is broken.
cros_ec_sysfs should be its own driver and its attributes should be
associated with the sysfs driver not the mfd driver.
The patch also adds the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Do
The entire way how cros debugfs attibutes are created is broken.
cros_ec_debugfs should be its own driver and its attributes should be
associated with a debugfs driver not the mfd driver.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Add a "de
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Removed unneded check for ec_dev.
Changes in v2:
- Removed the two exported functions to attach/detach to the cros_class.
- Use dev_warn instead of dev_err when adding the lightbar.
...sfs-class-chromeos-driver
.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 37 --
1 file changed, 13 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b
.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3: None
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 37 --
1 file changed, 13 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Removed the two exported functions to attach/detach to the cros_class.
- Use dev_warn instead of dev_err when adding the lightbar.
...sfs-class-chromeos-driver-cros-ec-lightbar | 74 +
drivers/mfd
ve dev_err message telling that VBC is found.
- Use dev_warn instead of dev_err as the error is ignored.
- Removed ec_with_lightbar variable.
- Fix WARN when unloading. This is new in these series.
Enric Balletbo i Serra (8):
mfd / platform: cros_ec: use devm_mfd_add_devices.
mfd / platform: cro
documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Remove unneeded check of ec_dev.
.../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++
drivers/mfd/cros_ec_dev.c | 14 +-
drivers/platform/chrome/Kconfig | 10 +
drivers/platform/chrome
the sysfs documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Removed the two exported functions to attach/detach to the cros_class.
- Use dev_warn instead of dev_err when adding the lightbar.
...sfs-class-chromeos-driver-cros-ec-lightbar | 74 +
drivers/mfd
ve dev_err message telling that VBC is found.
- Use dev_warn instead of dev_err as the error is ignored.
- Removed ec_with_lightbar variable.
- Fix WARN when unloading. This is new in these series.
Enric Balletbo i Serra (8):
mfd / platform: cros_ec: use devm_mfd_add_devices.
mfd / platform: cro
documentation.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Remove unneeded check of ec_dev.
.../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++
drivers/mfd/cros_ec_dev.c | 14 +-
drivers/platform/chrome/Kconfig | 10 +
drivers/platform/chrome
-by: Enric Balletbo i Serra
---
Changes in v2:
- Fix WARN when unloading. This is new in these series.
drivers/mfd/cros_ec_dev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 13b6dc26dc9a..bd561e91153a 100644
--- a/drivers/mfd
.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 40 +++---
1 file changed, 12 insertions(+), 28 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b/drivers/platform
.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Removed ec_with_lightbar variable.
drivers/platform/chrome/cros_ec_lightbar.c | 40 +++---
1 file changed, 12 insertions(+), 28 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c
b/drivers/platform
-by: Enric Balletbo i Serra
---
Changes in v2:
- Fix WARN when unloading. This is new in these series.
drivers/mfd/cros_ec_dev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 13b6dc26dc9a..bd561e91153a 100644
--- a/drivers/mfd
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the empty
folder is not created, so, the folder is only created if the vbc is set.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Remove
a bit the actual behaviour.
Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder
is created in /sys/class/chromeos/, after the patch the empty
folder is not created, so, the folder is only created if the vbc is set.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Remove
701 - 800 of 2632 matches
Mail list logo
