[PATCH v2 5/8] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

2018-11-26 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_sysfs should be its own driver and its attributes should be associated with the sysfs driver not the mfd driver. The patch also adds the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- Changes in v2

[PATCH v2 5/8] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

2018-11-26 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_sysfs should be its own driver and its attributes should be associated with the sysfs driver not the mfd driver. The patch also adds the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- Changes in v2

[PATCH v2 1/8] mfd / platform: cros_ec: use devm_mfd_add_devices.

2018-11-26 Thread Enric Balletbo i Serra
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This reduces the need of remove callback from platform/chrome for removing the MFD child devices. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Use devm only for the cros-ec core. drivers/mfd/cros_ec.c

[PATCH v2 4/8] mfd / platform: cros_ec: move debugfs attributes to its own driver.

2018-11-26 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_debugfs should be its own driver and its attributes should be associated with a debugfs driver not the mfd driver. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Add a "default MFD_CROS_EC_CHARDEV"

[PATCH v2 1/8] mfd / platform: cros_ec: use devm_mfd_add_devices.

2018-11-26 Thread Enric Balletbo i Serra
Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This reduces the need of remove callback from platform/chrome for removing the MFD child devices. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Use devm only for the cros-ec core. drivers/mfd/cros_ec.c

[PATCH v2 4/8] mfd / platform: cros_ec: move debugfs attributes to its own driver.

2018-11-26 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_debugfs should be its own driver and its attributes should be associated with a debugfs driver not the mfd driver. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Add a "default MFD_CROS_EC_CHARDEV"

Re: [PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 18:41, Guenter Roeck wrote: > Hi Enric, > > On Thu, Nov 22, 2018 at 12:33:51PM +0100, Enric Balletbo i Serra wrote: >> The entire way how cros sysfs attibutes are created is broken. >> cros_ec_lightbar should be its own driver and its attributes sh

Re: [PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 18:41, Guenter Roeck wrote: > Hi Enric, > > On Thu, Nov 22, 2018 at 12:33:51PM +0100, Enric Balletbo i Serra wrote: >> The entire way how cros sysfs attibutes are created is broken. >> cros_ec_lightbar should be its own driver and its attributes sh

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: >> Due to the way attribute groups visibility work, the function >> cros_ec_lightbar_attrs_are_visible is called multiple times, once per >>

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: >> Due to the way attribute groups visibility work, the function >> cros_ec_lightbar_attrs_are_visible is called multiple times, once per >>

Re: [PATCH 6/7] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:14, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:55PM +0100, Enric Balletbo i Serra wrote: >> The cros-ec-vbc driver is DT-only and there is a DT property that >> indicates if the EC has the VCB NVRAM, in such case instantiate the >> driver

Re: [PATCH 6/7] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:14, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:55PM +0100, Enric Balletbo i Serra wrote: >> The cros-ec-vbc driver is DT-only and there is a DT property that >> indicates if the EC has the VCB NVRAM, in such case instantiate the >> driver

[PATCH 5/7] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_sysfs should be its own driver and its attributes should be associated with the sysfs driver not the mfd driver. The patch also adds the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- .../ABI/testing

[PATCH 5/7] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_sysfs should be its own driver and its attributes should be associated with the sysfs driver not the mfd driver. The patch also adds the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- .../ABI/testing

[PATCH 6/7] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

2018-11-22 Thread Enric Balletbo i Serra
a bit the actual behaviour. Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder is created in /sys/class/chromeos/, after the patch the empty folder is not created, so, the folder is only created if the vbc is set. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd

[PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- ...sfs-class-chromeos-driver-cros-ec-lightbar | 74 + drivers/mfd/cros_ec_dev.c | 37 +-- drivers/mfd/cros_ec_dev.h | 6 -- drivers/platform/chrome/Kconfig

[PATCH 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers.

2018-11-22 Thread Enric Balletbo i Serra
. Waiting for your feedback. Best regards, Enric Enric Balletbo i Serra (7): mfd: cros_ec: use devm_mfd_add_devices. mfd / platform: cros_ec: move lightbar attributes to its own driver. mfd / platform: cros_ec: move vbc attributes to its own driver. mfd / platform: cros_ec: move debugfs

[PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_lightbar.c | 29 +- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c index 31d22f594fac

[PATCH 6/7] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

2018-11-22 Thread Enric Balletbo i Serra
a bit the actual behaviour. Before the patch if an EC doesn't have a VBC NVRAM an empty vbc folder is created in /sys/class/chromeos/, after the patch the empty folder is not created, so, the folder is only created if the vbc is set. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd

[PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
the sysfs documentation. Signed-off-by: Enric Balletbo i Serra --- ...sfs-class-chromeos-driver-cros-ec-lightbar | 74 + drivers/mfd/cros_ec_dev.c | 37 +-- drivers/mfd/cros_ec_dev.h | 6 -- drivers/platform/chrome/Kconfig

[PATCH 0/7] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers.

2018-11-22 Thread Enric Balletbo i Serra
. Waiting for your feedback. Best regards, Enric Enric Balletbo i Serra (7): mfd: cros_ec: use devm_mfd_add_devices. mfd / platform: cros_ec: move lightbar attributes to its own driver. mfd / platform: cros_ec: move vbc attributes to its own driver. mfd / platform: cros_ec: move debugfs

[PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_lightbar.c | 29 +- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c index 31d22f594fac

[PATCH 1/7] mfd: cros_ec: use devm_mfd_add_devices.

2018-11-22 Thread Enric Balletbo i Serra
Use devm_mfd_add_devices() for adding MFD child devices. This reduces the need of remove callback for removing MFD child devices. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec.c | 12 ++-- drivers/mfd/cros_ec_dev.c | 8 drivers

[PATCH 4/7] mfd / platform: cros_ec: move debugfs attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_debugfs should be its own driver and its attributes should be associated with a debugfs driver not the mfd driver. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 41

[PATCH 1/7] mfd: cros_ec: use devm_mfd_add_devices.

2018-11-22 Thread Enric Balletbo i Serra
Use devm_mfd_add_devices() for adding MFD child devices. This reduces the need of remove callback for removing MFD child devices. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec.c | 12 ++-- drivers/mfd/cros_ec_dev.c | 8 drivers

[PATCH 4/7] mfd / platform: cros_ec: move debugfs attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
The entire way how cros debugfs attibutes are created is broken. cros_ec_debugfs should be its own driver and its attributes should be associated with a debugfs driver not the mfd driver. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 41

[PATCH 3/7] mfd / platform: cros_ec: move vbc attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
documentation. Signed-off-by: Enric Balletbo i Serra --- .../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++ drivers/mfd/cros_ec_dev.c | 2 +- drivers/platform/chrome/Kconfig | 10 drivers/platform/chrome/Makefile | 3 +- drivers/platform/chrome

[PATCH 3/7] mfd / platform: cros_ec: move vbc attributes to its own driver.

2018-11-22 Thread Enric Balletbo i Serra
documentation. Signed-off-by: Enric Balletbo i Serra --- .../sysfs-class-chromeos-driver-cros-ec-vbc | 6 +++ drivers/mfd/cros_ec_dev.c | 2 +- drivers/platform/chrome/Kconfig | 10 drivers/platform/chrome/Makefile | 3 +- drivers/platform/chrome

[PATCH v2 1/2] power: supply: add input voltage limit property.

2018-11-22 Thread Enric Balletbo i Serra
a means to set a voltage limit. This patch exposes a new property, similar to input current limit, to re-configure the maximum voltage from the external supply at runtime based on system-level knowledge or user input. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes

[PATCH v2 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-22 Thread Enric Balletbo i Serra
knowledge or user input. By default there is no limit, this is reported as a -1 when reading from userspace. Writing a value will set the current or voltage limit in uA or uV, and writing any negative value will remove that limit. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Fix

[PATCH v2 1/2] power: supply: add input voltage limit property.

2018-11-22 Thread Enric Balletbo i Serra
a means to set a voltage limit. This patch exposes a new property, similar to input current limit, to re-configure the maximum voltage from the external supply at runtime based on system-level knowledge or user input. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes

[PATCH v2 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-22 Thread Enric Balletbo i Serra
knowledge or user input. By default there is no limit, this is reported as a -1 when reading from userspace. Writing a value will set the current or voltage limit in uA or uV, and writing any negative value will remove that limit. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Fix

[PATCH 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-21 Thread Enric Balletbo i Serra
knowledge or user input. By default there is no limit, this is reported as a -1 when reading from userspace. Writing a value will set the current or voltage limit in uA or uV, and writing any negative value will remove that limit. Signed-off-by: Enric Balletbo i Serra --- drivers/power/supply

[PATCH 1/2] power: supply: add input voltage limit property.

2018-11-21 Thread Enric Balletbo i Serra
a means to set a voltage limit. This patch exposes a new property, similar to input current limit, to re-configure the maximum voltage from the external supply at runtime based on system-level knowledge or user input. Signed-off-by: Enric Balletbo i Serra --- Documentation/power

[PATCH 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-21 Thread Enric Balletbo i Serra
knowledge or user input. By default there is no limit, this is reported as a -1 when reading from userspace. Writing a value will set the current or voltage limit in uA or uV, and writing any negative value will remove that limit. Signed-off-by: Enric Balletbo i Serra --- drivers/power/supply

[PATCH 1/2] power: supply: add input voltage limit property.

2018-11-21 Thread Enric Balletbo i Serra
a means to set a voltage limit. This patch exposes a new property, similar to input current limit, to re-configure the maximum voltage from the external supply at runtime based on system-level knowledge or user input. Signed-off-by: Enric Balletbo i Serra --- Documentation/power

[PATCH] arm64: dts: rockchip: Use default brightness table for gru.

2018-10-16 Thread Enric Balletbo i Serra
human eye. Use that table instead of have a DT-defined table with less granularity. Signed-off-by: Enric Balletbo i Serra --- Hi Heiko, Note that the patch was only tested on a Samsung Chromebook Plus (kevin), will be very interesting if someone can test on other gru-based devices, like Bob, be

[PATCH] arm64: dts: rockchip: Use default brightness table for gru.

2018-10-16 Thread Enric Balletbo i Serra
human eye. Use that table instead of have a DT-defined table with less granularity. Signed-off-by: Enric Balletbo i Serra --- Hi Heiko, Note that the patch was only tested on a Samsung Chromebook Plus (kevin), will be very interesting if someone can test on other gru-based devices, like Bob, be

[PATCH] clk: rockchip: Fix static checker warning in rockchip_ddrclk_get_parent call

2018-10-16 Thread Enric Balletbo i Serra
already ensures the validity of the clk index returned (index >= core->num_parents). Fixes: a4f182bf81f18 ("clk: rockchip: add new clock-type for the ddrclk") Signed-off-by: Enric Balletbo i Serra --- drivers/clk/rockchip/clk-ddr.c | 4 1 file changed, 4 deletions(-) diff

[PATCH] clk: rockchip: Fix static checker warning in rockchip_ddrclk_get_parent call

2018-10-16 Thread Enric Balletbo i Serra
already ensures the validity of the clk index returned (index >= core->num_parents). Fixes: a4f182bf81f18 ("clk: rockchip: add new clock-type for the ddrclk") Signed-off-by: Enric Balletbo i Serra --- drivers/clk/rockchip/clk-ddr.c | 4 1 file changed, 4 deletions(-) diff

[PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor

2018-10-16 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- drivers/devfreq/devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 62ead442a872..b10124c7308f 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfre

[PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor

2018-10-16 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- drivers/devfreq/devfreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 62ead442a872..b10124c7308f 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfre

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Enric Balletbo i Serra
tream version if is preferred. Neil, can you give us your Tested-by to have the make sure this doesn't break with protocol v1, I don't have such hardware. Benson, will be really good have this merged in this rc. Are you fine with this solution? BTW, you can add my in next version. Acked-by: Enric Balletbo i Serra

Re: [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer

2018-10-03 Thread Enric Balletbo i Serra
tream version if is preferred. Neil, can you give us your Tested-by to have the make sure this doesn't break with protocol v1, I don't have such hardware. Benson, will be really good have this merged in this rc. Are you fine with this solution? BTW, you can add my in next version. Acked-by: Enric Balletbo i Serra

[RESEND PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-08-27 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chanwoo Choi --- Changes in v5: - Requested by MyungJoo and Chanwoo. - Fix returning without the lock acquired after request_module. - Requested by Chanwoo. - In request governor

[RESEND PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-08-27 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chanwoo Choi --- Changes in v5: - Requested by MyungJoo and Chanwoo. - Fix returning without the lock acquired after request_module. - Requested by Chanwoo. - In request governor

Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-16 Thread Enric Balletbo i Serra
Hi Rob, On 16/08/18 00:21, Rob Herring wrote: > On Wed, Aug 15, 2018 at 11:59:32AM +0200, Enric Balletbo i Serra wrote: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properties. The extcon property is used to

Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-16 Thread Enric Balletbo i Serra
Hi Rob, On 16/08/18 00:21, Rob Herring wrote: > On Wed, Aug 15, 2018 at 11:59:32AM +0200, Enric Balletbo i Serra wrote: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properties. The extcon property is used to

Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-15 Thread Enric Balletbo i Serra
Hi Heiko, On 15/08/18 12:29, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properti

Re: [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-15 Thread Enric Balletbo i Serra
Hi Heiko, On 15/08/18 12:29, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properti

Re: [PATCH 3/4] phy: rockchip-inno-usb2: allow to force the B-Device Session Valid bit.

2018-08-15 Thread Enric Balletbo i Serra
Hi Heiko, On 15/08/18 12:18, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 15. August 2018, 11:59:33 CEST schrieb Enric Balletbo i Serra: >> The OTG disconnection event is generated after the presence/abscense of >> an ID connection, but some platforms doesn't have the

Re: [PATCH 3/4] phy: rockchip-inno-usb2: allow to force the B-Device Session Valid bit.

2018-08-15 Thread Enric Balletbo i Serra
Hi Heiko, On 15/08/18 12:18, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 15. August 2018, 11:59:33 CEST schrieb Enric Balletbo i Serra: >> The OTG disconnection event is generated after the presence/abscense of >> an ID connection, but some platforms doesn't have the

[PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-15 Thread Enric Balletbo i Serra
properties in the documentation binding. Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Enric Balletbo i Serra --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Docu

[PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties.

2018-08-15 Thread Enric Balletbo i Serra
properties in the documentation binding. Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Enric Balletbo i Serra --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Docu

[PATCH 0/4] phy: rockchip-inno-usb2: document improvements and allow to force B-device valid session bit.

2018-08-15 Thread Enric Balletbo i Serra
ethernet gadget my workstation with the chromebook through a usb-a to type-c cable. Best regards, Enric Enric Balletbo i Serra (4): phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation. dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid

[PATCH 0/4] phy: rockchip-inno-usb2: document improvements and allow to force B-device valid session bit.

2018-08-15 Thread Enric Balletbo i Serra
ethernet gadget my workstation with the chromebook through a usb-a to type-c cable. Best regards, Enric Enric Balletbo i Serra (4): phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation. dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid

[PATCH 1/4] phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation.

2018-08-15 Thread Enric Balletbo i Serra
ber 'dev' not described in 'rockchip_usb2phy' :234: warning: Function parameter or member 'clk480m_hw' not described in 'rockchip_usb2phy' Signed-off-by: Enric Balletbo i Serra --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 35 ++- 1 file changed, 19 insertions(+),

[PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property.

2018-08-15 Thread Enric Balletbo i Serra
This property is used when the otg-id pin is not connected. When this property is set it forces to set the B-Device Session Valid bit when the port works as device and clears that bit when the port works as host. Signed-off-by: Enric Balletbo i Serra --- .../devicetree/bindings/phy/phy

[PATCH 3/4] phy: rockchip-inno-usb2: allow to force the B-Device Session Valid bit.

2018-08-15 Thread Enric Balletbo i Serra
device The patch allows to tell the PHY to force the B-Device Session Valid bit when the OTG role is device and clear that bit if the OTG role is host. Signed-off-by: Enric Balletbo i Serra --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 35 +++ 1 file changed, 35 insertions

[PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property.

2018-08-15 Thread Enric Balletbo i Serra
This property is used when the otg-id pin is not connected. When this property is set it forces to set the B-Device Session Valid bit when the port works as device and clears that bit when the port works as host. Signed-off-by: Enric Balletbo i Serra --- .../devicetree/bindings/phy/phy

[PATCH 3/4] phy: rockchip-inno-usb2: allow to force the B-Device Session Valid bit.

2018-08-15 Thread Enric Balletbo i Serra
device The patch allows to tell the PHY to force the B-Device Session Valid bit when the OTG role is device and clear that bit if the OTG role is host. Signed-off-by: Enric Balletbo i Serra --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 35 +++ 1 file changed, 35 insertions

[PATCH 1/4] phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation.

2018-08-15 Thread Enric Balletbo i Serra
ber 'dev' not described in 'rockchip_usb2phy' :234: warning: Function parameter or member 'clk480m_hw' not described in 'rockchip_usb2phy' Signed-off-by: Enric Balletbo i Serra --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 35 ++- 1 file changed, 19 insertions(+),

[PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-08-14 Thread Enric Balletbo i Serra
The "atomic" API allows us to configure PWM period and duty_cycle and enable it in one call. The patch also moves the pwm_init_state just before any use of the pwm_state struct, this fixes a potential bug where pwm_get_state can be called before pwm_init_state. Signed-off-by: Enric

[PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-08-14 Thread Enric Balletbo i Serra
The "atomic" API allows us to configure PWM period and duty_cycle and enable it in one call. The patch also moves the pwm_init_state just before any use of the pwm_state struct, this fixes a potential bug where pwm_get_state can be called before pwm_init_state. Signed-off-by: Enric

Re: [PATCH v1] arm64: dts: rockchip: add support for ROC-RK3399-PC board

2018-07-26 Thread Enric Balletbo i Serra
Hi Levin, Some few comments. On 26/07/18 09:13, d...@t-chip.com.cn wrote: > From: Levin Du > > ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board > computer with USB 3.0 and Gigabit Ethernet in a form factor > compatible with the Raspberry Pi. It is based on the Rockchip > RK3399 SoC,

Re: [PATCH v1] arm64: dts: rockchip: add support for ROC-RK3399-PC board

2018-07-26 Thread Enric Balletbo i Serra
Hi Levin, Some few comments. On 26/07/18 09:13, d...@t-chip.com.cn wrote: > From: Levin Du > > ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board > computer with USB 3.0 and Gigabit Ethernet in a form factor > compatible with the Raspberry Pi. It is based on the Rockchip > RK3399 SoC,

[PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments.

2018-07-18 Thread Enric Balletbo i Serra
by kerneldoc script. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.h| 13 +- include/linux/mfd/cros_ec.h | 214 ++- include/linux/mfd/cros_ec_commands.h | 295 +-- 3 files changed, 310 insertions(+), 212 deletions

[PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments.

2018-07-18 Thread Enric Balletbo i Serra
by kerneldoc script. Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.h| 13 +- include/linux/mfd/cros_ec.h | 214 ++- include/linux/mfd/cros_ec_commands.h | 295 +-- 3 files changed, 310 insertions(+), 212 deletions

[PATCH 0/2] mfd: platform/chrome: some more cleanups between these subsystems.

2018-07-18 Thread Enric Balletbo i Serra
. Best regards, Enric Enric Balletbo i Serra (2): platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform. mfd: cros_ec: Fix and improve kerneldoc comments. drivers/mfd/cros_ec_dev.h | 13 +- drivers/platform/chrome/cros_ec_lpc.c | 3 +- drivers

[PATCH 1/2] platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform.

2018-07-18 Thread Enric Balletbo i Serra
the includes from include/linux/mfd to drivers/platform/chrome. Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_lpc.c | 3 ++- drivers/platform/chrome/cros_ec_lpc_mec.c | 3 ++- .../linux/mfd => drivers/platform/chr

[PATCH 0/2] mfd: platform/chrome: some more cleanups between these subsystems.

2018-07-18 Thread Enric Balletbo i Serra
. Best regards, Enric Enric Balletbo i Serra (2): platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform. mfd: cros_ec: Fix and improve kerneldoc comments. drivers/mfd/cros_ec_dev.h | 13 +- drivers/platform/chrome/cros_ec_lpc.c | 3 +- drivers

[PATCH 1/2] platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform.

2018-07-18 Thread Enric Balletbo i Serra
the includes from include/linux/mfd to drivers/platform/chrome. Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_lpc.c | 3 ++- drivers/platform/chrome/cros_ec_lpc_mec.c | 3 ++- .../linux/mfd => drivers/platform/chr

Re: [PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-18 Thread Enric Balletbo i Serra
Hi MyungJoo, On 05/07/18 02:13, Chanwoo Choi wrote: > Hi Enric, > > 2018-07-04 17:45 GMT+09:00 Enric Balletbo i Serra > : >> When the devfreq driver and the governor driver are built as modules, >> the call to devfreq_add_device() or governor_store() fails becaus

Re: [PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-18 Thread Enric Balletbo i Serra
Hi MyungJoo, On 05/07/18 02:13, Chanwoo Choi wrote: > Hi Enric, > > 2018-07-04 17:45 GMT+09:00 Enric Balletbo i Serra > : >> When the devfreq driver and the governor driver are built as modules, >> the call to devfreq_add_device() or governor_store() fails becaus

[PATCH 2/5] arm64: defconfig: Enable Infineon TPM security chip.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks (like the Samsung Chromebook Plus) have a TPM security chip that is compliant with the TCG TIS 1.2 TPM specification and Infineon's I2C Protocol Stack. So, add support in the defconfig. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 2 ++ 1 file

[PATCH 3/5] arm64: defconfig: Enable vctrl regulators for Gru/Kevin.

2018-07-17 Thread Enric Balletbo i Serra
Gru/Kevin uses vctrl regulators for dynamic CPU voltages, so enable in the default defconfig in order to have support for cpufreq. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch

[PATCH 2/5] arm64: defconfig: Enable Infineon TPM security chip.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks (like the Samsung Chromebook Plus) have a TPM security chip that is compliant with the TCG TIS 1.2 TPM specification and Infineon's I2C Protocol Stack. So, add support in the defconfig. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 2 ++ 1 file

[PATCH 3/5] arm64: defconfig: Enable vctrl regulators for Gru/Kevin.

2018-07-17 Thread Enric Balletbo i Serra
Gru/Kevin uses vctrl regulators for dynamic CPU voltages, so enable in the default defconfig in order to have support for cpufreq. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch

[PATCH 4/5] arm64: defconfig: Enable Camera (uvcvideo) support.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks have a UVC camera device, so enable in the default defconfig to support it. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH 4/5] arm64: defconfig: Enable Camera (uvcvideo) support.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks have a UVC camera device, so enable in the default defconfig to support it. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH 5/5] arm64: defconfig: Enable support for SBS battery driver.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks, like the Samsung Chromebook Plus, come with a SBS-compliant gas gauges, so enable the support in the default kernel configuration. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH 5/5] arm64: defconfig: Enable support for SBS battery driver.

2018-07-17 Thread Enric Balletbo i Serra
Some Chromebooks, like the Samsung Chromebook Plus, come with a SBS-compliant gas gauges, so enable the support in the default kernel configuration. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH 1/5] arm64: defconfig: Enable sound support for Samsung Chromebook Plus.

2018-07-17 Thread Enric Balletbo i Serra
Enable the Rockchip sound driver with MAX98357A/RT5514/DA7219 codecs needed for the Samsung Chromebook Plus. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs

[PATCH 1/5] arm64: defconfig: Enable sound support for Samsung Chromebook Plus.

2018-07-17 Thread Enric Balletbo i Serra
Enable the Rockchip sound driver with MAX98357A/RT5514/DA7219 codecs needed for the Samsung Chromebook Plus. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/configs/defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs

[PATCH] arm64: dts: rockchip: remove deprecated Type-C PHY properties on rk3399

2018-07-09 Thread Enric Balletbo i Serra
Commit 0fbc47d9e426 ("phy: rockchip-typec: deprecate some DT properties for various register fields.") deprecates some Rockchip Type-C properties. As these are now not needed, remove from the device tree file. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/r

[PATCH] arm64: dts: rockchip: remove deprecated Type-C PHY properties on rk3399

2018-07-09 Thread Enric Balletbo i Serra
Commit 0fbc47d9e426 ("phy: rockchip-typec: deprecate some DT properties for various register fields.") deprecates some Rockchip Type-C properties. As these are now not needed, remove from the device tree file. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/r

[RESEND PATCH] ARM: multi_v7_defconfig: Enable missing drivers for supported Chromebooks.

2018-07-04 Thread Enric Balletbo i Serra
for all Veyron boards. - ChromeOS EC userspace interface for all chromebooks boards. - ChromeOS EC light and proximity sensors for some chromebooks. Signed-off-by: Enric Balletbo i Serra --- Fixed some conflicts when I picked up the old patch [1] [1] https://patchwork.kernel.org/patch/10300677

[RESEND PATCH] ARM: multi_v7_defconfig: Enable missing drivers for supported Chromebooks.

2018-07-04 Thread Enric Balletbo i Serra
for all Veyron boards. - ChromeOS EC userspace interface for all chromebooks boards. - ChromeOS EC light and proximity sensors for some chromebooks. Signed-off-by: Enric Balletbo i Serra --- Fixed some conflicts when I picked up the old patch [1] [1] https://patchwork.kernel.org/patch/10300677

Re: [RESEND PATCH v3 2/2] thermal: core: introduce thermal zone device mode control

2018-07-04 Thread Enric Balletbo i Serra
want to double check and >> perhaps learn a thing or two. >> >> On Mon, Feb 26, 2018 at 03:41:18PM +0100, Enric Balletbo i Serra wrote: >>> From: Zhang Rui >>> >>> Thermal "mode" sysfs attribute is introduced to enable/disable a thermal >>>

Re: [RESEND PATCH v3 2/2] thermal: core: introduce thermal zone device mode control

2018-07-04 Thread Enric Balletbo i Serra
want to double check and >> perhaps learn a thing or two. >> >> On Mon, Feb 26, 2018 at 03:41:18PM +0100, Enric Balletbo i Serra wrote: >>> From: Zhang Rui >>> >>> Thermal "mode" sysfs attribute is introduced to enable/disable a thermal >>>

[PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-04 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra --- Changes in v5: - Requested by MyungJoo and Chanwoo. - Fix returning without the lock acquired after request_module. - Requested by Chanwoo. - In request governor function check if governor name

[PATCH v5] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-04 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra --- Changes in v5: - Requested by MyungJoo and Chanwoo. - Fix returning without the lock acquired after request_module. - Requested by Chanwoo. - In request governor function check if governor name

Re: [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-04 Thread Enric Balletbo i Serra
Hi Chanwoo, On 04/07/18 03:06, Chanwoo Choi wrote: > Hi Enric, > > On 2018년 07월 03일 22:29, Enric Balletbo i Serra wrote: >> When the devfreq driver and the governor driver are built as modules, >> the call to devfreq_add_device() or governor_store() fails because t

Re: [PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-04 Thread Enric Balletbo i Serra
Hi Chanwoo, On 04/07/18 03:06, Chanwoo Choi wrote: > Hi Enric, > > On 2018년 07월 03일 22:29, Enric Balletbo i Serra wrote: >> When the devfreq driver and the governor driver are built as modules, >> the call to devfreq_add_device() or governor_store() fails because t

[PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-03 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra --- Changes in v4: - Kept "locked" devfreq_list from the return of find_devfreq_governor() to the unlock of governor_store(). Requested by MyungJoo Ham. Changes in v3: - Remove unne

[PATCH v4] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-03 Thread Enric Balletbo i Serra
/ devfreq: map devfreq drivers to governor using name) Signed-off-by: Enric Balletbo i Serra --- Changes in v4: - Kept "locked" devfreq_list from the return of find_devfreq_governor() to the unlock of governor_store(). Requested by MyungJoo Ham. Changes in v3: - Remove unne

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-03 Thread Enric Balletbo i Serra
Hi MyungJoo On 03/07/18 12:57, MyungJoo Ham wrote: >> @@ -988,12 +1030,13 @@ static ssize_t governor_store(struct device *dev, >> struct device_attribute *attr, >> if (ret != 1) >> return -EINVAL; >> >> -mutex_lock(_list_lock); >> -governor =

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-07-03 Thread Enric Balletbo i Serra
Hi MyungJoo On 03/07/18 12:57, MyungJoo Ham wrote: >> @@ -988,12 +1030,13 @@ static ssize_t governor_store(struct device *dev, >> struct device_attribute *attr, >> if (ret != 1) >> return -EINVAL; >> >> -mutex_lock(_list_lock); >> -governor =

[PATCH 0/3] platform/chrome: mfd: Move cros-ec transport drivers to drivers/platform

2018-07-02 Thread Enric Balletbo i Serra
symbols, modifies the defconfigs that used these symbols and fixes the KEYBOARD_CROS_EC Kconfig help. Best regards, Enric Enric Balletbo i Serra (3): platform/chrome: Move cros-ec transport drivers to drivers/platform. arm/arm64: configs: Remove the MFD_ prefix for MFD_CROS_EC_I2C/SPI

[PATCH 3/3] Input: keyboard: Fix ChromeOS EC keyboard help message.

2018-07-02 Thread Enric Balletbo i Serra
The cros-ec I2C and SPI transport drivers have been moved from MFD subsystem to platform/chrome, at the same time, the config symbol has been renamed and lost the MFD_ prefix So, update the help message accordingly. Signed-off-by: Enric Balletbo i Serra --- drivers/input/keyboard/Kconfig | 2

<    4   5   6   7   8   9   10   11   12   13   >