Re: [tip: x86/seves] x86/kvm: Add KVM-specific VMMCALL handling under SEV-ES

2020-10-28 Thread Erdem Aktas
ure how those leaked registers can be used, but depending on which function call hypercall[0-3], there will be some leak. -Erdem On Wed, Oct 28, 2020 at 2:49 AM Joerg Roedel wrote: > > On Tue, Oct 27, 2020 at 04:14:15PM -0700, Erdem Aktas wrote: > > It seems to me that the kvm_sev_

Re: [tip: x86/seves] x86/kvm: Add KVM-specific VMMCALL handling under SEV-ES

2020-10-27 Thread Erdem Aktas
[resending in plain/text, sorry for double sending] It seems to me that the kvm_sev_es_hcall_prepare is leaking more information than it is needed. Is this an expected behavior? -Erdem > > On Thu, Sep 10, 2020 at 2:39 AM tip-bot2 for Tom Lendacky > wrote: >> >> The following commit has been me

Re: [tip: x86/seves] x86/vmware: Add VMware-specific handling for VMMCALL under SEV-ES

2020-10-27 Thread Erdem Aktas
Looking at the VMWARE_VMCALL(cmd, eax, ebx, ecx, edx) definition, it seems to me only 4 registers are required to be shared with hypervisor. I don't know much about vmware but is not vmware_sev_es_hcall_prepare expose more registers than needed and also vmware_sev_es_hcall_finish might let the hypv

Re: [PATCH v4 00/75] x86: SEV-ES Guest Support

2020-07-22 Thread Erdem Aktas
is to retrieve the encryption bit location. -Erdem On Wed, Jul 22, 2020 at 2:04 AM Joerg Roedel wrote: > > Hi Erdem, > > On Tue, Jul 21, 2020 at 09:48:51AM -0700, Erdem Aktas wrote: > > Yes, I am using OVMF with SEV-ES (sev-es-v12 patches applied). I am > > running Ubun

Re: [PATCH v4 00/75] x86: SEV-ES Guest Support

2020-07-21 Thread Erdem Aktas
wrote: > > Hi, > > On Mon, Jul 20, 2020 at 06:09:19PM -0700, Erdem Aktas wrote: > > It looks like there is an expectation that the bootloader will start > > from the 64bit entry point in header_64.S. With the current patch > > series, it will not boot up if the boot

Re: [PATCH v4 00/75] x86: SEV-ES Guest Support

2020-07-20 Thread Erdem Aktas
Hi, It looks like there is an expectation that the bootloader will start from the 64bit entry point in header_64.S. With the current patch series, it will not boot up if the bootloader jumps to the startup_32 entry, which might break some default distro images. What are supported bootloaders and c