RE: [lustre-devel] [PATCH 14/21] staging: lustre: fix assorted checkpatch errors

2018-02-20 Thread Eremin, Dmitry
> -Original Message- > Thanks for the review. Yes, you are correct. > I had seen that end_dirent was initialized to NULL, and let myself > believe that would make the transformation safe. > In fact, that initialization to NULL is pointless as it is never used. > > Maybe this would be bett

RE: [lustre-devel] [PATCH 14/21] staging: lustre: fix assorted checkpatch errors

2018-02-20 Thread Eremin, Dmitry
Hello Neil, > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c > b/drivers/staging/lustre/lustre/mdc/mdc_request.c > index ab48746ce433..bde27acb0dd3 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_request.c > +++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c > @@ -1060,8 +106

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
The logic of the original commit 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") was assumed conditional free of struct kib_conn if the second argument free_conn in function kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn) is true. But this hunk of code was

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 was missed one hunk. Added it now to avoid issue with use after free. Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers