Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 2:14 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit <ere...@dev.mellanox.co.il> > wrote: >> On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Tue, Ap

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 2:14 PM, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit > wrote: >> On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: >>> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >>>> From: Honggang Li >

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >> From: Honggang Li >> >> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which >> is smaller than

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: > On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >> From: Honggang Li >> >> Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which >> is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the >> size of headroom

Re: [PATCH] IB/ipoib: Add readout of statistics using ethtool

ried by ethtool. > > Signed-off-by: Hans Westgaard Ry <hans.westgaard...@oracle.com> > Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > Reviewed-by: Santosh Shilimkar <santosh.shilim...@oracle.com> > Tested-by: Yuval Shaia <yuval.sh...@oracle.com> Acked-by

Re: [PATCH] IB/ipoib: Add readout of statistics using ethtool

Hans Westgaard Ry > Reviewed-by: Yuval Shaia > Reviewed-by: Santosh Shilimkar > Tested-by: Yuval Shaia Acked-by: Erez Shitrit > --- > drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 70 > > 1 file changed, 70 insertions(+) > >

Re: [PATCH] IB/ipoib: optimized the function ipoib_mcast_alloc

On Sun, Nov 1, 2015 at 8:23 AM, Saurabh Sengar wrote: > ipoib_mcast_alloc is called only in atomic context, > hence removing the extra check. > > Signed-off-by: Saurabh Sengar Acked-by: Erez Shitrit > --- > Hi, > Even if in future, if there are some functions expected

Re: [PATCH] IB/ipoib: optimized the function ipoib_mcast_alloc

On Sun, Nov 1, 2015 at 8:23 AM, Saurabh Sengar <saurabh.tr...@gmail.com> wrote: > ipoib_mcast_alloc is called only in atomic context, > hence removing the extra check. > > Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> Acked-by: Erez Shitrit <ere...@mellan

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On Wed, Apr 15, 2015 at 7:06 PM, Jason Gunthorpe wrote: > On Wed, Apr 15, 2015 at 09:17:14AM +0300, Erez Shitrit wrote: >> >>+ /* parent interface */ >> >>+ if (!test_bit(IPOIB_FLAG_SUBINTERFACE, >flags)) >> >>+ return dev-&

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On Wed, Apr 15, 2015 at 7:06 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Apr 15, 2015 at 09:17:14AM +0300, Erez Shitrit wrote: + /* parent interface */ + if (!test_bit(IPOIB_FLAG_SUBINTERFACE, priv-flags)) + return dev-ifindex

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On 4/14/2015 11:41 PM, Jason Gunthorpe wrote: On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitrit wrote: diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 657b89b..11ea6e2 100644 +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On 4/14/2015 11:41 PM, Jason Gunthorpe wrote: On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitrit wrote: diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 657b89b..11ea6e2 100644 +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On Tue, Apr 14, 2015 at 6:20 PM, Honggang Li wrote: > [...] Hi, > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c > b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 657b89b..11ea6e2 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

On Tue, Apr 14, 2015 at 6:20 PM, Honggang Li ho...@redhat.com wrote: [...] Hi, diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 657b89b..11ea6e2 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++