Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Eric Curtin
t to 2 if only HT STAs are associated in BSS, + * however and at least one 20 MHz HT STA is associated + * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated + * (currently non-GF HT station is considered as non-HT STA also) + * / Like Dan said, you need a space after the

Re: [PATCH] Increase limit of max_user_watches from 1/25 to 1/16

2021-01-20 Thread Eric Curtin
On Wed, 20 Jan 2021 at 13:02, Eric Curtin wrote: > > The current default value for max_user_watches is the 1/16 (6.25%) of > the available low memory, divided for the "watch" cost in bytes. > > Tools like inotify-tools and visual studio code, seem to hit these

[PATCH] Increase limit of max_user_watches from 1/25 to 1/16

2021-01-20 Thread Eric Curtin
value for this. Signed-off-by: Eric Curtin --- Documentation/admin-guide/sysctl/fs.rst | 4 ++-- fs/eventpoll.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs

[PATCH] Update Documentation/admin-guide/sysctl/fs.rst

2021-01-20 Thread Eric Curtin
max_user_watches for epoll should say 1/25, rather than 1/32 Signed-off-by: Eric Curtin --- Documentation/admin-guide/sysctl/fs.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst index

[PATCH] rename lpfc_sli4_dump_page_a0 to lpfc_sli4_dump_sfp_pagea0

2021-01-19 Thread Eric Curtin
Comment did not match function signature. Signed-off-by: Eric Curtin --- drivers/scsi/lpfc/lpfc_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c index 3414ffcb26fe..c03a7f12dd65 100644 --- a/drivers/scsi

Solving the portable binaries problem in the elf loader

2020-11-02 Thread Eric Curtin
Hi Guys, I remember watching this YouTube video years ago and something Linus said really stuck with me: https://www.youtube.com/watch?v=5PmHRSeA2c8 It was around the whole binaries, package management problem, because it's been something that has been troublesome for me, building separate binar

Trying to run mptcp on my machine

2020-08-31 Thread Eric Curtin
Hi Guys, I've been trying to get mptcp up and running on my machine (xubuntu 20.04) with little joy. What I did was install 5,8,5 kernel from here: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.8.5/amd64/ Reboot, tried a curl: curl http://www.multipath-tcp.org Nay, Nay, Nay, your have an ol

inotify question on modify events and openat

2020-06-24 Thread Eric Curtin
Hi Guys, In the manpages "man inotify" it is suggested that function calls like write and truncate are modify events. But from this opened issue it appears like openat might be a modify event to inotify also? https://github.com/inotify-tools/inotify-tools/issues/116 Just curious, is this expecte

Re: Looking for an open-source thesis idea

2020-05-27 Thread Eric Curtin
hanks for that. Any other ideas, keep them coming :) On Tue, 26 May 2020 at 08:18, Sandy Harris wrote: > > Eric Curtin wrote: > > > Hope I'm not bothering you. I'm looking for a masters thesis idea, ... > > > I'm really liking this > > new QUIC

Looking for an open-source thesis idea

2020-05-22 Thread Eric Curtin
Hi Guys, Hope I'm not bothering you. I'm looking for a masters thesis idea, and if possible doing one related to open source software (of course I have the option of tying it in to the Powermax kernel I work on also with Dell). One idea that sprung to mind is, I'm really liking this new QUIC (UDP)

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-12-07 Thread Eric Curtin
Hi Guys, I initially thought these patches were a joke. But I guess they are not. I suppose 2018 is the year everything became offensive. Could we avoid the s/fuck/hug/g though? I have nothing against re-wording this stuff to remove the curse word, but it should at least make sense. What's going

Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-05-25 Thread Eric Curtin
On 28 April 2017 at 11:07, Greg KH wrote: > On Sun, Apr 23, 2017 at 03:21:31PM +0100, Eric Curtin wrote: >> checkpatch spits out a warning about the 80 character line limit. Split >> the parameters of these functions onto different lines. Put the ; with >> the macro cal

[PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-04-23 Thread Eric Curtin
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that. Signed-off-by: Eric Curtin --- drivers/staging/fbtft/fbtft

[PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.

2017-04-22 Thread Eric Curtin
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that. Signed-off-by: Eric Curtin --- drivers/staging/fbtft/fbtft

Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

2016-01-30 Thread Eric Curtin
On 30 January 2016 at 12:20, Henrique de Moraes Holschuh wrote: > On Wed, 27 Jan 2016, Joe Perches wrote: >> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: >> > Message gets logged on machines that are well supported. >> > >> > Signed-off-by: Eric Cur

Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

2016-01-27 Thread Eric Curtin
On 28 January 2016 at 00:43, Joe Perches wrote: > On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote: >> On 27 January 2016 at 23:26, Joe Perches wrote: >> > On Wed, 2016-01-27 at 22:14 +, Eric Curtin wrote: >> > > Message gets logged on machines that are

Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

2016-01-27 Thread Eric Curtin
On 27 January 2016 at 23:26, Joe Perches wrote: > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: >> Message gets logged on machines that are well supported. >> >> Signed-off-by: Eric Curtin >> --- >> drivers/platform/x86/thinkpad_acpi.c | 1 - >> 1

[PATCH] Remove ambiguous logging for "Unsupported brightness interface"

2016-01-27 Thread Eric Curtin
Message gets logged on machines that are well supported. Signed-off-by: Eric Curtin --- drivers/platform/x86/thinkpad_acpi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index a268a7a..4eb41aa 100644 --- a/drivers

Re: [PATCH] Remove logging for "Unsupported brightness interface"

2016-01-26 Thread Eric Curtin
On 23 January 2016 at 00:28, Eric Curtin wrote: > Message gets logged on machines that are well supported. > > Signed-off-by: Eric Curtin > --- > drivers/platform/x86/thinkpad_acpi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/thi

Re: [PATCH] Remove logging for "Unsupported brightness interface"

2016-01-21 Thread Eric Curtin
On 16 January 2016 at 23:43, Eric Curtin wrote: > Message gets logged on machines that are well supported. > Fixed one checkpatch.pl ERROR also. > > Signed-off-by: Eric Curtin > --- > drivers/platform/x86/thinkpad_acpi.c | 6 ++ > 1 file changed, 2 insertions(+), 4

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2016-01-06 Thread Eric Curtin
On 6 November 2015 at 17:57, Darren Hart wrote: > > On Fri, Nov 06, 2015 at 03:19:43PM +0100, David Herrmann wrote: > > Hi Darren! > > > > On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart wrote: > > > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh > > > wrote: > > >> On Wed, O

Re: Problems with printk logs and my driver

2015-10-14 Thread Eric Curtin
On 4 October 2015 at 16:28, Alan Stern wrote: > On Sun, 4 Oct 2015, Eric Curtin wrote: > >> Ok so for the fun of it, I changed the VENDOR_ID and DEVICE_ID of my >> keyboard to use the driver for this samsung Wireless keyboard and >> mouse, crazy I know since I have a dif

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Eric Curtin
On 13 October 2015 at 00:24, Dave Chinner wrote: > > On Mon, Oct 12, 2015 at 03:41:35PM -0600, Ross Zwisler wrote: > > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > > Add locking to ensure that DAX faults are

Re: Problems with printk logs and my driver

2015-10-04 Thread Eric Curtin
On 30 September 2015 at 13:07, Austin S Hemmelgarn wrote: > On 2015-09-29 18:11, Eric Curtin wrote: >> >> On 25 September 2015 at 16:45, Austin S Hemmelgarn >> wrote: >>> >>> On 2015-09-25 08:02, Jiri Kosina wrote: >>>> >>>> >

Re: Problems with printk logs and my driver

2015-09-29 Thread Eric Curtin
On 25 September 2015 at 16:45, Austin S Hemmelgarn wrote: > On 2015-09-25 08:02, Jiri Kosina wrote: >> >> On Fri, 25 Sep 2015, Felipe Tonello wrote: >> >>> Maybe a better description on Kconfig and/or comments on source code >>> it's enough. >> >> >> I personally find the current Kconfig descripti

Re: First kernel patch (optimization)

2015-09-29 Thread Eric Curtin
On 29 September 2015 at 14:51, Austin S Hemmelgarn wrote: > On 2015-09-26 09:28, Eric Curtin wrote: >> >> Hi Dimitry, >> >>> Is it Debian-derivative by any chance? Their capslock setup is wonky >>> because CapsLock key does no actually set up as a CapsLock

Re: First kernel patch (optimization)

2015-09-26 Thread Eric Curtin
Hi Dimitry, > Is it Debian-derivative by any chance? Their capslock setup is wonky > because CapsLock key does no actually set up as a CapsLock but another > modifier. Also is it in X or is it on text console? Because X handles > led state on its own... I'm on Fedora 22. Yeah, you're correct X is

Problems with printk logs and my driver

2015-09-23 Thread Eric Curtin
Hi Guys, Just wondering what I am doing wrong. I can't see my logs. I figured out what driver is used for my keyboard and started adding logging: [curtine@localhost ~]$ sudo lsusb -v | grep eyboard -B 13 Bus 001 Device 003: ID 04ca:008d Lite-On Technology Corp. Device Descriptor: bLength

Re: First kernel patch (optimization)

2015-09-22 Thread Eric Curtin
On 22 September 2015 at 18:38, Linus Torvalds wrote: > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: >> My first kernel patch, hope I did everything correctly! Instead of calling >> strlen on every iteration of the for loop, just call it once instead and >> store i

Re: First kernel patch (optimization)

2015-09-16 Thread Eric Curtin
On 16 September 2015 at 21:02, Greg KH wrote: > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: >> Hi Greg, >> >> As I said in the subject of the mail (which I have been since told I >> shouldn't have done this), I'm a noob to kernel code. I

Re: First kernel patch (optimization)

2015-09-16 Thread Eric Curtin
:45:53AM -0400, Austin S Hemmelgarn wrote: > > On 2015-09-15 20:09, Steve Calfee wrote: > > >On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin > > >wrote: > > >>Signed-off-by: Eric Curtin > > >> > > >>diff --git a/tools/usb/usbip/src/usb

tools: usbip: detach: avoid calling strlen() at each iteration

2015-09-15 Thread Eric Curtin
Instead of calling strlen on every iteration of the for loop, just call it once and cache the result in a temporary local variable which will be used in the for loop instead. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index

First kernel patch (optimization)

2015-09-15 Thread Eric Curtin
My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index

First kernel patch (optimization)

2015-09-15 Thread Eric Curtin
My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index