Re: [PATCH v3 net] flow_dissector: fix vlan tag handling

2016-10-25 Thread Eric Garver
ater check. With those changes, the warning also disappears. > > Fixes: 3805a938a6c2 ("flow_dissector: Check skb for VLAN only if skb > specified.") > Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from > skb->vlan_tci") > Signed-off-by: Arnd Bergmann Acked-by: Eric Garver

Re: [PATCH] flow_dissector: avoid uninitialized variable access

2016-10-22 Thread Eric Garver
On Sat, Oct 22, 2016 at 12:16:29AM +0200, Arnd Bergmann wrote: > On Friday, October 21, 2016 11:05:45 PM CEST Arnd Bergmann wrote: > > > > Can you explain why "dissector_uses_key(flow_dissector, > > FLOW_DISSECTOR_KEY_VLAN) && skb_vlan_tag_present(skb)" implies > > "eth_type_vlan(proto))"? > > >