Re: [PATCH v2 30/30] media: atmel: atmel-isc: add microchip-xisc driver

2021-04-12 Thread Eugen.Hristev
On 4/12/21 4:41 PM, Jacopo Mondi wrote: > Hi Eugene, > > On Mon, Apr 12, 2021 at 12:37:41PM +, eugen.hris...@microchip.com wrote: >>> +static int xisc_parse_dt(struct device *dev, struct isc_device *isc) >>> +{ >>> + struct device_node *np = dev->of_node; >>> + struct device_node *epn =

Re: [PATCH v2 30/30] media: atmel: atmel-isc: add microchip-xisc driver

2021-04-12 Thread Eugen.Hristev
On 4/5/21 6:51 PM, Eugen Hristev wrote: > Add driver for the extended variant of the isc, the microchip XISC > present on sama7g5 product. > > Signed-off-by: Eugen Hristev > --- > Changes in v2: > - adapted to new fwnode subdev style API, as in kernel 5.12. > my old code was based on 5.10 style

Re: [PATCH v2 28/30] dt-bindings: media: atmel: add microchip-xisc binding

2021-04-12 Thread Eugen.Hristev
On 4/12/21 12:57 PM, Jacopo Mondi wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Eugene, > > On Mon, Apr 05, 2021 at 06:51:03PM +0300, Eugen Hristev wrote: >> Add bindings for the microchip xisc, a driver based on atmel-isc. >> It

Re: [PATCH v2 04/30] media: atmel: atmel-isc: specialize max width and max height

2021-04-12 Thread Eugen.Hristev
On 4/12/21 12:53 PM, Jacopo Mondi wrote: > Ups, > > On Mon, Apr 12, 2021 at 11:43:12AM +0200, Jacopo Mondi wrote: >> Hi Eugene, >> >> On Mon, Apr 05, 2021 at 06:50:39PM +0300, Eugen Hristev wrote: >>> Move the max width and max height constants to the product specific driver >>> and have them in

Re: [PATCH 3/3] ARM: at91: Kconfig: select PLL, generic clock and utmi support

2021-04-08 Thread Eugen.Hristev
On 4/7/21 8:13 PM, Alexandre Belloni wrote: > Hi, > > On 07/04/2021 20:00:53+0300, Eugen Hristev wrote: >> From: Claudiu Beznea >> >> Select PLL, generic clock and UTMI support for SAMA7G5. >> >> Signed-off-by: Claudiu Beznea >> Signed-off-by: Eugen Hristev >> --- >>

Re: [PATCH 2/4] iio: adc: at91-sama5d2: initialize hardware after clock is started

2021-03-08 Thread Eugen.Hristev
On 06.03.2021 19:20, Jonathan Cameron wrote: > On Mon, 1 Mar 2021 16:32:54 +0200 > Eugen Hristev wrote: > >> The hw_init hardware init call must happen after the clock is prepared and >> enabled. Otherwise, writing to the registers might lead to a block or >> external abort. > > Fix for

Re: [PATCH 4/4] iio: adc: at91-sama5d2: add support for sama7g5 device

2021-03-08 Thread Eugen.Hristev
On 06.03.2021 19:30, Jonathan Cameron wrote: > On Mon, 1 Mar 2021 16:32:56 +0200 > Eugen Hristev wrote: > >> Add support to sama7g5 ADC which is similar with sama5d2/sam9x60 device. >> Differences are highlighted by compatible. >> Main differences include 16 channels instead of 12 and missing >>

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-04 Thread Eugen.Hristev
On 03.02.2021 20:15, Saravana Kannan wrote: > On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus > wrote: >> >> These are all "early clocks" that require initialization just at >> of_clk_init() time. Use CLK_OF_DECLARE() to declare them. >> >> This also fixes a problem that was spotted when fw_devlink

Re: [PATCH v5 2/3] media: atmel: introduce microchip csi2dc driver

2020-11-18 Thread Eugen.Hristev
On 18.11.2020 13:38, Jacopo Mondi wrote: > Hi Eugen, > > On Wed, Nov 18, 2020 at 09:48:19AM +, eugen.hris...@microchip.com wrote: >> On 18.11.2020 11:11, Jacopo Mondi wrote: >>> Hello Eugen, >>> > > [snip] > Hello, First of all thank you for the review and explanations.

Re: [PATCH v5 2/3] media: atmel: introduce microchip csi2dc driver

2020-11-18 Thread Eugen.Hristev
On 18.11.2020 11:11, Jacopo Mondi wrote: > Hello Eugen, > > On Tue, Nov 17, 2020 at 05:24:30PM +, eugen.hris...@microchip.com wrote: >> On 17.11.2020 14:09, Laurent Pinchart wrote: >>> Hello everybody, >>> >>> On Tue, Nov 17, 2020 at 12:59:02PM +0100, Jacopo Mondi wrote: On Thu, Nov 12,

Re: [PATCH v5 2/3] media: atmel: introduce microchip csi2dc driver

2020-11-17 Thread Eugen.Hristev
On 17.11.2020 14:09, Laurent Pinchart wrote: > Hello everybody, > > On Tue, Nov 17, 2020 at 12:59:02PM +0100, Jacopo Mondi wrote: >> On Thu, Nov 12, 2020 at 03:34:36PM +0200, Eugen Hristev wrote: >>> Microchip CSI2DC (CSI2 Demultiplexer Controller) is a misc bridge device >>> that converts a byte

Re: [PATCH v5 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc

2020-11-17 Thread Eugen.Hristev
On 17.11.2020 12:37, Jacopo Mondi wrote: > Hi again, > > On Thu, Nov 12, 2020 at 03:34:35PM +0200, Eugen Hristev wrote: >> Add bindings documentation for Microchip CSI2 Demultiplexer controller. >> >> CSI2DC is a demultiplexer from Synopsys IDI interface specification to >> parallel interface

Re: [PATCH v3 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc

2020-10-16 Thread Eugen.Hristev
On 12.10.2020 16:04, Jacopo Mondi wrote: > Hello, > just my 2 cents, as I've noticed this patch skimming through the > list > > On Mon, Oct 12, 2020 at 07:19:43AM +, eugen.hris...@microchip.com wrote: >> On 11.10.2020 00:17, Laurent Pinchart wrote: >>> Hi Eugen, >>> >>> Thank you for

Re: [PATCH 6/7] dt-bindings: dmaengine: at_xdmac: add optional microchip,m2m property

2020-10-16 Thread Eugen.Hristev
On 16.10.2020 10:06, Vinod Koul wrote: > Hi Eugen, > > On 16-10-20, 06:45, eugen.hris...@microchip.com wrote: >> On 23.09.2020 02:33, Rob Herring wrote: >> >>> On Mon, Sep 14, 2020 at 05:09:55PM +0300, Eugen Hristev wrote: Add optional microchip,m2m property that specifies if a controller is

Re: [PATCH 5/7] dmaengine: at_xdmac: add support for sama7g5 based at_xdmac

2020-10-16 Thread Eugen.Hristev
On 23.09.2020 10:08, Tudor Ambarus - M18064 wrote: > On 9/14/20 5:09 PM, Eugen Hristev wrote: >> SAMA7G5 SoC uses a slightly different variant of the AT_XDMAC. >> Added support by a new compatible and a layout struct that copes >> to the specific version considering the compatible string. >> Only

Re: [PATCH 6/7] dt-bindings: dmaengine: at_xdmac: add optional microchip,m2m property

2020-10-16 Thread Eugen.Hristev
On 23.09.2020 02:33, Rob Herring wrote: > On Mon, Sep 14, 2020 at 05:09:55PM +0300, Eugen Hristev wrote: >> Add optional microchip,m2m property that specifies if a controller is >> dedicated to memory to memory operations only. >> >> Signed-off-by: Eugen Hristev >> --- >>

Re: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver

2020-10-12 Thread Eugen.Hristev
On 12.10.2020 10:15, Eugen Hristev - M18282 wrote: > On 09.10.2020 17:58, Sakari Ailus wrote: > >> Hi Eugen, >> >> My apologies for the late reply. >> > > Hi, > > Thank you for replying, > >> On Mon, Sep 07, 2020 at 09:16:57AM +, eugen.hris...@microchip.com wrote: >>> On 31.08.2020 11:50,

Re: [PATCH v3 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc

2020-10-12 Thread Eugen.Hristev
On 11.10.2020 00:17, Laurent Pinchart wrote: > Hi Eugen, > > Thank you for the patch. Hi, Thank you for your review, > > On Wed, Aug 26, 2020 at 09:51:40AM +0300, Eugen Hristev wrote: >> Add bindings documentation for Microchip CSI2 Demultiplexer controller. >> >> CSI2DC is a demultiplexer

Re: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver

2020-10-12 Thread Eugen.Hristev
On 09.10.2020 17:58, Sakari Ailus wrote: > Hi Eugen, > > My apologies for the late reply. > Hi, Thank you for replying, > On Mon, Sep 07, 2020 at 09:16:57AM +, eugen.hris...@microchip.com wrote: >> On 31.08.2020 11:50, Sakari Ailus wrote: >> >>> Hi Eugen, >>> >>> Thanks for the update.

Re: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver

2020-09-28 Thread Eugen.Hristev
On 07.09.2020 12:16, Eugen Hristev - M18282 wrote: > On 31.08.2020 11:50, Sakari Ailus wrote: > >> Hi Eugen, >> >> Thanks for the update. > > Hi Sakari, > > Thanks for reviewing, but, could you please help me understand your > review below ? > Gentle ping Thanks >> >> On Wed, Aug 26, 2020

Re: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver

2020-09-07 Thread Eugen.Hristev
On 31.08.2020 11:50, Sakari Ailus wrote: > Hi Eugen, > > Thanks for the update. Hi Sakari, Thanks for reviewing, but, could you please help me understand your review below ? > > On Wed, Aug 26, 2020 at 09:51:41AM +0300, Eugen Hristev wrote: >> Microchip CSI2DC (CSI2 Demultiplexer

Re: [PATCH v2 3/4] media: misc: introduce microchip_csi2dc driver

2020-08-25 Thread Eugen.Hristev
On 25.08.2020 15:44, Eugen Hristev - M18282 wrote: > On 14.08.2020 01:44, Sakari Ailus wrote: > >> Hi Eugen, >> >> Thanks for the patch. > > Hello Sakari, > > Thanks for reviewing. > >> >> On Fri, Jul 03, 2020 at 10:44:15AM +0300, Eugen Hristev wrote: >>> Microchip CSI2DC (CSI2 Demultiplexer

Re: [PATCH v2 3/4] media: misc: introduce microchip_csi2dc driver

2020-08-25 Thread Eugen.Hristev
On 14.08.2020 01:44, Sakari Ailus wrote: > Hi Eugen, > > Thanks for the patch. Hello Sakari, Thanks for reviewing. > > On Fri, Jul 03, 2020 at 10:44:15AM +0300, Eugen Hristev wrote: >> Microchip CSI2DC (CSI2 Demultiplexer Controller) is a misc bridge device >> that converts a byte stream in

Re: [PATCH v2 1/4] dt-bindings: media: csi2dc: add bindings for microchip csi2dc

2020-08-19 Thread Eugen.Hristev
On 03.07.2020 10:44, Eugen Hristev wrote: > Add bindings documentation for microchip CSI2 Demultiplexer controller. > > CSI2DC is a demultiplexer from Synopsys IDI interface specification to > parallel interface connection or direct memory access. > > Signed-off-by: Eugen Hristev > --- >

Re: [PATCH v2 1/4] dt-bindings: media: csi2dc: add bindings for microchip csi2dc

2020-08-19 Thread Eugen.Hristev
On 14.07.2020 05:55, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Jul 03, 2020 at 10:44:13AM +0300, Eugen Hristev wrote: >> Add bindings documentation for microchip CSI2 Demultiplexer controller. >> >> CSI2DC is a

Re: [PATCH v2 1/4] dt-bindings: media: csi2dc: add bindings for microchip csi2dc

2020-08-19 Thread Eugen.Hristev
On 14.08.2020 01:46, Sakari Ailus wrote: > Hi Eugen, > > On Fri, Jul 03, 2020 at 10:44:13AM +0300, Eugen Hristev wrote: >> Add bindings documentation for microchip CSI2 Demultiplexer controller. > > ... > >> + port@1: >> +type: object >> +description: >> + Output port node, single

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-18 Thread Eugen.Hristev
On 17.06.2020 16:52, Ardelean, Alexandru wrote: > On Wed, 2020-06-17 at 13:37 +, eugen.hris...@microchip.com wrote: >> [External] >> >> On 02.06.2020 11:54, Jonathan Cameron wrote: >>> On Tue, 2 Jun 2020 07:50:23 + >>> "Ardelean, Alexandru" wrote: >>> On Sun, 2020-05-31 at 16:40

Re: [PATCH] iio: at91-sama5d2_adc: remove usage of iio_priv_to_dev() helper

2020-06-18 Thread Eugen.Hristev
On 17.06.2020 17:02, Ardelean, Alexandru wrote: > On Wed, 2020-06-17 at 13:25 +, eugen.hris...@microchip.com wrote: >> On 31.05.2020 17:39, Jonathan Cameron wrote: >> >>> On Mon, 25 May 2020 13:53:41 +0300 >>> Alexandru Ardelean wrote: >>> We may want to get rid of the iio_priv_to_dev()

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-17 Thread Eugen.Hristev
On 02.06.2020 11:54, Jonathan Cameron wrote: > On Tue, 2 Jun 2020 07:50:23 + > "Ardelean, Alexandru" wrote: > >> On Sun, 2020-05-31 at 16:40 +0100, Jonathan Cameron wrote: >>> On Mon, 25 May 2020 14:38:55 +0300 >>> Alexandru Ardelean wrote: >>> From: Lars-Peter Clausen This

Re: [PATCH] iio: at91-sama5d2_adc: remove usage of iio_priv_to_dev() helper

2020-06-17 Thread Eugen.Hristev
On 31.05.2020 17:39, Jonathan Cameron wrote: > On Mon, 25 May 2020 13:53:41 +0300 > Alexandru Ardelean wrote: > >> We may want to get rid of the iio_priv_to_dev() helper. The reason is that >> we will hide some of the members of the iio_dev structure (to prevent >> drivers from accessing them

Re: drivers/media/platform/atmel/atmel-sama5d2-isc.c:323:34: warning: unused variable 'atmel_isc_of_match'

2020-06-12 Thread Eugen.Hristev
On 12.06.2020 09:02, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: b791d1bdf9212d944d749a5c7ff6febdba241771 > commit: 0a0e265515db7619d0da9331d74245d02c741f07 media: atmel: atmel-isc: > split driver into driver base and

Re: [RFC PATCH] iio: __iio_update_buffers: Update mode before preenable/after postdisable

2020-05-14 Thread Eugen.Hristev
On 04.05.2020 15:27, Eugen Hristev - M18282 wrote: > On 30.04.2020 11:42, Eugen Hristev - M18282 wrote: >> On 30.04.2020 11:24, Alexandru Ardelean wrote: >>> From: Lars-Peter Clausen >>> >>> It is clear that we transition to INDIO_DIRECT_MODE when disabling the >>> buffer(s) and it is also clear

Re: [RFC PATCH] iio: __iio_update_buffers: Update mode before preenable/after postdisable

2020-05-04 Thread Eugen.Hristev
On 30.04.2020 11:42, Eugen Hristev - M18282 wrote: > On 30.04.2020 11:24, Alexandru Ardelean wrote: >> From: Lars-Peter Clausen >> >> It is clear that we transition to INDIO_DIRECT_MODE when disabling the >> buffer(s) and it is also clear that we transition from INDIO_DIRECT_MODE >> when enabling

Re: [RFC PATCH] iio: __iio_update_buffers: Update mode before preenable/after postdisable

2020-04-30 Thread Eugen.Hristev
On 30.04.2020 11:24, Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > It is clear that we transition to INDIO_DIRECT_MODE when disabling the > buffer(s) and it is also clear that we transition from INDIO_DIRECT_MODE > when enabling the buffer(s). So leaving the currentmode field >

[PATCH v6 3/9] i2c: add support for filters optional properties

2019-10-23 Thread Eugen.Hristev
From: Eugen Hristev i2c-digital-filter-width-ns: This optional timing property specifies the width of the spikes on the i2c lines (in ns) that can be filtered out by built-in digital filters which are embedded in some i2c controllers. i2c-analog-filter-cutoff-frequency: This optional timing

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-23 Thread Eugen.Hristev
On 21.10.2019 18:23, Peter Rosin wrote: > > On 2019-10-21 16:05, Wolfram Sang wrote: >> On Mon, Oct 07, 2019 at 07:53:21AM +, eugen.hris...@microchip.com wrote: >>> >>> >>> On 11.09.2019 11:24, Eugen Hristev - M18282 wrote: From: Eugen Hristev Hello, This series

[PATCH v2 2/2] watchdog: sama5d4_wdt: addition of sam9x60 compatible watchdog

2019-10-21 Thread Eugen.Hristev
From: Eugen Hristev Add support for SAM9X60 WDT into sama5d4_wdt. This means that this driver will have a platform data that will hold differences. Added definitions of different bits. The ops functions will differentiate between the two hardware blocks. Signed-off-by: Eugen Hristev ---

[PATCH v2 1/2] dt-bindings: watchdog: sama5d4_wdt: add microchip,sam9x60-wdt compatible

2019-10-21 Thread Eugen.Hristev
From: Eugen Hristev The Atmel sama5d4_wdt needs to be compatible with microchip,sam9x60-wdt The sama5d4_wdt driver is updated to work with both hardware blocks (sama5d4/sama5d2 and sam9x60 based blocks) Signed-off-by: Eugen Hristev ---

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-14 Thread Eugen.Hristev
On 07.10.2019 10:47, Eugen Hristev wrote: > > > On 11.09.2019 11:24, Eugen Hristev - M18282 wrote: >> From: Eugen Hristev >> >> Hello, >> >> This series adds support for analog and digital filters for i2c >> controllers >> >> This series is based on the series: >> [PATCH v2 0/9] i2c: at91:

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-07 Thread Eugen.Hristev
On 07.10.2019 16:14, Alexandre Belloni wrote: > > On 07/10/2019 05:36:38-0700, Guenter Roeck wrote: >> On 10/7/19 12:58 AM, eugen.hris...@microchip.com wrote: >> [ ... ] >>> Hello Guenter, >>> >>> Thank you for the feedback. >>> After reviewing this, can you please guide me towards one of the

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-07 Thread Eugen.Hristev
On 02.10.2019 16:16, Guenter Roeck wrote: > > On 10/2/19 12:35 AM, eugen.hris...@microchip.com wrote: >> From: Eugen Hristev >> >> This is the driver for SAM9X60 watchdog timer. >> The offered functionality is the same as sama5d4_wdt. >> The difference comes in register map, way to configure

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-07 Thread Eugen.Hristev
On 11.09.2019 11:24, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > Hello, > > This series adds support for analog and digital filters for i2c controllers > > This series is based on the series: > [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs > and later > [PATCH v4 0/9]

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-10-03 Thread Eugen.Hristev
On 13.08.2019 09:53, Ludovic Desroches wrote: > On Mon, Aug 12, 2019 at 03:38:34PM +, eugen.hris...@microchip.com wrote: >> On 09.08.2019 09:23, Ludovic Desroches wrote: >>> On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: On 8/08/19 3:42 PM, Ludovic Desroches wrote: >

Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-02 Thread Eugen.Hristev
On 02.10.2019 13:23, Alexandre Belloni wrote: > Hi, > > On 02/10/2019 07:35:26+, eugen.hris...@microchip.com wrote: >> +static void wdt_write(struct sam9x60_wdt *wdt, u32 field, u32 val) >> +{ >> +/* >> + * WDT_CR and WDT_MR must not be modified within three slow clock >> + *

[PATCH 1/3] dt-bindings: watchdog: sam9x60_wdt: add bindings

2019-10-02 Thread Eugen.Hristev
From: Eugen Hristev Add bindings for Microchip SAM9X60 Watchdog Timer It has the same bindings as Documentation/devicetree/bindings/watchdog/atmel-sama5d4-wdt.txt except the compatible. Signed-off-by: Eugen Hristev --- .../devicetree/bindings/watchdog/sam9x60-wdt.txt | 34

[PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver

2019-10-02 Thread Eugen.Hristev
From: Eugen Hristev This is the driver for SAM9X60 watchdog timer. The offered functionality is the same as sama5d4_wdt. The difference comes in register map, way to configure the timeout and interrupts. Developed starting from sama5d4_wdt.c Signed-off-by: Eugen Hristev ---

[PATCH 3/3] MAINTAINERS: add sam9x60_wdt

2019-10-02 Thread Eugen.Hristev
From: Eugen Hristev Add sam9x60_wdt watchdog driver to at91 soc support. Signed-off-by: Eugen Hristev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 296de2b..109b030 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1972,6 +1972,7 @@ F:

[PATCH] clk: at91: sam9x60: fix programmable clock

2019-09-24 Thread Eugen.Hristev
From: Eugen Hristev The prescaler mask for sam9x60 must be 0xff (8 bits). Being set to 0, means that we cannot set any prescaler, thus the programmable clocks do not work (except the case with prescaler 0) Set the mask accordingly in layout struct. Fixes: 01e2113de9a5 ("clk: at91: add sam9x60

Re: [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-09-20 Thread Eugen.Hristev
On 12.09.2019 23:09, Ludovic Desroches wrote: > > In the SAM9x60 SoC, there are only two clocks instead of three for the > SDHCI device. The base clk is no longer provided, it is generated > internally from the mult clk. > > The values of the base clk and mul in the capabilities registers may

Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL

2019-09-17 Thread Eugen.Hristev
On 16.09.2019 22:52, Stephen Boyd wrote: > Quoting eugen.hris...@microchip.com (2019-09-10 23:39:20) >> From: Eugen Hristev >> >> The PLL input range needs to be able to allow 24 Mhz crystal as input >> Update the range accordingly in plla characteristics struct >> >> Signed-off-by: Eugen

Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL

2019-09-12 Thread Eugen.Hristev
On 12.09.2019 14:06, Alexander Dahl wrote: > > Hello, > > out of curiosity: The SAMA5D27-SOM1-EK board has a 24 MHz crystal, that is > also what /sys/kernel/debug/clk/clk_summary says and the board runs without > obvious problems. What is this change improving in real practice then? > The

[PATCH v5 5/9] i2c: at91: add support for digital filtering

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for digital filtering for i2c. The sama5d4, sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 9 +

[PATCH v5 7/9] i2c: at91: add support for analog filtering

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add support for analog filtering for i2c lines. The sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 18 ++ drivers/i2c/busses/i2c-at91.h

[PATCH v5 4/9] i2c: at91: add new platform support for sam9x60

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for the sam9x60 SoC Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c index

[PATCH v5 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Some i2c controllers have a built-in digital or analog filter. This is specifically required depending on the hardware PCB/board. Some controllers also allow specifying the maximum width of the spikes that can be filtered for digital filter. The width length can be specified

[PATCH v5 3/9] i2c: add support for filters optional properties

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev i2c-digital-filter-width-ns: This optional timing property specifies the width of the spikes on the i2c lines (in ns) that can be filtered out by built-in digital filters which are embedded in some i2c controllers. i2c-analog-filter-cutoff-frequency: This optional timing

[PATCH v5 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add property for analog and digital filter for i2c1 and i2c2 nodes for sama5d2_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH v5 9/9] ARM: dts: at91: sama5d4_xplained: add digital filter for i2c

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add property for digital filter for i2c0 node sama5d4_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts

[PATCH v5 6/9] i2c: at91: add support for advanced digital filtering

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for advanced digital filtering for i2c. The sama5d2 and sam9x60 support this feature. This digital filter allows the user to configure the maximum width of the spikes that can be filtered. Signed-off-by: Eugen Hristev ---

[PATCH v5 0/9] i2c: add support for filters

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Hello, This series adds support for analog and digital filters for i2c controllers This series is based on the series: [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs and later [PATCH v4 0/9] i2c: add support for filters and enhanced to add the bindings for all

[PATCH v5 1/9] dt-bindings: i2c: at91: add new compatible

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev Add compatible for new Microchip SoC, sam9x60 Reviewed-by: Rob Herring Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] clk: at91: allow 24 Mhz clock as input for PLL

2019-09-11 Thread Eugen.Hristev
From: Eugen Hristev The PLL input range needs to be able to allow 24 Mhz crystal as input Update the range accordingly in plla characteristics struct Signed-off-by: Eugen Hristev --- drivers/clk/at91/sama5d2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] clk: at91: fix update bit maps on CFG_MOR write

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev The regmap update bits call was not selecting the proper mask, considering the bits which was updating. Update the mask from call to also include OSCBYPASS. Removed MOSCEN which was not updated. Fixes: 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally")

[PATCH 2/2] clk: at91: select parent if main oscillator or bypass is enabled

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev Selecting the right parent for the main clock is done using only main oscillator enabled bit. In case we have this oscillator bypassed by an external signal (no driving on the XOUT line), we still use external clock, but with BYPASS bit set. So, in this case we must select

[PATCH v2 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev Add bindings for optional rtc clock pin. Signed-off-by: Eugen Hristev Acked-by: Ajay Singh --- Changes in v2: - none drivers/staging/wilc1000/microchip,wilc1000,sdio.txt | 8 +++- drivers/staging/wilc1000/microchip,wilc1000,spi.txt | 8 2 files changed, 15

[PATCH v2 2/2] staging: wilc1000: look for rtc_clk clock

2019-09-09 Thread Eugen.Hristev
From: Eugen Hristev If rtc_clk is provided from DT, use it and enable it. This is optional. The signal may be hardcoded and no need to be requested, but if DT provides it, use it. Signed-off-by: Eugen Hristev Acked-by: Ajay Singh --- Changes in v2: - rebased on staging-next

[PATCH 2/2] staging: wilc1000: look for rtc_clk clock

2019-09-04 Thread Eugen.Hristev
From: Eugen Hristev If rtc_clk is provided from DT, use it and enable it. This is optional. The signal may be hardcoded and no need to be requested, but if DT provides it, use it. Signed-off-by: Eugen Hristev --- drivers/staging/wilc1000/wilc_sdio.c | 14 ++

[PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-04 Thread Eugen.Hristev
From: Eugen Hristev Add bindings for optional rtc clock pin. Signed-off-by: Eugen Hristev --- drivers/staging/wilc1000/microchip,wilc1000,sdio.txt | 8 +++- drivers/staging/wilc1000/microchip,wilc1000,spi.txt | 8 2 files changed, 15 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Eugen.Hristev
On 02.09.2019 13:49, Peter Rosin wrote: > On 2019-09-02 12:12, eugen.hris...@microchip.com wrote: >> From: Eugen Hristev >> >> Some i2c controllers have a built-in digital or analog filter. >> This is specifically required depending on the hardware PCB/board. >> Some controllers also allow

Re: [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible

2019-09-02 Thread Eugen.Hristev
On 02.09.2019 13:44, Peter Rosin wrote: > > On 2019-09-02 12:11, eugen.hris...@microchip.com wrote: >> From: Eugen Hristev >> >> Add compatible for new Microchip SoC, sam9x60 >> >> Reviewed-by: Rob Herring >> Signed-off-by: Eugen Hristev >> --- >>

[PATCH v4 9/9] ARM: dts: at91: sama5d4_xplained: add digital filter for i2c

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add property for digital filter for i2c0 node sama5d4_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts

[PATCH v4 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add property for analog and digital filter for i2c1 and i2c2 nodes for sama5d2_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH v4 6/9] i2c: at91: add support for advanced digital filtering

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for advanced digital filtering for i2c. The sama5d2 and sam9x60 support this feature. This digital filter allows the user to configure the maximum width of the spikes that can be filtered. Signed-off-by: Eugen Hristev ---

[PATCH v4 0/9] i2c: add support for filters

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Hello, This series adds support for analog and digital filters for i2c controllers This series is based on the series: [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs and enhanced to add the bindings for all controllers plus an extra binding for the width of the

[PATCH v4 7/9] i2c: at91: add support for analog filtering

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add support for analog filtering for i2c lines. The sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 18 ++ drivers/i2c/busses/i2c-at91.h

[PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add compatible for new Microchip SoC, sam9x60 Reviewed-by: Rob Herring Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v4 5/9] i2c: at91: add support for digital filtering

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for digital filtering for i2c. The sama5d4, sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 9 +

[PATCH v4 4/9] i2c: at91: add new platform support for sam9x60

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for the sam9x60 SoC Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c index

[PATCH v4 3/9] i2c: add support for filter-width-ns optional property

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev This optional timing property specifies the width of the spikes on the i2c lines (in ns) that can be filtered out by built-in analog or digital filters which are embedded in some i2c controllers. Include it in the timings structure and read it as integer property.

[PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-09-02 Thread Eugen.Hristev
From: Eugen Hristev Some i2c controllers have a built-in digital or analog filter. This is specifically required depending on the hardware PCB/board. Some controllers also allow specifying the maximum width of the spikes that can be filtered. The width length can be specified in nanoseconds.

Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-09-02 Thread Eugen.Hristev
On 31.08.2019 15:17, Wolfram Sang wrote: > >>> + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node, >>> +"i2c-dig-filter"); >>> + >> >> What do you think of the idea to introduce 'flags' to struct i2c_timings >> and parse the

Re: [PATCH v3 0/9] i2c: add support for filters

2019-08-22 Thread Eugen.Hristev
On 12.07.2019 11:20, Ludovic Desroches wrote: > On Tue, Jul 09, 2019 at 03:19:26PM +0200, Eugen Hristev - M18282 wrote: >> From: Eugen Hristev >> >> Hello, >> >> This series adds support for analog and digital filters for i2c controllers >> >> This series is based on the series: >> [PATCH v2

[PATCH] media: atmel: atmel-isi: fix timeout value for stop streaming

2019-08-20 Thread Eugen.Hristev
From: Alexandre Kroupski In case of sensor malfunction, stop streaming timeout takes much longer than expected. This is due to conversion of time to jiffies: milliseconds multiplied with HZ (ticks/second) gives out a value of jiffies with 10^3 greater. We need to also divide by 10^3 to obtain

Re: [PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-12 Thread Eugen.Hristev
On 09.08.2019 09:23, Ludovic Desroches wrote: > On Thu, Aug 08, 2019 at 03:57:30PM +0300, Adrian Hunter wrote: >> On 8/08/19 3:42 PM, Ludovic Desroches wrote: >>> On Thu, Aug 08, 2019 at 10:35:43AM +0200, Eugen Hristev - M18282 wrote: From: Eugen Hristev Add mmc capabilities for

[PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200

2019-08-08 Thread Eugen.Hristev
From: Eugen Hristev HS200 is not implemented in the driver, but the controller claims it through caps. Remove it via quirk. Without this quirk, the mmc core will try to enable hs200, which will fail, and the eMMC initialization will fail. Signed-off-by: Eugen Hristev ---

[PATCH 2/2] ARM: dts: at91: sama5d27_som1_ek: add mmc capabilities for SDMMC0

2019-08-08 Thread Eugen.Hristev
From: Eugen Hristev Add mmc capabilities for SDMMC0 for this board. With this enabled, eMMC connected card is detected as: mmc0: new DDR MMC card at address 0001 Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-07-26 Thread Eugen.Hristev
On 26.07.2019 12:50, Luis de Oliveira wrote: > Hi Sakari, > > Thank you for the review, my answers inline. > >> From: Sakari Ailus >> Date: Thu, Jul 25, 2019 at 21:02:11 >> >> Hi Luis, >> >> On Wed, Jul 10, 2019 at 10:20:55AM +, Luis de Oliveira wrote: >>> Hi Sakari, >>> >>> From: Sakari

Re: [v4 2/6] media: platform: dwc: Add MIPI CSI-2 controller driver

2019-07-10 Thread Eugen.Hristev
Hello Luis, A few questions inline: On 11.06.2019 22:20, Luis Oliveira wrote: > Add the Synopsys MIPI CSI-2 controller driver. This > controller driver is divided in platform functions and core functions. > This way it serves as platform for future DesignWare drivers. > > Signed-off-by: Luis

Re: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-07-10 Thread Eugen.Hristev
On 09.07.2019 20:08, Luis de Oliveira wrote: > > Hi Eugen, > > > From: eugen.hris...@microchip.com > Date: Tue, Jul 09, 2019 at 15:33:50 > >> >> >> On 11.06.2019 22:20, Luis Oliveira wrote: >>> From: Luis Oliveira >>> >>> Add bindings for Synopsys DesignWare MIPI CSI-2 host. >>> >>>

Re: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-07-09 Thread Eugen.Hristev
On 11.06.2019 22:20, Luis Oliveira wrote: > From: Luis Oliveira > > Add bindings for Synopsys DesignWare MIPI CSI-2 host. > > Signed-off-by: Luis Oliveira > --- > Changelog > v3-v4 > - remove "plat" from the block name @rob @laurent > - remove "phy-names" when single-entry @rob > - remove

[PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for digital filtering for i2c. The sama5d4, sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 9 +

[PATCH v3 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add property for analog and digital filter for i2c1 and i2c2 nodes for sama5d2_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH v3 9/9] ARM: dts: at91: sama5d4_xplained: add digital filter for i2c

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add property for digital filter for i2c0 node sama5d4_xplained Signed-off-by: Eugen Hristev --- arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts

[PATCH v3 3/9] i2c: add support for filter-width-ns optional property

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev This optional timing property specifies the width of the spikes on the i2c lines (in ns) that can be filtered out by built-in analog or digital filters which are embedded in some i2c controllers. Include it in the timings structure and read it as integer property.

[PATCH v3 7/9] i2c: at91: add support for analog filtering

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add support for analog filtering for i2c lines. The sama5d2 and sam9x60 support this feature. Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 9 + drivers/i2c/busses/i2c-at91-master.c | 18 ++ drivers/i2c/busses/i2c-at91.h

[PATCH v3 6/9] i2c: at91: add support for advanced digital filtering

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for advanced digital filtering for i2c. The sama5d2 and sam9x60 support this feature. This digital filter allows the user to configure the maximum width of the spikes that can be filtered. Signed-off-by: Eugen Hristev ---

[PATCH v3 4/9] i2c: at91: add new platform support for sam9x60

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add new platform data support for the sam9x60 SoC Signed-off-by: Eugen Hristev --- drivers/i2c/busses/i2c-at91-core.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c index

[PATCH v3 1/9] dt-bindings: i2c: at91: add new compatible

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Add compatible for new Microchip SoC, sam9x60 Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt

[PATCH v3 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Some i2c controllers have a built-in digital or analog filter. This is specifically required depending on the hardware PCB/board. Some controllers also allow specifying the maximum width of the spikes that can be filtered. The width length can be specified in nanoseconds.

[PATCH v3 0/9] i2c: add support for filters

2019-07-09 Thread Eugen.Hristev
From: Eugen Hristev Hello, This series adds support for analog and digital filters for i2c controllers This series is based on the series: [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs and enhanced to add the bindings for all controllers plus an extra binding for the width of the

  1   2   >