Re: [PATCH] softirq: Be more verbose on t->state BUG()

Hello Thomas, On Tue, Mar 16, 2021 at 06:13:12PM +0100, Thomas Gleixner wrote: > On Tue, Mar 16 2021 at 16:10, Eugeniu Rosca wrote: > > If no other comments in the next days, I will resubmit your proposal as > > v2, marked with 'Suggested-by: Thomas Gleixner '. > > > &g

[PATCH v2] softirq: s/BUG/WARN_ONCE/ on tasklet SCHED state not set

From: Dirk Behme Replace BUG() with WARN_ONCE() on wrong tasklet state, in order to: * increase the verbosity / aid in debugging * avoid fatal/unrecoverable state Suggested-by: Thomas Gleixner Signed-off-by: Dirk Behme Signed-off-by: Eugeniu Rosca --- Changes since v1: * Factored out

Re: [PATCH] softirq: Be more verbose on t->state BUG()

Hello Thomas, On Tue, Mar 16, 2021 at 03:31:50PM +0100, Thomas Gleixner wrote: > On Mon, Mar 15 2021 at 16:44, Eugeniu Rosca wrote: > > From: Dirk Behme > > > > In case this BUG() is hit, it helps debugging a lot to get an idea > > what tasklet is the root cause. S

[PATCH] softirq: Be more verbose on t->state BUG()

From: Dirk Behme In case this BUG() is hit, it helps debugging a lot to get an idea what tasklet is the root cause. So, be slightly more verbose here. Signed-off-by: Dirk Behme Signed-off-by: Eugeniu Rosca --- kernel/softirq.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

Re: [PATCH 2/2] arm64: dts: renesas: r8a77961: ulcb-kf: Initial device tree

Hi Geert, On Thu, Oct 29, 2020 at 07:23:53PM +0100, Geert Uytterhoeven wrote: > On Thu, Oct 29, 2020 at 5:34 PM Eugeniu Rosca wrote: [..] > I don't think we want to add new compatible string to describe each > combo. Just add "renesas,r8a77961" to the last enum? I'm afra

[PATCH v2 3/3] dt-bindings: arm: renesas: Add R-Car M3-W+ ULCB with Kingfisher

Document the use of the Kingfisher expansion board with the R-Car Starter Kit Pro equipped with an R-Car M3-W+ (aka M3-ES3.0) SoC. Inspired from v5.5 commit 24169f0a453754 ("dt-bindings: arm: renesas: Add R-Car M3-N ULCB with Kingfisher"). Suggested-by: Geert Uytterhoeven Signed-off-b

[PATCH v2 2/3] arm64: dts: renesas: r8a77961: ulcb-kf: Initial device tree

/r8a77960-ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dts Signed-off-by: Eugeniu Rosca Reviewed-by: Geert Uytterhoeven --- v2: Add "Reviewed-by". No other change. v1: https://lore.kernel.org/linux-renesas-soc/20201029133741.25721-2-ero...@de.adit-jv.com/ --- arch/arm64/boot/d

[PATCH v2 0/3] Add R-Car M3-W+ ULCB with Kingfisher

Add initial M3-ES3.0-ULCB-KF support. v2: Add "Reviewed-by". Update renesas.yaml. v1: - https://lore.kernel.org/linux-renesas-soc/20201029133741.25721-1-ero...@de.adit-jv.com/ - https://lore.kernel.org/linux-renesas-soc/20201029133741.25721-2-ero...@de.adit-jv.com/ Eugeniu Rosca (3

[PATCH v2 1/3] arm64: dts: renesas: r8a77961: Add CAN{0,1} placeholder nodes

With the same background and purpose as described in v4.20-rc1 commit 92bc66bfce99cd ("arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes"), add can0 and can1 placeholder nodes. Signed-off-by: Eugeniu Rosca Reviewed-by: Geert Uytterhoeven --- v2: Add "Reviewed-by&qu

Re: [PATCH 2/2] arm64: dts: renesas: r8a77961: ulcb-kf: Initial device tree

Hi Geert, On Thu, Oct 29, 2020 at 03:09:10PM +0100, Geert Uytterhoeven wrote: > On Thu, Oct 29, 2020 at 2:38 PM Eugeniu Rosca wrote: > > Create a dedicated DTB for M3-ES3.0 + ULCB + Kingfisher combo. > > Inspire from the pre-existing ULCB-KF device trees: > > > >

[PATCH 1/2] arm64: dts: renesas: r8a77961: Add CAN{0,1} placeholder nodes

With the same background and purpose as described in v4.20-rc1 commit 92bc66bfce99cd ("arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes"), add can0 and can1 placeholder nodes. Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 10 ++ 1 fi

[PATCH 2/2] arm64: dts: renesas: r8a77961: ulcb-kf: Initial device tree

/r8a77960-ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dts Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 1 + arch/arm64/boot/dts/renesas/r8a77961-ulcb-kf.dts | 15 +++ 2 files changed, 16 insertions(+) create mode 100644 arch/arm64/boot/dts

Re: [PATCH v3] USB: hub.c: decrease the number of attempts of enumeration scheme

uot; [**]? [*] https://www.usb.org/compliance [**] https://www.usb.org/sites/default/files/otgeh_compliance_plan_1_2.pdf -- Best regards, Eugeniu Rosca

[PATCH v2] i2c: i2c-rcar: Auto select RESET_CONTROLLER

me Signed-off-by: Andy Lowe [erosca: Add "if ARCH_RCAR_GEN3" on Wolfram's request] Signed-off-by: Eugeniu Rosca --- v2: - Append "if ARCH_RCAR_GEN3" to "select", as requested by Wolfram in https://lore.kernel.org/linux-i2c/20200824120734.GA2500@ninjato/ v

[PATCH v2] mm: slub: fix conversion of freelist_corrupted()

upted freechain in deactivate_slab()") Cc: Andrew Morton Cc: Dongli Zhang Cc: Signed-off-by: Eugeniu Rosca --- v2: - Address the review finding from Dongli Zhang in: https://lore.kernel.org/linux-mm/f93a9f06-8608-6f28-27c0-b17f86dca...@oracle.com/ ---8<--- This is good to me.

[PATCH] i2c: i2c-rcar: Auto select RESET_CONTROLLER

Dirk Behme Signed-off-by: Andy Lowe Signed-off-by: Eugeniu Rosca --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 293e7a0760e7..bb80f0944d61 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/buss

Re: hibernation reverts in 4.19.134: better alternative?

2:58:32 2020 -0400 > > Revert "usb/ohci-platform: Fix a warning when hibernating" > > This reverts commit c83258a757687ffccce37ed73dba56cc6d4b8a1b. > > Eugeniu Rosca writes: > > ... > > > - Backporting 987351e1ea7772 ("ph

Re: [PATCH 4.14 105/136] usb/ehci-platform: Set PM runtime as active on resume

23.802028] Code: d65f03c0 52808000 17fd d503233f (b940) [ 23.808137] ---[ end trace f663646e2a9dfb93 ]--- [ 23.812773] SMP: stopping secondary CPUs [ 23.812774] Kernel Offset: disabled [ 23.812775] CPU features: 0x040022,20006004 [ 23.812777] Memory Limit: none -- Best regards, Eugeniu Rosca

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hi Jacopo, On Fri, Jun 12, 2020 at 05:12:09PM +0200, Jacopo Mondi wrote: > On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote: > > FWIW, I seem to hit pre-existing issues in vanilla rcar-du, > > while unplugging HDMI cable during a cyclic suspend-resume: > > > &

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hi, On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote: > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > > On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote: > > > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart w

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

("drm: rcar-du: kms: Initialize CMM instances") -- Best regards, Eugeniu Rosca

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hello, Many thanks for your comments and involvement. On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > On Fri, Jun 05, 2020 at 03:53:15PM +0200, Jacopo Mondi wrote: > > On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote: > > > On Fri, Jun 05,

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hi Jacopo, On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > Could you kindly share the cross compilation steps for your kmsxx fork? > > I usually build it on the target :) Interesting approach. W

[PATCH v2] media: vsp1: dl: Fix NULL pointer dereference on unbind

el.org # v4.19+ Signed-off-by: Eugeniu Rosca Reviewed-by: Kieran Bingham Tested-by: Kieran Bingham --- Changes in v2: - Rephrased the description based on Kieran's proposal - Added the Reviewed-by/Tested-by signatures - No change in the contents --- drivers/media/platform/vsp1/vsp1_dl.c

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

Hi Geert, On Wed, May 27, 2020 at 09:34:30AM +0200, Geert Uytterhoeven wrote: > On Wed, May 27, 2020 at 9:16 AM Eugeniu Rosca wrote: > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > > CMM functionalities are retained between suspend/res

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

hub.com/renesas-rcar/du_cmm/blob/c393ed49834bdbc/meta-rcar-gen3/recipes-kernel/linux/linux-renesas/0001-drm-rcar-du-Add-DU-CMM-support.patch#L1912 -- Best regards, Eugeniu Rosca

Re: [PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

UBJECT to match what is performed in the > patch, which is perhaps more like: > > "media: vsp1: dl: Store VSP reference when creating cmd pools" To be honest, I am not a big fan of WHAT summary lines. Rather, I prefer the WHY summary lines (and I think everyone should). >

[PATCH] media: vsp1: dl: Fix NULL pointer dereference on unbind

a...@vger.kernel.org # v4.19+ Signed-off-by: Eugeniu Rosca --- How about adding a new unit test perfoming unbind/rebind to http://git.ideasonboard.com/renesas/vsp-tests.git, to avoid such issues in future? Locally, below command has been used to identify the problem: for f in $(find /sys/bu

[PATCH] usb: core: hub: limit HUB_QUIRK_DISABLE_AUTOSUSPEND to USB5534B

i-Heng Feng Signed-off-by: Eugeniu Rosca --- drivers/usb/core/hub.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 2b6565c06c23..fc748c731832 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -3

Re: [RESEND PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

Wischer > > [erosca: minor improvements in commit description] > > Cc: Andrew Gabbasov > > Cc: sta...@vger.kernel.org # v4.20+ > > Signed-off-by: Eugeniu Rosca > > --- > > Acked-by: Kuninori Morimoto Many thanks for the prompt responses. -- Best Regards, Eugeniu

Re: [alsa-devel] [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

On Tue, Oct 22, 2019 at 05:53:37PM +0100, Mark Brown wrote: > On Tue, Oct 22, 2019 at 06:46:07PM +0200, Eugeniu Rosca wrote: > > On Tue, Oct 22, 2019 at 05:35:01PM +0100, Mark Brown wrote: > > > On Tue, Oct 22, 2019 at 05:49:04PM +0200, Eugeniu Rosca wrote: > > > &

[RESEND PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

f-by: Timo Wischer [erosca: minor improvements in commit description] Cc: Andrew Gabbasov Cc: sta...@vger.kernel.org # v4.20+ Signed-off-by: Eugeniu Rosca --- Originally submitted as https://patchwork.kernel.org/patch/10825513/ ("ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address") --- sou

[PATCH] ASoC: rsnd: dma: set bus width to data width for monaural data

bus width to: - [monaural case] data width - [non-monaural case] 32bits (as prior applying the patch) Cc: Andrew Gabbasov Cc: Timo Wischer Signed-off-by: Jiada Wang Signed-off-by: Eugeniu Rosca --- sound/soc/sh/rcar/dma.c | 30 -- 1 file changed, 28 insertions

Re: [alsa-devel] [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

Hi Mark, Thanks for the prompt reply. On Tue, Oct 22, 2019 at 05:35:01PM +0100, Mark Brown wrote: > On Tue, Oct 22, 2019 at 05:49:04PM +0200, Eugeniu Rosca wrote: > > > It still applies cleanly to v5.4-rc4-18-g3b7c59a1950c. > > Any chance to see it in vanilla? > > Some

Re: [alsa-devel] [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

g - 0x00141000 + (0x1000 * (i)) > + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400)) > +#define RDMA_SSIU_I_P(addr, i, j) (addr ##_reg - 0x00141000 + (0x1000 * (i)) > + (((j) / 4) * 0xA000) + (((j) % 4) * 0x400) - (0x4000 * ((i) / 9) * ((j) / > 4))) > #define RDMA_SSIU_O_P(addr, i, j) RDMA_S

[PATCH] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting

n Signed-off-by: Eugeniu Rosca --- sound/soc/sh/rcar/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index bda5b958d0dc..e9596c2096cd 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -761,6 +761,7

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

Hi Shuah, On Tue, Oct 01, 2019 at 08:41:43PM +, patchwork-bot+linux-kselft...@kernel.org wrote: > Hello: > > This series was applied to shuah/linux-kselftest.git (refs/heads/fixes). > > On Tue, 17 Sep 2019 20:40:22 +0200 you wrote: > > From: "George G. Davis" > > > > The newly added

Re: [PATCH V3 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

On Thu, Sep 26, 2019 at 03:51:01PM +0200, Balasubramani Vivekanandan wrote: > When a cpu requests broadcasting, before starting the tick broadcast > hrtimer, bc_set_next() checks if the timer callback (bc_handler) is > active using hrtimer_try_to_cancel(). But hrtimer_try_to_cancel() does > not

Re: [PATCH V1 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

On Mon, Sep 23, 2019 at 09:51:54PM +0200, Thomas Gleixner wrote: > On Wed, 18 Sep 2019, Balasubramani Vivekanandan wrote: > > > > When there are no more cpus subscribed to broadcast, the timer callback > > might not set the expiry time for hrtimer. Therefore the callback timer > > function is

Re: [PATCH V1 0/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

+linux-renesas-soc In hope that the issue reported in [1] was seen by other members of Renesas community. [1] https://lkml.org/lkml/2019/9/18/711 On Wed, Sep 18, 2019 at 04:41:37PM +0200, Balasubramani Vivekanandan wrote: > I was investigating a rcu stall warning on ARM64 Renesas Rcar3 >

Re: [PATCH V1 0/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

+linux-renesas-soc In hope that the issue reported in [1] was seen by other members of Renesas community. [1] https://lkml.org/lkml/2019/9/18/711 On Wed, Sep 18, 2019 at 04:41:37PM +0200, Balasubramani Vivekanandan wrote: > I was investigating a rcu stall warning on ARM64 Renesas Rcar3 >

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

Hi Shuah, On Wed, Sep 18, 2019 at 03:05:33PM -0600, Shuah wrote: [..] > They both look good to me. I will apply these patches once the merge > window closes or when my first pull request to Linus clears. > > You will see a notification when I apply them to kselftest tree. Many thanks for your

Re: [PATCH v3 1/2] selftests: watchdog: Validate optional file argument

Hi Shuah, On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote: > From: "George G. Davis" > > The newly added optional file argument does not validate if the > file is indeed a watchdog, e.g.: > > ./watchdog-test -f /dev/zero > Watchdog Ticking

Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

(For LKML readability) Superseded by: - https://patchwork.kernel.org/patch/11149287/ ("[v3,1/2] selftests: watchdog: Validate optional file argument") -- Best Regards, Eugeniu.

Re: [PATCH 2/2] selftests: watchdog: Add command line option to show watchdog_info

(For LKML readability) Superseded by: - https://patchwork.kernel.org/patch/11149289/ ("[v3,2/2] selftests: watchdog: Add command line option to show watchdog_info") -- Best Regards, Eugeniu.

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

(For LKML readability) Superseded by: - https://patchwork.kernel.org/patch/11149287/ ("[v3,1/2] selftests: watchdog: Validate optional file argument") - https://patchwork.kernel.org/patch/11149289/ ("[v3,2/2] selftests: watchdog: Add command line option to show watchdog_info") -- Best

[PATCH v3 2/2] selftests: watchdog: Add command line option to show watchdog_info

From: "George G. Davis" With the new ioctl(WDIOC_GETSUPPORT) call in place, add a command line option to show the watchdog_info. Suggested-by: Eugeniu Rosca Signed-off-by: George G. Davis Signed-off-by: Eugeniu Rosca --- v3: - Used v1 as starting point and simplified commit d

[PATCH v3 1/2] selftests: watchdog: Validate optional file argument

: watchdog: Add optional file argument") Reported-by: Eugeniu Rosca Signed-off-by: George G. Davis Signed-off-by: Eugeniu Rosca --- v3: - Used v1 as starting point and simplified commit description - Added Fixes tag (WARNING: commit id is from linux-next!) - No change in the contents - Applied

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: > On 9/17/19 10:54 AM, Eugeniu Rosca wrote: > > Shuah, > > > > On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: > > > > [..] > > > > > I want two patches and the first one with &

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] > I want two patches and the first one with > Fixes tag. I am not sure we are on the same page and you don't seem to be receptive to what I say. > The reason for that is that the first patch fixes a problem > in patch that is

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

Shuah, On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote: > On 9/16/19 12:49 PM, George G. Davis wrote: > > As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 > > ("selftests: watchdog: Add optional file argument") is that arbitrary files >

Re: [PATCH 2/2] selftests: watchdog: Add command line option to show watchdog_info

Hi Shuah, CC George On Mon, Sep 16, 2019 at 07:26:41AM -0600, shuah wrote: [..] > > case 'f': > > /* Handled above */ > > break; > > + case 'i': > > + /* > > +* watchdog_info was obtained as part

Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument

Hi Shuah, On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote: > From: "George G. Davis" > > As reported by Eugeniu Rosca, the newly added optional file > argument does not validate if the file is indeed a watchdog, e.g.: > > ./watchdog-test -f /dev/

[PATCH 1/2] selftests: watchdog: Validate optional file argument

From: "George G. Davis" As reported by Eugeniu Rosca, the newly added optional file argument does not validate if the file is indeed a watchdog, e.g.: ./watchdog-test -f /dev/zero Watchdog Ticking Away! Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds. Reported-by: Eug

[PATCH 2/2] selftests: watchdog: Add command line option to show watchdog_info

tchdog: Validate optional file argument" was added to validate that a file is indeed a watchdog device via an ioctl(WDIOC_GETSUPPORT) call. Since the watchdog_info is available as a result of the ioctl(WDIOC_GETSUPPORT) call, add a command line option to show the watchdog_info. Suggested

Re: [PATCH v2] selftests: watchdog: Add optional file argument

electing non-default watchdog devices for testing. > > Tested-by: Eugeniu Rosca > Signed-off-by: George G. Davis > --- > v1: > - https://lkml.org/lkml/2019/8/29/16 > v2: > - Update printf for ENOENT case based on report from Eugeniu Rosca Below interdiff [1] matche

Re: [PATCH] selftests: watchdog: Add optional file argument

On Thu, Aug 29, 2019 at 04:38:14PM +0200, Eugeniu Rosca wrote: > Hi George, > > On Thu, Aug 29, 2019 at 12:39:25AM -0400, George G. Davis wrote: > > Some systems have multiple watchdog devices where the first device > > registered is assigned to the /dev/watchdog device file

Re: [PATCH] selftests: watchdog: Add optional file argument

Hi George, On Thu, Aug 29, 2019 at 12:39:25AM -0400, George G. Davis wrote: > Some systems have multiple watchdog devices where the first device > registered is assigned to the /dev/watchdog device file. Confirmed on R-Car H3-Salvator-X: root@rcar-gen3:~# ls -al /dev/watchdog* crw---1

Re: [PATCH] usb: gadget: u_audio: Fixed variable declaration coding style issue

rom my end: Reviewed-by: Eugeniu Rosca [1] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget/function | wc -l 32 [2] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget | wc -l 99 -- Best Regards, Eugeniu.

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

Hi Marc, Thanks for your comment. On Wed, Jun 12, 2019 at 11:17:10AM +0100, Marc Zyngier wrote: > Eugeniu Rosca wrote: > > On Tue, Jun 11, 2019 at 10:00:41AM +0100, Marc Zyngier wrote: [..] > > > We already have plenty of that in the tree, the canonical example > >

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

; > On Mon, Jun 10, 2019 at 10:30 AM Tony Lindgren wrote: > >> * Kalle Valo [190610 07:01]: > >>> Eugeniu Rosca writes: > >>> > >>>> The wl1837mod datasheet [1] says about the WL_IRQ pin: > >>>> > >>>> ---8<---

[PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

rnel.org/patch/10895879/ ("arm64: dts: ulcb-kf: Add support for TI WL1837") Signed-off-by: Eugeniu Rosca --- drivers/net/wireless/ti/wl18xx/main.c | 5 + drivers/net/wireless/ti/wlcore/sdio.c | 2 ++ drivers/net/wireless/ti/wlcore/wlcore_i.h | 4 3 files chang

Re: [PATCH] usb: hub: report failure to enumerate uevent to userspace

Hi Greg, We really appreciate your feedback. On Wed, Jun 05, 2019 at 12:03:37PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 05, 2019 at 11:05:56AM +0200, Eugeniu Rosca wrote: > > From: Spyridon Papageorgiou > > > > When a USB device fails to enumerate, only a kern

[PATCH] usb: hub: report failure to enumerate uevent to userspace

ction name follows the syntax of "port_over_current_notify()" used in v4.20-rc1 commit 201af55da8a398 ("usb: core: added uevent for over-current"). Signed-off-by: Spyridon Papageorgiou Signed-off-by: Eugeniu Rosca --- Documentation/ABI/testing/usb-uevent | 36

Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837

Hi Geert, We appreciate your review comments. On Tue, May 28, 2019 at 11:19:04AM +0200, Geert Uytterhoeven wrote: [..] > > + wlan_en: regulator-wlan_en { > > + compatible = "regulator-fixed"; > > + regulator-name = "wlan-en-regulator"; > > + > > +

Re: [PATCH] arm64: dts: ulcb-kf: Add support for TI WL1837

Hi Simon, On Fri, May 31, 2019 at 11:37:02AM +0200, Simon Horman wrote: > Hi Spyridon, > > please respond to Geert's review below and > if appropriate provide an incremental patch. > > Thanks in advance, > Simon > Spyridon is on vacation, so I will handle the open points. -- Best Regards,

Re: [PATCH] serial: sh-sci: disable DMA for uart_console

Hi George, On Fri, May 10, 2019 at 02:38:47PM -0400, George G. Davis wrote: > Hello Eugeniu, > > On Fri, May 10, 2019 at 07:10:21PM +0200, Eugeniu Rosca wrote: > > Hi George, > > > > I am able to reproduce the SCIF2 console freeze described in the > > referen

Re: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

Hi Niklas, On Fri, May 10, 2019 at 01:36:08PM +0200, Niklas Söderlund wrote: > Hi Eugeniu, > > On 2019-05-10 12:42:31 +0200, Eugeniu Rosca wrote: > > Hi Niklas, > > > > On Wed, May 08, 2019 at 01:54:03AM +0200, Niklas Söderlund wrote: > > > Hi Jiada, >

Re: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

Hi Niklas, On Wed, May 08, 2019 at 01:54:03AM +0200, Niklas Söderlund wrote: > Hi Jiada, [..] > I really like this series, nice work. > > Tested-by: Niklas Söderlund > Reviewed-by: Niklas Söderlund Is there anything off-the-shelf available for testing the rcar3 thermal driver, to avoid

Re: [PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit

On Thu, May 02, 2019 at 07:39:20PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 24, 2019 at 09:23:43PM +0200, Eugeniu Rosca wrote: > > From: Suresh Udipi > > > > It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 > > commit [1] missed to fix the memor

[PATCH] staging: most: cdev: fix chrdev_region leak in mod_exit

f7ae7ea381 ("staging: most: cdev: fix leak for chrdev_region") Signed-off-by: Suresh Udipi Signed-off-by: Eugeniu Rosca --- drivers/staging/most/cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.

Re: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove

rupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang Based on https://patchwork.kernel.org/cover/10914079/#22603533 : Reviewed-and-Tested-by: Eugeniu Rosca Thanks! -- Best regards, Eugeniu.

Re: [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type

rite of REG_GEN3_IRQSTR with lock. > > Fixes: 7d4b269776ec6 ("enable hardware interrupts for trip points") > Signed-off-by: Jiada Wang Based on https://patchwork.kernel.org/cover/10914079/#22603533 : Reviewed-and-Tested-by: Eugeniu Rosca Thanks! -- Best regards, Eugeniu.

Re: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

org/patch/10913165/#22601305 . In addition, I made sure there are either false positives or no new issues reported by: - sparse v0.5.2-1-ga3c4716a703a - smatch v0.5.0-4785-g4968bcad1c08 - cppcheck 1.88 dev - make W=123 - make coccicheck I repeated the same test steps as described in https://pat

Re: [PATCH v3 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

t; --- > v3: fix to use correct code base > remove unused "flag" variable in rcar_gen3_thermal_irq [..] Based on below: - basic functional testing [1] - 40 min of loading and unloading the driver in a loop doesn't trigger the original problem (soft lockup) Tested-by: Eugeniu R

Re: [PATCH v3 1/2] thermal: rcar_gen3_thermal: fix interrupt type

Hi Jiada, On Tue, Apr 23, 2019 at 11:14:13PM +0900, Jiada Wang wrote: > Currently IRQF_SHARED type interrupt line is allocated, but it > is not appropriate, as the interrupt line isn't shared between > different devices, instead IRQF_ONESHOT is the proper type. > > By changing interrupt type to

Re: [PATCH v2 1/2] thermal: rcar_gen3_thermal: fix interrupt type

Hi Jiada, On Tue, Apr 23, 2019 at 03:12:17PM +0900, Jiada Wang wrote: > Currently IRQF_SHARED type interrupt line is allocated, but it > is not appropriate, as the interrupt line isn't shared between > different devices, instead IRQF_ONESHOT is the proper type. > > By changing interrupt type to

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

Hi Simon, On Tue, Apr 23, 2019 at 12:01:07PM +0200, Simon Horman wrote: > On Tue, Apr 16, 2019 at 07:48:30PM +0200, Eugeniu Rosca wrote: > > Hi Jiada, > > > > Adding below people, since they've made recent contributions to the > > driver and might be interested in y

Re: [PATCH v1 1/1] thermal: rcar_gen3_thermal: request IRQ after device initialization

t for over one hour w/o seeing the issue reproduced. So, while there might be slight variations in how the final solution looks like, I think the patch already deserves a: Tested-by: Eugeniu Rosca [1] Soft lockup reproduced with v5.1-rc5-10-g618d919cae2f root@rcar-gen3:~# while true; do rmm

Re: [PATCH] serial: sh-sci: Fix HSCIF RX sampling point calculation

Hi Geert, On Mon, Apr 01, 2019 at 01:25:10PM +0200, Geert Uytterhoeven wrote: > There are several issues with the formula used for calculating the > deviation from the intended rate: > 1. While min_err and last_stop are signed, srr and baud are unsigned. > Hence the signed values are

Re: [PATCH v3] drivers: base: add support to skip power management in device/driver model

vailable at: https://gist.github.com/erosca/1af11aa62e16903e1b6964be6a9eea77 Tested-by: Eugeniu Rosca Thanks! Eugeniu.

Re: [PATCH v2] drivers: base: add support to skip power management in device/driver model

Hello Sudeep, I appreciate your efforts. Currently, this patch generates below warnings during s2ram on R-Car H3-Salvator-X: [ 46.874214] PM: suspend entry (deep) [ 46.878211] PM: Syncing filesystems ... done. [ 46.989148] Freezing user space processes ... (elapsed 0.004 seconds) done. [

Re: [RFC PATCH] drivers core: cpu: add hotplug callback to update cpu_dev state to resumed

-y 7 0x30 0x20 0x0F root@salvator-x:~# echo deep > /sys/power/mem_sleep root@salvator-x:~# echo mem > /sys/power/state Tested-by: Eugeniu Rosca

Re: potential deadlock in cpufreq-dt

Hi all, [since Jiada's initial report was based on 4.14.50+] FWIW, I can consistently reproduce this lockdep issue on 4.18.0-rc6: [ 17.119559] == [ 17.119571] WARNING: possible circular locking dependency detected [ 17.119589] 4.18.0-rc6

Re: potential deadlock in cpufreq-dt

Hi all, [since Jiada's initial report was based on 4.14.50+] FWIW, I can consistently reproduce this lockdep issue on 4.18.0-rc6: [ 17.119559] == [ 17.119571] WARNING: possible circular locking dependency detected [ 17.119589] 4.18.0-rc6

Re: [PATCH] locking/lockdep: Report comm/pid/timestamp information

On Mon, Jul 09, 2018 at 10:31:18AM +0200, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 02:57:25AM +0200, Eugeniu Rosca wrote: > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > index 6fc77d4dbdcd..eeed7ea2e198 100644 > > --- a/include/linux/lockdep.h &g

Re: [PATCH] locking/lockdep: Report comm/pid/timestamp information

On Mon, Jul 09, 2018 at 10:31:18AM +0200, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 02:57:25AM +0200, Eugeniu Rosca wrote: > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > index 6fc77d4dbdcd..eeed7ea2e198 100644 > > --- a/include/linux/lockdep.h &g

[PATCH] locking/lockdep: Report comm/pid/timestamp information

1.570576] driver_attach+0x50/0x5c [ 21.570587] bus_add_driver+0x2a8/0x2fc [ 21.570597] driver_register+0x180/0x1c8 [ 21.570607] __platform_driver_register+0x9c/0xac [ 21.570628] dt_cpufreq_platdrv_init+0x28/0x1000 [cpufreq_dt] [ 21.570638] do_one_initcall+0x608/0xc54 [ 21.570650]

[PATCH] locking/lockdep: Report comm/pid/timestamp information

1.570576] driver_attach+0x50/0x5c [ 21.570587] bus_add_driver+0x2a8/0x2fc [ 21.570597] driver_register+0x180/0x1c8 [ 21.570607] __platform_driver_register+0x9c/0xac [ 21.570628] dt_cpufreq_platdrv_init+0x28/0x1000 [cpufreq_dt] [ 21.570638] do_one_initcall+0x608/0xc54 [ 21.570650]

Re: [PATCHv2 3/3] usb: gadget: f_uac*: Support multiple sampling rates

Hi Julian, [CC:Takashi, since we are discussing sound-related parts of USB] On Mon, Jul 02, 2018 at 04:07:19PM +0200, Julian Scheel wrote: > Hi Eugeniu, > > On 30.06.2018 20:16, Eugeniu Rosca wrote: > > Would it be possible to revive the uac2 multiple sampling rate > > patc

Re: [PATCHv2 3/3] usb: gadget: f_uac*: Support multiple sampling rates

Hi Julian, [CC:Takashi, since we are discussing sound-related parts of USB] On Mon, Jul 02, 2018 at 04:07:19PM +0200, Julian Scheel wrote: > Hi Eugeniu, > > On 30.06.2018 20:16, Eugeniu Rosca wrote: > > Would it be possible to revive the uac2 multiple sampling rate > > patc

Re: [PATCH 1/4] mm: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Wed, Mar 21, 2018 at 08:28:18PM +0800, Jia He wrote: > > > On 3/21/2018 6:14 PM, Daniel Vacek Wrote: > >On Wed, Mar 21, 2018 at 9:09 AM, Jia He wrote: > >>Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > >>where possible") optimized the loop in

Re: [PATCH 1/4] mm: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Wed, Mar 21, 2018 at 08:28:18PM +0800, Jia He wrote: > > > On 3/21/2018 6:14 PM, Daniel Vacek Wrote: > >On Wed, Mar 21, 2018 at 9:09 AM, Jia He wrote: > >>Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > >>where possible") optimized the loop in memmap_init_zone().

Re: [PATCH v4 1/2] kconfig: warn unmet direct dependency of tristate symbols selected by y

Hi Masahiro, On Tue, Mar 13, 2018 at 06:56:07PM +0900, Masahiro Yamada wrote: > Commit 246cf9c26bf1 ("kbuild: Warn on selecting symbols with unmet > direct dependencies") forcibly promoted ->dir_dep.tri to yes from mod. > So, the unmet direct dependencies of tristate symbols are not reported. >

Re: [PATCH v4 1/2] kconfig: warn unmet direct dependency of tristate symbols selected by y

Hi Masahiro, On Tue, Mar 13, 2018 at 06:56:07PM +0900, Masahiro Yamada wrote: > Commit 246cf9c26bf1 ("kbuild: Warn on selecting symbols with unmet > direct dependencies") forcibly promoted ->dir_dep.tri to yes from mod. > So, the unmet direct dependencies of tristate symbols are not reported. >

Re: [PATCH v3] kconfig: make unmet dependency warnings readable

Hi Masahiro, Some "final polishing" review comments. Feel free to pick/drop them at your will. On Sun, Mar 11, 2018 at 12:51:59AM +0900, Masahiro Yamada wrote: > Currently, the unmet dependency warnings end up with endlessly long > expressions, most of which are false positives. > > Here is

Re: [PATCH v3] kconfig: make unmet dependency warnings readable

Hi Masahiro, Some "final polishing" review comments. Feel free to pick/drop them at your will. On Sun, Mar 11, 2018 at 12:51:59AM +0900, Masahiro Yamada wrote: > Currently, the unmet dependency warnings end up with endlessly long > expressions, most of which are false positives. > > Here is

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

Hi Masahiro, Thanks for constantly improving the user experience of Kconfig. Just one small remark below. On Tue, Mar 06, 2018 at 07:51:39PM +0900, Masahiro Yamada wrote: > Currently, the unmet dependency warnings end up with endlessly long > expressions, most of which are false positives. > >

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

Hi Masahiro, Thanks for constantly improving the user experience of Kconfig. Just one small remark below. On Tue, Mar 06, 2018 at 07:51:39PM +0900, Masahiro Yamada wrote: > Currently, the unmet dependency warnings end up with endlessly long > expressions, most of which are false positives. > >

Re: mmotm 2018-02-21-14-48 uploaded (mm/page_alloc.c on UML)

Hello Andrew, Michal, On Thu, Feb 22, 2018 at 02:26:30PM +0100, Michal Hocko wrote: > On Thu 22-02-18 14:08:14, Eugeniu Rosca wrote: > > On Thu, Feb 22, 2018 at 01:59:55PM +0100, Michal Hocko wrote: > > > On Thu 22-02-18 11:38:32, Eugeniu Rosca wrote: > > > > Hi M

  1   2   >