[PATCH v3] drivers/clocksource/mediatek: Ack and disable interrupts on suspend

2021-04-11 Thread Evan Benn
Interrupts are disabled during suspend before this driver disables its timers. ARM trusted firmware will abort suspend if the timer irq is pending, so ack and disable the timer interrupt during suspend. Signed-off-by: Evan Benn --- Changes in v3: Move the ACK from the shutdown to the suspend

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-04-05 Thread Evan Benn
On Sat, Apr 3, 2021 at 1:15 AM Daniel Lezcano wrote: > > > > That said I am happy to upload that version if people think it is better. > > IMO, it is not in the normal flow to disable/enable the interrupts. Hi Daniel, no problem. I will upload the suspend/resume version. Please note the similar

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-26 Thread Evan Benn
rsion if people think it is better. https://elixir.bootlin.com/linux/latest/source/include/linux/clockchips.h#L120 On Thu, 25 Mar 2021 at 19:10, Daniel Lezcano wrote: > > On 25/03/2021 02:35, Evan Benn wrote: > > set_state_shutdown is called during system suspend after interru

[PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-24 Thread Evan Benn
disable the IRQ in state transitions, and re-enable in set_periodic and next_event. Signed-off-by: Evan Benn --- Changes in v2: Remove the patch that splits the drivers into 2 files. drivers/clocksource/timer-mediatek.c | 49 +--- 1 file changed, 30 insertions(+), 19

Re: [PATCH 1/2] drivers/clocksource/mediatek: Split mediatek drivers into 2 files

2021-03-23 Thread Evan Benn
On Mon, Mar 22, 2021 at 10:19 PM Daniel Lezcano wrote: > > > Hi Evan, > > On 18/03/2021 06:04, Evan Benn wrote: > > mtk_gpt and mtk_syst drivers for mt6577 and mt6765 devices were not > > sharing any code. So split them into separate files. > > For the sake of c

Re: [PATCH] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on Mediatek Socs

2021-03-22 Thread Evan Benn
On Thu, Mar 4, 2021 at 11:07 AM Fengquan Chen wrote: > > 1)ensure systimer is enabled before clear and disable interrupt, which only > for systimer in Mediatek Socs. Why does the timer need to be enabled before the interrupt can be disabled? The datasheet I have does not suggest that this is requ

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-21 Thread Evan Benn
On Sat, Mar 20, 2021 at 8:36 AM Alex Deucher wrote: > > On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote: > > > > On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote: > > > On 2021-03-19 10:22 a.m., Alex Deucher wrote: > > > > On Fri, M

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Evan Benn
On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote: > On 2021-03-19 10:22 a.m., Alex Deucher wrote: > > On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: > >> > >> AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 > >> to ensure no display backlight

[PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-18 Thread Evan Benn
user cannot set the brightness to a low level even if the display would support such a low PWM. This ATIF feature is not implemented on for example AMD grunt chromebooks. Signed-off-by: Evan Benn --- I could not find a justification for the reason for the value. It has caused some noticable

[PATCH] scripts/coccinelle: Add script to detect sign extension

2021-03-18 Thread Evan Benn
sizes differ. Thanks Evan Benn Signed-off-by: Evan Benn --- .../coccinelle/tests/int_sign_extend.cocci| 35 +++ 1 file changed, 35 insertions(+) create mode 100644 scripts/coccinelle/tests/int_sign_extend.cocci diff --git a/scripts/coccinelle/tests/int_sign_extend.cocci b

Re: [PATCH 2/2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-18 Thread Evan Benn
/ clockevents_shutdown. Also reviewed here vs the 4.19 chromeos kernel branch: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2766504 Thanks Evan Benn On Thu, Mar 18, 2021 at 4:05 PM Evan Benn wrote: > > set_state_shutdown is called during system suspend after inte

[PATCH 2/2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

2021-03-17 Thread Evan Benn
disable the IRQ in state transitions, and re-enable in set_periodic and next_event. Signed-off-by: Evan Benn --- drivers/clocksource/timer-mediatek-mt6577.c | 49 + 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/clocksource/timer-mediatek-mt6577.c b

[PATCH 1/2] drivers/clocksource/mediatek: Split mediatek drivers into 2 files

2021-03-17 Thread Evan Benn
mtk_gpt and mtk_syst drivers for mt6577 and mt6765 devices were not sharing any code. So split them into separate files. Signed-off-by: Evan Benn --- arch/arm/mach-mediatek/Kconfig| 3 +- arch/arm64/Kconfig.platforms | 3 +- drivers/clocksource/Kconfig

[PATCH 2/2] platform/chrome: cros_ec_proto: Add LID and BATTERY to default mask

2020-12-09 Thread Evan Benn
es. Fixes: c214e564acb2ad9463293ab9c109bfdae91fbeaf Signed-off-by: Evan Benn --- drivers/platform/chrome/cros_ec_proto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 4e442175612d..ea5149efcbea 10

[PATCH 1/2] platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT

2020-12-09 Thread Evan Benn
Signed-off-by: Evan Benn --- drivers/platform/chrome/cros_ec_proto.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 0ecee8b8773d..4e442175612d 100644 --- a/drivers/platf

[PATCH] media: mtk-vcodec: Fix order of log arguments

2020-11-25 Thread Evan Benn
Signed-off-by: Evan Benn --- drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c index a3c7a380c9308..785ec0df445ec

Re: [PATCH] MAINTAINERS: rectify entry in ARM SMC WATCHDOG DRIVER

2020-06-04 Thread Evan Benn
t/?id=72a9e7fea5866fc471fda78f05f166595c8c6ba6 On Wed, Jun 3, 2020 at 9:22 AM Evan Benn wrote: > > Apologies for that slip up. > > Reviewed-by: Evan Benn > > On Wed, Jun 3, 2020 at 6:16 AM Julius Werner wrote: > > > > Reviewed-by: Julius Werner

Re: [PATCH] MAINTAINERS: rectify entry in ARM SMC WATCHDOG DRIVER

2020-06-02 Thread Evan Benn
Apologies for that slip up. Reviewed-by: Evan Benn On Wed, Jun 3, 2020 at 6:16 AM Julius Werner wrote: > > Reviewed-by: Julius Werner

[PATCH v6 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls.

2020-05-04 Thread Evan Benn
back to arm - Add optional get_timeleft op - change name to arm_smc_wdt Changes in v2: - Change name arm > mt8173 - use watchdog_stop_on_reboot - use watchdog_stop_on_unregister - use devm_watchdog_register_device - remove smcwd_shutdown, smcwd_remove - change error codes Evan Benn (1): dt-

[PATCH v6 2/2] watchdog: Add new arm_smc_wdt watchdog driver

2020-05-04 Thread Evan Benn
Monitor firmware to have the final control over the watchdog. This is implemented on mt8173 chromebook devices oak, elm and hana in arm trusted firmware file plat/mediatek/mt8173/drivers/wdt/wdt.c. Signed-off-by: Julius Werner Signed-off-by: Evan Benn --- Changes in v6: - Use default arm,smc-id

[PATCH v6 1/2] dt-bindings: watchdog: Add ARM smc wdt for mt8173 watchdog

2020-05-04 Thread Evan Benn
This watchdog can be used on ARM systems with a Secure Monitor firmware to forward watchdog operations to firmware via a Secure Monitor Call. Signed-off-by: Evan Benn --- Changes in v6: - Don't use dt default Changes in v5: - Change compatible to arm,smc-wdt Changes in v4: - Add arm,s