On Mon, 07 Mar 2005 15:37:30 -0800
"Randy.Dunlap" <[EMAIL PROTECTED]> wrote:
> Evgeniy Polyakov wrote:
> > --- /tmp/empty/crypto_dev.c 1970-01-01 03:00:00.0 +0300
> > +++ ./acrypto/crypto_dev.c 2005-03-07 20:35:36.0 +0300
> > @@ -0,0 +1,421 @@
On Mon, 7 Mar 2005 14:40:52 -0800
Nish Aravamudan <[EMAIL PROTECTED]> wrote:
> On Mon, 7 Mar 2005 23:37:34 +0300, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> > --- /tmp/empty/crypto_dev.c 1970-01-01 03:00:00.0 +0300
> > +++ ./acrypto/crypto_dev.c 20
I'm pleased to announce asynchronous crypto layer for Linux kernel 2.6.
It supports following features:
- multiple asynchronous crypto device queues
- crypto session routing
- crypto session binding
- modular load balancing
- crypto session batching genetically implemented by design
- crypto sess
--- ./arch/arm/Kconfig~ 2005-03-02 10:38:10.0 +0300
+++ ./arch/arm/Kconfig 2005-03-07 21:26:11.0 +0300
@@ -735,4 +735,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
--- ./arch/alpha/Kconfig~ 2005-03-02 10:38:38.0 +0300
+++ ./arch/alpha/Kconfig2005-03-07 21:25:54.0 +0300
@@ -602,5 +602,7 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe l
--- /tmp/empty/crypto_dev.c 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_dev.c 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,421 @@
+/*
+ * crypto_dev.c
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
On Mon, 07 Mar 2005 22:13:18 +0100
Fruhwirth Clemens <[EMAIL PROTECTED]> wrote:
> On Mon, 2005-03-07 at 23:37 +0300, Evgeniy Polyakov wrote:
>
> > I'm pleased to announce asynchronous crypto layer for Linux kernel 2.6.
>
> Thanks Evgeniy for your work! Even though,
--- /tmp/empty/crypto_user_direct.c 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_user_direct.c 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,390 @@
+/*
+ * crypto_user_direct.c
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This prog
/*
* ucon_crypto.c
*
* Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
*
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2
--- ./arch/m68k/Kconfig~2005-03-02 10:38:10.0 +0300
+++ ./arch/m68k/Kconfig 2005-03-07 21:28:12.0 +0300
@@ -667,4 +667,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kerne
--- ./arch/sh64/Kconfig~2005-03-02 10:38:17.0 +0300
+++ ./arch/sh64/Kconfig 2005-03-07 21:30:08.0 +0300
@@ -273,4 +273,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kerne
--- ./arch/mips/Kconfig~2005-03-02 10:38:09.0 +0300
+++ ./arch/mips/Kconfig 2005-03-07 21:28:46.0 +0300
@@ -1648,6 +1648,8 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
#
-
To unsubscribe from this list: send the line "unsubscribe linu
--- ./arch/sh/Kconfig~ 2005-03-02 10:38:33.0 +0300
+++ ./arch/sh/Kconfig 2005-03-07 21:29:53.0 +0300
@@ -792,4 +792,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
--- ./arch/i386/Kconfig~2005-03-02 10:37:49.0 +0300
+++ ./arch/i386/Kconfig 2005-03-07 20:52:47.0 +0300
@@ -1214,6 +1214,8 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
#
-
To unsubscribe from this list: send the line "unsubscribe linu
--- ./arch/arm26/Kconfig~ 2005-03-02 10:38:10.0 +0300
+++ ./arch/arm26/Kconfig2005-03-07 21:26:23.0 +0300
@@ -224,4 +224,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe lin
--- ./arch/sparc64/Kconfig~ 2005-03-02 10:38:25.0 +0300
+++ ./arch/sparc64/Kconfig 2005-03-07 21:30:33.0 +0300
@@ -606,4 +606,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe lin
diff -Nru /tmp/empty/Kconfig ./acrypto/Kconfig
--- /tmp/empty/Kconfig 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/Kconfig 2005-03-07 21:21:33.0 +0300
@@ -0,0 +1,30 @@
+menu "Asynchronous crypto layer"
+
+config ACRYPTO
+ tristate "Asynchronous crypto layer"
+ select CON
--- ./arch/ppc/Kconfig~ 2005-03-02 10:38:33.0 +0300
+++ ./arch/ppc/Kconfig 2005-03-07 21:29:12.0 +0300
@@ -1294,3 +1294,5 @@
source "security/Kconfig"
source "crypto/Kconfig"
+
+source "acrypto/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
#include
#include
#include
#include
#include
#include
#include
#include
#include
#include
#define __USE_LARGEFILE64
#include
#include "bd.h"
#include "bd_fd.h"
#include "bd_acrypto.h"
#include "../crypto/crypto_def.h"
#define ulog(f, a...) fprintf(stderr, f, ##a)
struct table;
stru
--- /tmp/empty/crypto_stat.c1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_stat.c 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,100 @@
+/*
+ * crypto_stat.c
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
--- /tmp/empty/crypto_stat.h1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_stat.h 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,32 @@
+/*
+ * crypto_stat.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
--- ./arch/ppc64/Kconfig~ 2005-03-02 10:38:10.0 +0300
+++ ./arch/ppc64/Kconfig2005-03-07 21:29:24.0 +0300
@@ -396,4 +396,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe lin
--- /tmp/empty/crypto_main.c1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_main.c 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,374 @@
+/*
+ * crypto_main.c
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
--- ./arch/x86_64/Kconfig~ 2005-03-02 10:38:18.0 +0300
+++ ./arch/x86_64/Kconfig 2005-03-07 21:31:22.0 +0300
@@ -456,4 +456,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe lin
--- /tmp/empty/crypto_user_ioctl.h 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_user_ioctl.h 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,67 @@
+/*
+ * crypto_user_ioctl.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program i
--- /tmp/empty/crypto_lb.h 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_lb.h 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,63 @@
+/*
+ * crypto_lb.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
--- /tmp/empty/crypto_route.h 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_route.h2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,242 @@
+/*
+ * crypto_route.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; y
--- /tmp/empty/crypto_user_direct.h 1970-01-01 03:00:00.0 +0300
+++ ./acrypto/crypto_user_direct.h 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,74 @@
+/*
+ * crypto_user_direct.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This prog
--- ./arch/sparc/Kconfig~ 2005-03-02 10:37:30.0 +0300
+++ ./arch/sparc/Kconfig2005-03-07 21:30:22.0 +0300
@@ -390,4 +390,6 @@
source "crypto/Kconfig"
+source "acrypto/Kconfig"
+
source "lib/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe lin
--- /tmp/empty/acrypto.h1970-01-01 03:00:00.0 +0300
+++ ./acrypto/acrypto.h 2005-03-07 20:35:36.0 +0300
@@ -0,0 +1,245 @@
+/*
+ * acrypto.h
+ *
+ * Copyright (c) 2004 Evgeniy Polyakov <[EMAIL PROTECTED]>
+ *
+ *
+ * This program is free software; you can redist
Benchmark: Bonnie++ 1.03.
Machine: 2-way Xeon (1+1HT), 1Gb ram.
Ext2 filesystem over file(mapped using loop(cryptoloop, dm_crypt)
or bd_fd filter for bd).
Version @version@ --Sequential Output-- --Sequential Input-
--Random-
-Per Chr- --Block-- -Rewrite- -Per C
On Thu, 2005-03-03 at 14:51 +0300, Evgeniy Polyakov wrote:
> Simple program to test fork() performance.
...
In a bit more advanced version it checks for error value,
but it never happend.
It can also have more fine grained measurment,
but IMHO the picture is clear for small systems.
> Cr
fork lock does not cost anything
(tested both with and without userspace listener), but it is only 2-way(pseudo).
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
sizeof(int);
> hdr->nlmsg_type = 0;
> hdr->nlmsg_flags = 0;
> hdr->nlmsg_seq = 0;
> hdr->nlmsg_pid = getpid();
> msg->id.idx = 0xfeed;
> msg->id.val = 0xbeef;
> msg->seq = msg->ack = 0;
> msg->len = sizeof(int);
>
"requested msg->len=%u[%u],
> nlh->nlmsg_len=%u, skb->len=%u.\n",
> + msg->len, NLMSG_SPACE(msg->len +
> sizeof(*msg)),
> + nlh->nlmsg_len, skb->len);
> kfree_skb(skb);
> return -EINVAL;
> }
>
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
s, then group check is useless.
I would prefer Guillaume Thouvenin as fork connector author to test
his current implementation and show that connector's cost is negligible
both with and without userspace listeners.
As far as I remember it is first entry in fork connector's TODO list.
&
st extend protocol a bit?
Add header after cn_msg, which will have get/set field and that is all.
Properly using seq/ack fields userspace can avoid locks.
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
various process' states
over netlink.
Discussion at http://lkml.org/lkml/2005/2/17/87
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
ng '\0'
> + */
> + /* just fill the data part with '\0' */
> + memset(msg->data, '\0', CN_FORK_INFO_SIZE);
> + msg->len = scnprintf(msg->data, CN_FORK_INFO_SIZE-1,
> + "%i %i", parent, child) + 1;
> +
> + cn_netlink_send(msg, CN_IDX_FORK);
> + }
> +}
> +#else
> +static inline void fork_connector(pid_t parent, pid_t child)
> +{
> + return;
> +}
> +#endif
> +
> int nr_processes(void)
> {
> int cpu;
> @@ -1238,6 +1281,8 @@ long do_fork(unsigned long clone_flags,
> if (unlikely (current->ptrace & PT_TRACE_VFORK_DONE))
> ptrace_notify ((PTRACE_EVENT_VFORK_DONE << 8) |
> SIGTRAP);
> }
> +
> + fork_connector(current->pid, p->pid);
> } else {
> free_pidmap(pid);
> pid = PTR_ERR(p);
>
>
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
On Thu, 2005-02-24 at 07:41 +0100, Guillaume Thouvenin wrote:
> On Wed, 2005-02-23 at 14:41 +0300, Evgeniy Polyakov wrote:
> > > Please assume that > > originally written for> will always be listening.
> > >
> > > > > What happened to t
On Wed, 23 Feb 2005 02:58:06 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
> >
> > On Wed, 23 Feb 2005 01:07:47 -0800
> > Andrew Morton <[EMAIL PROTECTED]> wrote:
> >
> > > Guillaume Thou
1;
>
> scnprintf() would be more appropriate here, even though it should be a "can't
> happen".
>
> > + cn_netlink_send(msg, CN_IDX_FORK);
> > +
> > + kfree(msg);
>
> `msg' is only 84 bytes and do
On Mon, 2005-02-21 at 09:05 +0100, Guillaume Thouvenin wrote:
> On Thu, 2005-02-17 at 18:50 +0300, Evgeniy Polyakov wrote:
> > >
> > > +#if defined(CONFIG_CONNECTOR) && defined(CONFIG_FORK_CONNECTOR)
> >
> > I suspect CONFIG_FORK_CONNECTOR is enough.
&
On Mon, 2005-02-21 at 08:07 +0100, Guillaume Thouvenin wrote:
> On Thu, 2005-02-17 at 18:50 +0300, Evgeniy Polyakov wrote:
> > On Thu, 2005-02-17 at 15:55 +0100, Guillaume Thouvenin wrote:
> > > It's a new patch that implements a fork connector in the
> > > kern
roper group for you.
> + kfree(msg);
> + }
> + }
> +}
> +#else
> +static inline void fork_connector(pid_t parent, pid_t child)
> +{
> + return;
> +}
> +#endif
> +
> int nr_processes(void)
> {
> int cpu;
&g
static LIST_HEAD(notify_list);
> >
> > static struct cn_dev cdev;
> >
>
> Isn't this supposed to be "static DEFINE_SPINLOCK(notify_lock);" nowadays?
That's not a problem, I will cook up a patch and send it through Greg.
Thank you.
> --
> Dmitry
, uint, 0);
> module_param(cn_val, uint, 0);
>
> -spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
> +static spinlock_t notify_lock = SPIN_LOCK_UNLOCKED;
> static LIST_HEAD(notify_list);
>
> static struct cn_dev cdev;
--
Evgeniy Polyakov
Crash is better than data corru
On Wed, 26 Jan 2005 15:22:52 -0500
Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> On Wed, 26 Jan 2005 23:07:12 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> >
> > Chip driver provides access methods to the attached logical devices.
> > It probes and a
On Thu, 27 Jan 2005 10:19:51 -0500
Bill Davidsen <[EMAIL PROTECTED]> wrote:
> Evgeniy Polyakov wrote:
> > On Mon, 24 Jan 2005 18:54:49 +0100
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
> >
> >>It seems noone who reviewed the SuperIO patches not
On Thu, 2005-01-27 at 11:20 +0100, Adrian Bunk wrote:
> On Wed, Jan 26, 2005 at 10:27:43PM +0300, Evgeniy Polyakov wrote:
> >...
> > I greatly appreciate your comments, and they were addressed.
> > Part of exported symbols are unexported, patch is just waiting to be sent,
&
On Wed, 2005-01-26 at 11:55 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 19:46:14 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Wed, 2005-01-26 at 11:25 -0500, Dmitry Torokhov wrote:
> > > On Wed, 26 Jan 2005 18:54:08 +0300, Evgeniy Polyakov
>
On Wed, 26 Jan 2005 19:19:41 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Wed, Jan 26, 2005 at 07:38:48PM +0300, Evgeniy Polyakov wrote:
> >...
> > Btw, where was comments about w1, kernel connector and acrypto?
> > They were presented several times in lkml
not superio logical device but is fitted design quite well), for such
cases there is also infrastructure in superio driver. For example scx.c -
it has it's own private GPIO logical device, which is "cloned" from the
"standard"(described in sc_gpio.c) logical device(clones act
e other is PCI-based. psmouse would not care less which one is
> behind the port it is bound to.
Chip driver provides access methods to the attached logical devices.
It probes and activates them, if appropriate module is loaded.
Your example again is not suitable for superio case.
With superio
On Wed, 2005-01-26 at 11:25 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 18:54:08 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Wed, 2005-01-26 at 10:26 -0500, Dmitry Torokhov wrote:
> > > On Wed, 26 Jan 2005 17:59:07 +0300, Evgeniy Polyakov
>
On Wed, 2005-01-26 at 09:00 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 13:59:17 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Wed, 2005-01-26 at 10:14 +, Christoph Hellwig wrote:
> > > On Wed, Jan 26, 2005 at 01:35:56AM +0300, Evgeniy Polyako
still
> do not agree.
>
> Don't get me wrong, I am not saying that I don't want your code in the
> kernel. I am actually interested in it (the base superio part, in fact).
> All I am asking for is that you put some efforts in presenting your code
> correctly, splitting i
On Wed, 2005-01-26 at 10:26 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 17:59:07 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
>
> > Each superio chip has the same logical devices inside.
> > With your approach we will have following schema:
> >
On Wed, 2005-01-26 at 08:46 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 11:25:02 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Tue, 2005-01-25 at 23:57 -0500, Dmitry Torokhov wrote:
> >
> > > > > I have a slightly different co
On Wed, 2005-01-26 at 08:32 -0500, Dmitry Torokhov wrote:
> On Wed, 26 Jan 2005 11:31:07 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Tue, 2005-01-25 at 22:42 +, Christoph Hellwig wrote:
> > > > Yes, and it is better than removing modu
On Wed, 2005-01-26 at 10:14 +, Christoph Hellwig wrote:
> On Wed, Jan 26, 2005 at 01:35:56AM +0300, Evgeniy Polyakov wrote:
> > I have one rule - if noone answers that it means noone objects,
> > or it is not interesting for anyone, and thus noone objects.
>
> That
uperio chips are only a new way to access the subdevices. What
> we need for them is an extension of the request_region/release_region
> mechanism, because superios introduce a two-level addressing scheme. And
> this is about it.
And that will end up having tons of duplicated code in eac
which is
very good, I doubt each block device module increment it's module
reference
when it catch a request...
It is internal structure that has reference counter, not module itself,
and this
structure may be in use, when module is unloaded, thus unloading must
wait,
untill all it's structures are freed.
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
4.0/sio2
> | | | |-acb
> | | | | |-sio0 ->
> ../../../../devices/pci:00/:00:1e.0/:02:03.0/sio0
> |
> |-class
> | |-gpio
> | | |-gpio0
> | | |-gpio1
>
> gpioX have control and data attributes that allow reading and writing...
>
> Am I missing somet
ce you implemented it as part of i2c core,
that is why I created parts that was not touched by your driver.
Since GPIO can be used with w1 it had greater priority.
Your driver is part of i2c core, it just not supposed to be used
in superio, although many hardware routings could be used.
I wil
n the sensor chip drivers I mentioned above,
> and that's about it. I am not familiar enough with kernel core
> architectures to decide whether Evgeniy's approach is correct or not. I
> am willing to help, but I can do so only within my own current skills.
I always appreciate your com
On Tue, 25 Jan 2005 19:21:10 +0100
J_rn Engel <[EMAIL PROTECTED]> wrote:
> On Tue, 25 January 2005 19:04:47 +0300, Evgeniy Polyakov wrote:
> > On Tue, 2005-01-25 at 16:34 +0100, Bartlomiej Zolnierkiewicz wrote:
> >
> > > Ugh, now think about that:
> >
On Tue, 25 Jan 2005 11:11:42 -0500
Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> On Tue, 25 Jan 2005 18:24:50 +0300, Evgeniy Polyakov
> <[EMAIL PROTECTED]> wrote:
> > On Tue, 2005-01-25 at 14:23 +, Christoph Hellwig wrote:
> > > &
On Tue, 25 Jan 2005 15:36:57 +
Paulo Marques <[EMAIL PROTECTED]> wrote:
> Evgeniy Polyakov wrote:
> > [...]
> > No, it is not called lock order reversal.
> >
> > There are no places like
> > lock a
> > lock b
> > unlock a
> > unlock b
other places they should go through the same lock(sdev or chain):
like
lock sdev_lock
lock chain
unclok chain
lock logic
unlock logic
unlock sdev_lock
lock sdev_lock
lock logic
unlock logic
lock chain
unclok chain
unlock sdev_lock
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
> big warning sign.
No, it is not called lock order reversal.
There are no places like
lock a
lock b
unlock a
unlock b
and if they are, then I'm completely wrong.
What you see is only following:
place 1:
lock a
lock b
unlock b
lock c
unlock c
unlock a
place 2:
lock b
lock a
unlock a
lock c
unlock c
unlock b
It is done since manipulation with the chain pointer can be done from
logical device structure and from superio chip structure, and this
operations are absolutely the same in nature.
> > Resume:
> > Cristoph, you rudely try to show that this code is badly broken.
> > It is not.
> > It was tested as opposed to your claims, and works as expected.
>
> I've seen tons of code that "works as expected" but still is buggy.
> That's why code needs to be both tested (with a workload as
> expected and other stress testing that shows it handles loads _not_
> expected) and reviewed for errors that don't happen with a normal
> load or design problems.
Yes, you are right, of course.
That is why we write code, test and discuss(but not knock against each
other) it.
I will send patch to address your comments soon, thank you.
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
w easy control.
It is not directory like char/.
> diff -Nru a/drivers/superio/chain.c b/drivers/superio/chain.c
> --- /dev/null Wed Dec 31 16:00:00 196900
> +++ b/drivers/superio/chain.c 2005-01-23 22:34:15 -08:00
> @@ -0,0 +1,52 @@
> +/*
> + * chain.c
>
> superfluos,
eady sent to Greg, it will be included in next release.
Attached one with fixed scx200/scx filename.
> Thanks,
> Nish
Evgeniy Polyakov
Only failure makes us experts. -- Theo de Raadt
msleep_superio.patch
Description: Binary data
gt;
> Did anyone review them?
As I said it is completely my fault, I pressed on Greg,
since patch several month laid after testing and people often asked
about GPIO in various SuperIO chips.
Patches were sent into lm_sensors@ mail list some time ago
and code itself did not meet any object
Change scx200 module name to scx.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
--- linux-2.6/drivers/superio/scx.c 1970-01-01 03:00:00.0 +0300
+++ linux-2.6/drivers/superio/scx.c 2005-01-24 22:06:15.0 +0300
@@ -0,0 +1,413 @@
+/*
+ * scx.c
+ *
+
name, but different
elf sections in it, it is of course different things, but they do have the same
roots in common.
As I have beed told in private,
"what is technically possible, is not necessarily practically useful.", probably
it is the essence.
Thank you for discussion.
> --
> Dmi
On Mon, 24 Jan 2005 20:03:20 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 24, 2005 at 10:19:29PM +0300, Evgeniy Polyakov wrote:
> > On Mon, 24 Jan 2005 19:29:26 +0100
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
> > > On Mon, Jan 24,
On Mon, 24 Jan 2005 20:05:46 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 24, 2005 at 10:23:02PM +0300, Evgeniy Polyakov wrote:
> > On Mon, 24 Jan 2005 19:41:11 +0100
> > Jurriaan <[EMAIL PROTECTED]> wrote:
> >
> > > From: Evgeniy Polyako
On Mon, 24 Jan 2005 19:41:11 +0100
Jurriaan <[EMAIL PROTECTED]> wrote:
> From: Evgeniy Polyakov <[EMAIL PROTECTED]>
> Date: Mon, Jan 24, 2005 at 09:43:36PM +0300
> > On Mon, 24 Jan 2005 18:54:49 +0100
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
>
On Mon, 24 Jan 2005 19:29:26 +0100
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 24, 2005 at 09:43:36PM +0300, Evgeniy Polyakov wrote:
> > On Mon, 24 Jan 2005 18:54:49 +0100
> > Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
> > > It seems noone who
for many days.
>"Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
Evgeniy Polyakov
Only failure makes us experts. -- Theo de Raadt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
Remove unneded exports and make some functions static.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
diff -ru linux-2.6/drivers/superio.orig/sc_acb.c
linux-2.6/drivers/superio/sc_acb.c
--- linux-2.6/drivers/superio.orig/sc_acb.c 2005-01-24
17:07:28.295779728 +0300
+++ linux-2.6/d
On Mon, 2005-01-24 at 16:04 +0300, Evgeniy Polyakov wrote:
> On Mon, 2005-01-24 at 12:34 +, Christoph Hellwig wrote:
> > On Mon, Jan 24, 2005 at 01:25:41PM +0100, Adrian Bunk wrote:
> > > On Mon, Jan 24, 2005 at 02:15:16AM -0800, Andrew Morton wrote:
> > > >...
&g
That code was written by me.
Please provide full error output, since it is compiled successfully
here.
Thank you.
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
signature.asc
Description: This is a digitally signed message part
On Wed, 2005-01-19 at 15:05 -0800, Greg KH wrote:
> On Thu, Jan 13, 2005 at 01:15:19AM +0300, Evgeniy Polyakov wrote:
> > --- include/linux/connector.h~ 2005-01-13 00:21:55.0 +0300
> > +++ include/linux/connector.h 2005-01-13 00:53:21.0 +0300
>
801 - 885 of 885 matches
Mail list logo