Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Ewan Milne
On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote: > On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > >>> vports = lpfc_create_vport_work_array(phba); > >>> - if (vports != NULL) > >>> + if (vports != NULL) { > >>>

Re: [PATCH] snic: correctly check for array overrun on overly long version number

2016-03-01 Thread Ewan Milne
On Thu, 2016-02-25 at 22:58 +, Colin King wrote: > From: Colin Ian King > > The snic version number is expected to be 4 decimals in the form like > a netmask string with each number stored in an element in array v. > However, there is an off-by-one check on the number of elements in v > allow

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-18 Thread Ewan Milne
On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: > It also appears to me upon further inspection that the existing code has > other problems. In particular, once mpt_mapresources() has returned > with a nonzero error code, it looks like iounmap() should be called, but > it is not

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-18 Thread Ewan Milne
On Thu, 2016-02-18 at 10:00 +0100, Johannes Thumshirn wrote: > On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote: > > the failure of ioc->reset_work_q is checked, > > but not ioc->fw_event_q. > > > > Signed-off-by: Insu Yun > > --- > > drivers/message/fusion/mptbase.c | 44 > > ++

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

2016-02-16 Thread Ewan Milne
On Tue, 2016-02-16 at 13:33 -0500, Insu Yun wrote: > > > On Tue, Feb 16, 2016 at 1:18 PM, Ewan Milne wrote: > On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: > > the failure of ioc->reset_work_q is checked, > > but not ioc->fw_event_q.

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

2016-02-16 Thread Ewan Milne
On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: > the failure of ioc->reset_work_q is checked, > but not ioc->fw_event_q. > > Signed-off-by: Insu Yun > --- > drivers/message/fusion/mptbase.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/message/fusion/mptbase.c > b

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-14 Thread Ewan Milne
On Sun, 2015-12-13 at 11:16 -0800, Lee Duncan wrote: > On 12/11/2015 07:31 AM, Ewan Milne wrote: > > On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: > >> On 11/17/2015 03:20 PM, Martin K. Petersen wrote: > >>>>>>>> "Lee" == Lee Duncan wr

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-11 Thread Ewan Milne
On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: > On 11/17/2015 03:20 PM, Martin K. Petersen wrote: > >> "Lee" == Lee Duncan writes: > > > > Lee> Martin: I will be glad to update the patch, creating a modprobe > > Lee> parameter as suggested, if you find this acceptable. > > > > For dev

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-04 Thread Ewan Milne
On Fri, 2015-12-04 at 11:16 -0800, James Bottomley wrote: > On Fri, 2015-12-04 at 11:58 -0500, Ewan Milne wrote: > > On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > > > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > > > sg_map -i &

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-04 Thread Ewan Milne
On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > sg_map -i > > > > in your system, you should see something with an inquiry string like > > enclosure. It's the /dev/sg of that you need to run sg_ses on. > > root@glen:

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-20 Thread Ewan Milne
On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: > Can't we have a joint effort here? > I've been spending a _LOT_ of time trying to debug things here, but > none of the ideas I've come up with have been able to fix anything. Yes. I'm not the one primarily looking at it, and we don't hav

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-20 Thread Ewan Milne
On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote: > On 11/19/2015 09:23 AM, Christoph Hellwig wrote: > > It's pretty much guaranteed a block layer bug, most likely in the > > merge bios to request infrastucture where we don't obey the merging > > limits properly. > > > > Does either of you

Re: [PATCH] [SCSI] st: Remove obsolete scsi_tape.max_pfn

2015-11-17 Thread Ewan Milne
On Sun, 2015-11-15 at 12:48 +0100, Geert Uytterhoeven wrote: > Its last user was removed 10 years ago, in commit > 8b05b773b6030de5 ("[SCSI] convert st to use scsi_execute_async"). > > Signed-off-by: Geert Uytterhoeven > --- > drivers/scsi/st.h | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

2015-10-27 Thread Ewan Milne
On Mon, 2015-10-26 at 15:54 +0100, Peter Oberparleiter wrote: > Writing a number to /sys/bus/scsi/devices//queue_ramp_up_period > returns the value of that number instead of the number of bytes written. > This behavior can confuse programs expecting POSIX write() semantics. > Fix this by returning

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread Ewan Milne
On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > Removing a SCSI target via scsi_remove_target() suspected to be racy. When a > > sibling get's removed from the list it can occassionly happen that one CPU > > is > > stuck

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-08-27 Thread Ewan Milne
On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote: > On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote: > > > > > > + /* this should never happen */ > > > > + if (WARN_ON(!cmnd)) > > > > + return SCSI_MLQUEUE_HOST_BUSY; > > > > > > > > - if (NULL == cmn

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-08-25 Thread Ewan Milne
On Tue, 2015-07-28 at 16:54 +0300, Tomas Winkler wrote: > The function should never be called with cmnd NULL so > put a fat WARN there. > Fix also smatch wraning: > schedule_resp() warn: variable dereferenced before check 'cmnd' > > Cc: Douglas Gilbert > Signed-off-by: Tomas Winkler > Acked-by:

Re: [PATCH] scsi: fix memory leak with scsi-mq

2015-07-27 Thread Ewan Milne
On Thu, 2015-07-16 at 11:40 -0400, Tony Battersby wrote: > Fix a memory leak with scsi-mq triggered by commands with large data > transfer length. > > __sg_alloc_table() sets both table->nents and table->orig_nents to the > same value. When the scatterlist is DMA-mapped, table->nents is > overwri

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-08-29 Thread Ewan Milne
On Thu, 2014-08-28 at 21:42 -0500, Mike Christie wrote: > On 08/27/2014 09:31 AM, Hannes Reinecke wrote: > > On 08/19/2014 07:54 PM, Christoph Hellwig wrote: > >> On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote: > >>> The host asks the guest to scan when a LUN is removed or added.

Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: > sd_print_sense_hdr() calls scsi_show_extd_sense(), > but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). > We can get same result, so we delete it. > > Note: > Calling scsi_show_extd_sense() is introduced in fdd8b297. > > Sig

Re: [RFC PATCH 05/10] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: > For getting driver byte, host byte, msg byte, and status byte, macros are > implemented in scsi/scsi.h, so we use it. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbert > Cc: Martin K. Petersen > Cc: Chris

Re: [RFC PATCH 04/10] scsi/constants: Cleanup printk message in scsi_dump_sense_buffer()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: > Unrecognized sense data should be output after linebuf is filled because > "[%s] Unrecognized sense data (in hex): %s" message is output many times in > loop. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbe

Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

2014-08-15 Thread Ewan Milne
On Fri, 2014-08-08 at 11:50 +, Yoshihiro YUNOMAE wrote: > All bytes in CDB should be output after linebuf is filled because > "[%s] CDB: %s\n" message is output many times in loop. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbert > Cc: Martin K. Petersen > Cc:

Re: [PATCH] sd: bad return code of init_sd

2014-06-04 Thread Ewan Milne
On Tue, 2014-06-03 at 23:34 +0200, Clément Calmels wrote: > In init_sd function, if kmem_cache_create or mempool_create_slab_pools > calls fail, the error will not be correclty reported because > class_register previously set the value of err to 0. > > Signed-off-by: Clément Calmels > --- > driv

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Ewan Milne
On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: > On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger > wrote: > > > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > Ideally, I want this to be adjustable like the way we can change the I/O > > > timeout. > > > Since that h

Re: [patch] block: fix race between request completion and timeout handling

2013-09-10 Thread Ewan Milne
On Thu, 2013-08-29 at 15:14 -0400, Jeff Moyer wrote: ... > RIP: 0010:[] [] > blk_requeue_request+0x94/0xa0 ... > Call Trace: > [] __scsi_queue_insert+0xa3/0x150 > [] ? scsi_eh_ready_devs+0x5e3/0x850 > [] scsi_queue_insert+0x13/0x20 > [] scsi_eh_flush_done_q+0x104/0x160 > [] scsi_error_handle

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-23 Thread Ewan Milne
On Fri, 2013-08-23 at 06:19 -0700, James Bottomley wrote: > On Fri, 2013-08-23 at 18:10 +0900, Eiichi Tsukata wrote: > > Yes, basically the device should be offlined on error detection. > > Just offlining the disk is enough when an error occurs on "not" os-installed > > system disk. Panic is going

Re: [RFC PATCH] scsi: Add failfast mode to avoid infinite retry loop

2013-08-20 Thread Ewan Milne
On Tue, 2013-08-20 at 16:13 +0900, Eiichi Tsukata wrote: > (2013/08/19 23:30), James Bottomley wrote: > > On Mon, 2013-08-19 at 18:39 +0900, Eiichi Tsukata wrote: > >> Hello, > >> > >> This patch adds scsi device failfast mode to avoid infinite retry loop. > >> > >> Currently, scsi error handling i