[PATCH 1/1 linux-next] udf: remove bool assignment to 0/1

2015-02-04 Thread Fabian Frederick
Fix the following coccinelle warnings: fs/udf/inode.c:753:2-13: WARNING: Assignment of bool to 0/1 fs/udf/inode.c:795:2-13: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick --- fs/udf/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/udf

[PATCH 1/1 linux-next] udf: use bool for done

2015-02-04 Thread Fabian Frederick
variable 'done' is only used for true/false in loop. Signed-off-by: Fabian Frederick --- fs/udf/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index 3d35a75..f169411 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1599,7

[PATCH 1/1 linux-next] udf: use bool for done

2015-02-04 Thread Fabian Frederick
variable 'done' is only used for true/false in loop. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/udf/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index 3d35a75..f169411 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c

[PATCH 1/1 linux-next] udf: remove bool assignment to 0/1

2015-02-04 Thread Fabian Frederick
Fix the following coccinelle warnings: fs/udf/inode.c:753:2-13: WARNING: Assignment of bool to 0/1 fs/udf/inode.c:795:2-13: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick f...@skynet.be --- fs/udf/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/1 linux-next] ocfs2: make resv_lock spinlock static

2015-02-04 Thread Fabian Frederick
resv_lock is only used in reservations.c Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ocfs2/reservations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/reservations.c b/fs/ocfs2/reservations.c index 41ffd36..6a348b0 100644 --- a/fs/ocfs2/reservations.c

[PATCH 1/1 linux-next] staging: lustre: make obd_updatemax_lock static

2015-02-04 Thread Fabian Frederick
obd_updatemax_lock is only used in class_obd.c Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre

[PATCH 1/1 linux-next] scsi: make bnx2fc_global_lock spinlock static

2015-02-04 Thread Fabian Frederick
bnx2fc_global_lock is only used in bnx2fc_fcoe.c Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 98d06d1..66fb527

[PATCH 5/6 linux-next] fs/affs/inode.c: remove double extern affs_symlink_inode_operations

2015-02-03 Thread Fabian Frederick
affs_symlink_inode_operations was already declared extern in affs.h Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 25cb4b4..6f34510 100644 --- a/fs/affs/inode.c +++ b/fs/affs

[PATCH 4/6 linux-next] fs/affs/bitmap.c: remove unnecessary return

2015-02-03 Thread Fabian Frederick
return is not needed at the end of function. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c index c8de511..6751489 100644 --- a/fs/affs/bitmap.c +++ b/fs/affs/bitmap.c @@ -99,7 +99,6

[PATCH 6/6 linux-next] fs/affs/super.c: fix switch indentation

2015-02-03 Thread Fabian Frederick
Fix checkpatch error: "ERROR: switch and case should be at the same indent" Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/super.c | 66 - 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/fs/affs/su

[PATCH 2/6 linux-next] FS/AFFS: define AFFSNAMEMAX to replace constant use

2015-02-03 Thread Fabian Frederick
30 was used all over the place to compare name length against AFFS maximum name length. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 2 ++ fs/affs/amigaffs.c | 6 +++--- fs/affs/dir.c | 3 ++- fs/affs/namei.c| 16 fs/affs/super.c

[PATCH 3/6 linux-next] fs/affs/amigaffs.c: remove else after return

2015-02-03 Thread Fabian Frederick
else is unnecessary after return -ENAMETOOLONG Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/amigaffs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 581a2fb..029e23a 100644 --- a/fs/affs/amigaffs.c +++ b/fs

[PATCH 1/6 linux-next] FS/AFFS: replace min() with casting/constant suffix by min_t

2015-02-03 Thread Fabian Frederick
This patch prepares for AFFSNAMEMAX definition Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/amigaffs.c | 2 +- fs/affs/dir.c | 2 +- fs/affs/namei.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index

[PATCH 1/1 linux-next] fs/ufs/super.c: fix potential race condition

2015-02-03 Thread Fabian Frederick
ooked at (ufs_frag_map) does sb_bread() under lock_ufs(). And sb_bread() will call schedule(), very commonly. The ->mutex_owner stuff is a bit hacky but should work OK. " Cc: Evgeniy Dushistov Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/ufs/super.c | 4 1 file changed, 4 delet

[PATCH 1/1 linux-next] fs/ufs/super.c: fix potential race condition

2015-02-03 Thread Fabian Frederick
at (ufs_frag_map) does sb_bread() under lock_ufs(). And sb_bread() will call schedule(), very commonly. The -mutex_owner stuff is a bit hacky but should work OK. Cc: Evgeniy Dushistov dushis...@mail.ru Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ufs

[PATCH 2/6 linux-next] FS/AFFS: define AFFSNAMEMAX to replace constant use

2015-02-03 Thread Fabian Frederick
30 was used all over the place to compare name length against AFFS maximum name length. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/affs.h | 2 ++ fs/affs/amigaffs.c | 6 +++--- fs/affs/dir.c | 3 ++- fs/affs/namei.c| 16

[PATCH 6/6 linux-next] fs/affs/super.c: fix switch indentation

2015-02-03 Thread Fabian Frederick
Fix checkpatch error: ERROR: switch and case should be at the same indent Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/super.c | 66 - 1 file changed, 33 insertions(+), 33 deletions

[PATCH 4/6 linux-next] fs/affs/bitmap.c: remove unnecessary return

2015-02-03 Thread Fabian Frederick
return is not needed at the end of function. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c index c8de511..6751489 100644 --- a/fs/affs/bitmap.c

[PATCH 5/6 linux-next] fs/affs/inode.c: remove double extern affs_symlink_inode_operations

2015-02-03 Thread Fabian Frederick
affs_symlink_inode_operations was already declared extern in affs.h Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 25cb4b4..6f34510 100644

[PATCH 3/6 linux-next] fs/affs/amigaffs.c: remove else after return

2015-02-03 Thread Fabian Frederick
else is unnecessary after return -ENAMETOOLONG Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/amigaffs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 581a2fb..029e23a

[PATCH 1/6 linux-next] FS/AFFS: replace min() with casting/constant suffix by min_t

2015-02-03 Thread Fabian Frederick
This patch prepares for AFFSNAMEMAX definition Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/amigaffs.c | 2 +- fs/affs/dir.c | 2 +- fs/affs/namei.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/affs

[PATCH 1/1 linux-next] fs/ufs/super.c: remove CONFIG_SMP/CONFIG_PREEMPT testing

2015-02-01 Thread Fabian Frederick
Let locking subsystem decide on mutex management. Cc: Evgeniy Dushistov Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/ufs/super.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ufs/super.c b/fs/ufs/super.c index e515e99..8092d37 100644 --- a/fs/ufs/super.c +++ b/fs/ufs

[PATCH 1/1 linux-next] fs/ufs/super.c: remove CONFIG_SMP/CONFIG_PREEMPT testing

2015-02-01 Thread Fabian Frederick
Let locking subsystem decide on mutex management. Cc: Evgeniy Dushistov dushis...@mail.ru Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ufs/super.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ufs/super.c b/fs/ufs/super.c index

[PATCH 1/1 linux-next] task IO accounting: add conditional read/write counters

2015-01-30 Thread Fabian Frederick
This patch adds syscre and syscwe respectively effective read/write syscall counters. We already had syscr/syscw which were unconditionally incremented. Doing the difference between those variables could give interesting statistics. Signed-off-by: Fabian Frederick --- Documentation/filesystems

[PATCH 1/1 linux-next] task IO accounting: add conditional read/write counters

2015-01-30 Thread Fabian Frederick
This patch adds syscre and syscwe respectively effective read/write syscall counters. We already had syscr/syscw which were unconditionally incremented. Doing the difference between those variables could give interesting statistics. Signed-off-by: Fabian Frederick f...@skynet.be

[PATCH 1/1 linux-next] FS/AFFS: use inode writecount instead of local i_opencnt

2015-01-28 Thread Fabian Frederick
atomic_t i_opencnt was used to free allocation in case there were no more opens. This patch replaces affs_file_open by generic_file_open and uses FMODE_WRITE/i_writecount==1 for the task like other FS. Reviewed-by: Jan Kara Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/affs.h

[PATCH 1/1 linux-next] FS/AFFS: use inode writecount instead of local i_opencnt

2015-01-28 Thread Fabian Frederick
-by: Fabian Frederick f...@skynet.be --- fs/affs/affs.h | 1 - fs/affs/file.c | 17 - fs/affs/inode.c | 2 -- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index ff44ff3..c50815f 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h

[RFC 2/2] fs/affs/super.c: let vfs do mount_bdev

2015-01-19 Thread Fabian Frederick
share fill_super with vfs and remove local mount function. Signed-off-by: Fabian Frederick --- fs/affs/super.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/affs/super.c b/fs/affs/super.c index ee8eca7..9f7bba9 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c

[RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function.

2015-01-19 Thread Fabian Frederick
Currently, a lot of filesystem mounting functions feature in file_system_type only to be called from vfs mount_fs and call mount_bdev. This patch adds fill_super function to that structure and lets vfs call mount_bdev when no mount function is declared. Signed-off-by: Fabian Frederick --- fs

[RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function.

2015-01-19 Thread Fabian Frederick
Currently, a lot of filesystem mounting functions feature in file_system_type only to be called from vfs mount_fs and call mount_bdev. This patch adds fill_super function to that structure and lets vfs call mount_bdev when no mount function is declared. Signed-off-by: Fabian Frederick f

[RFC 2/2] fs/affs/super.c: let vfs do mount_bdev

2015-01-19 Thread Fabian Frederick
share fill_super with vfs and remove local mount function. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/super.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/affs/super.c b/fs/affs/super.c index ee8eca7..9f7bba9 100644 --- a/fs/affs/super.c +++ b/fs

[PATCH 1/1 linux-next] fs/affs/super.c: destroy sbi mutex in affs_kill_sb()

2015-01-13 Thread Fabian Frederick
Call mutex_destroy() on superblock mutex in affs_kill_sb() otherwise mutex debugging code isn't able to detect that mutex is used after being freed. (thanks to Jan Kara for complete definition). Cc: Jan Kara Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/super.c | 1 + 1 file

[PATCH V2 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-13 Thread Fabian Frederick
suitable_migration_target() is only used by isolate_freepages() Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. Fix the following warning: mm/compaction.c:311:13: warning: 'suitable_migration_target' defined but not used [-Wunused-function] Signed-off-by: Fabian Frederick --- v2

[PATCH 1/1 linux-next] fs/affs/super.c: destroy sbi mutex in affs_kill_sb()

2015-01-13 Thread Fabian Frederick
Call mutex_destroy() on superblock mutex in affs_kill_sb() otherwise mutex debugging code isn't able to detect that mutex is used after being freed. (thanks to Jan Kara for complete definition). Cc: Jan Kara j...@suse.cz Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick

[PATCH V2 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-13 Thread Fabian Frederick
suitable_migration_target() is only used by isolate_freepages() Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. Fix the following warning: mm/compaction.c:311:13: warning: 'suitable_migration_target' defined but not used [-Wunused-function] Signed-off-by: Fabian Frederick f

[PATCH 1/1 linux-next] udf: destroy sbi mutex in put_super

2015-01-10 Thread Fabian Frederick
Call mutex_destroy() on superblock mutex in udf_put_super() otherwise mutex debugging code isn't able to detect that mutex is used after being freed. (thanks to Jan Kara for complete definition). Signed-off-by: Fabian Frederick --- fs/udf/super.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/1 linux-next] tty: remove unused variable sprop

2015-01-10 Thread Fabian Frederick
sprop is unused in find_console_handle() since commit a752ee56ad84 ("tty: Update hypervisor tty drivers to use core stdout parsing code.") Signed-off-by: Fabian Frederick --- drivers/tty/ehv_bytechan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/ehv_bytechan.c b/d

[PATCH 1/1 linux-next] tty: remove unused variable sprop

2015-01-10 Thread Fabian Frederick
sprop is unused in find_console_handle() since commit a752ee56ad84 (tty: Update hypervisor tty drivers to use core stdout parsing code.) Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/tty/ehv_bytechan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/ehv_bytechan.c b

[PATCH 1/1 linux-next] udf: destroy sbi mutex in put_super

2015-01-10 Thread Fabian Frederick
Call mutex_destroy() on superblock mutex in udf_put_super() otherwise mutex debugging code isn't able to detect that mutex is used after being freed. (thanks to Jan Kara for complete definition). Signed-off-by: Fabian Frederick f...@skynet.be --- fs/udf/super.c | 1 + 1 file changed, 1 insertion

Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-09 Thread Fabian Frederick
> On 06 January 2015 at 18:21 Vlastimil Babka wrote: > > > On 01/03/2015 05:04 PM, Fabian Frederick wrote: > > suitable_migration_target() is only used by isolate_freepages() > > Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. > > > &g

[PATCH 1/1 linux-next] fs/affs/file.c: fix direct IO writes beyond EOF

2015-01-09 Thread Fabian Frederick
for helping me on this problem. Cc: Jan Kara Cc: Andrew Morton Signed-off-by: Fabian Frederick --- Ideal solution suggested by Jan Kara would be to use cont_write_begin but affs direct_IO shouldn't be used a lot anyway... fs/affs/file.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/affs

[PATCH 1/1 linux-next] fs/affs/file.c: fix direct IO writes beyond EOF

2015-01-09 Thread Fabian Frederick
for helping me on this problem. Cc: Jan Kara j...@suse.cz Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- Ideal solution suggested by Jan Kara would be to use cont_write_begin but affs direct_IO shouldn't be used a lot anyway... fs/affs/file.c | 7 +++ 1

Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-09 Thread Fabian Frederick
On 06 January 2015 at 18:21 Vlastimil Babka vba...@suse.cz wrote: On 01/03/2015 05:04 PM, Fabian Frederick wrote: suitable_migration_target() is only used by isolate_freepages() Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. Fix the following warning: mm

[PATCH 1/1 linux-next] ceph: use %zu for size_t display

2015-01-03 Thread Fabian Frederick
Fixes the following 32-bit compilation warning: fs/ceph/addr.c:1419:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat=] Signed-off-by: Fabian Frederick --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-03 Thread Fabian Frederick
suitable_migration_target() is only used by isolate_freepages() Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. Fix the following warning: mm/compaction.c:311:13: warning: 'suitable_migration_target' defined but not used [-Wunused-function] Signed-off-by: Fabian Frederick --- mm

[PATCH 1/1 linux-next] hp100: simplify hp100_module_init

2015-01-03 Thread Fabian Frederick
-Avoid double goto and directly return err where possible. -Remove unused labels which fixes: drivers/net/ethernet/hp/hp100.c:3047:2: warning: label 'out3' defined but not used [-Wunused-label] Signed-off-by: Fabian Frederick --- This is untested. drivers/net/ethernet/hp/hp100.c | 17

[PATCH 2/2 net-next] netfilter: remove 0 assignment on static

2015-01-03 Thread Fabian Frederick
static values are automatically initialized to 0 Signed-off-by: Fabian Frederick --- net/bridge/br_netfilter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index 37e7d9a..26d73fa 100644 --- a/net/bridge

[PATCH 1/2 net-next] netfilter: remove err1 label only used with CONFIG_SYSCTL

2015-01-03 Thread Fabian Frederick
This patch fixes the following warning: net/bridge/br_netfilter.c:995:1: warning: label ‘err1’ defined but not used [-Wunused-label] Signed-off-by: Fabian Frederick --- net/bridge/br_netfilter.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/bridge

[PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG_COMPACTION

2015-01-03 Thread Fabian Frederick
suitable_migration_target() is only used by isolate_freepages() Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed. Fix the following warning: mm/compaction.c:311:13: warning: 'suitable_migration_target' defined but not used [-Wunused-function] Signed-off-by: Fabian Frederick f

[PATCH 1/1 linux-next] ceph: use %zu for size_t display

2015-01-03 Thread Fabian Frederick
Fixes the following 32-bit compilation warning: fs/ceph/addr.c:1419:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat=] Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2 net-next] netfilter: remove err1 label only used with CONFIG_SYSCTL

2015-01-03 Thread Fabian Frederick
This patch fixes the following warning: net/bridge/br_netfilter.c:995:1: warning: label ‘err1’ defined but not used [-Wunused-label] Signed-off-by: Fabian Frederick f...@skynet.be --- net/bridge/br_netfilter.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/bridge

[PATCH 2/2 net-next] netfilter: remove 0 assignment on static

2015-01-03 Thread Fabian Frederick
static values are automatically initialized to 0 Signed-off-by: Fabian Frederick f...@skynet.be --- net/bridge/br_netfilter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index 37e7d9a..26d73fa 100644 --- a/net

[PATCH 1/1 linux-next] hp100: simplify hp100_module_init

2015-01-03 Thread Fabian Frederick
-Avoid double goto and directly return err where possible. -Remove unused labels which fixes: drivers/net/ethernet/hp/hp100.c:3047:2: warning: label 'out3' defined but not used [-Wunused-label] Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. drivers/net/ethernet/hp/hp100.c

Re: [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

2014-12-31 Thread Fabian Frederick
> On 28 December 2014 at 19:21 Al Viro wrote: > > > On Sun, Dec 28, 2014 at 08:45:44AM -0800, Joe Perches wrote: > > On Sun, 2014-12-28 at 15:33 +, Al Viro wrote: > > > On Sun, Dec 28, 2014 at 04:28:29PM +0100, Fabian Frederick wrote: > > > > Fix the f

Re: [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

2014-12-31 Thread Fabian Frederick
On 28 December 2014 at 19:21 Al Viro v...@zeniv.linux.org.uk wrote: On Sun, Dec 28, 2014 at 08:45:44AM -0800, Joe Perches wrote: On Sun, 2014-12-28 at 15:33 +, Al Viro wrote: On Sun, Dec 28, 2014 at 04:28:29PM +0100, Fabian Frederick wrote: Fix the following coccinelle warning

Re: [PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

2014-12-30 Thread Fabian Frederick
> On 30 December 2014 at 00:42 Laurent Pinchart > wrote: > > > Hi Fabian, > > Thank you for the patch. > > On Monday 29 December 2014 15:29:43 Fabian Frederick wrote: > > Based on versioncheck. > > > > Signed-off-by: Fabian Frederick > > Acke

Re: [PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

2014-12-30 Thread Fabian Frederick
On 30 December 2014 at 00:42 Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Fabian, Thank you for the patch. On Monday 29 December 2014 15:29:43 Fabian Frederick wrote: Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be Acked-by: Laurent Pinchart

[PATCH 11/11 linux-next] s390/hmcdrv: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/s390/char/hmcdrv_mod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/char/hmcdrv_mod.c b/drivers/s390/char/hmcdrv_mod.c index 505c6a7..251a318 100644 --- a/drivers/s390/char/hmcdrv_mod.c +++ b/drivers/s390/char

[PATCH 10/11 linux-next] GenWQE: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/misc/genwqe/card_base.h | 1 - drivers/misc/genwqe/card_sysfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/misc/genwqe/card_base.h b/drivers/misc/genwqe/card_base.h index c64d7ca..e735344 100644 --- a/drivers

[PATCH 01/11 linux-next] rsxx: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/block/rsxx/rsxx_priv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rsxx/rsxx_priv.h b/drivers/block/rsxx/rsxx_priv.h index 6bbc64d..21adc25 100644 --- a/drivers/block/rsxx/rsxx_priv.h +++ b/drivers/block

[PATCH 06/11 linux-next] [media] s5p-g2d: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/media/platform/s5p-g2d/g2d.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c index 47ba8fb..ec3e124 100644 --- a/drivers/media/platform/s5p-g2d

[PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/media/usb/uvc/uvc_v4l2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 9c5cbcf..43e953f 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers

[PATCH 03/11 linux-next] ipmi: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/char/ipmi/ipmi_ssif.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index fd5a5e8..120ed8d 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi

[PATCH 08/11 linux-next] [media] vivid: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/media/platform/vivid/vivid-tpg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/vivid/vivid-tpg.h b/drivers/media/platform/vivid/vivid-tpg.h index 9dc463a4..bd8b1c7 100644 --- a/drivers/media/platform

[PATCH 04/11 linux-next] input: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/input/touchscreen/elants_i2c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index a510f7e..926c58e 100644 --- a/drivers/input/touchscreen

[PATCH 07/11 linux-next] [media] s5p-mfc: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 1 - drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc

[PATCH 05/11 linux-next] [media] tw68: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/media/pci/tw68/tw68.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/tw68/tw68.h b/drivers/media/pci/tw68/tw68.h index 7a7501b..93f2335 100644 --- a/drivers/media/pci/tw68/tw68.h +++ b/drivers/media/pci

[PATCH 02/11 linux-next] skd: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick --- drivers/block/skd_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 1e46eb2..542353a 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -34,7 +34,6

[PATCH 00/11 linux-next] drivers: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
This small patchset removes unnecessary version.h includes detected by versioncheck in drivers branch. Fabian Frederick (11): rsxx: remove unnecessary version.h inclusion skd: remove unnecessary version.h inclusion ipmi: remove unnecessary version.h inclusion input: remove unnecessary

[PATCH 1/1 RESEND] ptrace: remove linux/compat.h inclusion under CONFIG_COMPAT

2014-12-29 Thread Fabian Frederick
Commit 84c751bd4aeb ("ptrace: add ability to retrieve signals without removing from a queue (v4)") includes globally in ptrace.c This patch removes inclusion under if defined CONFIG_COMPAT. Signed-off-by: Fabian Frederick --- kernel/ptrace.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 1/1 RESEND] ptrace: remove linux/compat.h inclusion under CONFIG_COMPAT

2014-12-29 Thread Fabian Frederick
Commit 84c751bd4aeb (ptrace: add ability to retrieve signals without removing from a queue (v4)) includes linux/compat.h globally in ptrace.c This patch removes inclusion under if defined CONFIG_COMPAT. Signed-off-by: Fabian Frederick f...@skynet.be --- kernel/ptrace.c | 1 - 1 file changed, 1

[PATCH 00/11 linux-next] drivers: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
This small patchset removes unnecessary version.h includes detected by versioncheck in drivers branch. Fabian Frederick (11): rsxx: remove unnecessary version.h inclusion skd: remove unnecessary version.h inclusion ipmi: remove unnecessary version.h inclusion input: remove unnecessary

[PATCH 02/11 linux-next] skd: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/block/skd_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 1e46eb2..542353a 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c

[PATCH 07/11 linux-next] [media] s5p-mfc: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 1 - drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform

[PATCH 05/11 linux-next] [media] tw68: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/pci/tw68/tw68.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/tw68/tw68.h b/drivers/media/pci/tw68/tw68.h index 7a7501b..93f2335 100644 --- a/drivers/media/pci/tw68/tw68.h +++ b/drivers

[PATCH 03/11 linux-next] ipmi: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/char/ipmi/ipmi_ssif.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index fd5a5e8..120ed8d 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers

[PATCH 08/11 linux-next] [media] vivid: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/platform/vivid/vivid-tpg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/vivid/vivid-tpg.h b/drivers/media/platform/vivid/vivid-tpg.h index 9dc463a4..bd8b1c7 100644 --- a/drivers

[PATCH 04/11 linux-next] input: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/input/touchscreen/elants_i2c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index a510f7e..926c58e 100644 --- a/drivers/input

[PATCH 06/11 linux-next] [media] s5p-g2d: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/platform/s5p-g2d/g2d.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d/g2d.c index 47ba8fb..ec3e124 100644 --- a/drivers/media

[PATCH 09/11 linux-next] [media] uvcvideo: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/usb/uvc/uvc_v4l2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 9c5cbcf..43e953f 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c

[PATCH 10/11 linux-next] GenWQE: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/misc/genwqe/card_base.h | 1 - drivers/misc/genwqe/card_sysfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/misc/genwqe/card_base.h b/drivers/misc/genwqe/card_base.h index c64d7ca..e735344 100644

[PATCH 01/11 linux-next] rsxx: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/block/rsxx/rsxx_priv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rsxx/rsxx_priv.h b/drivers/block/rsxx/rsxx_priv.h index 6bbc64d..21adc25 100644 --- a/drivers/block/rsxx/rsxx_priv.h +++ b

[PATCH 11/11 linux-next] s390/hmcdrv: remove unnecessary version.h inclusion

2014-12-29 Thread Fabian Frederick
Based on versioncheck. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/s390/char/hmcdrv_mod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/char/hmcdrv_mod.c b/drivers/s390/char/hmcdrv_mod.c index 505c6a7..251a318 100644 --- a/drivers/s390/char/hmcdrv_mod.c +++ b

[PATCH V2 linux-next] fs/ufs/super.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
Fix the following coccinelle warning: fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory allocation function to (struct ufs_inode_info *) is useless. Cc: Evgeniy Dushistov Cc: Andrew Morton Cc: Joe Perches Signed-off-by: Fabian Frederick --- V2: separate declaration from

[PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
Fix the following coccinelle warning: fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory allocation function to (struct ufs_inode_info *) is useless. Cc: Evgeniy Dushistov Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/ufs/super.c | 4 ++-- 1 file changed, 2

[PATCH 1/1] fs/befs/linuxvfs.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
Fix the following coccinelle warning: fs/befs/linuxvfs.c:278:14-36: WARNING: casting value returned by memory allocation function to (struct befs_inode_info *) is useless. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/befs/linuxvfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 1/1 linux-next] fs/affs/file.c: replace if/BUG by BUG_ON

2014-12-28 Thread Fabian Frederick
Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 8faa659..e1b51e5 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -180,8 +180,7 @@ affs_get_extblock_slow

[PATCH 1/1 linux-next] fs/affs/file.c: replace if/BUG by BUG_ON

2014-12-28 Thread Fabian Frederick
Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 8faa659..e1b51e5 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -180,8

[PATCH 1/1] fs/befs/linuxvfs.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
Fix the following coccinelle warning: fs/befs/linuxvfs.c:278:14-36: WARNING: casting value returned by memory allocation function to (struct befs_inode_info *) is useless. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/befs/linuxvfs.c | 5

[PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
Fix the following coccinelle warning: fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory allocation function to (struct ufs_inode_info *) is useless. Cc: Evgeniy Dushistov dushis...@mail.ru Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be

[PATCH V2 linux-next] fs/ufs/super.c: remove unnecessary casting

2014-12-28 Thread Fabian Frederick
-by: Fabian Frederick f...@skynet.be --- V2: separate declaration from allocation (suggested by Joe Perches) fs/ufs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ufs/super.c b/fs/ufs/super.c index da73801..e515e99 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c

[PATCH 1/1 linux-next] fs/coda/dir.c: forward declaration clean-up

2014-12-27 Thread Fabian Frederick
uld be on the previous line +const struct dentry_operations coda_dentry_operations = +{ ERROR: that open brace { should be on the previous line +const struct inode_operations coda_dir_inode_operations = +{ Cc: Jan Harkes Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/coda/dir.c |

[PATCH 1/1 linux-next] logfs: kernel-doc warning fix

2014-12-27 Thread Fabian Frederick
logfs_segment_read() receives a page not a buffer. Signed-off-by: Fabian Frederick --- fs/logfs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c index 7f9b096..b2dddce 100644 --- a/fs/logfs/segment.c +++ b/fs/logfs/segment.c

[PATCH 1/1 linux-next] drm/gma500: replace 0 by NULL for pointer

2014-12-27 Thread Fabian Frederick
Fix sparse warning: drivers/gpu/drm/gma500/psb_drv.c: 328:56: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm

[PATCH 1/1 linux-next] drm/nouveau/disp: replace 0x0000 by NULL for pointer

2014-12-27 Thread Fabian Frederick
Fix sparse warning: drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c: 815:32: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick --- drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 1/1 linux-next] ext3: destroy sbi mutexes in put_super

2014-12-27 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- This is untested. fs/ext3/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 9b4e7d7..d4dbf3c 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -466,6 +466,8 @@ static void ext3_put_super (struct

[PATCH 1/1 linux-next] ext3: destroy sbi mutexes in put_super

2014-12-27 Thread Fabian Frederick
Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. fs/ext3/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 9b4e7d7..d4dbf3c 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -466,6 +466,8 @@ static void ext3_put_super

[PATCH 1/1 linux-next] drm/nouveau/disp: replace 0x0000 by NULL for pointer

2014-12-27 Thread Fabian Frederick
Fix sparse warning: drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c: 815:32: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/1 linux-next] drm/gma500: replace 0 by NULL for pointer

2014-12-27 Thread Fabian Frederick
Fix sparse warning: drivers/gpu/drm/gma500/psb_drv.c: 328:56: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b

[PATCH 1/1 linux-next] logfs: kernel-doc warning fix

2014-12-27 Thread Fabian Frederick
logfs_segment_read() receives a page not a buffer. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/logfs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c index 7f9b096..b2dddce 100644 --- a/fs/logfs/segment.c +++ b/fs

<    7   8   9   10   11   12   13   14   15   16   >