[PATCH 1/1 linux-next] fs/coda/dir.c: forward declaration clean-up

be on the previous line +const struct dentry_operations coda_dentry_operations = +{ ERROR: that open brace { should be on the previous line +const struct inode_operations coda_dir_inode_operations = +{ Cc: Jan Harkes jahar...@cs.cmu.edu Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian

[PATCH 1/1 net-next] tipc: replace 0 by NULL for pointers

Fix sparse warning: net/tipc/link.c:1924:40: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick --- net/tipc/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index 23bcc11..082c3b5 100644 --- a/net/tipc/link.c

[PATCH 1/1 linux-next] fs/reiserfs/inode.c: replace 0 by NULL for pointers

Fix sparse warning: fs/reiserfs/inode.c:2769:19: warning: Using plain integer as NULL pointer Cc: reiserfs-de...@vger.kernel.org Cc: Jeff Mahoney Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/reiserfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH 1/1 linux-next] fs/reiserfs/inode.c: replace 0 by NULL for pointers

Fix sparse warning: fs/reiserfs/inode.c:2769:19: warning: Using plain integer as NULL pointer Cc: reiserfs-de...@vger.kernel.org Cc: Jeff Mahoney je...@suse.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/reiserfs/inode.c | 2 +- 1 file

[PATCH 1/1 net-next] tipc: replace 0 by NULL for pointers

Fix sparse warning: net/tipc/link.c:1924:40: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick f...@skynet.be --- net/tipc/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index 23bcc11..082c3b5 100644

[PATCH 1/1 linux-next] pinctrl: use ERR_CAST instead of ERR_PTR/PTR_ERR

Signed-off-by: Fabian Frederick --- include/linux/pinctrl/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h index 18eccef..d7e5d60 100644 --- a/include/linux/pinctrl/consumer.h +++ b/include/linux

[PATCH 1/1 linux-next] pinctrl: use ERR_CAST instead of ERR_PTR/PTR_ERR

Signed-off-by: Fabian Frederick f...@skynet.be --- include/linux/pinctrl/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h index 18eccef..d7e5d60 100644 --- a/include/linux/pinctrl/consumer.h +++ b

[PATCH 1/1 linux-next] ocfs2: remove unnecessary else in ocfs2_set_acl()

else is unnecessary after return Signed-off-by: Fabian Frederick --- fs/ocfs2/acl.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c index 7e8282d..c58a1bc 100644 --- a/fs/ocfs2/acl.c +++ b/fs/ocfs2/acl.c @@ -245,16 +245,14

[PATCH 1/1 linux-next] ocfs2: remove unnecessary sizeof(char)

sizeof(char) is always 1. Suggested-by: Joe Perches Signed-off-by: Fabian Frederick --- fs/ocfs2/journal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index e238bbc..750597c 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2

[PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

sizeof(char) is always 1. Suggested-by: Joe Perches Signed-off-by: Fabian Frederick --- net/netfilter/nf_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c index 43c926c..1191f66 100644 --- a/net/netfilter/nf_log.c +++ b

[PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)

sizeof(char) is always 1. Suggested-by: Joe Perches j...@perches.com Signed-off-by: Fabian Frederick f...@skynet.be --- net/netfilter/nf_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c index 43c926c..1191f66 100644

[PATCH 1/1 linux-next] ocfs2: remove unnecessary sizeof(char)

sizeof(char) is always 1. Suggested-by: Joe Perches j...@perches.com Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ocfs2/journal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index e238bbc..750597c 100644 --- a/fs/ocfs2

[PATCH 1/1 linux-next] ocfs2: remove unnecessary else in ocfs2_set_acl()

else is unnecessary after return Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ocfs2/acl.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c index 7e8282d..c58a1bc 100644 --- a/fs/ocfs2/acl.c +++ b/fs/ocfs2/acl.c @@ -245,16

Re: [PATCH 1/1] scripts: add a graph generator based on checkpatch reports

> On 23 November 2014 at 21:27 Joe Perches wrote: > > > On Sat, 2014-11-22 at 21:56 +0100, Fabian Frederick wrote: > > This script generates a graph based on errors/warnings/checks detected > > by checkpatch -f recursively on each files of a directory. > > Res

Re: [PATCH 1/1] scripts: add a graph generator based on checkpatch reports

On 23 November 2014 at 21:27 Joe Perches j...@perches.com wrote: On Sat, 2014-11-22 at 21:56 +0100, Fabian Frederick wrote: This script generates a graph based on errors/warnings/checks detected by checkpatch -f recursively on each files of a directory. Results are grouped

[PATCH 1/1] scripts: add a graph generator based on checkpatch reports

kernel source root. eg scripts/checkstat.pl fs Cc: Joe Perches Cc: Linus Torvalds Cc: Andrew Morton Signed-off-by: Fabian Frederick --- scripts/checkstat.pl | 120 +++ 1 file changed, 120 insertions(+) create mode 100755 scripts/checkstat.pl diff

[PATCH 1/1] scripts: add a graph generator based on checkpatch reports

kernel source root. eg scripts/checkstat.pl fs Cc: Joe Perches j...@perches.com Cc: Linus Torvalds torva...@linux-foundation.org Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- scripts/checkstat.pl | 120

[PATCH 1/1 net-next] dev_ioctl: use sizeof(x) instead of sizeof x

Also remove spaces after cast. Signed-off-by: Fabian Frederick --- net/core/dev_ioctl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 72e899a..b94b1d2 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c

[PATCH 1/1 net-next] net/core: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick --- net/core/gen_estimator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/gen_estimator.c b/net/core/gen_estimator.c index 9dfb88a..d654d6f 100644 --- a/net/core/gen_estimator.c +++ b/net/core/gen_estimator.c @@ -13,7 +13,7

[PATCH 1/1 net-next] net: fix spelling for synchronized

Signed-off-by: Fabian Frederick --- net/core/dev_addr_lists.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index b6b2306..c0548d2 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c @@ -278,8

[PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

Signed-off-by: Fabian Frederick --- net/core/link_watch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/link_watch.c b/net/core/link_watch.c index bd0767e..49a9e3e 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c @@ -21,7 +21,7 @@ #include #include

[PATCH 1/1 net-next] dccp: spelling s/reseting/resetting

Signed-off-by: Fabian Frederick --- net/dccp/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/input.c b/net/dccp/input.c index 3c8ec7d..3bd14e8 100644 --- a/net/dccp/input.c +++ b/net/dccp/input.c @@ -537,7 +537,7 @@ static int

[PATCH 1/1 net-next] dccp: replace min/casting by min_t

Signed-off-by: Fabian Frederick --- net/dccp/ackvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c index ba07824..bd9e718 100644 --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c @@ -218,7 +218,7 @@ static void dccp_ackvec_add_new(struct

[PATCH 1/1 net-next] dccp: remove blank lines between function/EXPORT_SYMBOL

See Documentation/CodingStyle chapter 6. Signed-off-by: Fabian Frederick --- net/dccp/ipv4.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 6ca645c..e45b968 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c @@ -140,7 +140,6 @@ failure

[PATCH 1/1 net-next] dccp: kerneldoc warning fixes

Signed-off-by: Fabian Frederick --- net/dccp/feat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 9733ddb..1704948 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -478,7 +478,7 @@ static struct dccp_feat_entry * * @fn_list

[PATCH 1/1 net-next] dccp: kerneldoc warning fixes

Signed-off-by: Fabian Frederick f...@skynet.be --- net/dccp/feat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dccp/feat.c b/net/dccp/feat.c index 9733ddb..1704948 100644 --- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -478,7 +478,7 @@ static struct dccp_feat_entry

[PATCH 1/1 net-next] dccp: remove blank lines between function/EXPORT_SYMBOL

See Documentation/CodingStyle chapter 6. Signed-off-by: Fabian Frederick f...@skynet.be --- net/dccp/ipv4.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 6ca645c..e45b968 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c @@ -140,7 +140,6

[PATCH 1/1 net-next] dccp: replace min/casting by min_t

Signed-off-by: Fabian Frederick f...@skynet.be --- net/dccp/ackvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c index ba07824..bd9e718 100644 --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c @@ -218,7 +218,7 @@ static void

[PATCH 1/1 net-next] dccp: spelling s/reseting/resetting

Signed-off-by: Fabian Frederick f...@skynet.be --- net/dccp/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/input.c b/net/dccp/input.c index 3c8ec7d..3bd14e8 100644 --- a/net/dccp/input.c +++ b/net/dccp/input.c @@ -537,7 +537,7 @@ static int

[PATCH 1/1 net-next] net/core: include linux/types.h instead of asm/types.h

Signed-off-by: Fabian Frederick f...@skynet.be --- net/core/link_watch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/link_watch.c b/net/core/link_watch.c index bd0767e..49a9e3e 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c @@ -21,7 +21,7

[PATCH 1/1 net-next] net: fix spelling for synchronized

Signed-off-by: Fabian Frederick f...@skynet.be --- net/core/dev_addr_lists.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index b6b2306..c0548d2 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c

[PATCH 1/1 net-next] net/core: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick f...@skynet.be --- net/core/gen_estimator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/gen_estimator.c b/net/core/gen_estimator.c index 9dfb88a..d654d6f 100644 --- a/net/core/gen_estimator.c +++ b/net/core/gen_estimator.c @@ -13,7

[PATCH 1/1 net-next] dev_ioctl: use sizeof(x) instead of sizeof x

Also remove spaces after cast. Signed-off-by: Fabian Frederick f...@skynet.be --- net/core/dev_ioctl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 72e899a..b94b1d2 100644 --- a/net/core/dev_ioctl.c +++ b/net/core

Re: frequent lockups in 3.18rc4: revert suggestion

> On 17 November 2014 at 01:35 Linus Torvalds > wrote: > > > On Sun, Nov 16, 2014 at 12:42 PM, Fabian Frederick wrote: > > > > Thomas talked about csd_lock and the last reliable stack function > > being smp_call_function_single, I thought it could be interestin

Re: [PATCH 1/1 net-next] wireless: remove unnecessary sizeof(u8)

> On 16 November 2014 at 23:33 Julian Calaby wrote: > > > Hi Fabian, > > On Sat, Nov 15, 2014 at 7:55 AM, Fabian Frederick wrote: > > sizeof(u8) is always 1. > > I thought that sizeof(*variable) was preferred over sizeof(type), so > shouldn't these be switch

Re: frequent lockups in 3.18rc4: revert suggestion

> On 16 November 2014 at 21:03 Linus Torvalds > wrote: > > > On Sun, Nov 16, 2014 at 12:33 AM, Fabian Frederick wrote: > > > >         Have you tried reverting the following patches (all from rc1) ? > > Hmm. Any particular reason you're looking at those? &g

[RFC 1/1] fs/affs/file.c: remove obsolete pagesize check

linux kernel doesn't manage page sizes below 4kb. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/file.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 05005bd..8faa659 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -15,10 +15,6

[PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick --- drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c index 78a6a1a..5b37737

[PATCH 1/1 linux-next] drm: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick --- drivers/gpu/drm/r128/r128_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/r128/r128_state.c b/drivers/gpu/drm/r128/r128_state.c index 575e986..8fd2d9f 100644 --- a/drivers/gpu/drm/r128

[PATCH 1/1 linux-next] tpm: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick --- drivers/char/tpm/tpm_i2c_stm_st33.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_i2c_stm_st33.c b/drivers/char/tpm/tpm_i2c_stm_st33.c index 4669e37..5271b75 100644 --- a/drivers/char/tpm

[PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick --- drivers/acpi/utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index 371ac12..dd8ff63 100644 --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -136,8

frequent lockups in 3.18rc4: revert suggestion

Hi Dave,         I was reading your report http://marc.info/?l=linux-kernel=141600070111887=2         Have you tried reverting the following patches (all from rc1) ?                 c6f4459 v3.18-rc1 smp: Add new wake_up_all_idle_cpus() function         bb964a9 v3.18-rc1 kernel misc: Replace

frequent lockups in 3.18rc4: revert suggestion

Hi Dave,         I was reading your report http://marc.info/?l=linux-kernelm=141600070111887w=2         Have you tried reverting the following patches (all from rc1) ?                 c6f4459 v3.18-rc1 smp: Add new wake_up_all_idle_cpus() function         bb964a9 v3.18-rc1 kernel misc: Replace

[PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/acpi/utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index 371ac12..dd8ff63 100644 --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c

[PATCH 1/1 linux-next] tpm: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/char/tpm/tpm_i2c_stm_st33.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/tpm/tpm_i2c_stm_st33.c b/drivers/char/tpm/tpm_i2c_stm_st33.c index 4669e37..5271b75 100644

[PATCH 1/1 linux-next] drm: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/gpu/drm/r128/r128_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/r128/r128_state.c b/drivers/gpu/drm/r128/r128_state.c index 575e986..8fd2d9f 100644 --- a/drivers

[PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/iio/common/st_sensors/st_sensors_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/st_sensors/st_sensors_spi.c b/drivers/iio/common/st_sensors/st_sensors_spi.c index

[RFC 1/1] fs/affs/file.c: remove obsolete pagesize check

linux kernel doesn't manage page sizes below 4kb. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/file.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 05005bd..8faa659 100644 --- a/fs/affs

Re: frequent lockups in 3.18rc4: revert suggestion

On 16 November 2014 at 21:03 Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Nov 16, 2014 at 12:33 AM, Fabian Frederick f...@skynet.be wrote:          Have you tried reverting the following patches (all from rc1) ? Hmm. Any particular reason you're looking at those

Re: [PATCH 1/1 net-next] wireless: remove unnecessary sizeof(u8)

On 16 November 2014 at 23:33 Julian Calaby julian.cal...@gmail.com wrote: Hi Fabian, On Sat, Nov 15, 2014 at 7:55 AM, Fabian Frederick f...@skynet.be wrote: sizeof(u8) is always 1. I thought that sizeof(*variable) was preferred over sizeof(type), so shouldn't these be switched

Re: frequent lockups in 3.18rc4: revert suggestion

On 17 November 2014 at 01:35 Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Nov 16, 2014 at 12:42 PM, Fabian Frederick f...@skynet.be wrote: Thomas talked about csd_lock and the last reliable stack function being smp_call_function_single, I thought it could be interesting

[PATCH 1/1 net-next] wireless: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick --- drivers/net/wireless/b43/ppr.c| 2 +- drivers/net/wireless/iwlwifi/pcie/trans.c | 2 +- drivers/net/wireless/rtlwifi/efuse.c | 16 3 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 1/1 linux-next] ARM: edma: remove unnecessary sizeof(s8)

sizeof(s8) is always 1 Signed-off-by: Fabian Frederick --- arch/arm/common/edma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 72041f0..d6659fd 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c

Re: [PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

> On 14 November 2014 at 20:14 Joe Perches wrote: > > > On Fri, 2014-11-14 at 20:02 +0100, Fabian Frederick wrote: > > On 14 November 2014 at 19:47 Joe Perches wrote: > > > On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: > > > > kmal

Re: [PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

> On 14 November 2014 at 19:47 Joe Perches wrote: > > > On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: > > kmalloc_array manages count*sizeof overflow. > > Fundamentally correct, but is this necessary or useful? > sizeof(s8) isn't often going to be anythi

[PATCH V4 linux-next RESEND 2] bfa: replace 2 kzalloc/copy_from_user by memdup_user

This patch also removes unnecessary printk(KERN_INFO Signed-off-by: Fabian Frederick --- V4: remove blank line after memdup_user V3: memdup_user first argument is already void __user * (thanks to Joe Perches) typo in title V2: Remove printk(KERN_INFO (suggested by Alan) drivers/scsi/bfa

[PATCH 1/1 net-next] net: dsa: replace count*size kzalloc by kcalloc

kcalloc manages count*sizeof overflow. Signed-off-by: Fabian Frederick --- net/dsa/dsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 4648f12..e84b656 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -606,8 +606,8 @@ static int

[PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

kmalloc_array manages count*sizeof overflow. Signed-off-by: Fabian Frederick --- net/dsa/dsa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 4648f12..c00cca3 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -526,7 +526,8 @@ static int

[PATCH 1/1 net-next] Bluetooth: hidp: replace kzalloc/copy_from_user by memdup_user

use memdup_user for rd_data import. Signed-off-by: Fabian Frederick --- net/bluetooth/hidp/core.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 1b7d605..cc25d0b 100644 --- a/net/bluetooth/hidp/core.c

[PATCH 1/1 net-next] openvswitch: use PTR_ERR_OR_ZERO

Signed-off-by: Fabian Frederick --- net/openvswitch/flow_netlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index c0d066d..c8fccdd 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch

Re: linux-next: build failure after merge of the block tree

> On 11 November 2014 at 16:27 Jens Axboe wrote: > > > On 2014-11-11 04:20, Fabian Frederick wrote: > > > > > >> On 11 November 2014 at 03:12 Stephen Rothwell > >> wrote: > >> > >> > >> Hi Jens, > >> > >> A

Re: linux-next: build failure after merge of the block tree

On 11 November 2014 at 16:27 Jens Axboe ax...@kernel.dk wrote: On 2014-11-11 04:20, Fabian Frederick wrote: On 11 November 2014 at 03:12 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Jens, After merging the block tree, today's linux-next build (x86_64 allmodconfig

[PATCH 1/1 net-next] openvswitch: use PTR_ERR_OR_ZERO

Signed-off-by: Fabian Frederick f...@skynet.be --- net/openvswitch/flow_netlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index c0d066d..c8fccdd 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net

[PATCH 1/1 net-next] Bluetooth: hidp: replace kzalloc/copy_from_user by memdup_user

use memdup_user for rd_data import. Signed-off-by: Fabian Frederick f...@skynet.be --- net/bluetooth/hidp/core.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 1b7d605..cc25d0b 100644 --- a/net/bluetooth

[PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

kmalloc_array manages count*sizeof overflow. Signed-off-by: Fabian Frederick f...@skynet.be --- net/dsa/dsa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 4648f12..c00cca3 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -526,7 +526,8

[PATCH 1/1 net-next] net: dsa: replace count*size kzalloc by kcalloc

kcalloc manages count*sizeof overflow. Signed-off-by: Fabian Frederick f...@skynet.be --- net/dsa/dsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 4648f12..e84b656 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -606,8 +606,8

[PATCH V4 linux-next RESEND 2] bfa: replace 2 kzalloc/copy_from_user by memdup_user

This patch also removes unnecessary printk(KERN_INFO Signed-off-by: Fabian Frederick f...@skynet.be --- V4: remove blank line after memdup_user V3: memdup_user first argument is already void __user * (thanks to Joe Perches) typo in title V2: Remove printk(KERN_INFO (suggested by Alan

Re: [PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

On 14 November 2014 at 19:47 Joe Perches j...@perches.com wrote: On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: kmalloc_array manages count*sizeof overflow. Fundamentally correct, but is this necessary or useful? sizeof(s8) isn't often going to be anything other than 1

Re: [PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array

On 14 November 2014 at 20:14 Joe Perches j...@perches.com wrote: On Fri, 2014-11-14 at 20:02 +0100, Fabian Frederick wrote: On 14 November 2014 at 19:47 Joe Perches j...@perches.com wrote: On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: kmalloc_array manages count*sizeof

[PATCH 1/1 linux-next] ARM: edma: remove unnecessary sizeof(s8)

sizeof(s8) is always 1 Signed-off-by: Fabian Frederick f...@skynet.be --- arch/arm/common/edma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 72041f0..d6659fd 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common

[PATCH 1/1 net-next] wireless: remove unnecessary sizeof(u8)

sizeof(u8) is always 1. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/net/wireless/b43/ppr.c| 2 +- drivers/net/wireless/iwlwifi/pcie/trans.c | 2 +- drivers/net/wireless/rtlwifi/efuse.c | 16 3 files changed, 10 insertions(+), 10 deletions

Re: linux-next: build failure after merge of the block tree

> On 11 November 2014 at 03:12 Stephen Rothwell wrote: > > > Hi Jens, > > After merging the block tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/built-in.o: In function `cdrom_sysctl_handler': > cdrom_sysctl.c:(.text+0x156d92): undefined reference to

Re: linux-next: build failure after merge of the block tree

On 11 November 2014 at 03:12 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Jens, After merging the block tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/built-in.o: In function `cdrom_sysctl_handler': cdrom_sysctl.c:(.text+0x156d92): undefined

[PATCH v2 05/10 linux-next] cdrom: remove bool comparison/assignment to 0/1

/cdrom.c:295:12-30: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index ca47919..a4dd382 100644 --- a/drivers/cdrom

[PATCH v2 04/10 linux-next] cdrom: move EXPORT_SYMBOL after functions

Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index deda0f1..ca47919 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -638,6

[PATCH v2 03/10 linux-next] cdrom: fix spaces required errors

Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index c311e0d..deda0f1 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom

[PATCH v2 10/10 linux-next] cdrom: uniformize lba command initialization

logical block address field was initialized in different functions directly in package cmd or bio cmd. Note that cdrom_dummy_generic_packet didn't use & 0xff Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 33 + 1 file changed, 13 insertions(+)

[PATCH v2 06/10 linux-next] cdrom: use bool for true/false initialized variable

Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index a4dd382..a1a26d5 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3678,9 +3678,9 @@ static

[PATCH v2 09/10 linux-next] cdrom: remove unnecessary status

cdrom_number_of_slots returns nslots and doesn't need status variable. Just remove it and test cdrom_read_mech_status(). Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c

[PATCH v2 08/10 linux-next] cdrom: fix init_cdrom_command in dvd_do_auth

Remove memset 0 (init_cdrom_command already does it) and send sizeof(buf) instead of 0 for buffer size. Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 9b08f91

[PATCH v2 07/10 linux-next] cdrom: export sysctl code

-Move all sysctl operations to cdrom_sysctl -Remove static/add extern in cdrom.h for some variables -Prefix those variables with cdrom_ (suggested by Joe Perches) -Fix some checkpatch warnings -Update cdrom makefile accordingly. Signed-off-by: Fabian Frederick --- drivers/cdrom/Makefile

[PATCH v2 01/10 linux-next] cdrom: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 5d28a45..c7fa0e2 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -281,8 +281,7 @@ #include

[PATCH v2 00/10 linux-next] cdrom: sysctl export + clean-up

This patchset moves sysctl functions to a new file cdrom_sysctl.c and tries to solve small code / coding style issues. V2: -Use cdrom_ prefix for global variables (suggested by Joe Perches) -Add 2 patches Fabian Frederick (10): cdrom: include linux/uaccess.h

[PATCH v2 02/10 linux-next] cdrom: use static const char * const where possible

Both mrw_format_status and mrw_address_space strings are only read in pr_info. Signed-off-by: Fabian Frederick --- drivers/cdrom/cdrom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index c7fa0e2..c311e0d 100644

[PATCH v2 02/10 linux-next] cdrom: use static const char * const where possible

Both mrw_format_status and mrw_address_space strings are only read in pr_info. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index c7fa0e2..c311e0d

[PATCH v2 00/10 linux-next] cdrom: sysctl export + clean-up

This patchset moves sysctl functions to a new file cdrom_sysctl.c and tries to solve small code / coding style issues. V2: -Use cdrom_ prefix for global variables (suggested by Joe Perches) -Add 2 patches Fabian Frederick (10): cdrom: include linux/uaccess.h

[PATCH v2 01/10 linux-next] cdrom: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 5d28a45..c7fa0e2 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -281,8 +281,7

[PATCH v2 07/10 linux-next] cdrom: export sysctl code

-Move all sysctl operations to cdrom_sysctl -Remove static/add extern in cdrom.h for some variables -Prefix those variables with cdrom_ (suggested by Joe Perches) -Fix some checkpatch warnings -Update cdrom makefile accordingly. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom

[PATCH v2 09/10 linux-next] cdrom: remove unnecessary status

cdrom_number_of_slots returns nslots and doesn't need status variable. Just remove it and test cdrom_read_mech_status(). Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers

[PATCH v2 08/10 linux-next] cdrom: fix init_cdrom_command in dvd_do_auth

Remove memset 0 (init_cdrom_command already does it) and send sizeof(buf) instead of 0 for buffer size. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c

[PATCH v2 06/10 linux-next] cdrom: use bool for true/false initialized variable

Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index a4dd382..a1a26d5 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3678,9 +3678,9

[PATCH v2 04/10 linux-next] cdrom: move EXPORT_SYMBOL after functions

Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index deda0f1..ca47919 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom

[PATCH v2 03/10 linux-next] cdrom: fix spaces required errors

Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index c311e0d..deda0f1 100644 --- a/drivers/cdrom/cdrom.c +++ b

[PATCH v2 10/10 linux-next] cdrom: uniformize lba command initialization

logical block address field was initialized in different functions directly in package cmd or bio cmd. Note that cdrom_dummy_generic_packet didn't use 0xff Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 33 + 1 file changed, 13

[PATCH v2 05/10 linux-next] cdrom: remove bool comparison/assignment to 0/1

/cdrom.c:295:12-30: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/cdrom/cdrom.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index ca47919..a4dd382 100644

[PATCH V2 linux-next] ipv4: add kernel parameter tcpmhash_entries

This patch also adds a reference to ip-sysctl.txt where TCP metrics setup is described Signed-off-by: Fabian Frederick --- V2: Add a reference to ip-sysctl and update description. (suggested by Jonathan Corbet). Documentation/kernel-parameters.txt | 7 +++ 1 file changed, 7 insertions

[PATCH V2 linux-next] ipv4: add kernel parameter tcpmhash_entries

This patch also adds a reference to ip-sysctl.txt where TCP metrics setup is described Signed-off-by: Fabian Frederick f...@skynet.be --- V2: Add a reference to ip-sysctl and update description. (suggested by Jonathan Corbet). Documentation/kernel-parameters.txt | 7 +++ 1 file changed, 7

[PATCH/TRIVIAL 1/1 net-next] udp: remove blank line between set and test

Suggested-by: Joe Perches Signed-off-by: Fabian Frederick --- net/ipv4/udp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index cf0cece..3f001db 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1784,7 +1784,6 @@ int __udp4_lib_rcv(struct sk_buff *skb

[PATCH V2 net-next] esp4: remove assignment in if condition

Signed-off-by: Fabian Frederick --- V2: remove blank line between set and test (suggested by Joe Perches). net/ipv4/esp4.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 360b565..d2bf02e 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4

[PATCH V2 linux-next] fs/affs/file.c: adding support to O_DIRECT

Based on ext2_direct_IO Tested with O_DIRECT file open and sysbench/mariadb with 1% written queries improvement (update_non_index test) on a volume created with mkaffs. Cc: Al Viro Cc: Andrew Morton Signed-off-by: Fabian Frederick --- V2: Adding test results (suggested by Andrew Morton) fs

<    8   9   10   11   12   13   14   15   16   17   >