[PATCH 07/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com_reg.h

RATE_ALL_OFDM_2SS RATR_MCS8 | RATR_MCS9 | RATR_MCS10 | RATR_MCS11 |\ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/hal_com_reg.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers

[PATCH 03/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/odm_debug.h

) \ no_printk fmt Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm_debug.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h index be0d4c49a747..e6eb517c8685 100644

[PATCH 04/15] staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.h

: +#define SET_BITS_TO_LE_1BYTE(__pstart, __bitoffset, __bitlen, __val) \ parentheses solution preferred for all fixes and made macros more readables Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/include/basic_types.h | 30 +++ 1 file changed, 18 insertions(+), 12 deletions

[PATCH 02/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/HalBtcOutSrc.h

(dbgtype, dbgflag, printstr, _Ptr) \ no_printk printstr Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h b/drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h

[PATCH 01/15] staging: rtl8723bs: inlcude macros in a do..while loop in core/rtw_security.c

-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_security.c | 94 +++ 1 file changed, 54 insertions(+), 40 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index 44e2b362c867..c92984fcf42d 100644

[PATCH 00/15] staging: rtl8723bs: fix checkpatch errors on macros

c__, adapter->pnetdev->nam All those macros are not used to generate expressions but arguments of a functions. If someone knows how to silence those errors as well, please tell me. Fabio Aiuto (15): staging: rtl8723bs: inlcude macros in a do..while loop in core/rtw_security.c

[PATCH] staging: rtl8723bs: fix indentation broken by previous patch

fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiut...@gmail.com Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core

[PATCH 3/3] staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_linux.c

/rtl8723bs/os_dep/ioctl_linux.c:4239: + if (!(ext = vmalloc(len))) -- ERROR: do not use assignment in if condition 4253: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4253: + if (!(ext_dbg = vmalloc(len))) { Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

[PATCH 2/3] staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c

) { -- ERROR: do not use assignment in if condition 3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335: + if (!(ndev = wdev_to_ndev(wdev))) Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 13 - 1 file changed, 8 insertions(+), 5

[PATCH 1/3] staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c

fix the following checkpatch warning: ERROR: do not use assignment in if condition 1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118: + if ((addr = of_get_property(np, "local-mac-address", )) && Signed-off-by: Fabio Aiuto --- drivers/stag

[PATCH 0/3] staging: rtl8723bs: remove assignment in conditions

remove all assignment in conditions in rtl8723bs, warned by checkpatch.pl Fabio Aiuto (3): staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c staging: rtl8723bs: remove assignment

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > > Actually, these would seem to be better as one or multiple functions with > local statics or even as static inlines functions in the .h file > > $ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core >

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

On Mon, Mar 22, 2021 at 10:29:27PM +0300, Dan Carpenter wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/cor

[PATCH v2 8/9] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

remove unnecessary extern. The function is defined static in os_dep/os_intfs.c and used only once in the same file Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b

[PATCH v2 9/9] staging: rtl8723bs: remove blank line os_dep/os_intfs.c

remove blank line Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index c6c5cc0a9e08..405aa95af579 100644 --- a/drivers

[PATCH v2 4/9] staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c

: +extern unsigned char WPA_TKIP_CIPHER[4]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index bfd55a0356f5

[PATCH v2 7/9] staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c

fix the following checkpatch issue: WARNING: externs should be avoided in .c files 486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486: +extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1

[PATCH v2 6/9] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c

:197: +int netdev_open(struct net_device *pnetdev); moved function prototype in include/osdep_intf.h removed function prototype and made a static removed unnecessary extern declaration in os_dep/ioctl_cfg80211.c Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h| 2

[PATCH v2 5/9] staging: rtl8723bs: remove function prototypes in hal/odm.c

*pDM_Odm); removed function prototypes and made staics where needed in hal/odm.c moved function definition in file to let the compiler work Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 1717 +-- 1 file changed, 824 insertions(+), 893 deletions

[PATCH v2 3/9] staging: rtl8723bs: removed function prototypes and made statics in core/rtw_recv.c

static function definitions before their usage to make code compile Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 441 ++ 1 file changed, 207 insertions(+), 234 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging

[PATCH v2 2/9] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2

[PATCH v2 1/9] staging: rtl8723bs: removed function prototypes in core/rtw_efuse.c

fix the following checkpatch issues: WARNING: externs should be avoided in .c files 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: +bool removed two function prototypes in core/rtw_efuse.c and made definition static Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core

[PATCH v2 0/9] fix extern declarations checkpatch issues

Fix extern declaration issues warned by checkpatch. Changes in v2: - removal of prototypes when function can be static - move of static function defs inside file to let the code compile - split last patch in two patches (one patch for blank line removal) Fabio Aiuto (9

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

On Mon, Mar 22, 2021 at 05:09:00PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 40: FILE: drivers/staging/rtl8723bs/core/

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

On Mon, Mar 22, 2021 at 05:07:53PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch issues: > > > > WARNING: externs should be avoided in .c files > > 35: FILE: drivers/staging/rtl8723bs/cor

Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

On Mon, Mar 22, 2021 at 05:11:13PM +0100, Greg KH wrote: > On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > > remove debug_priv argument so function prototype can be > > easily moved away > > > > Signed-off-by: Fabio Aiuto > > --- > > drivers

[PATCH 11/11] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

remove unnecessary extern. The function is defined static in os_dep/os_intfs.c and used only once in the same file remove also a blank line Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 2 files changed

[PATCH 08/11] staging: rtl8723bs: move function prototypes out of hal/odm.c

*pDM_Odm); moved function prototypes in hal/odm.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 68 - drivers/staging/rtl8723bs/hal/odm.h | 62 ++ 2 files changed, 62 insertions(+), 68 deletions(-) diff --git a/drivers

[PATCH 09/11] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c

:197: +int netdev_open(struct net_device *pnetdev); moved function prototypes in include/osdep_intf.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h | 3 +++ drivers/staging/rtl8723bs/os_dep/os_intfs.c| 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 04/11] staging: rtl8723bs: moved function prototypes out of core/rtw_recv.c

in include/rtw_recv.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c| 31 +--- drivers/staging/rtl8723bs/include/rtw_recv.h | 51 2 files changed, 52 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers

[PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

remove debug_priv argument so function prototype can be easily moved away Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging

[PATCH 07/11] staging: rtl8723bs: delete extern declarations in core/rtw_wlan_util.c

: +extern unsigned char WPA_TKIP_CIPHER[4]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index bfd55a0356f5

[PATCH 10/11] staging: rtl8723bs: remove undefined function prototype in of os_dep/sdio_intf.c

fix the following checkpatch issue: WARNING: externs should be avoided in .c files 486: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:486: +extern int pm_netdev_close(struct net_device *pnetdev, u8 bnormal); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1

[PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2

[PATCH 06/11] staging: rtl8723bs: move function prototype out of core/rtw_recv.c

move function prototype in include/rtw_recv.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_recv.c| 1 - drivers/staging/rtl8723bs/include/rtw_recv.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b

[PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

fix the following checkpatch issues: WARNING: externs should be avoided in .c files 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: +bool moved two function prototypes in include/rtw_efuse.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_efuse.c| 10

[PATCH 01/11] staging: rtl8723bs: delete extern declarations in core/rtw_ap.c

/staging/rtl8723bs/core/rtw_ap.c:15: +extern unsigned char WPS_OUI[]; -- WARNING: externs should be avoided in .c files 16: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:16: +extern unsigned char P2P_OUI[]; Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 5 - 1 file

[PATCH 00/11] staging: rtl8723bs: fix extern declaration checkpatch issues

Fix extern declaration issues warned by checkpatch Fabio Aiuto (11): staging: rtl8723bs: delete extern declarations in core/rtw_ap.c staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 11:59:44AM +0100, Greg KH wrote: > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > Hi, > > > > here's an issue in checkpatch.pl > > > > $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c >

Re: CHECKPATCH: missing a warning soon after include files decl -c

On Sat, Mar 20, 2021 at 04:28:51AM -0700, Joe Perches wrote: > On Sat, 2021-03-20 at 11:59 +0100, Greg KH wrote: > > On Sat, Mar 20, 2021 at 11:54:24AM +0100, Fabio Aiuto wrote: > > > Hi, > > > > > > here's an issue in checkpatch.pl > > > > &g

CHECKPATCH: missing a warning soon after include files decl -c

Hi, here's an issue in checkpatch.pl $ perl script/checkpatch.pl -f drivers/staging/rtl8723bs/core/rtw_ap.c I get three warning related to an extern declaration WARNING: externs should be avoided in .c files #14: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:14: +extern unsigned char

[PATCH v2] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2230: + DBG_8192C("%s\n", __func__); Changes in v2: removed empty #ifdef block Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 17 - 1 file changed, 17 deletions(-) dif

[PATCH 14/15] staging: rtl8723bs: remove unnecessary logging in os_dep/os_intfs.c

func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1177: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:1177: + DBG_871X("<=== %s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 7 --- 1 file c

[PATCH 12/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2230: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl

[PATCH 13/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_linux.c

DBG_871X("%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index aac1391bdbf1..590da

[PATCH 15/15] staging: rtl8723bs: remove unnecessary logging in os_dep/wifi_regd.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 153: FILE: drivers/staging/rtl8723bs/os_dep/wifi_regd.c:153: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2

[PATCH 08/15] staging: rtl8723bs: remove unnecessary logging in hal/odm.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1109: FILE: drivers/staging/rtl8723bs/hal/odm.c:1109: + /* printk("==> %s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 2 -- 1 fi

[PATCH 11/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_hal_init.c

E: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1722: +/* DBG_8192C("%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.

[PATCH 07/15] staging: rtl8723bs: remove unnecessary logging in hal/hal_com_phycfg.c

FILE: drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:265: + /* DBG_871X("<===%s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_p

[PATCH 10/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_cmd.c

1X("%s>\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 965: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:965: + /* DBG_871X("%s>\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl872

[PATCH 09/15] staging: rtl8723bs: remove unnecessary logging in hal/odm_debug.h

ace 135: FILE: drivers/staging/rtl8723bs/hal/odm_debug.h:135: +#define ODM_dbg_exit() { DbgPrint("<== %s\n", __func__); } and removed containing unused macros Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm_debug.h | 2 -- 1 file changed, 2 deletions(-) di

[PATCH 05/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_wlan_util.c

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1140: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:1140: + DBG_871X("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c

[PATCH 06/15] staging: rtl8723bs: remove unnecessary logging in hal/HalBtcOutSrc.h

fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 126: FILE: drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h:126: + DbgPrint("%s(): ", __func__);\ and remove the whole unused containing macro BTC_PRINT_F Signed-off-by: F

[PATCH 03/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c

race 5355: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:5355: + DBG_871X("=>%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 5366: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:5366: + DBG_871X("%s\n", __func__

[PATCH 04/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_pwrctrl.c

FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:606: + DBG_871X("%s.\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 753: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:753: + /* DBG_871X("%s\n", __func__); */ Signed-off-by:

[PATCH 02/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c

E: drivers/staging/rtl8723bs/core/rtw_mlme.c:1223: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1528: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:1528: + DBG_871X("%s\n", __func__); Signed-off-by: Fabio Aiuto ---

[PATCH 01/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c

1X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1716: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:1716: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1740: FILE: drivers/staging/

[PATCH 00/15] remove unnecessary logging

remove unnsecessary loggings warned by checkpatch Fabio Aiuto (15): staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c staging: rtl8723bs

staging: rtl8723bs: prefer ftrace

Hi, some suggestions before diving in a new task. The following checkpatch issue: -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559: + DBG_871X("%s\n", __func__); simply says to remove the line, due to the existence

[PATCH] staging: rtl8723bs: remove unused code blocks completed

left are checked by existing defines. Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/TODO b/drivers/staging/rtl8723bs/TODO index 45065fd3fd5d..afa620ceb2d8 100644 --- a/drivers/staging/rtl8723bs/TODO +++ b

staging: rtl8723bs: remove unused code blocks completed?

Hi, I'm trying to search other unused code blocks: grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/ drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)

staging: rtl8723bs: remove unused code blocks completed?

Hi, I'm trying to search other unused code blocks: grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/ drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM) drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)

[PATCH 12/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_MULTI_VIR_IFACES

remove conditional code blocks checked by unused CONFIG_MULTI_VIR_IFACES cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/drv_types.h | 3 --- 1 file changed, 3 deletions

[PATCH 10/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_BSD_RX_USE_MBUF

remove conditional code blocks checked by unused CONFIG_BSD_RX_USE_MBUF cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 - 1 file changed, 5 deletions

[PATCH 11/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_R871X_TEST

remove conditional code blocks checked by unused CONFIG_R871X_TEST cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH 08/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SINGLE_RECV_BUF

remove conditional code blocks checked by unused CONFIG_SINGLE_RECV_BUF cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 8 ++-- 1 file changed, 2 insertions

[PATCH 09/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_RX_INDICATE_QUEUE

remove conditional code blocks checked by unused CONFIG_RX_INDICATE_QUEUE cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 4 1 file changed, 4 deletions

[PATCH 07/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_USB_VENDOR*

remove conditional code blocks checked by unused CONFIG_USB_VENDOR family defines cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/drv_conf.h | 10 -- 1 file changed, 10

[PATCH 06/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_LAYER2_ROAMING_ACTIVE

remove conditional code blocks checked by unused CONFIG_LAYER2_ROAMING_ACTIVE cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 --- 1 file changed, 3 deletions

[PATCH 05/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_VALIDATE_SSID

remove conditional code blocks checked by unused CONFIG_VALIDATE_SSID cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 11 --- 1 file changed, 11

[PATCH 03/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_DISABLE_MCS13TO15

remove conditional code blocks checked by unused CONFIG_DISABLE_MCS13TO15 cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 16 +--- drivers/staging

[PATCH 02/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

remove conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 30

[PATCH 04/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ

remove conditional code blocks checked by unused CONFIG_UPDATE_INDICATE_SEQ_WHILE_PROCESS_ADDBA_REQ cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 8 1

[PATCH 01/12] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CMCC_TEST

remove conditional code blocks checked by unused CONFIG_CMCC_TEST cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 19 --- 1 file changed, 19

[PATCH 00/12] Remove more unused code blocks

Remove unused code clocks, as required in TODO list: find and remove code blocks guarded by never set CONFIG_FOO defines Fabio Aiuto (12): staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CMCC_TEST staging: rtl8723bs: remove unused code blocks

[PATCH v2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_GPIO_API

remove conditional code blocks checked by unused CONFIG_GPIO_API cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Changes in v2: rebase of conflicting code in public staging-testing Signed-off-by: Fabio Aiuto --- .../staging

[PATCH v2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AP_WOWLAN

remove conditional code blocks checked by unused CONFIG_AP_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Changes in v2: rebase of conflicting code with public tree Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs

Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM

On Tue, Mar 16, 2021 at 12:39:19PM +0100, Greg KH wrote: > On Mon, Mar 15, 2021 at 11:15:02AM +0100, Fabio Aiuto wrote: > > remove conditional code blocks checked by unused CONFIG_PM > > > > cleaning required in TODO file: > > > > find and remove code block

[PATCH 14/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_C2H_PACKET_EN

remove conditional code blocks checked by unused CONFIG_C2H_PACKET_EN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 15/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_ODM_ADAPTIVITY

remove conditional code blocks checked by unused CONFIG_ODM_ADAPTIVITY cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH 12/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SDIO_TX_TASKLET

remove conditional code blocks checked by unused CONFIG_SDIO_TX_TASKLET cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 drivers/staging/rtl8723bs/hal

[PATCH 11/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CHECK_BT_HANG

remove conditional code blocks checked by unused CONFIG_CHECK_BT_HANG cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 31 --- drivers/staging

[PATCH 13/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SW_CHANNEL_PLAN

remove conditional code blocks checked by unused CONFIG_SW_CHANNEL_PLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/hal_com.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 10/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_EXT_CLK

remove conditional code blocks checked by unused CONFIG_EXT_CLK cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 14 -- 1 file changed, 14 deletions

[PATCH 09/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_GPIO_API

remove conditional code blocks checked by unused CONFIG_GPIO_API cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 95 --- drivers/staging/rtl8723bs

[PATCH 07/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_BACKGROUND_NOISE_MONITOR

remove conditional code blocks checked by unused CONFIG_BACKGROUND_NOISE_MONITOR cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 - drivers/staging

[PATCH 08/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SKIP_SIGNAL_SCALE_MAPPING

remove conditional code blocks checked by unused CONFIG_SKIP_SIGNAL_SCALE_MAPPING cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 9 drivers/staging

[PATCH 06/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SIGNAL_DISPLAY_DBM

remove conditional code blocks checked by unused CONFIG_SIGNAL_DISPLAY_DBM cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/hal

[PATCH 04/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AP_WOWLAN

remove conditional code blocks checked by unused CONFIG_AP_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 35 -- .../staging/rtl8723bs/core

[PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM

remove conditional code blocks checked by unused CONFIG_PM cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 1 file changed, 8 deletions(-) diff

[PATCH 03/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_QOS_OPTIMIZATION

remove conditional code blocks checked by unused CONFIG_QOS_OPTIMIZATION cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 1 file changed, 4 deletions

[PATCH 02/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_HW_PWRP_DETECTION

remove conditional code blocks checked by unused CONFIG_HW_PWRP_DETECTION cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 1 file changed, 4 deletions

[PATCH 01/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AUTO_AP_MODE

remove conditional code blocks checked by unused CONFIG_AUTO_AP_MODE cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 - drivers/staging/rtl8723bs/core

[PATCH 00/15] staging: rtl8723bs: remove unused code blocks

Remove unused code blocks as required in TODO file Fabio Aiuto (15): staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AUTO_AP_MODE staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_HW_PWRP_DETECTION staging: rtl8723bs: remove

Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused code blocks

On Sun, Mar 14, 2021 at 04:57:38PM +0100, Greg KH wrote: > On Fri, Mar 12, 2021 at 07:33:13PM +0100, Fabio Aiuto wrote: > > This patch set removes unused code blocks as required in TODO file: > > > > find and remove code blocks guarded by never set CONFIG_FOO defines &

[PATCH v3 2/2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_WOWLAN

remove conditional code blocks checked by unused CONFIG_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

[PATCH v3 0/2] staging: rtl8723bs: remove unused code blocks

a patch previously excluded (removal of CONFIG_PNO_SET_DEBUG code) Fabio Aiuto (2): staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SUPPORT staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_WOWLAN drivers/staging

[PATCH v3 1/2] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SUPPORT

Remove conditional code blocks checked by unused CONFIG_PNO_SUPPORT Cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 -- .../staging/rtl8723bs/core

[PATCH v2 4/4] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_TCP_CSUM_OFFLOAD_RX

remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 - drivers/staging/rtl8723bs

[PATCH v2 3/4] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_WOWLAN

remove conditional code blocks checked by unused CONFIG_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

<    1   2   3   4   5   6   >