[PATCH v2 2/4] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SUPPORT

2021-03-12 Thread Fabio Aiuto
Remove conditional code blocks checked by unused CONFIG_PNO_SUPPORT Cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 -- .../staging/rtl8723bs/core

[PATCH v2 1/4] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SET_DEBUG

2021-03-12 Thread Fabio Aiuto
Remove conditional code block checked by unused CONFIG_PNO_SET_DEBUG Cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 48 drivers/staging

[PATCH v2 0/4] staging: rtl8723bs: remove unused code blocks

2021-03-12 Thread Fabio Aiuto
of CONFIG_PNO_SET_DEBUG code) Fabio Aiuto (4): staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SET_DEBUG staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PNO_SUPPORT staging: rtl8723bs: remove unused code blocks conditioned by never set

[PATCH 2/3] staging: rtl8723bs: remove unused code blocks

2021-03-12 Thread Fabio Aiuto
remove conditional code blocks checked by unused CONFIG_WOWLAN cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

[PATCH 1/3] staging: rtl8723bs: remove unused code blocks

2021-03-12 Thread Fabio Aiuto
Remove conditional code blocks checked by unused CONFIG_PNO_SUPPORT Cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 -- .../staging/rtl8723bs/core

[PATCH 0/3] staging: rtl8723bs: remove unused code blocks

2021-03-12 Thread Fabio Aiuto
This patch set removes unused code blocks as required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Fabio Aiuto (3): staging: rtl8723bs: remove unused code blocks staging: rtl8723bs: remove unused code blocks staging: rtl8723bs: remove unused

[PATCH 3/3] staging: rtl8723bs: remove unused code blocks

2021-03-12 Thread Fabio Aiuto
remove conditional code blocks checked by unused CONFIG_TCP_CSUM_OFFLOAD_RX cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 - drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: put quoted string in a single line

2021-03-12 Thread Fabio Aiuto
DBG_871X("%s STA %pM - no " + "greenfield, num of non-gf stations %d\n", WARNING: quoted string split across lines + DBG_871X("%s STA %pM - 20 MHz HT, " + "num of 20MH

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-12 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 10:27:53PM +, Eric Curtin wrote: > Hi Fabio, > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > > > thank you, > > > > fabio > > > > I'm only responding to this because this email

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-11 Thread Fabio Aiuto
On Thu, Mar 11, 2021 at 01:15:34AM -0800, Joe Perches wrote: > On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote: > > You need to have a space character after the '*'. > > Perhaps YA checkpatch test... > --- > scripts/checkpatch.pl | 15 +++ > 1 file changed, 15 insertions(+) >

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-11 Thread Fabio Aiuto
On Thu, Mar 11, 2021 at 09:03:57AM +0100, Miguel Ojeda wrote: > On Wed, Mar 10, 2021 at 11:00 PM Fabio Aiuto wrote: > > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > Pl

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 10:27:53PM +, Eric Curtin wrote: > Hi Fabio, > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > > > thank you, > > > > fabio > > > > I'm only responding to this because this email

[PATCH v2] staging: rtl8723bs: align and beautify comments

2021-03-10 Thread Fabio Aiuto
fix the following checkpatch warnings: WARNING: Block comments use * on subsequent lines + /* + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k -- WARNING: Block comments use * on subsequent lines +/* +op_mode Signed-off-by: Fabio Aiuto --- drivers/stag

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > > > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]

[PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
fix the following checkpatch warnings: WARNING: Block comments use * on subsequent lines + /* + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k -- WARNING: Block comments use * on subsequent lines +/* +op_mode Signed-off-by: Fabio Aiuto --- drivers/stag

[PATCH] staging: rtl8723bs: remove unused code block

2021-03-10 Thread Fabio Aiuto
Remove conditional code block checked by unused CONFIG_GPIO_WAKEUP Cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 8 --- drivers/staging/rtl8723bs/hal

[PATCH] staging: rtl8723bs: removed unused code block

2021-03-05 Thread Fabio Aiuto
Removed conditional code block checked by unused CONFIG_TX_BCAST2UNI This patch does the cleaning required in TODO file: find and remove code blocks guarded by never set CONFIG_FOO defines Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 --- 1 file changed, 3

<    1   2   3   4   5   6