fixes the problem by casting the signed registers to s16.
Tested on an INA219.
Signed-off-by: Fabio Baltieri
---
drivers/hwmon/ina2xx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index 93d26e8..bfd3f3e 100644
--- a
On Sun, Jun 8, 2014 at 9:30 PM, Guenter Roeck wrote:
> On Sun, Jun 08, 2014 at 01:16:00PM -0700, Guenter Roeck wrote:
>> On Sat, Jun 07, 2014 at 09:47:01PM +0100, Fabio Baltieri wrote:
>> > All devices supported by the ina2xx driver are bidirectional and reports
>> &
problem by using a s16 instead, and has been tested
on an INA219.
Signed-off-by: Fabio Baltieri
---
drivers/hwmon/ina2xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index 93d26e8..d994280 100644
--- a/drivers/hwmon/ina2xx.c
constant rate.
Signed-off-by: Fabio Baltieri
---
Changes from v1:
- fixed some wrong indentations
net/mac80211/ieee80211_i.h | 1 -
net/mac80211/led.c | 19 +++
net/mac80211/led.h | 2 +-
net/mac80211/status.c | 2 +-
net/mac80211/tx.c | 1 -
5
nd the code is simpler, so ... :)
Good enough... I'll send the v2 then. :-)
Thanks,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.or
On Wed, Jul 24, 2013 at 10:14:25AM +0200, Johannes Berg wrote:
> On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote:
> > Changes mac80211 LED trigger code to use the generic
> > led_trigger_blink_oneshot() API for transmit and receive activity
> > indication.
> &g
at constant rate.
Signed-off-by: Fabio Baltieri
---
net/mac80211/ieee80211_i.h | 1 -
net/mac80211/led.c | 21 +
net/mac80211/led.h | 2 +-
net/mac80211/status.c | 2 +-
net/mac80211/tx.c | 1 -
5 files changed, 11 insertions(+), 16 deletions
result for an activity
indicator: one visible blink for sporadic events and a steady on-off
blink sequence on constant traffic.
Would you consider this patch for wireless-next?
Thanks,
Fabio
Fabio Baltieri (1):
mac80211: use oneshot blink API for LED triggers
net/mac80211/ieee80211_i.h | 1 -
net
Add missing static qualifiers to hash_process_data and hash_hw_final.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/hash/hash_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/ux500/hash/hash_core.c
b/drivers/crypto/ux500/hash/hash_core.c
Add missing __iomem to struct cryp_register pointers, this solve some
"incorrect type in initializer (different address spaces)" sparse
warnings.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/cryp/cryp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Use dmaengine_prep_slave_sg inline function instead of going through the
structures manually.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/cryp/cryp_core.c | 20 ++--
drivers/crypto/ux500/hash/hash_core.c | 4 ++--
2 files changed, 12 insertions(+), 12 deletions
Use dmaengine_submit instead of calling desc->tx_submit manually.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/cryp/cryp_core.c | 2 +-
drivers/crypto/ux500/hash/hash_core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c
Use dmaengine_device_control inline function instead of going through the
structures manually.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/cryp/cryp_core.c | 4 ++--
drivers/crypto/ux500/hash/hash_core.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
Always use readl when reading memory mapped registers.
Signed-off-by: Fabio Baltieri
---
drivers/crypto/ux500/hash/hash_core.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/crypto/ux500/hash/hash_core.c
b/drivers/crypto/ux500/hash
.
Thanks,
Fabio
Fabio Baltieri (6):
crypto: ux500/hash: use readl on iomem addresses
crypto: ux500/hash: add missing static qualifiers
crypto: ux500/crypt: add missing __iomem qualifiers
crypto: ux500: use dmaengine_device_control API
crypto: ux500: use dmaengine_prep_slave_sg API
On Fri, Jun 21, 2013 at 08:40:00AM +0530, Vinod Koul wrote:
> On Thu, Jun 20, 2013 at 11:17:39AM +0200, Fabio Baltieri wrote:
> > Fix sparse warnings:
> >
> > drivers/dma/ste_dma40.c:81:26: warning: symbol 'dma40_memcpy_conf_phy' was
> > not declared.
Fix sparse warnings:
drivers/dma/ste_dma40.c:81:26: warning: symbol 'dma40_memcpy_conf_phy' was not
declared. Should it be static?
drivers/dma/ste_dma40.c:95:26: warning: symbol 'dma40_memcpy_conf_log' was not
declared. Should it be static?
Signed-off-by: Fabio Baltieri
--
may be useful to detect some fault condition
too... Is there a specific reasion to use the output register instead?
Thanks,
Fabio
> if (ret < 0) {
> dev_err(pct->dev, "%s failed\n", __func__);
> return ret;
> --
> 1.7.10
>
--
Fabio Baltieri
done in other conditions in the same 'switch', it may make
sense to have a patch just for that.
Thanks,
Fabio
> /*
>* if argument = 1 set the pull up
>* else clear the pull up
> @@ -1030,8 +1051,6 @@ static int abx500_pin
ring(np, "ste,function", &function);
> + if (ret >= 0)
> + reserve = 1;
> +
> + ret = pinconf_generic_parse_dt_config(np, &configs, &nconfigs);
> + if (nconfigs)
> + has_config = 1;
> +
> + np_config = of_parse_phandle(np, "
On Mon, Jun 17, 2013 at 05:42:48PM +0200, Linus Walleij wrote:
> On Thu, Jun 13, 2013 at 3:56 PM, Fabio Baltieri
> wrote:
>
> > Set coherent_dma_mask to DMA_BIT_MASK(32) for dma40 platform_device, as
> > without this DMA allocations were failing with the error:
> >
e]
drivers/spi/spi-pl022.c: In function 'pl022_resume_resources':
drivers/spi/spi-pl022.c:2334:6: warning: unused variable 'ret'
[-Wunused-variable]
introduced in:
f1c9cf0 spi: pl022: use pinctrl PM helpers
Signed-off-by: Fabio Baltieri
---
Hi Linus,
this is just a quick build wa
Add necessary code to restart ux500 based machines using
prcmu_system_reset().
Signed-off-by: Fabio Baltieri
---
Hi Linus,
this is something I had in my tree for some time. This adds basic
soft-reboot support for all ux500 machines using prcmu (the actual
reboot code was already there) and
Set coherent_dma_mask to DMA_BIT_MASK(32) for dma40 platform_device, as
without this DMA allocations were failing with the error:
dma40 dma40.0: coherent DMA mask is unset
when booting without device-tree.
Signed-off-by: Fabio Baltieri
---
Hi Linus, Lee,
I found this while removing the last
Add a field with the tx/rx register address to the DMA parameters
structure, and set it to the correct address during device
initialization.
This address used to be hardcoded in the DMA controller driver, it now
needs to be explicitly figured out by the device driver.
Signed-off-by: Fabio
Implement a DMA slave config prepare routine, as until now the MSP
driver depended on the DMA controller completing the channel
configuration on its own, but this is not the case anymore since the
recent DMA driver updates.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_pcm.c | 30
Move struct ux500_msp_dma_params declaration from ux500_msp_i2s_drvdata
to ux500_msp, this saves some confusing pointer passing and allows to
access all DMA configuration fields from ux500_msp_i2s.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_dai.c | 11 ---
sound/soc
to make it work with the current
dma40 implementation, and works fine even when booting with device-tree.
Would you consider merging these for asoc/topic/ux500?
Thanks,
Fabio
Fabio Baltieri (3):
ASoC: ux500: Move DMA parameters into ux500_msp
ASoC: ux500: Set DMA address during device i
On Tue, Jun 04, 2013 at 11:03:41AM +0200, Linus Walleij wrote:
> On Thu, May 30, 2013 at 3:27 PM, Fabio Baltieri
> wrote:
>
> > Ux500 ASoC driver is expected to have a specific device name to get
> > clock resources correctly. This patch provides the necessary
> >
Fix typo of VAMIC2 LDO regulator name in some DT-related files. This
patch replaces all occurrences with the right name.
Signed-off-by: Fabio Baltieri
---
arch/arm/boot/dts/dbx5x0.dtsi | 4 ++--
arch/arm/boot/dts/href.dtsi | 2 +-
arch/arm/boot/dts/hrefv60plus.dts | 2 +-
arch/arm
Ux500 ASoC driver is expected to have a specific device name to get
clock resources correctly. This patch provides the necessary
OF_DEV_AUXDATA to match the name in DT and non-DT cases.
Signed-off-by: Fabio Baltieri
---
arch/arm/mach-ux500/cpu-db8500.c | 2 ++
1 file changed, 2 insertions
Add of_compatible string to the ab8500-codec cell to allow the driver to
grab handlers such as regulators from device-tree when available.
Signed-off-by: Fabio Baltieri
---
drivers/mfd/ab8500-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd
Add regulator DT bindings for the ab8500-codec driver.
Signed-off-by: Fabio Baltieri
---
arch/arm/boot/dts/dbx5x0.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index d0b6e32..8e14042 100644
--- a/arch/arm/boot/dts
Fix VAMIC1 LDO comment in DT files to be make it coherent with the
others.
Signed-off-by: Fabio Baltieri
---
arch/arm/boot/dts/dbx5x0.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index b6bc4ff..e6ea7ba
safely go
through arm-soc, as there are no build dependencies or regression issues
in general.
Thanks,
Fabio
Fabio Baltieri (5):
ARM: ux500: Fix trivial typo in v-anamic1 comment
ARM: ux500: Correct anamic2 typo in DT files
ARM: ux500: Add DT regulators for ab8500-codec
ARM: ux500: Provide
the two device are
configure consistently. The check is added at machine driver level, as
how to lock DAI configuration depend of the actual hardware
implementation.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/mop500_ab8500.c | 35 +++
1 file changed, 35
On Mon, May 27, 2013 at 01:44:38PM +0200, Linus Walleij wrote:
> On Fri, May 24, 2013 at 3:28 PM, Fabio Baltieri
> wrote:
>
> > Enable ux500 specific ALSA SoC drivers by default on u8500_defconfig.
> >
> > Signed-off-by: Fabio Baltieri
>
> Thanks, patch applied
Enable ux500 specific ALSA SoC drivers by default on u8500_defconfig.
Signed-off-by: Fabio Baltieri
---
Hi Linus,
As I noticed that you just updated your ux500-defconfig branch, and the ux500
sound driver should be working fine in the next kernel, I'm sending a patch to
enable it by de
Drop struct i2s_controller from the ux500 ASoC driver as right now it is
instantiated but not used anywhere. Also drop a mismatched
device_unregister in the process.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_i2s.c | 19 ---
sound/soc/ux500/ux500_msp_i2s.h | 12
Define ab8500 codec operations structure on its own rather than inline
with snd_soc_dai_drivers to clean up the code and make the style
coherent with other codec drivers.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 19 +++
1 file changed, 7 insertions
-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_i2s.c | 56 ++---
sound/soc/ux500/ux500_msp_i2s.h | 6 -
2 files changed, 2 insertions(+), 60 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index f2db6c9
Ux500 has two equivalent enum for device id, one in platform_data and
one in a local header. Fix this by dropping the local one.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_i2s.h | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/sound/soc/ux500
Add a missing include that was resulting in some sparse warning for
non-static structure without forward declaration.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/mop500_ab8500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/ux500/mop500_ab8500.c b/sound/soc/ux500
Drop unused fields and structures from ux500_msp_i2s header file, as
those looks like leftover from a previous implementation of the driver.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_dai.h | 2 --
sound/soc/ux500/ux500_msp_i2s.h | 31 ---
2 files
bunch of sparse fixes and generic code cleanup and
dead code removal.
Thanks,
Fabio
Fabio Baltieri (6):
ASoC: ux500: Drop pinctrl sleep support
ASoC: ab8500-codec: Move codec ops on a separate structure
ASoC: ux500: Drop dangling struct i2s_controller
ASoC: ux500: Drop unused code from msp
Replace hard coded rx slot numbers from ab8500_codec_set_dai_tdm_slot
using the ones requested by the machine driver in rx_mask instead.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 29 -
sound/soc/codecs/ab8500-codec.h | 35
Replace hard-coded tx slot numbers from ab8500_codec_set_dai_tdm_slot
using the ones requested by the machine driver in tx_mask instead.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 31 +++
sound/soc/codecs/ab8500-codec.h | 7 +++
2 files
helping me figuring out the weird ab8500 slot
mapping logic.
Fabio
Fabio Baltieri (2):
ASoC: ab8500-codec: Set tx dai slots from tx_mask
ASoC: ab8500-codec: Set rx dai slots from rx_mask
sound/soc/codecs/ab8500-codec.c | 60 ++---
sound/soc/codecs/ab8500
Hi Samuel,
On Tue, May 21, 2013 at 10:56:50AM +0200, Samuel Ortiz wrote:
> Hi Fabio,
>
> On Fri, May 17, 2013 at 09:51:40AM +0200, Fabio Baltieri wrote:
> > Hello Samuel,
> >
> > On Fri, May 17, 2013 at 12:43:37AM +0200, Samuel Ortiz wrote:
> > > > Fabio
On Fri, May 17, 2013 at 10:25:10AM +0200, Linus Walleij wrote:
> On Fri, May 17, 2013 at 9:51 AM, Fabio Baltieri
> wrote:
> > Hello Samuel,
> (...)
> > The last two:
> >
> > mfd: ab8500-sysctrl: Set sysctrl_dev during probe
> > mfd: ab8500-sysctrl
On Wed, May 15, 2013 at 09:35:17PM +0200, Linus Walleij wrote:
> On Wed, May 8, 2013 at 11:09 AM, Fabio Baltieri
> wrote:
>
> > Update MSP1 pinctrl definitions in mop500_family_pinmap by removing
> > sleep state and setting default ones as pin hogs, as those are used by
>
Hello Samuel,
On Fri, May 17, 2013 at 12:43:37AM +0200, Samuel Ortiz wrote:
> > Fabio Baltieri (5):
> > mfd: abx500-core: Fix sparse warning
> > mfd: ab8500-sysctrl: Fix sparse warning
> > mfd: ab8500-sysctrl: Set sysctrl_dev during probe
> >
sh the burden from
> > platform data. This also removes quite a bit of complexity from the driver
> > and will aid us when we come to enable the driver for Device Tree.
> >
> > Cc: Felipe Balbi
> > Cc: linux-...@vger.kernel.org
> > Acked-by: Linus Walleij
> > Ac
Add support for the ab8540 variant of the ab8500 family.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Cc: Avinash Kumar
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 297 ++-
1 file changed, 294 insertions(+), 3 deletions
Add support for the ab9540 variant of the ab8500 family.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Cc: Avinash Kumar
Cc: Thirupathi Chippakurthy
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 213 +++
1 file changed, 213
Introduce a "flags" field in "struct ab8500_usb" to allow controlling
driver features and quirks depending on ab8500 chip variant and
revision.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/ph
Move each chip's PHY tuning value set code to a separate function to
improve code readability.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 161 +--
1 file changed, 86 inser
Add an initial platform_device_id table to the ab8500-usb driver to
allow probing additional variants of the ab8500 family chips.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 10 --
1 file changed, 8 insertions
check.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
index bbe51cc..d105cce 100644
Acked-by: Maxime Coquelin
Signed-off-by: Sakethram Bommisetti
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
index cc0d7e5
From: Mian Yousaf Kaukab
Add common clock support code for the ab8500-usb phy driver.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Mian Yousaf Kaukab
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 14 ++
1 file changed, 14 insertions
Various non functional coding style fixes on ux500_dma.c and
phy-ab8500-usb.c drivers.
Acked-by: Linus Walleij
Acked-by: Maxime Coquelin
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500_dma.c | 6 +++---
drivers/usb/phy/phy-ab8500-usb.c | 9 +
2 files changed, 8 insertions
coding style fixes, a patch to enable dma
support in host mode and a small workaround.
These are based on v3.10-rc1, and should merge fine with Lee's dma
patches on ux500-musb. I hope that you could review and take these for
your -next branch.
Thanks,
Fabio
Fabio Baltieri (7):
usb: musb: va
From: Mian Yousaf Kaukab
Host side dma support for ux500 is enabled by piggybacking on Inventra
dma support.
Acked-by: Linus Walleij
Signed-off-by: Mian Yousaf Kaukab
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/musb_host.c | 8
1 file changed, 4 insertions(+), 4 deletions
On Thu, May 09, 2013 at 10:41:03AM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 05:48:05PM +0200, Fabio Baltieri wrote:
> > On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote:
>
> > > So if these pins are being shared between the instances then surely
the necessary cleanup code in the driver's remove
function.
Signed-off-by: Fabio Baltieri
---
drivers/mfd/ab8500-sysctrl.c | 6 +-
include/linux/mfd/abx500/ab8500.h | 2 --
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/a
On Wed, May 08, 2013 at 11:56:54AM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 09:14:21AM +0200, Fabio Baltieri wrote:
> > Set AD_OUT1 and AD_OUT2, corresponding to LINL and LINR pins, as the
> > default input slots for the capture interfaces.
>
> If these are rout
On Wed, May 08, 2013 at 12:01:49PM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote:
> > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
> > the actual one used by STE. Also update a wrong comment in the process.
On Wed, May 08, 2013 at 03:29:38PM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote:
> > On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote:
>
> > > But why does the rest of the code work well if the reference counting is
>
On Wed, May 08, 2013 at 04:17:23PM +0200, Fabio Baltieri wrote:
> > > If I understood the problem correctly you do that when you want to cut
> > > power completely to some peripherals to avoid spurious current paths,
> > > and that should not be the case for the audi
On Wed, May 08, 2013 at 02:54:13PM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 03:10:20PM +0200, Fabio Baltieri wrote:
> > On Wed, May 08, 2013 at 01:32:25PM +0100, Mark Brown wrote:
>
> > > I'm saying that if functions like enable_msp() don't work reliably t
On Wed, May 08, 2013 at 01:32:25PM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 01:42:16PM +0200, Fabio Baltieri wrote:
> > On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote:
>
> > > I tend to agree with Lee that this looks like a bad approach - there's a
On Wed, May 08, 2013 at 11:34:01AM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 10:39:14AM +0200, Fabio Baltieri wrote:
> > As enable_msp gets called only after some audio data has been received,
> > if the userspace closes the device before sending any data it causes
> >
On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote:
> On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote:
> > Drop pinctrl default/sleep state switching code, as it was breaking the
> > capture interface by putting the I2S pins in hi-z mode regardless of its
&
On Wed, May 08, 2013 at 12:11:10PM +0100, Lee Jones wrote:
> On Wed, 08 May 2013, Mark Brown wrote:
>
> > On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote:
> > > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
> > > the actual o
Update MSP1 pinctrl definitions in mop500_family_pinmap by removing
sleep state and setting default ones as pin hogs, as those are used by
both ux500-msp-i2s.1 and ux500-msp-i2s.3.
Signed-off-by: Fabio Baltieri
---
arch/arm/mach-ux500/board-mop500-pins.c | 17 ++---
1 file changed
On Wed, May 08, 2013 at 09:48:46AM +0100, Lee Jones wrote:
> On Wed, 08 May 2013, Fabio Baltieri wrote:
>
> > On Wed, May 08, 2013 at 09:07:08AM +0100, Lee Jones wrote:
> > > On Wed, 08 May 2013, Fabio Baltieri wrote:
> > >
> > > > Drop pinctrl def
to decrementing the pinctrl usage counter (pinctrl_rxtx_ref) below zero.
To prevent this from happening add a condition to skip register and
pinctrl clear if current msp state is already MSP_STATE_IDLE.
Acked-by: Lee Jones
Signed-off-by: Fabio Baltieri
---
Changes from v1:
- fix grammatical
, 12
> > + "tristate", 13
> > + "tristate", 14
> > "tristate"}; 15
>
>
> --
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, May 08, 2013 at 09:07:08AM +0100, Lee Jones wrote:
> On Wed, 08 May 2013, Fabio Baltieri wrote:
>
> > Drop pinctrl default/sleep state switching code, as it was breaking the
> > capture interface by putting the I2S pins in hi-z mode regardless of its
> > usage st
AD slots definitions for ab8500 codec were erroneously swapped between
even and odd channels. Fix this by swapping the definitions to be
coherent with the channel number.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.h | 36 ++--
1 file changed
Set AD_OUT1 and AD_OUT2, corresponding to LINL and LINR pins, as the
default input slots for the capture interfaces.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/ab8500
Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
the actual one used by STE. Also update a wrong comment in the process.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 20 ++--
sound/soc/ux500/mop500_ab8500.c | 4 ++--
2 files changed
-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_i2s.c | 56 ++---
sound/soc/ux500/ux500_msp_i2s.h | 6 -
2 files changed, 2 insertions(+), 60 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 964cfd6
to decrementing the pinctrl usage counter (pinctrl_rxtx_ref) below zero.
To prevent this from happening add a condition to skip register and
pinctrl clear if current msp state is already MSP_STATE_IDLE.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/ux500_msp_i2s.c | 2 +-
1 file changed, 1
o declare those pin as a hog.
Patches 4 to 6 fixes some weirdness with time slot usage. After this
series the driver seems to work fine for both capture and playback
interface (tested on a snowball v11).
Thanks,
Fabio
Fabio Baltieri (6):
ASoC: ab8500-codec: Add missing ad_to_slot definitions
allows alsamixer to properly display the default
configuration, as all controls are set to tristate (=12) at reset.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500
audio playback and provide a
> Tested-by?
Sure, I applied just this patch and it still works fine, tested on HREF
with speaker-test.
I have another non-related hack on dmaengine applied though, but Lee is
already aware of it so this is good for me:
Tested-by: Fabio Baltieri
Thanks,
Fabio
--
Fa
On Fri, May 03, 2013 at 10:54:09AM +0200, Ulf Hansson wrote:
> On 3 May 2013 10:51, Ulf Hansson wrote:
> > On 30 April 2013 14:45, Fabio Baltieri wrote:
> >> Fix clk_reg_sysctrl() to set main clock registers of new struct
> >> clk_sysctrl even if the regi
Drop ab8500 clock gating widgets from mop500_ab8500_ctrls, as these bits
are already controlled by ab8500 codec driver and should not be exposed
to the user.
Signed-off-by: Fabio Baltieri
---
Was: ASoC: ux500: move clock controls to ab8500-codec
Changes from v1:
- rewrote the patch to just
On Thu, May 02, 2013 at 09:54:21AM +0200, Fabio Baltieri wrote:
> On Tue, Apr 30, 2013 at 07:30:35PM +0100, Mark Brown wrote:
> > On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote:
> > > Move ab8500 clock control definitions to the ab8500 codec driver,
> > >
On Tue, Apr 30, 2013 at 07:30:35PM +0100, Mark Brown wrote:
> On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote:
> > Move ab8500 clock control definitions to the ab8500 codec driver,
> > leaving only card specific setting in mop500_ab8500_ctrls.
>
> So, if this
Update mop500_ab8500_machine_init to register mop500_ab8500_ctrls as
card control instead of codec control, as it only contains
SOC_DAPM_PIN_SWITCH definitions.
Signed-off-by: Fabio Baltieri
---
sound/soc/ux500/mop500_ab8500.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
Move ab8500 clock control definitions to the ab8500 codec driver,
leaving only card specific setting in mop500_ab8500_ctrls.
Signed-off-by: Fabio Baltieri
---
sound/soc/codecs/ab8500-codec.c | 10 ++
sound/soc/ux500/mop500_ab8500.c | 10 --
2 files changed, 10 insertions(+), 10
Update dapm_clock_event to use clk_prepare_enable and
clk_disable_unprepare.
Signed-off-by: Fabio Baltieri
---
sound/soc/soc-dapm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 21779a6..a80c883 100644
--- a/sound/soc
sort out a mixup of card and codec controls in
mop500_ab8500.
Thanks,
Fabio
Fabio Baltieri (3):
ASoC: dapm: use clk_prepare_enable and clk_disable_unprepare
ASoC: ux500: move clock controls to ab8500-codec
ASoC: ux500: register controls to card instead of codec
sound/soc/codecs/ab8500-co
Fix clk_reg_sysctrl() to set main clock registers of new struct
clk_sysctrl even if the registered clock has no parents.
This fixes an issue where "ulpclk" was registered with all clk->reg_*
fields uninitialized, causing a -EINVAL error from clk_prepare().
Cc: Ulf Hansson
Signed-
Hi Lee,
On Tue, Apr 23, 2013 at 04:03:04PM +0100, Lee Jones wrote:
> In this patch-set we firstly ease the burden on data being passed from
> platform data, then start to build up support to finally enable Device
> Tree.
The whole series looks good to me, nice job!!
Acked-by: Fabio Bal
A check for a valid plat->sysctrl was introduced in:
2377e52 mfd: ab8500-sysctrl: Error check clean up
but the driver works just fine even without that initialization data.
This patch removes the check and let the driver go ahead with probe.
Signed-off-by: Fabio Baltieri
---
drivers/
The driver requires sysctrl_dev to be set at probe, as it's used by
other driver functions. This was dropped by mistake in:
2377e52 mfd: ab8500-sysctrl: Error check clean up
making all driver functions fail.
Signed-off-by: Fabio Baltieri
---
drivers/mfd/ab8500-sysctrl.c | 2 ++
1
1 - 100 of 332 matches
Mail list logo
