Re: [PATCH] usb: dwc3: Fix the USB 3.0 hub detection bug after warm boot

Hi, gustavo panizzo writes: >>> On Wed, Jul 12, 2017 at 02:08:04PM +0800, Baolin Wang wrote: Hi, On 12 July 2017 at 11:52, gustavo panizzo wrote: > > The dwc3 could not release resources when the module is built-in > because this module does not have shutdown

Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Lu Baolu writes: > +static void xhci_dbc_stop(struct xhci_hcd *xhci) > +{ > + struct xhci_dbc *dbc = xhci->dbc; > + > + WARN_ON(!dbc); > + > + cancel_delayed_work_sync(>event_work); > + > + if (dbc->gs_port_num != GSPORT_INVAL) { > +

Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Lu Baolu writes: > +static void xhci_dbc_stop(struct xhci_hcd *xhci) > +{ > + struct xhci_dbc *dbc = xhci->dbc; > + > + WARN_ON(!dbc); > + > + cancel_delayed_work_sync(>event_work); > + > + if (dbc->gs_port_num != GSPORT_INVAL) { > +

RE: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

(No top-posting!) "He, Bo" writes: > The patch I submitted is based on the latest kernel, > I checked the latest kernel has the same logic, > so I send the patch to LKML. but you haven't reproduced the bug on latest kernel, have you? Can you send me tracepoint output of one

RE: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

(No top-posting!) "He, Bo" writes: > The patch I submitted is based on the latest kernel, > I checked the latest kernel has the same logic, > so I send the patch to LKML. but you haven't reproduced the bug on latest kernel, have you? Can you send me tracepoint output of one test run

RE: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, (please don't top-post and also break your lines at 80-columns ;-) "He, Bo" writes: > 1. the issue reproduced very rarely, we run reboot test > reproduce the issue, it reproduced two times on two board after > more than 1500 cycles reboot. That's fine,

RE: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, (please don't top-post and also break your lines at 80-columns ;-) "He, Bo" writes: > 1. the issue reproduced very rarely, we run reboot test > reproduce the issue, it reproduced two times on two board after > more than 1500 cycles reboot. That's fine, we, somehow, got a

Re: [PATCH] usb: Convert to using %pOF instead of full_name

el.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: linux-...@vger.kernel.org is this going through your tree? Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: Convert to using %pOF instead of full_name

Hi, Rob Herring writes: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Feli

Re: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, "He, Bo" writes: > the patch is for fix the below kernel panic: > BUG: unable to handle kernel NULL pointer dereference at 002a > IP: [] composite_setup+0x3d/0x1830 > PGD 27525b067 PUD 27525a067 PMD 0 > Oops: 0002 [#1] PREEMPT SMP > Call Trace: > [] ?

Re: [PATCH] usb: gadget: udc: fix the kernel NULL pointer in composite_setup

Hi, "He, Bo" writes: > the patch is for fix the below kernel panic: > BUG: unable to handle kernel NULL pointer dereference at 002a > IP: [] composite_setup+0x3d/0x1830 > PGD 27525b067 PUD 27525a067 PMD 0 > Oops: 0002 [#1] PREEMPT SMP > Call Trace: > [] ? dwc3_trace+0x52/0x60 > []

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Pratyush Anand <pan...@redhat.com> writes: > Hi Felipe, > > On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote: >> +static void notrace ftrace_write(struct trace_export *ftrace, const void >> *buf, >> + unsigned int len

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Pratyush Anand writes: > Hi Felipe, > > On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote: >> +static void notrace ftrace_write(struct trace_export *ftrace, const void >> *buf, >> + unsigned int len) >> +{ >> +

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Pratyush Anand <pan...@redhat.com> writes: > On Friday 09 June 2017 03:58 PM, Felipe Balbi wrote: >> Felipe Balbi <felipe.ba...@linux.intel.com> writes: >> >>> Allow for ftrace data to be exported over a USB Gadget >>> Controller. Wi

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Pratyush Anand writes: > On Friday 09 June 2017 03:58 PM, Felipe Balbi wrote: >> Felipe Balbi writes: >> >>> Allow for ftrace data to be exported over a USB Gadget >>> Controller. With this, we have a potentially very fast pipe for >>> transmi

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decod

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Felipe Balbi writes: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decode the data, one needs access to k

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: >> Minas Harutyunyan writes: >>> USB CV driver stack doesn't perform USB RESET after device disconnect/ >>> connect, so need to reset to zero DEVADDR field in DCFG to pass >>> enumeration again. >>>

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: >> Minas Harutyunyan writes: >>> USB CV driver stack doesn't perform USB RESET after device disconnect/ >>> connect, so need to reset to zero DEVADDR field in DCFG to pass >>> enumeration again. >>> >>> Signed-off-by: Minas Harutyunyan >>> --- >>>

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: >>> Minas Harutyunyan writes: USB CV driver stack doesn't perform USB RESET after device disconnect/ connect, so need to reset to zero DEVADDR field in DCFG to pass enumeration again.

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: >>> Minas Harutyunyan writes: USB CV driver stack doesn't perform USB RESET after device disconnect/ connect, so need to reset to zero DEVADDR field in DCFG to pass enumeration again. Signed-off-by: Minas Harutyunyan ---

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi again, Felipe Balbi <ba...@kernel.org> writes: > Hi, > > Minas Harutyunyan <minas.harutyun...@synopsys.com> writes: >> USB CV driver stack doesn't perform USB RESET after device disconnect/ >> connect, so need to reset to zero DEVADDR field in DCFG to pass &

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi again, Felipe Balbi writes: > Hi, > > Minas Harutyunyan writes: >> USB CV driver stack doesn't perform USB RESET after device disconnect/ >> connect, so need to reset to zero DEVADDR field in DCFG to pass >> enumeration again. >> >> Signed-off-by: Mi

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: > USB CV driver stack doesn't perform USB RESET after device disconnect/ > connect, so need to reset to zero DEVADDR field in DCFG to pass > enumeration again. > > Signed-off-by: Minas Harutyunyan > --- >

Re: [PATCH] usb: dwc2: gadget: On disconnect reset device address to zero

Hi, Minas Harutyunyan writes: > USB CV driver stack doesn't perform USB RESET after device disconnect/ > connect, so need to reset to zero DEVADDR field in DCFG to pass > enumeration again. > > Signed-off-by: Minas Harutyunyan > --- > drivers/usb/dwc2/gadget.c | 3 +++ > 1 file changed, 3

Re: [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers

Hi, Minas Harutyunyan writes: > It's reverting patch for commit "usb: dwc2: gadget: > use ep->fifo_index in context of FIFO registers". > DTXFSTSn indexation based on EP number not TxFIFO number. > > Signed-off-by: Minas Harutyunyan have a

Re: [PATCH] usb: dwc2: gadget: Use ep->index in conext of FIFO registers

Hi, Minas Harutyunyan writes: > It's reverting patch for commit "usb: dwc2: gadget: > use ep->fifo_index in context of FIFO registers". > DTXFSTSn indexation based on EP number not TxFIFO number. > > Signed-off-by: Minas Harutyunyan have a look at 'git revert' -- balbi signature.asc

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, kbuild test robot writes: > Hi Felipe, > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.12-rc4 next-20170609] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] this patch depends on another

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, kbuild test robot writes: > Hi Felipe, > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.12-rc4 next-20170609] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] this patch depends on another patch [1] in order

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Steven Rostedt <rost...@goodmis.org> writes: > On Fri, 9 Jun 2017 09:13:27 +0300 > Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pip

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Hi, Steven Rostedt writes: > On Fri, 9 Jun 2017 09:13:27 +0300 > Felipe Balbi wrote: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pipe for >> transmitting ftrace data to a Host PC for fu

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Felipe Balbi <felipe.ba...@linux.intel.com> writes: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pipe for >> transmitting ftrace da

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Felipe Balbi writes: > Felipe Balbi writes: > >> Allow for ftrace data to be exported over a USB Gadget >> Controller. With this, we have a potentially very fast pipe for >> transmitting ftrace data to a Host PC for further analysis. >> >> Note that in order

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decode the d

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

Felipe Balbi writes: > Allow for ftrace data to be exported over a USB Gadget > Controller. With this, we have a potentially very fast pipe for > transmitting ftrace data to a Host PC for further analysis. > > Note that in order to decode the data, one needs access to kernel >

[PATCH] usb: gadget: functions: add ftrace export over USB

into function names and what not. Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- I wanted to take this through the gadget tree, but there is a dependency with a previous patch of mine adding and extra argument to the ->write() function. Hoping someone else will take it. drivers/u

[PATCH] usb: gadget: functions: add ftrace export over USB

into function names and what not. Signed-off-by: Felipe Balbi --- I wanted to take this through the gadget tree, but there is a dependency with a previous patch of mine adding and extra argument to the ->write() function. Hoping someone else will take it. drivers/usb/gadget/Kconfig|

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Greg KH writes: >> > I'm OK with dropping legacy f_uac1 implementation. >> > >> > Another idea I was thinking about is to implement simple in-kernel >> > driver which will do the same as existing alsaloop tool userspace >> > tool does (so legacy users will need

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Greg KH writes: >> > I'm OK with dropping legacy f_uac1 implementation. >> > >> > Another idea I was thinking about is to implement simple in-kernel >> > driver which will do the same as existing alsaloop tool userspace >> > tool does (so legacy users will need to load two kernel modules >>

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Ruslan Bilovol writes: >> Ruslan Bilovol writes: >>> I came to this patch series when wanted to do two things: >>> - use UAC1 as virtual ALSA sound card on gadget side, >>>just like UAC2 is used so it's possible to do rate >>>

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Ruslan Bilovol writes: >> Ruslan Bilovol writes: >>> I came to this patch series when wanted to do two things: >>> - use UAC1 as virtual ALSA sound card on gadget side, >>>just like UAC2 is used so it's possible to do rate >>>resampling >>> - have both playback/capture support in

Re: Ftrace Data Export

Hi, Chunyan Zhang writes: >> Maybe that's why they consider it an extra overhead? Have you considered >> off-loading raw data for further post processing? > > Yes, that's also the way off-loading function trace has been implemented now. > And like you said below, I

Re: Ftrace Data Export

Hi, Chunyan Zhang writes: >> Maybe that's why they consider it an extra overhead? Have you considered >> off-loading raw data for further post processing? > > Yes, that's also the way off-loading function trace has been implemented now. > And like you said below, I also believe we can do the

Re: Ftrace Data Export

Hi, (sorry for the long delay, just back from vacations) Chunyan Zhang <zhang.chun...@linaro.org> writes: > Hi Felipe, > > On 17 May 2017 at 16:08, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: >> >> Hi Chunyan, >> >> When you wrote your pa

Re: Ftrace Data Export

Hi, (sorry for the long delay, just back from vacations) Chunyan Zhang writes: > Hi Felipe, > > On 17 May 2017 at 16:08, Felipe Balbi wrote: >> >> Hi Chunyan, >> >> When you wrote your patchset to provide ftrace exports, why did you >> choose to export o

[PATCH v2] kernel: trace: pass export pointer as argument to ->write()

That way, users don't need to keep a global static pointer and can rely on container_of() to fetch their own structure. Acked-by: Steven Rostedt (VMware) <rost...@goodmis.org> Reviewed-by: Chunyan Zhang <zhang.chun...@linaro.org> Signed-off-by: Felipe Balbi <felipe.ba...@

[PATCH v2] kernel: trace: pass export pointer as argument to ->write()

That way, users don't need to keep a global static pointer and can rely on container_of() to fetch their own structure. Acked-by: Steven Rostedt (VMware) Reviewed-by: Chunyan Zhang Signed-off-by: Felipe Balbi --- Changes since v1: - add missing & operator drivers/hwtracing

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

url: > https://github.com/0day-ci/linux/commits/Felipe-Balbi/kernel-trace-pass-export-pointer-as-argument-to-write/20170518-135452 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

://github.com/0day-ci/linux/commits/Felipe-Balbi/kernel-trace-pass-export-pointer-as-argument-to-write/20170518-135452 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree &

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> Jerry Huang writes: >> >> >> -- >> >> >> 1.7.9.5 >> >> > Hi, Balbi and all guys, >> >> > Any comment for these patches? Can they be accepted? >> >> >> >> Rob had comments which you didn't reply yet. I cannot take this >> >>

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> Jerry Huang writes: >> >> >> -- >> >> >> 1.7.9.5 >> >> > Hi, Balbi and all guys, >> >> > Any comment for these patches? Can they be accepted? >> >> >> >> Rob had comments which you didn't reply yet. I cannot take this >> >> patchset yet ;-) >> >> >> > Balbi, >> > >>

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Ruslan Bilovol writes: > I came to this patch series when wanted to do two things: > - use UAC1 as virtual ALSA sound card on gadget side, >just like UAC2 is used so it's possible to do rate >resampling > - have both playback/capture support in UAC1 > >

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

Hi, Ruslan Bilovol writes: > I came to this patch series when wanted to do two things: > - use UAC1 as virtual ALSA sound card on gadget side, >just like UAC2 is used so it's possible to do rate >resampling > - have both playback/capture support in UAC1 > > Since I wanted to have same

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

Hi, Ruslan Bilovol writes: > Abstract the peripheral side ALSA sound card code from > the f_uac2 function into a component that can be called > by various functions, so the various flavors can be split > apart and selectively reused. > > Visible changes: > - add

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

Hi, Ruslan Bilovol writes: > Abstract the peripheral side ALSA sound card code from > the f_uac2 function into a component that can be called > by various functions, so the various flavors can be split > apart and selectively reused. > > Visible changes: > - add uac_params structure to pass

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Stefan Agner writes: > Hi Felipe, > > On 2017-04-19 01:53, Krzysztof Opasiak wrote: >> On 04/15/2017 03:35 AM, Stefan Agner wrote: >>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16 >>> when read. This isn't obvious when simply using cat since the

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Stefan Agner writes: > Hi Felipe, > > On 2017-04-19 01:53, Krzysztof Opasiak wrote: >> On 04/15/2017 03:35 AM, Stefan Agner wrote: >>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16 >>> when read. This isn't obvious when simply using cat since the null >>> characters

Re: [PATCH 9/9] [HSLPM] usb: dwc2: Enable LPM

Greg Kroah-Hartman writes: > On Fri, Apr 28, 2017 at 12:56:42PM +0400, Sevak Arakelyan wrote: >> From: John Youn >> >> Set 'lpm_capable' flag in the gadget structure so >> indicating that LPM is supported. >> >> Signed-off-by: Sevak Arakelyan

Re: [PATCH 9/9] [HSLPM] usb: dwc2: Enable LPM

Greg Kroah-Hartman writes: > On Fri, Apr 28, 2017 at 12:56:42PM +0400, Sevak Arakelyan wrote: >> From: John Youn >> >> Set 'lpm_capable' flag in the gadget structure so >> indicating that LPM is supported. >> >> Signed-off-by: Sevak Arakelyan > > No signed-off-by from John? right, I only

Re: [PATCH v2 51/53] usb: fix the comment with regards to DocBook

Mauro Carvalho Chehab writes: > The USB gadget documentation is not at DocBook anymore. > The main file was converted to ReST, and stored at > Documentation/driver-api/usb/gadget.rst, but there are > still several plain text files related to gadget under >

Re: [PATCH v2 51/53] usb: fix the comment with regards to DocBook

Mauro Carvalho Chehab writes: > The USB gadget documentation is not at DocBook anymore. > The main file was converted to ReST, and stored at > Documentation/driver-api/usb/gadget.rst, but there are > still several plain text files related to gadget under > Documentation/usb. > > So, be generic

Ftrace Data Export

Hi Chunyan, When you wrote your patchset to provide ftrace exports, why did you choose to export only function trace? Why not tracepoints, function_graph, hwlat, irqsoff and all the other possibilities? Is there an underlying reason why you chose to export only function trace? Thanks --

Ftrace Data Export

Hi Chunyan, When you wrote your patchset to provide ftrace exports, why did you choose to export only function trace? Why not tracepoints, function_graph, hwlat, irqsoff and all the other possibilities? Is there an underlying reason why you chose to export only function trace? Thanks --

[PATCH] kernel: trace: pass export pointer as argument to ->write()

That way, users don't need to keep a global static pointer and can rely on container_of() to fetch their own structure. Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- I'm working on exposing this data over a USB peripheral controller and I really can't have a global p

[PATCH] kernel: trace: pass export pointer as argument to ->write()

That way, users don't need to keep a global static pointer and can rely on container_of() to fetch their own structure. Signed-off-by: Felipe Balbi --- I'm working on exposing this data over a USB peripheral controller and I really can't have a global pointer there. drivers/hwtracing/stm

Re: [PATCH] usb: dwc3: gadget: Fix ISO transfer performance

Hi, Roger Quadros writes: > On 21/04/17 15:58, Roger Quadros wrote: >> Commit 08a36b543803 ("usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()") >> caused a small change in the way ISO transfer is handled in the case >> when XferInProgress event happens on Isoc EP with an

Re: [PATCH] usb: dwc3: gadget: Fix ISO transfer performance

Hi, Roger Quadros writes: > On 21/04/17 15:58, Roger Quadros wrote: >> Commit 08a36b543803 ("usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()") >> caused a small change in the way ISO transfer is handled in the case >> when XferInProgress event happens on Isoc EP with an active transfer. >>

Re: [usb-gadget-udc] question about null check after calling phys_to_virt() function

Hi, "Gustavo A. R. Silva" writes: > Hello everybody, > > While looking into Coverity ID 145958 I ran into the following piece > of code at drivers/usb/gadget/udc/amd5536udc.c:852: > > } else if (i == buf_len) { > /* first td */ > td = (struct

Re: [usb-gadget-udc] question about null check after calling phys_to_virt() function

Hi, "Gustavo A. R. Silva" writes: > Hello everybody, > > While looking into Coverity ID 145958 I ran into the following piece > of code at drivers/usb/gadget/udc/amd5536udc.c:852: > > } else if (i == buf_len) { > /* first td */ > td = (struct udc_data_dma *)phys_to_virt( >

Re: [PATCH v1] ACPI: Switch to use generic UUID API

gs <bske...@redhat.com> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: Joerg Roedel <j...@8bytes.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Yisen Zhuang <yisen.zhu...@huawei.com> > Cc: Bjorn Helgaas <bhelg...@googl

Re: [PATCH v1] ACPI: Switch to use generic UUID API

kinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Krogerus > Cc: Liam Girdwood > Cc: Mar

Re: [PATCH v2] usb: core: Warn if an URB's transfer_buffer is on stack

Hi, Greg Kroah-Hartman writes: > On Tue, Apr 25, 2017 at 01:35:33PM +0300, Maksim Salau wrote: >> > + } else if (object_is_on_stack(urb->transfer_buffer)) { >> > + WARN_ONCE(1, "transfer buffer is on stack\n"); >> > +

Re: [PATCH v2] usb: core: Warn if an URB's transfer_buffer is on stack

Hi, Greg Kroah-Hartman writes: > On Tue, Apr 25, 2017 at 01:35:33PM +0300, Maksim Salau wrote: >> > + } else if (object_is_on_stack(urb->transfer_buffer)) { >> > + WARN_ONCE(1, "transfer buffer is on stack\n"); >> > + ret =

Re: [PATCH] usb: typec: Don't prevent using constant typec_mode_desc initializers

Hi, Mats Karrman writes: > From 98ff2be4de83f4d4b5293bfa424c274b25400e1e Mon Sep 17 00:00:00 2001 > From: Mats Karrman > Date: Mon, 24 Apr 2017 15:21:39 +0200 > Subject: [PATCH] usb: typec: Don't prevent using constant > typec_mode_desc

Re: [PATCH] usb: typec: Don't prevent using constant typec_mode_desc initializers

Hi, Mats Karrman writes: > From 98ff2be4de83f4d4b5293bfa424c274b25400e1e Mon Sep 17 00:00:00 2001 > From: Mats Karrman > Date: Mon, 24 Apr 2017 15:21:39 +0200 > Subject: [PATCH] usb: typec: Don't prevent using constant > typec_mode_desc initializers > Unfortunately this is not how you send

Re: [PATCH] scripts: kconfig: implement a sort method

Hi, Randy Dunlap <rdun...@infradead.org> writes: > On 04/11/17 04:12, Felipe Balbi wrote: >> With a growing amount of Kernel configuration, it's >> getting ever more difficult to find anything on >> menuconfig. Because of that, implement mergesort for >> k

Re: [PATCH] scripts: kconfig: implement a sort method

Hi, Randy Dunlap writes: > On 04/11/17 04:12, Felipe Balbi wrote: >> With a growing amount of Kernel configuration, it's >> getting ever more difficult to find anything on >> menuconfig. Because of that, implement mergesort for >> kconfig to make it a little eas

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Greg KH writes: >> Here's what we have for most UDCs (net2280.c included): >> >> struct my_udc { >> struct gadget gadget; >> [...] >> }; >> >> probe() >> { >> struct my_udc *u; >> >> u =

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Greg KH writes: >> Here's what we have for most UDCs (net2280.c included): >> >> struct my_udc { >> struct gadget gadget; >> [...] >> }; >> >> probe() >> { >> struct my_udc *u; >> >> u = kzalloc(sizeof(*u),

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Greg KH <g...@kroah.com> writes: > On Tue, Apr 11, 2017 at 10:12:01AM -0400, Alan Stern wrote: >> On Tue, 11 Apr 2017, Felipe Balbi wrote: >> >> > > Oddly enough, yes. But it doesn't explain why this code doesn't blow >> > > up e

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Greg KH writes: > On Tue, Apr 11, 2017 at 10:12:01AM -0400, Alan Stern wrote: >> On Tue, 11 Apr 2017, Felipe Balbi wrote: >> >> > > Oddly enough, yes. But it doesn't explain why this code doesn't blow >> > > up every time it gets called, in its

[PATCH] scripts: kconfig: implement a sort method

With a growing amount of Kernel configuration, it's getting ever more difficult to find anything on menuconfig. Because of that, implement mergesort for kconfig to make it a little easier for anybody building kernels. Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- scripts/k

[PATCH] scripts: kconfig: implement a sort method

With a growing amount of Kernel configuration, it's getting ever more difficult to find anything on menuconfig. Because of that, implement mergesort for kconfig to make it a little easier for anybody building kernels. Signed-off-by: Felipe Balbi --- scripts/kconfig/lxdialog/menubox.c | 18

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: >> >> >> >> --- a/drivers/usb/gadget/udc/core.c >> >> >> >> +++ b/drivers/usb/gadget/udc/core.c >> >> >> >> @@ -1273,6 +1273,7 @@ void usb_del_gadget_udc(struct usb_gadget >> >> >> >> *gadget) >> >> >> >> flush_work(>work); >> >> >> >>

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: >> >> >> >> --- a/drivers/usb/gadget/udc/core.c >> >> >> >> +++ b/drivers/usb/gadget/udc/core.c >> >> >> >> @@ -1273,6 +1273,7 @@ void usb_del_gadget_udc(struct usb_gadget >> >> >> >> *gadget) >> >> >> >> flush_work(>work); >> >> >> >> device_unregister(>dev); >>

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

; >> > Cc: Dinh Nguyen <dingu...@opensource.altera.com> >> > Cc: John Youn <johny...@synopsys.com> >> > Cc: Felipe Balbi <felipe.ba...@linux.intel.com> >> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> >> >> doesn't a

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

>> > >> > This allows to return errors from devm_reset_control_get_optional and to >> > call reset_control_(de)assert unconditionally. >> > >> > Signed-off-by: Philipp Zabel >> > Cc: Dinh Nguyen >> > Cc: John Youn >> > Cc: Felipe Bal

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

is allows to return errors from devm_reset_control_get_optional and to > call reset_control_(de)assert unconditionally. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Cc: Dinh Nguyen <dingu...@opensource.altera.com> > Cc: John Youn <johny...@synopsys.com> > Cc: Felipe

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

et_optional and to > call reset_control_(de)assert unconditionally. > > Signed-off-by: Philipp Zabel > Cc: Dinh Nguyen > Cc: John Youn > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman doesn't apply to testing/next. Care to rebase and resend? Also, please Cc linux-usb ;-) -- balbi signature.asc Description: PGP signature

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern <st...@rowland.harvard.edu> writes: > On Wed, 5 Apr 2017, Felipe Balbi wrote: > >> >> >> --- a/drivers/usb/gadget/udc/core.c >> >> >> +++ b/drivers/usb/gadget/udc/core.c >> >> >> @@ -1273,6 +127

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: > On Wed, 5 Apr 2017, Felipe Balbi wrote: > >> >> >> --- a/drivers/usb/gadget/udc/core.c >> >> >> +++ b/drivers/usb/gadget/udc/core.c >> >> >> @@ -1273,6 +1273,7 @@ void usb_del_gadget_udc(struct us

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

Hi, John Stultz writes: > wrote: > On 4/4/2017 11:03 PM, John Stultz wrote: >> >> I did notice when cating the regdump file, I saw: >> dwc2 f72c.usb: Mode Mismatch

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

Hi, John Stultz writes: mailto:minas.harutyun...@synopsys.com>> wrote: > On 4/4/2017 11:03 PM, John Stultz wrote: >> >> I did notice when cating the regdump file, I saw: >> dwc2 f72c.usb: Mode Mismatch Interrupt: currently in Host mode >> twice. (You'll see it

Re: [PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup

Hi, cristian.bir...@microchip.com writes: > From: Cristian Birsan > > Minor code cleanup based on feedback received on mailinglist. > > Signed-off-by: Cristian Birsan > Acked-by: Nicolas Ferre patch 1

Re: [PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup

Hi, cristian.bir...@microchip.com writes: > From: Cristian Birsan > > Minor code cleanup based on feedback received on mailinglist. > > Signed-off-by: Cristian Birsan > Acked-by: Nicolas Ferre patch 1 applied fine, patch 2 didn't. Please rebase on testing/next -- balbi signature.asc

Re: [PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

Hi, "Gustavo A. R. Silva" writes: > Rewrite udc_free_dma_chain() function to avoid use of pointer after free. > > Addresses-Coverity-ID: 1091172 > Acked-by: Michal Nazarewicz > Reviewed-by: Greg Kroah-Hartman >

Re: [PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

Hi, "Gustavo A. R. Silva" writes: > Rewrite udc_free_dma_chain() function to avoid use of pointer after free. > > Addresses-Coverity-ID: 1091172 > Acked-by: Michal Nazarewicz > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva doesn't apply to testing/next. Care to

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: >> >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called >> >> repeatedly on the same gadget->dev structure. >> >> >> >> We need to clear the gadget->dev structure so that kobject_init() >> >> doesn't complain about already

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: >> >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called >> >> repeatedly on the same gadget->dev structure. >> >> >> >> We need to clear the gadget->dev structure so that kobject_init() >> >> doesn't complain about already initialized object. >> >> >> >>

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

Hi, Alan Stern writes: > On Mon, 3 Apr 2017, Roger Quadros wrote: > >> allow usb_del_gadget_udc() and usb add_gadget_udc() to be called >> repeatedly on the same gadget->dev structure. >> >> We need to clear the gadget->dev structure so that kobject_init() >> doesn't

<    2   3   4   5   6   7   8   9   10   11   >