Re: [PATCH v17 0/3] USB Type-C Connector class

quot; is hidden when the partner type is not > "Accessory". > > Changes since v2: > - Notification on role and alternate mode changes > - cleanups > > Changes since v1: > - Completely rewrote alternate mode support > - Patners, cables and cable plugs presented as de

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: >>> (One possible approach would be to have the setup routine return >>> different values for explicit and implicit status stages -- for >>> example, return 1 if it wants to submit an explicit status request. >>> That wouldn't be very different

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: >>> (One possible approach would be to have the setup routine return >>> different values for explicit and implicit status stages -- for >>> example, return 1 if it wants to submit an explicit status request. >>> That wouldn't be very different from the current >>>

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

Hi, Greg KH writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du &

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

Hi, Greg KH writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du & 0xff cannot be true when du

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Hi, Roger Quadros <rog...@ti.com> writes: > On 15/02/17 13:44, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rog...@ti.com> writes: >>> To avoid checkpatch warnings with new patches let's >>> start using the BIT() macro whe

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Hi, Roger Quadros writes: > On 15/02/17 13:44, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> To avoid checkpatch warnings with new patches let's >>> start using the BIT() macro wherever possible. >>> >>> Sig

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Hi, Roger Quadros writes: Why are we using sysdev to read DT property? We should be using the XHCI device (>dev) here, no? >>> >>> If I remember correctly, this is one of the cases where pdev does not >>> have a device node attached to it because it

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

Hi, Roger Quadros writes: Why are we using sysdev to read DT property? We should be using the XHCI device (>dev) here, no? >>> >>> If I remember correctly, this is one of the cases where pdev does not >>> have a device node attached to it because it was created by

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Hi, Roger Quadros writes: > To avoid checkpatch warnings with new patches let's > start using the BIT() macro wherever possible. > > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.h | 192 > +-- >

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Hi, Roger Quadros writes: > To avoid checkpatch warnings with new patches let's > start using the BIT() macro wherever possible. > > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.h | 192 > +-- > drivers/usb/dwc3/dwc3-omap.c | 48

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, Lu Baolu writes: >> Lu Baolu writes: >>> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h >>> index 1ac2cdf..c31eeaf 100644 >>> --- a/drivers/usb/host/xhci-trace.h >>> +++ b/drivers/usb/host/xhci-trace.h >>> @@

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, Lu Baolu writes: >> Lu Baolu writes: >>> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h >>> index 1ac2cdf..c31eeaf 100644 >>> --- a/drivers/usb/host/xhci-trace.h >>> +++ b/drivers/usb/host/xhci-trace.h >>> @@ -285,6 +285,96 @@ DEFINE_EVENT(xhci_log_urb,

Re: [PATCH 2/6] usb: xhci: enhance xhci_log_ctx trace events

Hi, Lu Baolu writes: > XHCI driver has defined xhci_log_ctx trace events to trace > the change of an xhci input or output context. This patch > extends the trace class of xhci_log_ctx to print out the > contents of a context block in a human readable way. > > This

Re: [PATCH 2/6] usb: xhci: enhance xhci_log_ctx trace events

Hi, Lu Baolu writes: > XHCI driver has defined xhci_log_ctx trace events to trace > the change of an xhci input or output context. This patch > extends the trace class of xhci_log_ctx to print out the > contents of a context block in a human readable way. > > This patch also adds some other

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, Lu Baolu writes: > diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h > index 1ac2cdf..c31eeaf 100644 > --- a/drivers/usb/host/xhci-trace.h > +++ b/drivers/usb/host/xhci-trace.h > @@ -285,6 +285,96 @@ DEFINE_EVENT(xhci_log_urb,

Re: [PATCH 1/6] usb: xhci: add xhci_log_cmd trace events

Hi, Lu Baolu writes: > diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h > index 1ac2cdf..c31eeaf 100644 > --- a/drivers/usb/host/xhci-trace.h > +++ b/drivers/usb/host/xhci-trace.h > @@ -285,6 +285,96 @@ DEFINE_EVENT(xhci_log_urb, xhci_urb_dequeue, > TP_ARGS(urb)

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Stefan Agner writes: >>> On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote: On 2017-02-01 08:59, Stefan Agner wrote: > On 2017-02-01 00:06, Greg KH wrote: >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >>> Currently qw_sign

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Stefan Agner writes: >>> On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote: On 2017-02-01 08:59, Stefan Agner wrote: > On 2017-02-01 00:06, Greg KH wrote: >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >>> Currently qw_sign requires UTF-8

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

Hi, Colin King writes: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with

Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

Hi, Colin King writes: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with CoverityScan, CID#114349 ("Logically dead code") > >

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Greg KH writes: > On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote: >> On 2017-02-01 08:59, Stefan Agner wrote: >> > On 2017-02-01 00:06, Greg KH wrote: >> >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >> >>> Currently qw_sign

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

Hi, Greg KH writes: > On Thu, Feb 09, 2017 at 10:04:43AM -0800, Stefan Agner wrote: >> On 2017-02-01 08:59, Stefan Agner wrote: >> > On 2017-02-01 00:06, Greg KH wrote: >> >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >> >>> Currently qw_sign requires UTF-8 character to set,

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> @@ struct dwc3 { >> enum usb_phy_interface hsphy_mode; >> >> u32 fladj; >> +/* >> + * For INCR burst type. >> + * First field: for undefined length INCR burst type enable. >> + * Second field: for

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> @@ struct dwc3 { >> enum usb_phy_interface hsphy_mode; >> >> u32 fladj; >> +/* >> + * For INCR burst type. >> + * First field: for undefined length INCR burst type enable. >> + * Second field: for INCRx burst type enable

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, Greg KH <gre...@linuxfoundation.org> writes: > On Wed, Feb 08, 2017 at 02:05:35PM +0200, Felipe Balbi wrote: >> >> Hi, >> >> "Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: >> >> "Gustavo A. R. Silva&quo

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, Greg KH writes: > On Wed, Feb 08, 2017 at 02:05:35PM +0200, Felipe Balbi wrote: >> >> Hi, >> >> "Gustavo A. R. Silva" writes: >> >> "Gustavo A. R. Silva" writes: >> >>> Add missing break in switch. >> &g

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, "Gustavo A. R. Silva" writes: >> "Gustavo A. R. Silva" writes: >>> Add missing break in switch. >>> >>> Addresses-Coverity-ID: 201385 >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>>

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, "Gustavo A. R. Silva" writes: >> "Gustavo A. R. Silva" writes: >>> Add missing break in switch. >>> >>> Addresses-Coverity-ID: 201385 >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/usb/gadget/udc/mv_udc_core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, "Gustavo A. R. Silva" writes: > Add missing break in switch. > > Addresses-Coverity-ID: 201385 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/gadget/udc/mv_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch

Hi, "Gustavo A. R. Silva" writes: > Add missing break in switch. > > Addresses-Coverity-ID: 201385 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/gadget/udc/mv_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/mv_udc_core.c >

Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line

Hi, Greg KH writes: > On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: >> Other unsigned properties return hexadecimal values, follow this >> convention when printing b_vendor_code too. Also add newlines to >> the OS Descriptor support related

Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line

Hi, Greg KH writes: > On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: >> Other unsigned properties return hexadecimal values, follow this >> convention when printing b_vendor_code too. Also add newlines to >> the OS Descriptor support related properties, like other sysfs >> files

Re: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

Hi, Cristian Birsan writes: >>> + /* It might be a little bit late to set this */ >> >> Is it too late or not? This comment is frightening... We may need some >> feedback from the USB guys here... >> > > If someone from USB can comment a bit on this

Re: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

Hi, Cristian Birsan writes: >>> + /* It might be a little bit late to set this */ >> >> Is it too late or not? This comment is frightening... We may need some >> feedback from the USB guys here... >> > > If someone from USB can comment a bit on this topic I will be grateful. it is

Re: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

-by: Cristian Birsan <cristian.bir...@microchip.com> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> But seems like we will need a fixup patch during v4.11-rc? -- balbi signature.asc Description: PGP signature

Re: [PATCH linux-next v2 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

he endpoints fifo size. All other modes contain fixed configurations optimized for different purposes. The idea is somehow similar with the approach used on musb driver. Signed-off-by: Cristian Birsan Signed-off-by: Felipe Balbi But seems like we will need a fixup patch during v4.

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Roger Quadros <rog...@ti.com> writes: > Felipe, > > On 03/01/17 14:53, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rog...@ti.com> writes: >>> Mathias & Felipe, >>> >>> On 17/11/16 17:01, Roger Quadros wrote:

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Roger Quadros writes: > Felipe, > > On 03/01/17 14:53, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> Mathias & Felipe, >>> >>> On 17/11/16 17:01, Roger Quadros wrote: >>>> Hi, &

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Alan Stern <st...@rowland.harvard.edu> writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> > The gadget driver never calls usb_ep_queue in order to receive the next >> > SETUP packet; the UDC driver takes care of SETUP handling >> > automatically

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Alan Stern writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> > The gadget driver never calls usb_ep_queue in order to receive the next >> > SETUP packet; the UDC driver takes care of SETUP handling >> > automatically. >> >> yeah, that's an

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

Hi, Richard Genoud <richard.gen...@gmail.com> writes: > On 19/01/2017 09:03, Felipe Balbi wrote: >> >> Hi, >> >> Richard Genoud <richard.gen...@gmail.com> writes: >>> Hi, >>> Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

Hi, Richard Genoud writes: > On 19/01/2017 09:03, Felipe Balbi wrote: >> >> Hi, >> >> Richard Genoud writes: >>> Hi, >>> Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit >>> paths") >>> (merged in

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

Hi, Richard Genoud writes: > Hi, > Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit paths") > (merged in 4.8), the usb ports on odroid-XU4 don't work anymore. > > [ Actually, it's commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all >

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

Hi, Richard Genoud writes: > Hi, > Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit paths") > (merged in 4.8), the usb ports on odroid-XU4 don't work anymore. > > [ Actually, it's commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all > cores"), cf below ] > > Inserting

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

Hi, Jerry Huang writes: >> >> So, I think we still need two vaue to specify INCRBrstEna and INCRx >> >> burst type. >> > Hi, Balbi, >> > It seems there is no feedback for my comment, so these patches can be >> accepted? >> >> probably not, we need to really understand

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

Hi, Jerry Huang writes: >> >> So, I think we still need two vaue to specify INCRBrstEna and INCRx >> >> burst type. >> > Hi, Balbi, >> > It seems there is no feedback for my comment, so these patches can be >> accepted? >> >> probably not, we need to really understand what information we

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: >> Baolin Wang writes: >>> When handing the SETUP packet by composite_setup(), we will release the >>> dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup >>> function, which means we

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: >> Baolin Wang writes: >>> When handing the SETUP packet by composite_setup(), we will release the >>> dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup >>> function, which means we need to delay handling the STATUS phase. >>

Re: [PATCH v3] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Jim Lin writes: > When gadget is disconnected, running sequence is like this. > . composite_disconnect > . Call trace: > usb_string_copy+0xd0/0x128 > gadget_config_name_configuration_store+0x4 > gadget_config_name_attr_store+0x40/0x50 >

Re: [PATCH v3] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Jim Lin writes: > When gadget is disconnected, running sequence is like this. > . composite_disconnect > . Call trace: > usb_string_copy+0xd0/0x128 > gadget_config_name_configuration_store+0x4 > gadget_config_name_attr_store+0x40/0x50 > configfs_write_file+0x198/0x1f4 >

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Greg KH <g...@kroah.com> writes: > On Tue, Jan 17, 2017 at 10:07:40AM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Jim Lin <ji...@nvidia.com> writes: >> > When gadget is disconnected, running sequence is like this. >> > . android_work:

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Greg KH writes: > On Tue, Jan 17, 2017 at 10:07:40AM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Jim Lin writes: >> > When gadget is disconnected, running sequence is like this. >> > . android_work: sent uevent USB_STATE=DISCONNECTED >&g

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Jim Lin writes: > When gadget is disconnected, running sequence is like this. > . android_work: sent uevent USB_STATE=DISCONNECTED I'm gonna have to ask you to try with actual mainline where there are no Android changes. -- balbi

Re: [PATCH] usb: gadget: configfs: Fix KASAN use-after-free

Hi, Jim Lin writes: > When gadget is disconnected, running sequence is like this. > . android_work: sent uevent USB_STATE=DISCONNECTED I'm gonna have to ask you to try with actual mainline where there are no Android changes. -- balbi

Re: Memory barrier needed with wake_up_process()?

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Alan Stern <st...@rowland.harvard.edu> writes: >> On Mon, 16 Jan 2017, Felipe Balbi wrote: >> >>> Sorry for the long delay, I finally have more information on this. All >>> this time I was doin

Re: Memory barrier needed with wake_up_process()?

Hi, Felipe Balbi writes: > Alan Stern writes: >> On Mon, 16 Jan 2017, Felipe Balbi wrote: >> >>> Sorry for the long delay, I finally have more information on this. All >>> this time I was doing something that I never considered to matter: I've >>> be

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Alan Stern <st...@rowland.harvard.edu> writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> >>>> Another point here is that the really robust way of fixing this is to >> >>>> get rid of USB_GADGET_DELAYED_STATUS altogether and just ma

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Alan Stern writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> >>>> Another point here is that the really robust way of fixing this is to >> >>>> get rid of USB_GADGET_DELAYED_STATUS altogether and just make sure >> >>>> ga

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern <st...@rowland.harvard.edu> writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> Sorry for the long delay, I finally have more information on this. All >> this time I was doing something that I never considered to matter: I've >> been running h

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern writes: > On Mon, 16 Jan 2017, Felipe Balbi wrote: > >> Sorry for the long delay, I finally have more information on this. All >> this time I was doing something that I never considered to matter: I've >> been running host and peripheral on the same

Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

Hi, Arnd Bergmann writes: > On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: >> Hi Arnd, >> >> On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann wrote: >> > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: >> >> The UDC is

Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

Hi, Arnd Bergmann writes: > On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: >> Hi Arnd, >> >> On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann wrote: >> > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: >> >> The UDC is based on Synopsys Designware core

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang <baolin.w...@linaro.org> writes: > Hi, > > On 16 January 2017 at 19:29, Felipe Balbi <ba...@kernel.org> wrote: >> >> Hi, >> >> Baolin Wang <baolin.w...@linaro.org> writes: >>> Hi, >>> >>> On

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > Hi, > > On 16 January 2017 at 19:29, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> Hi, >>> >>> On 16 January 2017 at 18:56, Felipe Balbi wrote: >>>> >>>> Hi, >>

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang <baolin.w...@linaro.org> writes: > Hi, > > On 16 January 2017 at 18:56, Felipe Balbi <ba...@kernel.org> wrote: >> >> Hi, >> >> Baolin Wang <baolin.w...@linaro.org> writes: >>> When handing the SETUP packet by com

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > Hi, > > On 16 January 2017 at 18:56, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> When handing the SETUP packet by composite_setup(), we will release the >>> dwc->lock. If we get the 'USB_GADGET

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, Alexandre Belloni writes: >> David Laight writes: >> > From: Alexandre Belloni >> >> Sent: 02 December 2016 16:19 >> >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> >> > From: Alexandre Belloni >> >> > > Sent: 01

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, Alexandre Belloni writes: >> David Laight writes: >> > From: Alexandre Belloni >> >> Sent: 02 December 2016 16:19 >> >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> >> > From: Alexandre Belloni >> >> > > Sent: 01 December 2016 10:27 >> >> > > Use devm_kasprintf instead of

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern <st...@rowland.harvard.edu> writes: > On Tue, 20 Sep 2016, Felipe Balbi wrote: > >> And here's trace output (complete, scroll to bottom). It seems to me >> like the thread didn't wake up at all. It didn't even try to >> execute. I'll add some mor

Re: Memory barrier needed with wake_up_process()?

Hi, Alan Stern writes: > On Tue, 20 Sep 2016, Felipe Balbi wrote: > >> And here's trace output (complete, scroll to bottom). It seems to me >> like the thread didn't wake up at all. It didn't even try to >> execute. I'll add some more traces and try to get better inf

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > When handing the SETUP packet by composite_setup(), we will release the > dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup > function, which means we need to delay handling the STATUS phase. this sentence needs a little

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

Hi, Baolin Wang writes: > When handing the SETUP packet by composite_setup(), we will release the > dwc->lock. If we get the 'USB_GADGET_DELAYED_STATUS' result from setup > function, which means we need to delay handling the STATUS phase. this sentence needs a little work. Seems like it's

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

Hi, John Youn writes: > On 1/12/2017 7:52 AM, Nicholas Mc Guire wrote: >> ulseep_range() uses hrtimers and provides no advantage over msleep() >> for larger delays. Fix up the 20+ ms delays here passing the adjusted "min" >> value to msleep(). This helps reduce the load

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

Hi, John Youn writes: > On 1/12/2017 7:52 AM, Nicholas Mc Guire wrote: >> ulseep_range() uses hrtimers and provides no advantage over msleep() >> for larger delays. Fix up the 20+ ms delays here passing the adjusted "min" >> value to msleep(). This helps reduce the load on the hrtimer

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, John Youn writes: >> Baolin Wang writes: Baolin Wang writes: > When dwc3 controller acts as host role with attaching slow speed device > (like mouse or keypad). Then if we plugged out the slow speed

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, John Youn writes: >> Baolin Wang writes: Baolin Wang writes: > When dwc3 controller acts as host role with attaching slow speed device > (like mouse or keypad). Then if we plugged out the slow speed device, > it will timeout to run the deconfiguration endpoint command to

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Chen Yu <cheny...@huawei.com> &g

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

issue by adding an extra argument to > dwc2_core_reset(), as suggested by John Youn, which allows us to > skip the waiting, which should be unnecessary when calling from > dwc2_hsotg_core_init_disconnected(). > > Cc: Wei Xu > Cc: Guodong Xu > Cc: Amit Pundir > Cc: Rob Herring

Re: [PATCH v2 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller

Hi, Sergio Prado writes: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB device controller. > > Signed-off-by: Sergio Prado without Ack from DT folks, I can't take this. -- balbi signature.asc

Re: [PATCH v2 1/2] dt-bindings: usb: add DT binding for s3c2410 USB device controller

Hi, Sergio Prado writes: > Adds the device tree bindings description for Samsung S3C2410 and > compatible USB device controller. > > Signed-off-by: Sergio Prado without Ack from DT folks, I can't take this. -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names

Hi, Shuah Khan writes: > Change goto labels to meaningful names from a series of errNs. > > Signed-off-by: Shuah Khan doesn't apply to testing/next, please rebase. -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names

Hi, Shuah Khan writes: > Change goto labels to meaningful names from a series of errNs. > > Signed-off-by: Shuah Khan doesn't apply to testing/next, please rebase. -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

i <cw00.c...@samsung.com> > Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> doesn't apply to testing/next. Please rebase -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi > Acked-by: Felipe

Re: [RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

Hi, John Stultz writes: > I just wanted to re-send my current queue of patches for dwc2 > controller on the HiKey board, as my last patchset ended up > colliding with a number of changes that landed in the 4.10-rc > merge window. > > I've fixed things up and validated

Re: [RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

Hi, John Stultz writes: > I just wanted to re-send my current queue of patches for dwc2 > controller on the HiKey board, as my last patchset ended up > colliding with a number of changes that landed in the 4.10-rc > merge window. > > I've fixed things up and validated these against HiKey. I

Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: > For some mobile devices with strict power management, we also want to suspend > the host when the slave is detached for power saving. Thus we add the host > suspend/resume functions to support this requirement. > > Signed-off-by: Baolin Wang

Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: > For some mobile devices with strict power management, we also want to suspend > the host when the slave is detached for power saving. Thus we add the host > suspend/resume functions to support this requirement. > > Signed-off-by: Baolin Wang > --- > Changes since v4:

RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, David Laight writes: > From: Alexandre Belloni >> Sent: 02 December 2016 16:19 >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> > From: Alexandre Belloni >> > > Sent: 01 December 2016 10:27 >> > > Use devm_kasprintf instead of simple kasprintf to free the

RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

Hi, David Laight writes: > From: Alexandre Belloni >> Sent: 02 December 2016 16:19 >> On 02/12/2016 at 15:59:57 +, David Laight wrote : >> > From: Alexandre Belloni >> > > Sent: 01 December 2016 10:27 >> > > Use devm_kasprintf instead of simple kasprintf to free the allocated >> > > memory

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

Hi, Jerry Huang writes: >> > On Thu, Dec 22, 2016 at 8:52 PM, Jerry Huang >> wrote: >> > > Hi, Rob, >> > >> -Original Message- >> > >> From: Rob Herring [mailto:r...@kernel.org] >> > >> Sent: Friday, December 23, 2016 2:45 AM >> > >> To: Jerry

RE: [PATCH v3 2/3] USB3/DWC3: Add property "snps, incr-burst-type-adjustment" for INCR burst type

Hi, Jerry Huang writes: >> > On Thu, Dec 22, 2016 at 8:52 PM, Jerry Huang >> wrote: >> > > Hi, Rob, >> > >> -Original Message- >> > >> From: Rob Herring [mailto:r...@kernel.org] >> > >> Sent: Friday, December 23, 2016 2:45 AM >> > >> To: Jerry Huang >> > >> Cc: ba...@kernel.org;

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

Hi, John Youn writes: > On 1/11/2017 4:22 PM, John Stultz wrote: >> Just wanted to resend my patches for dwc2 controller on the >> HiKey board for consideration for the 4.11 merge window. >> >> This patchset is the same as v2, only rebased against >> John's

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

Hi, John Youn writes: > On 1/11/2017 4:22 PM, John Stultz wrote: >> Just wanted to resend my patches for dwc2 controller on the >> HiKey board for consideration for the 4.11 merge window. >> >> This patchset is the same as v2, only rebased against >> John's synopsys-usb/next branch. >> >>

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, Baolin Wang writes: >> Baolin Wang writes: >>> When dwc3 controller acts as host role with attaching slow speed device >>> (like mouse or keypad). Then if we plugged out the slow speed device, >>> it will timeout to run the deconfiguration

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, Baolin Wang writes: >> Baolin Wang writes: >>> When dwc3 controller acts as host role with attaching slow speed device >>> (like mouse or keypad). Then if we plugged out the slow speed device, >>> it will timeout to run the deconfiguration endpoint command to drop the >>> endpoint's

Re: [PATCH] usb: dwc3-exynos Fix dma_mask WARN_ON from xhci_plat_probe()

Hi, Shuah Khan writes: > During dwc3_exynos_probe(), WARN_ON(!pdev->dev.dma_mask) is triggered from > xhci_plat_probe(). dwc3_host_init() doesn't configure DMA prior to adding > the platform device. > > dwc3_host_init() was changed to not configure DMA with the change

Re: [PATCH] usb: dwc3-exynos Fix dma_mask WARN_ON from xhci_plat_probe()

Hi, Shuah Khan writes: > During dwc3_exynos_probe(), WARN_ON(!pdev->dev.dma_mask) is triggered from > xhci_plat_probe(). dwc3_host_init() doesn't configure DMA prior to adding > the platform device. > > dwc3_host_init() was changed to not configure DMA with the change to use > bus->sysdev for

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: [...] and you have triggered this with mailine? How? We don't write to GEVNT* registers from PM code and we only allow runtime_suspend with cable dettached. >>> >>> Sorry for late reply since I am busy on other things. I just

<    4   5   6   7   8   9   10   11   12   13   >