Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2021-03-25 10:45, Rakesh Pillai wrote: > Hi Felix / Ben, > > In case of ath10k (snoc based targets), we have a lot of processing in the > NAPI context. > Even moving this to threaded NAPI is not helping much due to the load. > > Breaking the tasks into multiple context (with the patch

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2021-03-23 04:01, Ben Greear wrote: > On 3/22/21 6:20 PM, Brian Norris wrote: >> On Mon, Mar 22, 2021 at 4:58 PM Ben Greear wrote: >>> On 7/22/20 6:00 AM, Felix Fietkau wrote: >>>> On 2020-07-22 14:55, Johannes Berg wrote: >>>>> On Wed, 2

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

> On 17. Feb 2021, at 21:28, Shuah Khan wrote: > > On 2/17/21 7:56 AM, Shuah Khan wrote: >>> On 2/17/21 12:30 AM, Kalle Valo wrote: >>> Shuah Khan writes: >>> >>>> On 2/16/21 12:53 AM, Felix Fietkau wrote: >>>>> >&g

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

On 2021-02-16 08:03, Kalle Valo wrote: > Shuah Khan wrote: > >> ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() >> return pointer (sta) outside null check. Fix it by moving the code >> block under the null check. >> >> This problem was found while reviewing code to debug RCU

Re: [PATCH] rtw88: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix rtw_rx_addr_match_iter() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when

Re: [PATCH 1/2] ath9k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix ath_tx_process_buffer() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when

Re: [PATCH] mt76: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

On 2021-02-12 03:13, Shuah Khan wrote: > ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and > the resulting pointer is only valid under RCU lock as well. > > Fix mt76_check_sta() to hold RCU read lock before it calls > ieee80211_find_sta_by_ifaddr() and release it when the

Re: [PATCH] mt76: Fix queue ID variable types after mcu queue split

On 2021-01-11 09:06, Kalle Valo wrote: > Lorenzo Bianconi writes: > >>> Clang warns in both mt7615 and mt7915: >>> >>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:271:9: warning: implicit >>> conversion from enumeration type 'enum mt76_mcuq_id' to different >>> enumeration type 'enum

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

On 2020-12-15 18:23, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have sequence numbers for

Re: [PATCH -next] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

On 2020-07-16 10:58, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao This does not seem to apply to the current tree, please rebase. Thanks, - Felix

Re: perf regression after "genirq/affinity: Handle affinity setting on inactive interrupts correctly"

On 2020-08-21 19:38, Felix Fietkau wrote: > Hi Thomas, > > after updating my MT7622 ARM64 device from Linux 5.4.52 to 5.4.59, perf > stopped working. Whenever I started it, I got an IRQ storm on the second > arm-pmu IRQ. After some digging, I figured out that r

perf regression after "genirq/affinity: Handle affinity setting on inactive interrupts correctly"

Hi Thomas, after updating my MT7622 ARM64 device from Linux 5.4.52 to 5.4.59, perf stopped working. Whenever I started it, I got an IRQ storm on the second arm-pmu IRQ. After some digging, I figured out that reverting commit 9f8d3d2f79ba189ecc122d214d32396e5737963b ("genirq/affinity: Handle

Re: [RFC 0/7] Add support to process rx packets in thread

On 2020-07-26 10:32, Hillf Danton wrote: > > On Sun, 26 Jul 2020 10:10:15 +0200 Felix Fietkau wrote: >> On 2020-07-26 03:22, Hillf Danton wrote: >> > >> > Feel free to do that. Is it likely for me to select a Cc? >> > >> Shall I use Signed-o

Re: [RFC 0/7] Add support to process rx packets in thread

On 2020-07-26 03:22, Hillf Danton wrote: >> - add a state bit for threaded NAPI >> - make netif_threaded_napi_add inline >> - run queue_work outside of local_irq_save/restore (it does that >> internally already) >> >> If you don't mind, I'd like to propose this to netdev soon. Can I have >> your

Re: [RFC 0/7] Add support to process rx packets in thread

On 2020-07-25 10:16, Hillf Danton wrote: > Hi folks > > Below is a minimunm poc implementation I can imagine on top of workqueue > to make napi threaded. Thoughts are appreciated. Hi Hillf, For some reason I don't see your mails on linux-wireless/netdev. I've cleaned up your implementation a bit

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2020-07-22 14:55, Johannes Berg wrote: > On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: > >> I'm considering testing a different approach (with mt76 initially): >> - Add a mac80211 rx function that puts processed skbs into a list >> instead of handing t

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

On 2020-07-21 23:53, Rajkumar Manoharan wrote: > On 2020-07-21 10:14, Rakesh Pillai wrote: >> NAPI instance gets scheduled on a CPU core on which >> the IRQ was triggered. The processing of rx packets >> can be CPU intensive and since NAPI cannot be moved >> to a different CPU core, to get better

Re: [PATCH 4.19 157/267] mt76: avoid rx reorder buffer overflow

On 2020-06-19 16:32, Greg Kroah-Hartman wrote: > From: Ryder Lee > > [ Upstream commit 7c4f744d6703757be959f521a7a441bf34745d99 ] > > Enlarge slot to support 11ax 256 BA (256 MPDUs in an AMPDU) > > Signed-off-by: Chih-Min Chen > Signed-off-by: Ryder Lee > S

Re: [PATCH][next] mac80211: minstrel_ht: fix infinite loop because supported is not being shifted

ot;Infinite loop") > Fixes: 48cb39522a9d ("mac80211: minstrel_ht: improve rate probing for devices > with static fallback") > Signed-off-by: Colin Ian King Acked-by: Felix Fietkau Thanks, - Felix

Re: [PATCH v1 5/6] mt76: fix some checkpatch warnings

On 2019-07-24 10:58, Ryder Lee wrote: > --- a/drivers/net/wireless/mediatek/mt76/mt76.h > +++ b/drivers/net/wireless/mediatek/mt76/mt76.h > @@ -537,25 +537,25 @@ struct mt76_rx_status { > s8 chain_signal[IEEE80211_MAX_CHAINS]; > }; > > -#define __mt76_rr(dev, ...) (dev)->bus->rr((dev),

Re: [PATCH v3 2/2] mt76: mt7615: fix slow performance when enable encryption

On 2019-06-03 08:08, Ryder Lee wrote: > Fix wrong WCID assignment and add RKV (RX Key of this entry is valid) > flag to check if peer uses the same configuration with previous > handshaking. > > If the configuration is mismatch, WTBL indicates a “cipher mismatch” > to stop SEC decryption to

Re: [PATCH] mt76: Remove set but not used variables 'pid' and 'final_mpdu'

On 2019-05-29 16:53, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warnings: > > drivers/net/wireless/mediatek/mt76/mt7603/mac.c: In function mt7603_fill_txs: > drivers/net/wireless/mediatek/mt76/mt7603/mac.c:969:5: warning: variable pid > set but not used [-Wunused-but-set-variable]

Re: [PATCH v2] mt76: mt7615: add TX/RX antenna pattern capabilities

On 2019-04-26 07:23, Ryder Lee wrote: > Announce antenna pattern cap to adapt PHY and baseband settings. > > Signed-off-by: Ryder Lee > --- > Changes since v2: > - Add a prefix mt76 in the title. > --- > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [mt76/mt7603/mac] Question about missing variable assignment

On 2019-03-02 22:10, Gustavo A. R. Silva wrote: > Hi all, > > The following piece of code in drivers/net/wireless/mediatek/mt76/mt7603/mac.c > is missing a variable assignment before line 1058. Notice that there > is a potential execution path in which variable *i* is compared against > magic

Re: [PATCH] mt76: change the retun type of mt76_dma_attach()

On 2019-02-11 03:13, Ryder Lee wrote: > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. > > Signed-off-by: Ryder Lee Applied, thanks. - Felix

Re: [PATCH] mt76: convert to DEFINE_SHOW_ATTRIBUTE

On 2018-12-03 14:40, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Please rebase this patch > onto the mt76 branch of https://github.com/nbd168/wireless Thanks, - Felix

Re: [PATCH] mt76: make const array 'data' static, shrinks object size

On 2018-12-30 14:26, Colin King wrote: > From: Colin Ian King > > Don't populate the const array 'data' on the stack but instead > make it static. Makes the object code smaller by 78 bytes: > > Before: >textdata bss dec hex filename >54381080 065181976

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-03-31 09:05, Joe Perches wrote: > There are many local static and non-static arrays that are used for > Ethernet broadcast address output or comparison. > > Centralize the array into a single separate file and remove the local > arrays. I suspect that for many targets and configurations,

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-03-31 09:05, Joe Perches wrote: > There are many local static and non-static arrays that are used for > Ethernet broadcast address output or comparison. > > Centralize the array into a single separate file and remove the local > arrays. I suspect that for many targets and configurations,

[tip:timers/urgent] clocksource/drivers/mips-gic-timer: Use correct shift count to extract data

Commit-ID: 5753405e27f8fe4c42c1537d3ddbd9e058e54cdc Gitweb: https://git.kernel.org/tip/5753405e27f8fe4c42c1537d3ddbd9e058e54cdc Author: Felix Fietkau <n...@nbd.name> AuthorDate: Wed, 28 Feb 2018 10:56:10 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Wed,

[tip:timers/urgent] clocksource/drivers/mips-gic-timer: Use correct shift count to extract data

Commit-ID: 5753405e27f8fe4c42c1537d3ddbd9e058e54cdc Gitweb: https://git.kernel.org/tip/5753405e27f8fe4c42c1537d3ddbd9e058e54cdc Author: Felix Fietkau AuthorDate: Wed, 28 Feb 2018 10:56:10 +0100 Committer: Thomas Gleixner CommitDate: Wed, 28 Feb 2018 13:55:14 +0100 clocksource/drivers

[PATCH v2] clocksource: mips-gic-timer: fix clocksource counter width

e new GIC accessor functions") Cc: Paul Burton <paul.bur...@imgtec.com> Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau <n...@nbd.name> --- drivers/clocksource/mips-gic-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/mips-

[PATCH v2] clocksource: mips-gic-timer: fix clocksource counter width

e new GIC accessor functions") Cc: Paul Burton Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau --- drivers/clocksource/mips-gic-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-tim

Re: [PATCH] clocksource: mips-gic-timer: fix clocksource counter width

On 2018-02-28 09:56, Thomas Gleixner wrote: > On Wed, 21 Feb 2018, Felix Fietkau wrote: > >> This code needs to use ffs instead of fls on the mask to determine the >> shift for reading the GIC_CONFIG_COUNTBITS field. > > Why? >> count_width = read_gic_c

Re: [PATCH] clocksource: mips-gic-timer: fix clocksource counter width

On 2018-02-28 09:56, Thomas Gleixner wrote: > On Wed, 21 Feb 2018, Felix Fietkau wrote: > >> This code needs to use ffs instead of fls on the mask to determine the >> shift for reading the GIC_CONFIG_COUNTBITS field. > > Why? >> count_width = read_gic_c

[PATCH] clocksource: mips-gic-timer: fix clocksource counter width

This code needs to use ffs instead of fls on the mask to determine the shift for reading the GIC_CONFIG_COUNTBITS field. Fixes: e07127a077c7 ("clocksource: mips-gic-timer: Use new GIC accessor functions") Cc: Paul Burton <paul.bur...@imgtec.com> Cc: sta...@vger.kernel.org Sign

[PATCH] clocksource: mips-gic-timer: fix clocksource counter width

This code needs to use ffs instead of fls on the mask to determine the shift for reading the GIC_CONFIG_COUNTBITS field. Fixes: e07127a077c7 ("clocksource: mips-gic-timer: Use new GIC accessor functions") Cc: Paul Burton Cc: sta...@vger.kernel.org Signed-off-by: Felix Fietkau --

Re: [PATCH] ath9k: turn on btcoex_enable as default

On 2018-02-10 14:56, Kai Heng Feng wrote: > >> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: >> Sure, but we have to make sure that we don't create regressions on >> existing systems. For example, did you test this with any system which >> don't support btcoex? (just asking,

Re: [PATCH] ath9k: turn on btcoex_enable as default

On 2018-02-10 14:56, Kai Heng Feng wrote: > >> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: >> Sure, but we have to make sure that we don't create regressions on >> existing systems. For example, did you test this with any system which >> don't support btcoex? (just asking, haven't tested this

Re: [PATCH] ath9k: turn on btcoex_enable as default

On 2018-02-08 06:28, Kai-Heng Feng wrote: > Without btcoex_enable, WiFi activies make both WiFi and Bluetooth > unstable if there's a bluetooth connection. > > Enable this option when bt_ant_diversity is disabled. > > BugLink: https://bugs.launchpad.net/bugs/1746164 > Signed-off-by: Kai-Heng

Re: [PATCH] ath9k: turn on btcoex_enable as default

On 2018-02-08 06:28, Kai-Heng Feng wrote: > Without btcoex_enable, WiFi activies make both WiFi and Bluetooth > unstable if there's a bluetooth connection. > > Enable this option when bt_ant_diversity is disabled. > > BugLink: https://bugs.launchpad.net/bugs/1746164 > Signed-off-by: Kai-Heng

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

On 2018-01-18 14:14, Arnd Bergmann wrote: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

On 2018-01-18 14:14, Arnd Bergmann wrote: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated

Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found

On 2017-12-18 00:53, Tobin C. Harding wrote: > Currently if kallsyms_lookup() fails to find the symbol then the address > is printed. This potentially leaks sensitive information. Instead of > printing the address we can return an error, giving the calling code the > option to print the address or

Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found

On 2017-12-18 00:53, Tobin C. Harding wrote: > Currently if kallsyms_lookup() fails to find the symbol then the address > is printed. This potentially leaks sensitive information. Instead of > printing the address we can return an error, giving the calling code the > option to print the address or

Re: [PATCH] mt76: fix memcpy to potential null pointer on failed allocation

ue") > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Felix Fietkau <n...@nbd.name>

Re: [PATCH] mt76: fix memcpy to potential null pointer on failed allocation

c04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Colin Ian King Acked-by: Felix Fietkau

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

On 2017-12-07 07:06, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port Shouldn't that be VLAN-unaware/VLAN-aware (in the code as well)? - Felix

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

On 2017-12-07 07:06, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port Shouldn't that be VLAN-unaware/VLAN-aware (in the code as well)? - Felix

Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy

ad); >> frag_ptr = skb->data; >> frag_size = head_size; >> +frag--; > > Isn't it just a question of time until the compiler will see through > this trick and warn about it? Frag is incremented again before being accessed, so there is nothing for the compiler to see through here. Acked-by: Felix Fietkau <n...@nbd.name> - Felix

Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy

ag_ptr = skb->data; >> frag_size = head_size; >> +frag--; > > Isn't it just a question of time until the compiler will see through > this trick and warn about it? Frag is incremented again before being accessed, so there is nothing for the compiler to see through here. Acked-by: Felix Fietkau - Felix

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

On 2017-03-23 15:25, John Crispin wrote: > > > On 23/03/17 15:09, Felix Fietkau wrote: >> On 2017-03-23 09:06, Sean Wang wrote: >>> Hi Andrew, >>> >>> The purpose for the regmap table registered is to >>> >>> provide a way which h

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

On 2017-03-23 15:25, John Crispin wrote: > > > On 23/03/17 15:09, Felix Fietkau wrote: >> On 2017-03-23 09:06, Sean Wang wrote: >>> Hi Andrew, >>> >>> The purpose for the regmap table registered is to >>> >>> provide a way which h

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

On 2017-03-23 09:06, Sean Wang wrote: > Hi Andrew, > > The purpose for the regmap table registered is to > > provide a way which helps us to look up a specific > > register on the switch through regmap-debugfs. > > > And not all ranges of register is defined > > so I only include the

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

On 2017-03-23 09:06, Sean Wang wrote: > Hi Andrew, > > The purpose for the regmap table registered is to > > provide a way which helps us to look up a specific > > register on the switch through regmap-debugfs. > > > And not all ranges of register is defined > > so I only include the

[PATCH] kbuild: export SUBARCH

: 'asm/types.h' file not found #include Fixes: d51306f1a3bc ("x86: Make the vdso2c compiler use the host architecture headers") Signed-off-by: Felix Fietkau <n...@nbd.name> --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile in

[PATCH] kbuild: export SUBARCH

: 'asm/types.h' file not found #include Fixes: d51306f1a3bc ("x86: Make the vdso2c compiler use the host architecture headers") Signed-off-by: Felix Fietkau --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 96b27a888285..49

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-11 13:15, IgorMitsyanko wrote: > On 01/11/2017 02:30 PM, Felix Fietkau wrote: >> On 2017-01-11 12:26, IgorMitsyanko wrote: >>> On 01/11/2017 12:27 AM, Felix Fietkau wrote: >>>> On 2017-01-10 11:56, Johannes Berg wrote: >>>>> On Tue, 2

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-11 13:15, IgorMitsyanko wrote: > On 01/11/2017 02:30 PM, Felix Fietkau wrote: >> On 2017-01-11 12:26, IgorMitsyanko wrote: >>> On 01/11/2017 12:27 AM, Felix Fietkau wrote: >>>> On 2017-01-10 11:56, Johannes Berg wrote: >>>>> On Tue, 2

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-11 12:26, IgorMitsyanko wrote: > On 01/11/2017 12:27 AM, Felix Fietkau wrote: >> On 2017-01-10 11:56, Johannes Berg wrote: >>> On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >>>> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wro

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-11 12:26, IgorMitsyanko wrote: > On 01/11/2017 12:27 AM, Felix Fietkau wrote: >> On 2017-01-10 11:56, Johannes Berg wrote: >>> On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >>>> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wro

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes.

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes.

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-10 18:17, Dave Taht wrote: > In the case of wifi I have 3 issues with this line of thought. > > multicast in wifi has generally supposed to be unreliable. This makes > it reliable. reliability comes at a cost - > > multicast is typically set at a fixed low rate today. unicast is >

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-10 18:17, Dave Taht wrote: > In the case of wifi I have 3 issues with this line of thought. > > multicast in wifi has generally supposed to be unreliable. This makes > it reliable. reliability comes at a cost - > > multicast is typically set at a fixed low rate today. unicast is >

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-06 14:54, Johannes Berg wrote: > >> The bridge layer can use IGMP snooping to ensure that the multicast >> stream is only transmitted to clients that are actually a member of >> the group. Can the mac80211 feature do the same? > > No, it'll convert the packet for all clients that are

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-06 14:54, Johannes Berg wrote: > >> The bridge layer can use IGMP snooping to ensure that the multicast >> stream is only transmitted to clients that are actually a member of >> the group. Can the mac80211 feature do the same? > > No, it'll convert the packet for all clients that are

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-06 13:47, Johannes Berg wrote: > On Mon, 2017-01-02 at 20:32 +0100, Linus Lüssing wrote: >> Implements an optional, per bridge port flag and feature to deliver >> multicast packets to any host on the according port via unicast >> individually. This is done by copying the packet per host

Re: [PATCH net-next] bridge: multicast to unicast

On 2017-01-06 13:47, Johannes Berg wrote: > On Mon, 2017-01-02 at 20:32 +0100, Linus Lüssing wrote: >> Implements an optional, per bridge port flag and feature to deliver >> multicast packets to any host on the according port via unicast >> individually. This is done by copying the packet per host

Re: [PATCH net-next] bridge: multicast to unicast

t. > > The initial patch and idea is from Felix Fietkau. > > Cc: Felix Fietkau <n...@nbd.name> > Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> Please add Signed-off-by: Felix Fietkau <n...@nbd.name> in the next version, and maybe also From: Thanks, - Felix

Re: [PATCH net-next] bridge: multicast to unicast

t. > > The initial patch and idea is from Felix Fietkau. > > Cc: Felix Fietkau > Signed-off-by: Linus Lüssing Please add Signed-off-by: Felix Fietkau in the next version, and maybe also From: Thanks, - Felix

Re: [PATCH v2] ath9k: do not return early to fix rcu unlocking

y+0x148/0x170 > > Signed-off-by: Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> > Fixes: d94a461d7a7d ("ath9k: use ieee80211_tx_status_noskb where possible") > Cc: <sta...@vger.kernel.org> # v4.9 Acked-by: Felix Fietkau <n...@nbd.name>

Re: [PATCH v2] ath9k: do not return early to fix rcu unlocking

0x154/0x200 > [] rcu_irq_exit+0x44/0xa0 > [] irq_exit+0x61/0xd0 > [] do_IRQ+0x65/0x110 > [] common_interrupt+0x89/0x89 > > [] ? cpuidle_enter_state+0x151/0x200 > [] cpuidle_enter+0x12/0x20 > [] call_cpuidle+0x1e/0x40 > [] cpu_startup_entry+0x146/0x220 > [] start_secondary+0

Re: [PATCH] ath9k: unlock rcu read when returning early

On 2016-12-13 14:41, Tobias Klausmann wrote: > On 13.12.2016 11:41, Felix Fietkau wrote: >> On 2016-12-12 19:50, Tobias Klausmann wrote: >>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c >>> b/drivers/net/wireless/ath/ath9k/xmit.c >>> index 52bfbb988611..8

Re: [PATCH] ath9k: unlock rcu read when returning early

On 2016-12-13 14:41, Tobias Klausmann wrote: > On 13.12.2016 11:41, Felix Fietkau wrote: >> On 2016-12-12 19:50, Tobias Klausmann wrote: >>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c >>> b/drivers/net/wireless/ath/ath9k/xmit.c >>> index 52bfbb988611..8

Re: [PATCH] ath9k: unlock rcu read when returning early

On 2016-12-12 19:50, Tobias Klausmann wrote: > Starting with ath9k: use ieee80211_tx_status_noskb where possible > [d94a461d7a7df68991fb9663531173f60ef89c68] the driver uses rcu_read_lock() && > rcu_read_unlock() yet on returning early in ath_tx_edma_tasklet() the unlock > is > missing leading to

Re: [PATCH] ath9k: unlock rcu read when returning early

On 2016-12-12 19:50, Tobias Klausmann wrote: > Starting with ath9k: use ieee80211_tx_status_noskb where possible > [d94a461d7a7df68991fb9663531173f60ef89c68] the driver uses rcu_read_lock() && > rcu_read_unlock() yet on returning early in ath_tx_edma_tasklet() the unlock > is > missing leading to

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-10 21:32, Måns Rullgård wrote: > Felix Fietkau <n...@nbd.name> writes: > >> On 2016-12-10 14:25, Måns Rullgård wrote: >>> Felix Fietkau <n...@nbd.name> writes: >>> >>>> On 2016-12-07 19:54, Jason A. Donenfeld wrote:

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-10 21:32, Måns Rullgård wrote: > Felix Fietkau writes: > >> On 2016-12-10 14:25, Måns Rullgård wrote: >>> Felix Fietkau writes: >>> >>>> On 2016-12-07 19:54, Jason A. Donenfeld wrote: >>>>> On Wed, Dec 7, 2016 at 7:51 PM, D

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-10 14:25, Måns Rullgård wrote: > Felix Fietkau <n...@nbd.name> writes: > >> On 2016-12-07 19:54, Jason A. Donenfeld wrote: >>> On Wed, Dec 7, 2016 at 7:51 PM, David Miller <da...@davemloft.net> wrote: >>>> It's so much better to analy

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-10 14:25, Måns Rullgård wrote: > Felix Fietkau writes: > >> On 2016-12-07 19:54, Jason A. Donenfeld wrote: >>> On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >>>> It's so much better to analyze properly where the misalignment comes from >>

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-07 19:54, Jason A. Donenfeld wrote: > On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >> It's so much better to analyze properly where the misalignment comes from >> and address it at the source, as we have for various cases that trip up >> Sparc too. > >

Re: Misalignment, MIPS, and ip_hdr(skb)->version

On 2016-12-07 19:54, Jason A. Donenfeld wrote: > On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >> It's so much better to analyze properly where the misalignment comes from >> and address it at the source, as we have for various cases that trip up >> Sparc too. > > That's sort of my

Re: [PATCH v2 0/4] ubifs: Add overlayfs support

link count after RENAME_EXCHANGE > > Richard Weinberger (4): > ubifs: Implement O_TMPFILE > ubifs: Implement RENAME_WHITEOUT > ubifs: Implement RENAME_EXCHANGE > ubifs: Use move variable in ubifs_rename() Tested-by: Felix Fietkau <n...@nbd.name>

Re: [PATCH v2 0/4] ubifs: Add overlayfs support

link count after RENAME_EXCHANGE > > Richard Weinberger (4): > ubifs: Implement O_TMPFILE > ubifs: Implement RENAME_WHITEOUT > ubifs: Implement RENAME_EXCHANGE > ubifs: Use move variable in ubifs_rename() Tested-by: Felix Fietkau

Re: [PATCH 1/2] add basic register-field manipulation macros

itfield.h > > diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h > new file mode 100644 > index ..ae2224464523 > --- /dev/null > +++ b/include/linux/bitfield.h > @@ -0,0 +1,58 @@ > +/* > + * Copyright (C) 2014 Felix Fietkau <n...@openwrt.org> Please change my email address to n...@nbd.name here - Felix

Re: [PATCH 1/2] add basic register-field manipulation macros

de/linux/bitfield.h b/include/linux/bitfield.h > new file mode 100644 > index ..ae2224464523 > --- /dev/null > +++ b/include/linux/bitfield.h > @@ -0,0 +1,58 @@ > +/* > + * Copyright (C) 2014 Felix Fietkau Please change my email address to n...@nbd.name here - Felix

[PATCH] treewide: update my email address

My n...@openwrt.org address is no longer valid and bounces Signed-off-by: Felix Fietkau <n...@nbd.name> --- MAINTAINERS | 2 +- arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts| 2 +- arch/mips/ar7/c

[PATCH] treewide: update my email address

My n...@openwrt.org address is no longer valid and bounces Signed-off-by: Felix Fietkau --- MAINTAINERS | 2 +- arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts| 2 +- arch/mips/ar7/clock.c

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

On 2016-02-26 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

On 2016-02-26 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

ttp://patchwork.ozlabs.org/patch/553683/ >> > >> > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for >> > Winbond") >> > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash >> > at startup") >&

Re: [PATCH for-4.4 1/2] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

ttp://patchwork.ozlabs.org/patch/553683/ >> > >> > Fixes: 357ca38d4751 ("mtd: spi-nor: support lock/unlock/is_locked for >> > Winbond") >> > Fixes: c6fc2171b249 ("mtd: spi-nor: disable protection for Winbond flash >> > at startup") >

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

On 2015-10-02 15:30, Neil Armstrong wrote: > On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: >> On 10/2/2015 1:48 PM, Neil Armstrong wrote: >> >>> To simplify and prevent memory leakage when unbinding, use >>> the devm_ memory allocation calls. >>> >>> Tested-by: Andrew Lunn >>> Tested-by:

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

On 2015-10-02 15:30, Neil Armstrong wrote: > On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: >> On 10/2/2015 1:48 PM, Neil Armstrong wrote: >> >>> To simplify and prevent memory leakage when unbinding, use >>> the devm_ memory allocation calls. >>> >>> Tested-by: Andrew Lunn >>>

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

On 2015-10-02 12:48, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Tested-by: Andrew Lunn > Tested-by: Florian Fainelli > Signed-off-by: Neil Armstrong I think you also need to get rid of the corresponding free calls

  1   2   >