RE: [EXT] module refcount issues in the liquidio driver

2021-03-11 Thread Felix Manlunas
he module refcount ...". commit bb54be589c7a8451a0504924703abdffeb06b79f Author: Felix Manlunas Date: Tue Apr 4 19:26:57 2017 -0700 liquidio: fix Octeon core watchdog timeout false alarm Detection of watchdog timeout of Octeon cores is flawed and susceptible to false alarms. Refactor by re

Re: [PATCH] liquidio: fix liquidio_xmit()'s return type

2018-04-24 Thread Felix Manlunas
mitted to the device okay or not > * (NETDEV_TX_OK or NETDEV_TX_BUSY) > */ > -static int liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) > +static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device > *netdev) > { > struct octnet_buf_free_info *finfo; > union octnic_cmd_setup cmdsetup; > -- > 2.17.0 > Acked-by: Felix Manlunas

Re: [PATCH] liquidio: fix lio_vf_rep_pkt_xmit()'s return type

2018-04-24 Thread Felix Manlunas
-static int > +static netdev_tx_t > lio_vf_rep_pkt_xmit(struct sk_buff *skb, struct net_device *ndev) > { > struct lio_vf_rep_desc *vf_rep = netdev_priv(ndev); > -- > 2.17.0 > Thanks. Acked-by: Felix Manlunas

Re: [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources

2017-10-18 Thread Felix Manlunas
*oct) > > if (lio_wait_for_oq_pkts(oct)) > dev_err(&oct->pci_dev->dev, "OQ had pending packets\n"); > - > + /* fall through */ > case OCT_DEV_INTR_SET_DONE: > /* Disable interrupts */ >

Re: [PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists

2017-10-18 Thread Felix Manlunas
gt; list_delete_head(&lio->glist[i]); > - if (g) > - kfree(g); > + kfree(g); > } while (g); > > if (lio->glists_virt_base && lio->glists_virt_base[i] && > -- > 2.7.4 > Acked-by: Felix Manlunas

Re: [PATCH] [net] liquidio: fix timespec64_to_ns typo

2017-10-12 Thread Felix Manlunas
ptp_clock_info > *ptp, > struct lio *lio = container_of(ptp, struct lio, ptp_info); > struct octeon_device *oct = (struct octeon_device *)lio->oct_dev; > > - ns = timespec_to_ns(ts); > + ns = timespec64_to_ns(ts); > > spin_lock_irqsave(&lio->ptp_lock, flags); > lio_pci_writeq(oct, ns, CN6XXX_MIO_PTP_CLOCK_HI); > -- > 2.9.0 > Thanks. Acked-by: Felix Manlunas

Re: [PATCH] liquidio: fix duplicated code for different branches

2017-08-14 Thread Felix Manlunas
if (oct->chip_id == OCTEON_CN66XX) > octnet_gpio_access(netdev, VITESSE_PHY_GPIO_CFG, > VITESSE_PHY_GPIO_LOW); > - else if (oct->chip_id == OCTEON_CN68XX) > - return -EINVAL; > else > return -EINVAL; > > -- > 2.5.0 > Acked-by: Felix Manlunas

Re: [PATCH] liquidio: lio_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
; @@ -2544,8 +2544,8 @@ static inline int setup_io_queues(struct octeon_device > *octeon_dev, > { > struct octeon_droq_ops droq_ops; > struct net_device *netdev; > - static int cpu_id; > - static int cpu_id_modulus; > + int cpu_id; > + int cpu_id_modulus; > struct octeon_droq *droq; > struct napi_struct *napi; > int q, q_no, retval = 0; > -- > 2.5.0 > Thanks. Acked-by: Felix Manlunas

Re: [PATCH] liquidio: lio_vf_main: remove unnecessary static in setup_io_queues()

2017-07-18 Thread Felix Manlunas
struct octeon_droq *droq; > struct napi_struct *napi; > - static int cpu_id; > + int cpu_id; > int num_tx_descs; > struct lio *lio; > int retval = 0; > -- > 2.5.0 > Thanks. Acked-by: Felix Manlunas

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David Miller [mailto:da...@davemloft.net] >

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only compile-tested - I don't have the hardware. > > > > > >

Re: [PATCH 7/7] liquidio: use pcie_flr instead of duplicating it

2017-04-24 Thread Felix Manlunas
From: Christoph Hellwig Date: Fri, 14 Apr 2017 21:11:31 +0200 > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main