On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote:
> On 10/10/2014 06:21 AM, Fengwei Yin wrote:
> > @@ -787,6 +788,9 @@ check_pfn:
> > return NULL;
> > }
> >
> > + if (is_huge_zero_pfn(pfn))
> > + return NULL;
> &g
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote:
On 10/10/2014 06:21 AM, Fengwei Yin wrote:
@@ -787,6 +788,9 @@ check_pfn:
return NULL;
}
+ if (is_huge_zero_pfn(pfn))
+ return NULL;
+
That looks a lot better. One thing, why not put
On Tue, Oct 14, 2014 at 02:57:30PM +0300, Kirill A. Shutemov wrote:
> On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote:
> > On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
> > > On 10/09/2014 02:19 AM, Fengwei Yin wrote:
> > > > diff --git
On Tue, Oct 14, 2014 at 02:57:30PM +0300, Kirill A. Shutemov wrote:
On Fri, Oct 10, 2014 at 09:21:08PM +0800, Fengwei Yin wrote:
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
On 10/09/2014 02:19 AM, Fengwei Yin wrote:
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote:
> On 10/10/2014 06:21 AM, Fengwei Yin wrote:
> > @@ -787,6 +788,9 @@ check_pfn:
> > return NULL;
> > }
> >
> > + if (is_huge_zero_pfn(pfn))
> > + return NULL;
> &g
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote:
On 10/10/2014 06:21 AM, Fengwei Yin wrote:
@@ -787,6 +788,9 @@ check_pfn:
return NULL;
}
+ if (is_huge_zero_pfn(pfn))
+ return NULL;
+
That looks a lot better. One thing, why not put
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
> On 10/09/2014 02:19 AM, Fengwei Yin wrote:
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index 80ca4fb..8550b27 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> >
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
> On 10/09/2014 02:19 AM, Fengwei Yin wrote:
> > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> > index 80ca4fb..8550b27 100644
> > --- a/fs/proc/task_mmu.c
> > +++ b/fs/proc/task_mmu.c
> >
Hi,
Fengguang found that the RSS/PSS shown in smaps is not correct
if the file is /dev/zero.
Example:
7bea458b3000-7fea458b3000 r--p 00:13 39989
/dev/zero
Size: 4294967296 kB
Rss:10612736 kB
Pss:10612736 kB
Shared_Clean: 0 kB
Shared_Dirty:
Hi,
Fengguang found that the RSS/PSS shown in smaps is not correct
if the file is /dev/zero.
Example:
7bea458b3000-7fea458b3000 r--p 00:13 39989
/dev/zero
Size: 4294967296 kB
Rss:10612736 kB
Pss:10612736 kB
Shared_Clean: 0 kB
Shared_Dirty:
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
On 10/09/2014 02:19 AM, Fengwei Yin wrote:
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 80ca4fb..8550b27 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -476,7 +476,7 @@ static void smaps_pte_entry
On Thu, Oct 09, 2014 at 09:36:30AM -0700, Dave Hansen wrote:
On 10/09/2014 02:19 AM, Fengwei Yin wrote:
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 80ca4fb..8550b27 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -476,7 +476,7 @@ static void smaps_pte_entry
On Fri, Apr 25, 2014 at 12:29 AM, Al Viro wrote:
> On Thu, Apr 24, 2014 at 10:26:50PM +0800, Fengwei Yin wrote:
>> On Thu, Apr 24, 2014 at 5:58 AM, Al Viro wrote:
>> > On Mon, Apr 21, 2014 at 10:12:42PM +0800, Fengwei Yin wrote:
>> >> When dump /proc/xxx/maps, if d
On Thu, Apr 24, 2014 at 5:58 AM, Al Viro wrote:
> On Mon, Apr 21, 2014 at 10:12:42PM +0800, Fengwei Yin wrote:
>> When dump /proc/xxx/maps, if d_path return error in seq_path, the
>> buffer will be exhaust and trigger dead loop in seq_read. Till
>> kmalloc fails with -ENOM
On Thu, Apr 24, 2014 at 5:58 AM, Al Viro v...@zeniv.linux.org.uk wrote:
On Mon, Apr 21, 2014 at 10:12:42PM +0800, Fengwei Yin wrote:
When dump /proc/xxx/maps, if d_path return error in seq_path, the
buffer will be exhaust and trigger dead loop in seq_read. Till
kmalloc fails with -ENOMEM
On Fri, Apr 25, 2014 at 12:29 AM, Al Viro v...@zeniv.linux.org.uk wrote:
On Thu, Apr 24, 2014 at 10:26:50PM +0800, Fengwei Yin wrote:
On Thu, Apr 24, 2014 at 5:58 AM, Al Viro v...@zeniv.linux.org.uk wrote:
On Mon, Apr 21, 2014 at 10:12:42PM +0800, Fengwei Yin wrote:
When dump /proc/xxx/maps
When dump /proc/xxx/maps, if d_path return error in seq_path, the
buffer will be exhaust and trigger dead loop in seq_read. Till
kmalloc fails with -ENOMEM.
Saving and restoring the m->count to avoid the dead loop in seq_read
if d_path return error.
Signed-off-by: Fengwei Yin
---
fs/p
When dump /proc/xxx/maps, if d_path return error in seq_path, the
buffer will be exhaust and trigger dead loop in seq_read. Till
kmalloc fails with -ENOMEM.
Saving and restoring the m-count to avoid the dead loop in seq_read
if d_path return error.
Signed-off-by: Fengwei Yin yfw.ker...@gmail.com
On 7/20/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote:
On Thu, 2007-07-19 at 23:54 +0800, Fengwei Yin wrote:
> Hi,
> In get_page(), the parameter page is changed by
> page = compound_head(page);
> if the page is not the first page of compound pages.
>
> My qu
Hi,
In get_page(), the parameter page is changed by
page = compound_head(page);
if the page is not the first page of compound pages.
My question: is this behavior correct?
Regards
Yin, Fengwei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Hi,
In get_page(), the parameter page is changed by
page = compound_head(page);
if the page is not the first page of compound pages.
My question: is this behavior correct?
Regards
Yin, Fengwei
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
On 7/20/07, Peter Zijlstra [EMAIL PROTECTED] wrote:
On Thu, 2007-07-19 at 23:54 +0800, Fengwei Yin wrote:
Hi,
In get_page(), the parameter page is changed by
page = compound_head(page);
if the page is not the first page of compound pages.
My question: is this behavior correct
Hi,
In function tsdev_event() of drivers/input/tsdev.c,
conversion from usec to milisec is like:
client->event[client->head].millisecs =
time.tv_usec / 100;
~~ should be 1000?
Regards
Yin, Fengwei
-
To unsubscribe from this list: send the line
Hi,
In function tsdev_event() of drivers/input/tsdev.c,
conversion from usec to milisec is like:
client-event[client-head].millisecs =
time.tv_usec / 100;
~~ should be 1000?
Regards
Yin, Fengwei
-
To unsubscribe from this list: send the line
24 matches
Mail list logo