Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro

2016-10-17 Thread Fernando Apesteguía
On Mon, Oct 17, 2016 at 10:29 AM, Greg KH wrote: > On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: >> The patch replaces the macro with a function (dgnc_get_board) and >> substitutes the macro statement with a call to that function and a >> comparison on the returned value. >>

Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

2014-07-31 Thread Fernando Apesteguía
El 31/07/2014 10:21, "Dan Carpenter" escribió: > > You need to compile these things before sending them... > > This adds a GCC warning about uncalled functions. Sorry, but I did compile it with make C=1 M=drivers/staging But for the function to be called, DEBUG_EPROM must be defined and I had i

Re: [PATCH] Staging: vt6655: staticfy variable

2014-07-30 Thread Fernando Apesteguía
On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement wrote: > Hello, > >> Add static to variable. >> Signed-off-by: Fernando Apesteguia >> --- >> drivers/staging/vt6655/ioctl.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/vt6655/ioctl.c >> b/driver

Re: [PATCH] staging: vt6655: Fix device table definition.

2014-07-30 Thread Fernando Apesteguía
On Wed, Jul 30, 2014 at 1:43 PM, Tobias Klauser wrote: > > On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com > wrote: > > From: Fernando Apesteguia > > > > Add static to the definition of the pci device table. > > > > Signed-off-by: Fernando Apesteguia > > This change is already p