Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-06-03 Thread Fleming, Matt
On 27 May 2014 19:45, Dave Hansen wrote: > > I don't think this is quite right. pfn_valid() tells us whether we have > a 'struct page' there or not. *BUT*, it does not tell us whether it is > RAM that we can actually address and than can be freed in to the buddy > allocator. > > I think

Re: [PATCH] mm: bootmem: Check pfn_valid() before accessing struct page

2014-06-03 Thread Fleming, Matt
On 27 May 2014 19:45, Dave Hansen dave.han...@intel.com wrote: I don't think this is quite right. pfn_valid() tells us whether we have a 'struct page' there or not. *BUT*, it does not tell us whether it is RAM that we can actually address and than can be freed in to the buddy allocator. I

Re: [PATCH] efi: Fix compiler warnings (unused, const, type)

2014-06-02 Thread Fleming, Matt
On 2 June 2014 11:31, Catalin Marinas wrote: > This patch fixes a few compiler warning in the efi code for unused > variable, discarding const qualifier and wrong pointer type: > > drivers/firmware/efi/fdt.c|66 col 22| warning: unused variable ‘name’ > [-Wunused-variable] >

Re: [PATCH] efi: Fix compiler warnings (unused, const, type)

2014-06-02 Thread Fleming, Matt
On 2 June 2014 11:31, Catalin Marinas catalin.mari...@arm.com wrote: This patch fixes a few compiler warning in the efi code for unused variable, discarding const qualifier and wrong pointer type: drivers/firmware/efi/fdt.c|66 col 22| warning: unused variable ‘name’ [-Wunused-variable]

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 29 May 2014 13:59, Vivek Goyal wrote: > > Only second kernel boots with "noefi" and this parameter is appened by > kexec-tools to second kernel command line. So first kernel will still > boot *without noefi* and kexec-tools wil think that this system support > booting second kernel with UEFI

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 28 May 2014 20:04, Vivek Goyal wrote: > On Wed, May 28, 2014 at 10:51:04AM -0500, Alex Thorlton wrote: > > [..] >> A side note, though: We're going to have to figure out some way to >> determine whether or not to apply the old_map quirk on during boot >> anyway, so if it's easiest for you to

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 28 May 2014 15:51, Vivek Goyal wrote: > On Wed, May 28, 2014 at 10:09:35AM +0800, Dave Young wrote: > > [..] >> > I've only vaguely been following along with the other thread, so please >> > summarise everything again in your patch. Particularly, I need answers >> > to the following questions,

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 28 May 2014 15:51, Vivek Goyal vgo...@redhat.com wrote: On Wed, May 28, 2014 at 10:09:35AM +0800, Dave Young wrote: [..] I've only vaguely been following along with the other thread, so please summarise everything again in your patch. Particularly, I need answers to the following

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 28 May 2014 20:04, Vivek Goyal vgo...@redhat.com wrote: On Wed, May 28, 2014 at 10:51:04AM -0500, Alex Thorlton wrote: [..] A side note, though: We're going to have to figure out some way to determine whether or not to apply the old_map quirk on during boot anyway, so if it's easiest for

Re: [PATCH] export efi.flags to sysfs

2014-05-29 Thread Fleming, Matt
On 29 May 2014 13:59, Vivek Goyal vgo...@redhat.com wrote: Only second kernel boots with noefi and this parameter is appened by kexec-tools to second kernel command line. So first kernel will still boot *without noefi* and kexec-tools wil think that this system support booting second kernel

Re: [PATCH] export efi.flags to sysfs

2014-05-27 Thread Fleming, Matt
On 27 May 2014 04:00, Dave Young wrote: > On 05/26/14 at 04:39pm, Dave Young wrote: >> >> For efi=old_map and any old_map quirks like SGI UV in current >> tree kexec/kdump will fail because it depends on the new 1:1 mapping. >> >> Thus export the mapping method to sysfs so kexec tools can switch

Re: [PATCH] export efi.flags to sysfs

2014-05-27 Thread Fleming, Matt
On 27 May 2014 04:00, Dave Young dyo...@redhat.com wrote: On 05/26/14 at 04:39pm, Dave Young wrote: For efi=old_map and any old_map quirks like SGI UV in current tree kexec/kdump will fail because it depends on the new 1:1 mapping. Thus export the mapping method to sysfs so kexec tools can

Re: 3.13: disagrees about version of symbol

2014-04-07 Thread Fleming, Matt
On 7 April 2014 21:42, Andi Kleen wrote: > > This sounds like the UEFI boot corrupts some memory? Hmpf, yeah. I'll take a look in the morning. Thomas, you mention you're running in a 32-bit vm earlier in this thread. Any chance you're using ovmf because that would make it much easier to track

Re: 3.13: module disagrees about version of symbol symbol

2014-04-07 Thread Fleming, Matt
On 7 April 2014 21:42, Andi Kleen a...@linux.intel.com wrote: This sounds like the UEFI boot corrupts some memory? Hmpf, yeah. I'll take a look in the morning. Thomas, you mention you're running in a 32-bit vm earlier in this thread. Any chance you're using ovmf because that would make it much

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Fleming, Matt
On 4 October 2013 16:46, Seiji Aguchi wrote: > Are there anyone who can review this bugfix? Sorry I haven't got to it yet (or the previous version). It is on my TODO list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-04 Thread Fleming, Matt
On 4 October 2013 16:46, Seiji Aguchi seiji.agu...@hds.com wrote: Are there anyone who can review this bugfix? Sorry I haven't got to it yet (or the previous version). It is on my TODO list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 0/4] Make commonly useful UEFI functions common

2013-08-01 Thread Fleming, Matt
On 1 August 2013 21:26, H. Peter Anvin wrote: > Matt, I assume you're picking this up once the missing bits are plugged > in, right? Yep, that was my plan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/4] Make commonly useful UEFI functions common

2013-08-01 Thread Fleming, Matt
On 1 August 2013 21:26, H. Peter Anvin h...@zytor.com wrote: Matt, I assume you're picking this up once the missing bits are plugged in, right? Yep, that was my plan. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [REGRESSION] "UEFI: Don't pass boot services regions to SetVirtualAddressMap()" breaks macbook efi boot

2013-07-17 Thread Fleming, Matt
On 17 July 2013 01:32, H. Peter Anvin wrote: > On 07/10/2013 04:39 AM, Fleming, Matt wrote: >> On 10 July 2013 12:34, Maarten Lankhorst >> wrote: >>> Hey, >>> >>> It seems that in the merge window my macbook pro stopped working at some >>> poi

Re: [REGRESSION] UEFI: Don't pass boot services regions to SetVirtualAddressMap() breaks macbook efi boot

2013-07-17 Thread Fleming, Matt
On 17 July 2013 01:32, H. Peter Anvin h...@zytor.com wrote: On 07/10/2013 04:39 AM, Fleming, Matt wrote: On 10 July 2013 12:34, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Hey, It seems that in the merge window my macbook pro stopped working at some point. I looked

Re: [REGRESSION] "UEFI: Don't pass boot services regions to SetVirtualAddressMap()" breaks macbook efi boot

2013-07-10 Thread Fleming, Matt
On 10 July 2013 12:34, Maarten Lankhorst wrote: > Hey, > > It seems that in the merge window my macbook pro stopped working at some > point. I looked for suspicious > efi related commits, and found that reverting commit > 1acba98f810a14b1255e34bc620594f83de37e36 worked, > letting my macbook pro

Re: [REGRESSION] UEFI: Don't pass boot services regions to SetVirtualAddressMap() breaks macbook efi boot

2013-07-10 Thread Fleming, Matt
On 10 July 2013 12:34, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Hey, It seems that in the merge window my macbook pro stopped working at some point. I looked for suspicious efi related commits, and found that reverting commit 1acba98f810a14b1255e34bc620594f83de37e36 worked,

Re: [PATCH] [IA64] sim: Add casts to avoid assignment warnings

2013-06-21 Thread Fleming, Matt
On 21 June 2013 00:43, Tony Luck wrote: > Oops - pasted in old e-mail address for Boris Applied, thanks Tony. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] [IA64] sim: Add casts to avoid assignment warnings

2013-06-21 Thread Fleming, Matt
On 21 June 2013 00:43, Tony Luck tony.l...@gmail.com wrote: Oops - pasted in old e-mail address for Boris Applied, thanks Tony. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] Modify UEFI anti-bricking code

2013-06-05 Thread Fleming, Matt
On 4 June 2013 04:35, joeyli wrote: > 於 一,2013-06-03 於 16:31 +,Matthew Garrett 提到: >> On Tue, 2013-06-04 at 00:13 +0800, joeyli wrote: >> >> > Oliver raised a question for if power fails between that succesful >> > attempt and the deletion? >> >> It's a pretty tiny window, but sure. Making

Re: [PATCH] Modify UEFI anti-bricking code

2013-06-05 Thread Fleming, Matt
On 4 June 2013 04:35, joeyli j...@suse.com wrote: 於 一,2013-06-03 於 16:31 +,Matthew Garrett 提到: On Tue, 2013-06-04 at 00:13 +0800, joeyli wrote: Oliver raised a question for if power fails between that succesful attempt and the deletion? It's a pretty tiny window, but sure. Making sure

Re: [tip:x86/efi2] efivars: efivar_entry API

2013-04-26 Thread Fleming, Matt
On 26 April 2013 15:28, Seiji Aguchi wrote: > Matt, > > I built a tip tree With CONFIG_EFIVAR_FS=y. > But, I can't see any entries in the directory of /sys/firmware/efi/efivarfs... > > I'm not sure if it is a problem. > Just let you know. Did you mount the efivarfs file system there? -- To

Re: [tip:x86/efi2] efivars: efivar_entry API

2013-04-26 Thread Fleming, Matt
On 26 April 2013 15:28, Seiji Aguchi seiji.agu...@hds.com wrote: Matt, I built a tip tree With CONFIG_EFIVAR_FS=y. But, I can't see any entries in the directory of /sys/firmware/efi/efivarfs... I'm not sure if it is a problem. Just let you know. Did you mount the efivarfs file system