[PATCH v2 2/2] checkpatch: fix spurious vendor compatible warnings

2014-02-28 Thread Florian Vaussard
r,something"; Signed-off-by: Florian Vaussard --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e304e77..7437505 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2058,6 +2058,7 @@ sub process {

[PATCH v2 1/2] checkpatch: check vendor compatible with dashes

2014-02-28 Thread Florian Vaussard
The current vendor compatible check will not match vendors with dashes, like: compatible="asahi-kasei" Reported-by: Joe Perches Signed-off-by: Florian Vaussard --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl

[PATCH v2 0/2] checkpatch: fixes for vendor compatible check

2014-02-28 Thread Florian Vaussard
Hi, Since v1 [1]: - Add check for vendors with '-', as suggested by Joe Perches Regards, Florian [1] http://thread.gmane.org/gmane.linux.drivers.devicetree/63770 Florian Vaussard (2): checkpatch: check vendor compatible with dashes checkpatch: fix spurious vendor compatible warnings

[PATCH v2 0/2] checkpatch: fixes for vendor compatible check

2014-02-28 Thread Florian Vaussard
Hi, Since v1 [1]: - Add check for vendors with '-', as suggested by Joe Perches Regards, Florian [1] http://thread.gmane.org/gmane.linux.drivers.devicetree/63770 Florian Vaussard (2): checkpatch: check vendor compatible with dashes checkpatch: fix spurious vendor compatible warnings

[PATCH v2 1/2] checkpatch: check vendor compatible with dashes

2014-02-28 Thread Florian Vaussard
The current vendor compatible check will not match vendors with dashes, like: compatible=asahi-kasei Reported-by: Joe Perches j...@perches.com Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/2] checkpatch: fix spurious vendor compatible warnings

2014-02-28 Thread Florian Vaussard
With a compatible string like compatible = foo; checkpatch will currently try to find foo in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case. Skip the vendor test if the compatible is not like compatible = vendor,something; Signed-off-by: Florian

Re: [PATCH] checkpatch: fix spurious vendor compatible warnings

2014-02-27 Thread Florian Vaussard
On 02/27/2014 09:10 PM, Joe Perches wrote: > On Thu, 2014-02-27 at 20:56 +0100, Florian Vaussard wrote: >> With a compatible string like >> >> compatible = "foo"; >> >> checkpatch will currently try to find "foo" in vendor-prefixes.tx

[PATCH] checkpatch: fix spurious vendor compatible warnings

2014-02-27 Thread Florian Vaussard
r,something"; Signed-off-by: Florian Vaussard --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 464dcef..35ec185 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2058,6 +2058,7 @@ sub process {

Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock

2014-02-27 Thread Florian Vaussard
Hi Peter, On 02/27/2014 02:56 PM, Peter Ujfalusi wrote: > Hi, > > While looking into a report by Florian Vaussard [1] I have noticed couple of > most > likely unrelated issues: > - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is > set >

Re: [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock

2014-02-27 Thread Florian Vaussard
Hi Peter, On 02/27/2014 02:56 PM, Peter Ujfalusi wrote: Hi, While looking into a report by Florian Vaussard [1] I have noticed couple of most likely unrelated issues: - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set to 100KHz as default. - if I set

[PATCH] checkpatch: fix spurious vendor compatible warnings

2014-02-27 Thread Florian Vaussard
With a compatible string like compatible = foo; checkpatch will currently try to find foo in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case. Skip the vendor test if the compatible is not like compatible = vendor,something; Signed-off-by: Florian

Re: [PATCH] checkpatch: fix spurious vendor compatible warnings

2014-02-27 Thread Florian Vaussard
On 02/27/2014 09:10 PM, Joe Perches wrote: On Thu, 2014-02-27 at 20:56 +0100, Florian Vaussard wrote: With a compatible string like compatible = foo; checkpatch will currently try to find foo in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case

Re: [PATCH 0/2] mfd: twl6040: Small clean-ups

2014-02-25 Thread Florian Vaussard
On 02/25/2014 03:27 PM, Lee Jones wrote: >>> Here is two cleanups patches for the TWL6040 audio codec. The first >>> one checks for an error when reading the revision register (first read >>> in the probe path). The second removes a duplicate I2C writes. >>> >>> Regards, >>> Florian >> >> To

[PATCH 1/2] mfd: twl6040: Check for error when reading revision register

2014-02-25 Thread Florian Vaussard
We may have an error when reading the revision register, so check for the returned value. Signed-off-by: Florian Vaussard --- drivers/mfd/twl6040.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c index 32ce1ae..67e524e 100644 --- a/drivers

[PATCH 2/2] mfd: twl6040: Remove duplicate register write

2014-02-25 Thread Florian Vaussard
When probing, regmap_register_patch() will bypass the cache and perform i2c writes for the given patches. It is thus unnecessary to manually set the TWL6040_REG_ACCCTL register just before, as it will be done when registering the twl6040_patch. Signed-off-by: Florian Vaussard --- drivers/mfd

[PATCH 0/2] mfd: twl6040: Small clean-ups

2014-02-25 Thread Florian Vaussard
Hi, Here is two cleanups patches for the TWL6040 audio codec. The first one checks for an error when reading the revision register (first read in the probe path). The second removes a duplicate I2C writes. Regards, Florian Florian Vaussard (2): mfd: twl6040: Check for error when reading

[PATCH 0/2] mfd: twl6040: Small clean-ups

2014-02-25 Thread Florian Vaussard
Hi, Here is two cleanups patches for the TWL6040 audio codec. The first one checks for an error when reading the revision register (first read in the probe path). The second removes a duplicate I2C writes. Regards, Florian Florian Vaussard (2): mfd: twl6040: Check for error when reading

[PATCH 2/2] mfd: twl6040: Remove duplicate register write

2014-02-25 Thread Florian Vaussard
When probing, regmap_register_patch() will bypass the cache and perform i2c writes for the given patches. It is thus unnecessary to manually set the TWL6040_REG_ACCCTL register just before, as it will be done when registering the twl6040_patch. Signed-off-by: Florian Vaussard florian.vauss

[PATCH 1/2] mfd: twl6040: Check for error when reading revision register

2014-02-25 Thread Florian Vaussard
We may have an error when reading the revision register, so check for the returned value. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/mfd/twl6040.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c index 32ce1ae

Re: [PATCH 0/2] mfd: twl6040: Small clean-ups

2014-02-25 Thread Florian Vaussard
On 02/25/2014 03:27 PM, Lee Jones wrote: Here is two cleanups patches for the TWL6040 audio codec. The first one checks for an error when reading the revision register (first read in the probe path). The second removes a duplicate I2C writes. Regards, Florian To both: Acked-by: Peter

Re: [PATCH 3.11 032/121] pinctrl: do not init debugfs entries for unimplemented functionalities

2014-02-21 Thread Florian Vaussard
5959.html > -- > > From: Florian Vaussard > > commit e7f2a444891cb39f11d5429467d0fd7e011fe7fe upstream. > > Commit c420619 "pinctrl: pinconf: remove checks on ops->pin_config_get" > removed the check on (ops != NULL) when performing pinconf_pins_show() or > p

Re: [PATCH 3.11 032/121] pinctrl: do not init debugfs entries for unimplemented functionalities

2014-02-21 Thread Florian Vaussard
-- From: Florian Vaussard florian.vauss...@epfl.ch commit e7f2a444891cb39f11d5429467d0fd7e011fe7fe upstream. Commit c420619 pinctrl: pinconf: remove checks on ops-pin_config_get removed the check on (ops != NULL) when performing pinconf_pins_show() or pinconf_groups_show(). As these entries

Re: [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-02-06 Thread Florian Vaussard
Hi, On 02/06/2014 11:57 AM, Marc Kleine-Budde wrote: > On 01/31/2014 03:08 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 31-01-2014 17:34, Florian Vaussard wrote: >> >>> Add the 'reg-io-width' property for 8, 16 and 32-bit access, like >>> what is cu

Re: [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-02-06 Thread Florian Vaussard
Hi, On 02/06/2014 11:57 AM, Marc Kleine-Budde wrote: On 01/31/2014 03:08 PM, Sergei Shtylyov wrote: Hello. On 31-01-2014 17:34, Florian Vaussard wrote: Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot

[PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities

2014-02-04 Thread Florian Vaussard
ops. Instead of checking for ops, remove the corresponding debugfs entries if pinconf and/or pinmux are not implemented. Tested on OMAP3 (pinctrl-single). Signed-off-by: Florian Vaussard --- drivers/pinctrl/core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/p

Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-02-04 Thread Florian Vaussard
On 02/04/2014 09:19 AM, Andreas Larsson wrote: > On 2014-01-31 14:50, Andreas Larsson wrote: >> On 2014-01-31 14:40, Marc Kleine-Budde wrote: >>> On 01/31/2014 02:34 PM, Florian Vaussard wrote: >>>> Hello, >>>> >>>> (could someone with a

Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-02-04 Thread Florian Vaussard
On 02/04/2014 09:19 AM, Andreas Larsson wrote: On 2014-01-31 14:50, Andreas Larsson wrote: On 2014-01-31 14:40, Marc Kleine-Budde wrote: On 01/31/2014 02:34 PM, Florian Vaussard wrote: Hello, (could someone with a SJA1000 on SPARC perform a functional test to see if interrupts are working

[PATCH] pinctrl: do not init debugfs entries for unimplemented functionalities

2014-02-04 Thread Florian Vaussard
of checking for ops, remove the corresponding debugfs entries if pinconf and/or pinmux are not implemented. Tested on OMAP3 (pinctrl-single). Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/pinctrl/core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

2014-02-03 Thread Florian Vaussard
On 01/31/2014 01:29 PM, Marc Kleine-Budde wrote: > On 01/31/2014 11:35 AM, Florian Vaussard wrote: >> Add the reg-io-width property to describe the width of the memory >> accesses. >> >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: Pawel Moll >>

Re: [PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

2014-02-03 Thread Florian Vaussard
On 01/31/2014 01:29 PM, Marc Kleine-Budde wrote: On 01/31/2014 11:35 AM, Florian Vaussard wrote: Add the reg-io-width property to describe the width of the memory accesses. Cc: Grant Likely grant.lik...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc

Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
On 01/31/2014 02:50 PM, Andreas Larsson wrote: > On 2014-01-31 14:40, Marc Kleine-Budde wrote: >> On 01/31/2014 02:34 PM, Florian Vaussard wrote: >>> Hello, >>> >>> (could someone with a SJA1000 on SPARC perform a functional test >>> to see

[PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
.gmane.org/gmane.linux.can/4831 Florian Vaussard (5): can: sja1000: convert printk to use netdev API can: sja1000: platform: use devm_* APIs can: sja1000: fuse of_platform into platform Documentation: devicetree: sja1000: add reg-io-width binding can: sja1000: of: add reg-io-width property for 8, 16

[PATCH v3 1/5] can: sja1000: convert printk to use netdev API

2014-01-31 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644 --- a/drivers/net/can

[PATCH v3 3/5] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
The OpenFirmware probe can be merged into the standard platform probe to leverage common code. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/Kconfig | 13 +- drivers/net/can/sja1000/Makefile | 1 - drivers/net/can/sja1000/sja1000_of_platform.c | 221

[PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-01-31 Thread Florian Vaussard
Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_platform.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff

[PATCH v3 4/5] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-31 Thread Florian Vaussard
Add the reg-io-width property to describe the width of the memory accesses. Cc: Grant Likely Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Signed-off-by: Florian Vaussard --- Documentation/devicetree

[PATCH v3 2/5] can: sja1000: platform: use devm_* APIs

2014-01-31 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_platform.c | 46 -- 1 file changed, 12 insertions(+), 34 deletions(-) diff --git a/drivers/net/can/sja1000

Re: [PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
On 01/31/2014 01:51 PM, Marc Kleine-Budde wrote: > On 01/31/2014 01:49 PM, Marc Kleine-Budde wrote: >> On 01/31/2014 01:45 PM, Florian Vaussard wrote: >>> Hello Marc, >>> >>> On 01/31/2014 01:33 PM, Marc Kleine-Budde wrote: >>>>

Re: [PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
Hello Marc, On 01/31/2014 01:33 PM, Marc Kleine-Budde wrote: > On 01/31/2014 11:35 AM, Florian Vaussard wrote: >> The OpenFirmware probe can be merged into the standard platform >> probe to leverage common code. > > Good work, as we want to replace the existing dr

Re: [PATCH v2 0/6] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
Hello Marc, On 01/31/2014 01:37 PM, Marc Kleine-Budde wrote: > On 01/31/2014 11:35 AM, Florian Vaussard wrote: >> Hello, >> >> Changes sinces v1: >> - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4) >> >> The first part of this series perform

[PATCH v2 2/6] can: sja1000: convert printk to use netdev API

2014-01-31 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644 --- a/drivers/net/can

[PATCH v2 3/6] can: sja1000: platform: use devm_* APIs

2014-01-31 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_platform.c | 46 -- 1 file changed, 12 insertions(+), 34 deletions(-) diff --git a/drivers/net/can/sja1000

[PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-31 Thread Florian Vaussard
Add the reg-io-width property to describe the width of the memory accesses. Cc: Grant Likely Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Signed-off-by: Florian Vaussard --- Documentation/devicetree

[PATCH v2 0/6] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
to correctly take into account the aliasing of the address bus. All patches were tested using OF boot on my OMAP3 system with a memory-mapped SJA1000. Thus, the non-OF path is not tested, as I do not have a platform data at hand. Regards, Florian Florian Vaussard (6): can: sja1000: remove unused

[PATCH v2 1/6] can: sja1000: remove unused defines

2014-01-31 Thread Florian Vaussard
Remove unused defines for the OF platform. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_of_platform.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000/sja1000_of_platform.c index 047accd

[PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
The OpenFirmware probe can be merged into the standard platform probe to leverage common code. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/Kconfig | 13 +- drivers/net/can/sja1000/Makefile | 1 - drivers/net/can/sja1000/sja1000_of_platform.c | 218

[PATCH v2 6/6] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-01-31 Thread Florian Vaussard
Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_platform.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff

[PATCH v2 6/6] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-01-31 Thread Florian Vaussard
Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_platform.c | 13 +++-- 1 file changed, 11 insertions

[PATCH v2 1/6] can: sja1000: remove unused defines

2014-01-31 Thread Florian Vaussard
Remove unused defines for the OF platform. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_of_platform.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000

[PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
The OpenFirmware probe can be merged into the standard platform probe to leverage common code. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/Kconfig | 13 +- drivers/net/can/sja1000/Makefile | 1 - drivers/net/can/sja1000

[PATCH v2 5/6] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-31 Thread Florian Vaussard
...@codeaurora.org Cc: devicet...@vger.kernel.org Acked-by: Rob Herring r...@kernel.org Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- Documentation/devicetree/bindings/net/can/sja1000.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/sja1000

[PATCH v2 0/6] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
to correctly take into account the aliasing of the address bus. All patches were tested using OF boot on my OMAP3 system with a memory-mapped SJA1000. Thus, the non-OF path is not tested, as I do not have a platform data at hand. Regards, Florian Florian Vaussard (6): can: sja1000: remove unused

[PATCH v2 2/6] can: sja1000: convert printk to use netdev API

2014-01-31 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644

[PATCH v2 3/6] can: sja1000: platform: use devm_* APIs

2014-01-31 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_platform.c | 46 -- 1 file changed, 12 insertions(+), 34 deletions(-) diff --git

Re: [PATCH v2 0/6] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
Hello Marc, On 01/31/2014 01:37 PM, Marc Kleine-Budde wrote: On 01/31/2014 11:35 AM, Florian Vaussard wrote: Hello, Changes sinces v1: - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4) The first part of this series performs serveral small cleanups (patches 1 to 3). Patch 4

Re: [PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
Hello Marc, On 01/31/2014 01:33 PM, Marc Kleine-Budde wrote: On 01/31/2014 11:35 AM, Florian Vaussard wrote: The OpenFirmware probe can be merged into the standard platform probe to leverage common code. Good work, as we want to replace the existing driver, I'm quite picky on this patch

Re: [PATCH v2 4/6] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
On 01/31/2014 01:51 PM, Marc Kleine-Budde wrote: On 01/31/2014 01:49 PM, Marc Kleine-Budde wrote: On 01/31/2014 01:45 PM, Florian Vaussard wrote: Hello Marc, On 01/31/2014 01:33 PM, Marc Kleine-Budde wrote: On 01/31/2014 11:35 AM, Florian Vaussard wrote: The OpenFirmware probe can

[PATCH v3 2/5] can: sja1000: platform: use devm_* APIs

2014-01-31 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_platform.c | 46 -- 1 file changed, 12 insertions(+), 34 deletions(-) diff --git

[PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-01-31 Thread Florian Vaussard
Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_platform.c | 16 ++-- 1 file changed, 14 insertions

[PATCH v3 4/5] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-31 Thread Florian Vaussard
...@codeaurora.org Cc: devicet...@vger.kernel.org Acked-by: Rob Herring r...@kernel.org Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- Documentation/devicetree/bindings/net/can/sja1000.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/sja1000

[PATCH v3 3/5] can: sja1000: fuse of_platform into platform

2014-01-31 Thread Florian Vaussard
The OpenFirmware probe can be merged into the standard platform probe to leverage common code. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/Kconfig | 13 +- drivers/net/can/sja1000/Makefile | 1 - drivers/net/can/sja1000

[PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
/4831 Florian Vaussard (5): can: sja1000: convert printk to use netdev API can: sja1000: platform: use devm_* APIs can: sja1000: fuse of_platform into platform Documentation: devicetree: sja1000: add reg-io-width binding can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit

[PATCH v3 1/5] can: sja1000: convert printk to use netdev API

2014-01-31 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644

Re: [PATCH v3 0/5] can: sja1000: cleanups and new OF property

2014-01-31 Thread Florian Vaussard
On 01/31/2014 02:50 PM, Andreas Larsson wrote: On 2014-01-31 14:40, Marc Kleine-Budde wrote: On 01/31/2014 02:34 PM, Florian Vaussard wrote: Hello, (could someone with a SJA1000 on SPARC perform a functional test to see if interrupts are working? it would be great :-) Changes since v2

Re: [PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
On 01/30/2014 04:36 PM, Marc Kleine-Budde wrote: > On 01/30/2014 04:27 PM, Florian Vaussard wrote: >> Hello, >> >> On 01/30/2014 04:22 PM, Marc Kleine-Budde wrote: >>> Hello Florian, >>> >>> On 01/30/2014 03:29 PM, Florian Vaussard wrote: >

Re: [PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
Hello, On 01/30/2014 04:22 PM, Marc Kleine-Budde wrote: > Hello Florian, > > On 01/30/2014 03:29 PM, Florian Vaussard wrote: >> The first part of this series performs serveral small cleanups >> (patches 1 to 3). > > Thanks for your contribution. I like patches 1 a

[PATCH 5/5] can: sja1000: of: add read/write routines for 8, 16 and 32-bit register access

2014-01-30 Thread Florian Vaussard
Add routines for 8, 16 and 32-bit access like in sja1000_platform.c Cc: Grant Likely Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_of_platform.c | 41

[PATCH 3/5] can: sja1000: of: use devm_* APIs

2014-01-30 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_of_platform.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/net/can/sja1000

[PATCH 1/5] can: sja1000: remove unused defines

2014-01-30 Thread Florian Vaussard
Remove unused defines for the OF platform. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_of_platform.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000/sja1000_of_platform.c index 047accd

[PATCH 4/5] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-30 Thread Florian Vaussard
Add the reg-io-width property to describe the width of the memory accesses. Cc: Grant Likely Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off-by: Florian Vaussard --- Documentation/devicetree/bindings/net/can/sja1000

[PATCH 2/5] can: sja1000: convert printk to use netdev API

2014-01-30 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644 --- a/drivers/net/can

[PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
system to correctly take into account the aliasing of the address bus. All patches were tested on my OMAP3 system with a memory-mapped SJA1000. Regards, Florian Florian Vaussard (5): can: sja1000: remove unused defines can: sja1000: convert printk to use netdev API can: sja1000: of: use devm_

[PATCH 2/5] can: sja1000: convert printk to use netdev API

2014-01-30 Thread Florian Vaussard
Use netdev_* where applicable. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c index f17c301..55cce47 100644

[PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
system to correctly take into account the aliasing of the address bus. All patches were tested on my OMAP3 system with a memory-mapped SJA1000. Regards, Florian Florian Vaussard (5): can: sja1000: remove unused defines can: sja1000: convert printk to use netdev API can: sja1000: of: use devm_

[PATCH 4/5] Documentation: devicetree: sja1000: add reg-io-width binding

2014-01-30 Thread Florian Vaussard
...@codeaurora.org Cc: devicet...@vger.kernel.org Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- Documentation/devicetree/bindings/net/can/sja1000.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/sja1000.txt b/Documentation/devicetree

[PATCH 1/5] can: sja1000: remove unused defines

2014-01-30 Thread Florian Vaussard
Remove unused defines for the OF platform. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_of_platform.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net/can/sja1000

[PATCH 3/5] can: sja1000: of: use devm_* APIs

2014-01-30 Thread Florian Vaussard
Simplify probe and remove functions by converting most of the resources to use devm_* APIs. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_of_platform.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git

[PATCH 5/5] can: sja1000: of: add read/write routines for 8, 16 and 32-bit register access

2014-01-30 Thread Florian Vaussard
...@codeaurora.org Cc: devicet...@vger.kernel.org Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- drivers/net/can/sja1000/sja1000_of_platform.c | 41 +++ 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/sja1000/sja1000_of_platform.c b/drivers/net

Re: [PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
Hello, On 01/30/2014 04:22 PM, Marc Kleine-Budde wrote: Hello Florian, On 01/30/2014 03:29 PM, Florian Vaussard wrote: The first part of this series performs serveral small cleanups (patches 1 to 3). Thanks for your contribution. I like patches 1 and 2. The second part introduces

Re: [PATCH 0/5] can: sja1000: cleanups and new OF property

2014-01-30 Thread Florian Vaussard
On 01/30/2014 04:36 PM, Marc Kleine-Budde wrote: On 01/30/2014 04:27 PM, Florian Vaussard wrote: Hello, On 01/30/2014 04:22 PM, Marc Kleine-Budde wrote: Hello Florian, On 01/30/2014 03:29 PM, Florian Vaussard wrote: The first part of this series performs serveral small cleanups (patches

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2014-01-15 Thread Florian Vaussard
Hi On 01/02/2014 02:01 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Jan 02, 2014 at 01:13:42AM +0100, Laurent Pinchart wrote: >>> + .of_match_table = omap_iommu_of_match, >> >> If CONFIG_OF isn't defined (pretty unlikely I agree, but a possibility you >> seem to be prepared for

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2014-01-15 Thread Florian Vaussard
Hi Suman, So back to this... On 12/24/2013 12:35 AM, Anna, Suman wrote: > Hi Florian, > [...] >> >> If omap_iommu_probe() fails, the init will have called bus_set_iommu() >> anyways. Thus, when a driver request the iommu by calling >> iommu_domain_alloc(), it will succeed (but

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2014-01-15 Thread Florian Vaussard
Hi Suman, So back to this... On 12/24/2013 12:35 AM, Anna, Suman wrote: Hi Florian, [...] If omap_iommu_probe() fails, the init will have called bus_set_iommu() anyways. Thus, when a driver request the iommu by calling iommu_domain_alloc(), it will succeed (but iommu_attach_device()

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2014-01-15 Thread Florian Vaussard
Hi On 01/02/2014 02:01 AM, Sebastian Reichel wrote: Hi, On Thu, Jan 02, 2014 at 01:13:42AM +0100, Laurent Pinchart wrote: + .of_match_table = omap_iommu_of_match, If CONFIG_OF isn't defined (pretty unlikely I agree, but a possibility you seem to be prepared for nonetheless

Re: [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:08 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> The data are now passed using the devicetree. > > Patch is good by itself. A similar change is needed for the IVA > MMU as well. > As I under

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:02 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Currently, bus_set_iommu() is done in omap_iommu_init(). However, >> omap_iommu_probe() can fail in a number of ways, leaving the platform >> bu

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:48 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3 >> "ARM: OMAP2+: Fix more missing data for omap3.dtsi file" adds >> bas

Re: [PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:12 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Add missing information required to probe the iommu for the camera >> subsystem. >> >> Signed-off-by: Florian Vaussard >> --

Re: [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:05 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> When booting with a devietree, no platform data is provided. Do not >> prematurely >> exit iommu_enable() and iommu_disable() in such a case. &

Re: [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 07:52 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> OMAP2+ is heading towards a full device tree boot for 3.14. Currently, >> the iommu used by the OMAP3 camera subsystem is not yet converted. I

Re: [PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 07:52 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: OMAP2+ is heading towards a full device tree boot for 3.14. Currently, the iommu used by the OMAP3 camera subsystem is not yet converted. It cannot be probed as necessary data

Re: [PATCH 5/7] ARM: dts: Complete data for isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:12 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Add missing information required to probe the iommu for the camera subsystem. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch --- arch/arm/boot/dts/omap3.dtsi | 4

Re: [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:05 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: When booting with a devietree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Platform data may still be needed

Re: [PATCH 6/7] ARM: OMAP2+: Remove legacy data from hwmod for omap3 isp iommu

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:08 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: The data are now passed using the devicetree. Patch is good by itself. A similar change is needed for the IVA MMU as well. As I understood, the IVA MMU is still

Re: [PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:02 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non

Re: [PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-23 Thread Florian Vaussard
Hi Suman, On 12/23/2013 08:48 PM, Anna, Suman wrote: Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3 ARM: OMAP2+: Fix more missing data for omap3.dtsi file adds basic DT bits. But the driver is not yet converted, so

[PATCH 4/7] iommu/omap: Allow enable/disable even without pdata

2013-12-17 Thread Florian Vaussard
When booting with a devietree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Signed-off-by: Florian Vaussard --- drivers/iommu/omap-iommu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iommu

[PATCH 3/7] iommu/omap: Convert to devicetree

2013-12-17 Thread Florian Vaussard
uses 'dma-window' (already used by Tegra SMMU) and adds a custom 'ti,#tlb-entries' binding. Signed-off-by: Florian Vaussard --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 19 arch/arm/mach-omap2/omap-iommu.c | 5 +++ drivers/iommu/om

[PATCH 0/7] Fix omap-iommu probe and convert to DT for 3.14

2013-12-17 Thread Florian Vaussard
...@github.com:vaussard/linux.git overo-for-3.14/iommu/dt Florian Vaussard (7): iommu/omap: Do bus_set_iommu() only if probe() succeeds iommu/omap: omap_iommu_attach() should return ENODEV, not NULL iommu/omap: Convert to devicetree iommu/omap: Allow enable/disable even without pdata ARM: dts

[PATCH 1/7] iommu/omap: Do bus_set_iommu() only if probe() succeeds

2013-12-17 Thread Florian Vaussard
Currently, bus_set_iommu() is done in omap_iommu_init(). However, omap_iommu_probe() can fail in a number of ways, leaving the platform bus with a dangling reference to a non-initialized iommu. Perform bus_set_iommu() only if omap_iommu_probe() succeed. Signed-off-by: Florian Vaussard

<    1   2   3   4   >