Re: [PATCH v7] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

Hi! Le lundi 4 décembre 2023, 22:46:35 CET Alessandro Carminati (Red Hat) a écrit : > In the kernel environment, situations frequently arise where identical > names are shared among symbols within both the core image and modules. > While this doesn't pose issues for the kernel's binary itself,

Re: [PATCH for-next] tracing/kprobes: Add symbol counting check when module loads

Hi! Le dimanche 29 octobre 2023, 05:10:46 EET Masami Hiramatsu (Google) a écrit : > From: Masami Hiramatsu (Google) > > Check the number of probe target symbols in the target module when > the module is loaded. If the probe is not on the unique name symbols > in the module, it will be rejected

Re: [PATCH for-next] tracing/kprobes: Add symbol counting check when module loads

Hi! Le mercredi 1 novembre 2023, 01:15:09 EET Masami Hiramatsu a écrit : > Hi, > > On Tue, 31 Oct 2023 23:24:43 +0200 > > Francis Laniel wrote: > > > @@ -729,17 +744,55 @@ static int count_mod_symbols(void *data, const > > > char > >

Re: [PATCH for-next] tracing/kprobes: Add symbol counting check when module loads

Hi! Le dimanche 29 octobre 2023, 05:10:46 EET Masami Hiramatsu (Google) a écrit : > From: Masami Hiramatsu (Google) > > Check the number of probe target symbols in the target module when > the module is loaded. If the probe is not on the unique name symbols > in the module, it will be rejected

Re: [PATCH] tracing/kprobes: Fix symbol counting logic by looking at modules as well

... Sorry about this... Thank you for the fix, I will handle the patch for older kernels in case there are troubles applying it. > Fix this my calling module_kallsyms_on_each_symbol() in addition to > kallsyms_on_each_match_symbol() to perform a proper counting. > > Cc: Fran

Re: [PATCH v6] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

Hi! Le mercredi 25 octobre 2023, 21:33:43 EEST Alessandro Carminati a écrit : > Hi Francis, > Thanks a lot for your feedback! You are welcome! > Il giorno mer 25 ott 2023 alle ore 15:21 Francis Laniel > > /* SNIP */ > > > debug >= DebugLevel.INFO.value: > >

Re: [PATCH v6] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

Hi! Le mardi 24 octobre 2023, 23:11:57 EEST Alessandro Carminati (Red Hat) a écrit : > In the kernel environment, scenarios often arise where identical names > are shared among symbols within core image or modules. > While this poses no complications for the kernel's binary itself, it > creates

Re: [PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

! Best regards. > On Fri, 20 Oct 2023 13:42:48 +0300 > > Francis Laniel wrote: > > Hi. > > > > > > In the kernel source code, it exists different functions which share the > > same name but which have, of course, different addresses as they can be >

[PATCH v6 1/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

...@vger.kernel.org Fixes: 413d37d1eb69 ("tracing: Add kprobe-based event tracer") Suggested-by: Masami Hiramatsu Signed-off-by: Francis Laniel Link: https://lore.kernel.org/lkml/20230819101105.b0c104ae4494a7d1f2eea...@kernel.org/ --- kernel/trace/trace_kpr

[PATCH v6 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

registering the kprobe. v3: * Check symbol does not contain ':' before testing its uniqueness. * Add a selftest to check this is not possible to install a kprobe for a non unique symbol. v5: * No changes, just add linux-stable as recipient. v6: * Rephrase commit message. * Add &qu

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le jeudi 19 octobre 2023, 18:07:08 EEST Masami Hiramatsu a écrit : > On Thu, 19 Oct 2023 09:51:04 -0400 > > Steven Rostedt wrote: > > On Thu, 19 Oct 2023 21:18:43 +0900 > > > > Masami Hiramatsu (Google) wrote: > > > > So why is this adding stable? (and as Greg's form letter states, > > >

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le jeudi 19 octobre 2023, 16:51:04 EEST Steven Rostedt a écrit : > On Thu, 19 Oct 2023 21:18:43 +0900 > > Masami Hiramatsu (Google) wrote: > > > So why is this adding stable? (and as Greg's form letter states, that's > > > not > > > how you do that) > > > > > > I don't see this as a fix

Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi! Le mercredi 18 octobre 2023, 20:00:42 EEST Steven Rostedt a écrit : > On Wed, 18 Oct 2023 17:40:28 +0300 > > Francis Laniel wrote: > > Changes since: > > v1: > > * Use EADDRNOTAVAIL instead of adding a new error code. > > * Correct also this behavio

Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

Hi! Le mercredi 18 octobre 2023, 09:30:20 EEST Masami Hiramatsu a écrit : > Hi Francis, > > On Thu, 31 Aug 2023 09:14:55 +0200 > > Francis Laniel wrote: > > Hi. > > > > Le mercredi 30 août 2023, 01:57:19 CEST Steven Rostedt a écrit : > &g

[PATCH v5 1/2] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols

, because the effectively called one has no kprobes attached. So, this commit returns EADDRNOTAVAIL when func matches several symbols. This way, user needs to use address to remove the ambiguity. Suggested-by: Masami Hiramatsu Signed-off-by: Francis Laniel Link: https://lore.kernel.org/lkml

[PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

higher than 1. * Return ENOENT if above count is 0, as it would be returned later by while registering the kprobe. v3: * Check symbol does not contain ':' before testing its uniqueness. * Add a selftest to check this is not possible to install a kprobe for a non unique symbol. v5: * No changes, ju

Re: [PATCH v5] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

Hi. Le mercredi 27 septembre 2023, 20:35:16 EEST Alessandro Carminati (Red Hat) a écrit : > It is not uncommon for drivers or modules related to similar peripherals > to have symbols with the exact same name. > While this is not a problem for the kernel's binary itself, it becomes an > issue

Re: [PATCH v4] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

10fa070 t name_show@kernel_irq_irqdesc_c_264 815e67c0 t name_show 815e67c0 t name_show@drivers_pnp_card_c_186 81728bb0 t name_show 81728bb0 t name_show@drivers_gpu_drm_i915_gt_sysfs_engines_c_26 > Il giorno mer 20 set 2023 alle ore 12:53 Francis Laniel > >

Re: [PATCH v4] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

Hi. Le mardi 19 septembre 2023, 22:39:48 EEST Alessandro Carminati (Red Hat) a écrit : > It is not uncommon for drivers or modules related to similar peripherals > to have symbols with the exact same name. > While this is not a problem for the kernel's binary itself, it becomes an > issue when

Re: UBSAN: shift-out-of-bounds in std_validate

Le mardi 19 janvier 2021, 19:39:17 CET syzbot a écrit : > Hello, > > syzbot found the following issue on: > > HEAD commit:1e2a199f Merge tag 'spi-fix-v5.11-rc4' of git://git.kernel.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=146e0c94d0 >

Re: [RFC PATCH v1 07/12] efi: Replace strstarts() by str_has_prefix().

Le vendredi 4 décembre 2020, 19:02:09 CET James Bottomley a écrit : > On Fri, 2020-12-04 at 18:07 +0100, Ard Biesheuvel wrote: > > On Fri, 4 Dec 2020 at 18:06, > > > > wrote: > > > From: Francis Laniel > > > > > > The two functions

Re: [RFC PATCH v1 07/12] efi: Replace strstarts() by str_has_prefix().

Le vendredi 4 décembre 2020, 18:07:11 CET Ard Biesheuvel a écrit : > On Fri, 4 Dec 2020 at 18:06, wrote: > > From: Francis Laniel > > > > The two functions indicates if a string begins with a given prefix. > > The only difference is that strstarts() returns a bo

Re: [PATCH v6 0/5] Fortify strscpy()

Le vendredi 20 novembre 2020, 20:52:07 CET Kees Cook a écrit : > On Fri, Nov 20, 2020 at 10:40:38AM +0100, Francis Laniel wrote: > > Le vendredi 20 novembre 2020, 02:35:43 CET Andrew Morton a écrit : > > > On Thu, 19 Nov 2020 17:49:10 +0100 laniel_fran...@privacyr

Re: [PATCH v6 0/5] Fortify strscpy()

Le vendredi 20 novembre 2020, 14:33:53 CET David Laight a écrit : > From: Andrew Morton > > > Sent: 20 November 2020 01:36 > > ... > > > Could you please send along a reworked [0/n] cover letter? Explain in > > your own words, without requiring that readers go off and read web > > pages > > >

Re: [PATCH v6 1/5] string.h: detect intra-object overflow in fortified string functions

Le vendredi 20 novembre 2020, 02:38:22 CET Andrew Morton a écrit : > On Thu, 19 Nov 2020 17:49:11 +0100 laniel_fran...@privacyrequired.com wrote: > > From: Daniel Axtens > > > > ... > > > > Cc: Daniel Micay > > Cc: Kees Cook > > Reviewed-by: Kees Cook > > Signed-off-by: Daniel Axtens > >

Re: [PATCH v6 0/5] Fortify strscpy()

Le vendredi 20 novembre 2020, 02:35:43 CET Andrew Morton a écrit : > On Thu, 19 Nov 2020 17:49:10 +0100 laniel_fran...@privacyrequired.com wrote: > > From: Francis Laniel > > > > Hi. > > > > > > I hope your families, friends and yourselves are fi

Re: [PATCH v5 4/5] Add new file in LKDTM to test fortified strscpy.

Le mercredi 18 novembre 2020, 21:02:32 CET Kees Cook a écrit : > On Wed, Nov 18, 2020 at 12:07:30PM +0100, laniel_fran...@privacyrequired.com wrote: > > From: Francis Laniel > > > > This new test ensures that fortified strscpy has the same behavior than > > vani