Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > > - The reason why printing the related information to > > > > ker

Re: [PATCH v14 1/3] binder: move structs from core file to header file

2020-11-11 Thread Frankie Chang
On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 11, 2020 at 11:02:42PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Moving all structs to header file makes module more > > extendable, and makes all these struc

[PATCH v14] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
Change from v14: - prevent from directly print transaction info to kernel log. - give up doing the date math in the kernel. - track msec only instead of both sec and msec. - change EXPORT_TRACEPOINT_SYMBOL to EXPORT_TRACEPOINT_SYMBOL_GPL. Change from v13: - modify patch subject. Change

[PATCH v13] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig | 8 + drivers/android/Makefile| 1 + drivers/android/binder.c|

[PATCH v12] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
Change from v12: - rebase. Change from v11: - rebase. Change from v10: - replace timespec64 with ktime_t. - fix build warning. Change from v9: - rename timestamp to ts in binder_internal.h for conciseness. - change timeval to timespec64 in binder_internal.h Change from v8: -

Re: binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
On Tue, 2020-11-10 at 08:53 +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 10, 2020 at 08:52:09AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 10, 2020 at 03:33:00PM +0800, Frankie Chang wrote: > > > On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > >

Re: binder: add transaction latency tracer

2020-11-09 Thread Frankie Chang
On Mon, 2020-11-09 at 18:46 +0100, Greg Kroah-Hartman wrote: > On Fri, Oct 30, 2020 at 12:08:54AM +0800, Frankie Chang wrote: > > Change from v11: > > - rebase. > > This whole patch set is sent with DOS line-ends, which makes git really > unhappy when it tries to

binder: add transaction latency tracer

2020-10-29 Thread Frankie Chang
Change from v11: - rebase. Change from v10: - replace timespec64 with ktime_t. - fix build warning. Change from v9: - rename timestamp to ts in binder_internal.h for conciseness. - change timeval to timespec64 in binder_internal.h Change from v8: - change rtc_time_to_tm to

[PATCH v10 3/3] binder: add transaction latency tracer

2020-10-15 Thread Frankie Chang
Change from v10: - replace timespec64 with ktime_t. - fix build warning. Change from v9: - rename timestamp to ts in binder_internal.h for conciseness. - change timeval to timespec64 in binder_internal.h Change from v8: - change rtc_time_to_tm to rtc_time64_to_tm. - change timeval to

[PATCH v9] binder: transaction latency tracking for user build

2020-09-08 Thread Frankie Chang
Change from v9: - rename timestamp to ts in binder_internal.h for conciseness. - change 'struct timeval' to 'struct timespec64' in binder_internal.h. Change from v8: - change rtc_time_to_tm to rtc_time64_to_tm. - change timeval to __kernel_old_timeval due to

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Frankie Chang
On Mon, 2020-09-07 at 16:09 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote: > > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > >

Re: [PATCH v8 3/3] binder: add transaction latency tracer

2020-09-07 Thread Frankie Chang
On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transac

[PATCH v8] binder: transaction latency tracking for user build

2020-09-07 Thread Frankie Chang
Change from v8: - change rtc_time_to_tm to rtc_time64_to_tm. - change timeval to __kernel_old_timeval due to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c766d1472c70d25ad475cf56042af1652e792b23 - export tracepoint symbol for binder_txn_latency_* which

Re: [PATCH v7] binder: transaction latency tracking for user build

2020-09-07 Thread Frankie Chang
On Thu, 2020-09-03 at 18:21 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 04, 2020 at 09:59:09PM +0800, Frankie Chang wrote: > > > > Frankie.Chang (3): > > binder: move structs from core file to header file > > binder: add trace at free transaction. > >

[PATCH v7 3/3] binder: add transaction latency tracer

2020-08-04 Thread Frankie Chang
From: "Frankie.Chang" Record start/end timestamp for binder transaction. When transaction is completed or transaction is free, it would be checked if transaction latency over threshold (default 2 sec), if yes, printing related information for tracing. /* Implement details */ - Add latency

[PATCH v7 2/3] binder: add trace at free transaction.

2020-08-04 Thread Frankie Chang
From: "Frankie.Chang" Since the original trace_binder_transaction_received cannot precisely present the real finished time of transaction, adding a trace_binder_txn_latency_free at the point of free transaction may be more close to it. Signed-off-by: Frankie.Chang --- drivers/android/binder.c

[PATCH v7] binder: transaction latency tracking for user build

2020-08-04 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig |8 + drivers/android/Makefile|1 + drivers/android/binder.c|

[PATCH v7 1/3] binder: move structs from core file to header file

2020-08-04 Thread Frankie Chang
From: "Frankie.Chang" Moving all structs to header file makes module more extendable, and makes all these structs to be defined in the same file. Signed-off-by: Frankie.Chang --- drivers/android/binder.c | 405 - drivers/android/binder_internal.h

Re: [PATCH v6 2/3] binder: add trace at free transaction.

2020-08-03 Thread Frankie Chang
On Mon, 2020-08-03 at 08:12 -0700, Todd Kjos wrote: > On Sun, Aug 2, 2020 at 8:11 PM Frankie Chang > wrote: > > > > On Fri, 2020-07-31 at 11:50 -0700, Todd Kjos wrote: > > > On Mon, Jul 27, 2020 at 8:28 PM Frankie Chang > > > wrote: > > > > >

Re: [PATCH v6 2/3] binder: add trace at free transaction.

2020-08-02 Thread Frankie Chang
On Fri, 2020-07-31 at 11:50 -0700, Todd Kjos wrote: > On Mon, Jul 27, 2020 at 8:28 PM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Since the original trace_binder_transaction_received cannot > > precisely present

[PATCH v6 3/3] binder: add transaction latency tracer

2020-07-27 Thread Frankie Chang
From: "Frankie.Chang" Record start/end timestamp for binder transaction. When transaction is completed or transaction is free, it would be checked if transaction latency over threshold (default 2 sec), if yes, printing related information for tracing. /* Implement details */ - Add latency

[PATCH v6] binder: transaction latency tracking for user build

2020-07-27 Thread Frankie Chang
Change from v6: - change CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING type from bool to tristate - add comments to @timestamp and @tv under struct binder_transaction - make binder_txn_latency threshold configurable - enhance lock protection Change from v5: - change config name to the

[PATCH v6 2/3] binder: add trace at free transaction.

2020-07-27 Thread Frankie Chang
From: "Frankie.Chang" Since the original trace_binder_transaction_received cannot precisely present the real finished time of transaction, adding a trace_binder_txn_latency_free at the point of free transaction may be more close to it. Signed-off-by: Frankie.Chang --- drivers/android/binder.c

[PATCH v6 1/3] binder: move structs from core file to header file

2020-07-27 Thread Frankie Chang
From: "Frankie.Chang" Moving all structs to header file makes module more extendable, and makes all these structs to be defined in the same file. Signed-off-by: Frankie.Chang --- drivers/android/binder.c | 405 - drivers/android/binder_internal.h

Re: [PATCH v5 3/3] binder: add transaction latency tracer

2020-07-22 Thread Frankie Chang
On Mon, 2020-07-20 at 11:56 -0700, Todd Kjos wrote: > On Wed, Jun 10, 2020 at 5:34 AM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction i

Re: [PATCH v5 2/3] binder: add trace at free transaction.

2020-07-22 Thread Frankie Chang
On Mon, 2020-07-20 at 11:23 -0700, Todd Kjos wrote: > On Wed, Jun 10, 2020 at 5:24 AM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Since the original trace_binder_transaction_received cannot > > precisely present

Re: [PATCH v5] binder: transaction latency tracking for user build

2020-07-20 Thread Frankie Chang
Hi Greg, Todd and all Gentle ping for this patch set Thanks On Thu, 2020-07-02 at 21:25 +0800, Frankie Chang wrote: > Hi Greg, Todd and all > > Gentle remind of this patch set > > Thanks. > Frankie > > On Wed, 2020-06-10 at 20:23 +0800, Frankie Chang wro

Re: [PATCH v5] binder: transaction latency tracking for user build

2020-07-02 Thread Frankie Chang
Hi Greg, Todd and all Gentle remind of this patch set Thanks. Frankie On Wed, 2020-06-10 at 20:23 +0800, Frankie Chang wrote: > Frankie.Chang (3): > binder: move structs from core file to header file > binder: add trace at free transaction. > binder: add transaction la

[PATCH v5] binder: transaction latency tracking for user build

2020-06-10 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig | 8 + drivers/android/Makefile| 1 + drivers/android/binder.c|

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-11 Thread Frankie Chang
On Thu, 2020-05-07 at 11:21 -0700, Todd Kjos wrote: > On Thu, May 7, 2020 at 1:11 AM Frankie Chang > wrote: > > > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction i

Re: [PATCH v4 3/3] binder: add transaction latency tracer

2020-05-11 Thread Frankie Chang
On Thu, 2020-05-07 at 10:55 +0200, Greg Kroah-Hartman wrote: > On Thu, May 07, 2020 at 04:10:55PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transac

binder: transaction latency tracking for user build

2020-05-07 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig | 8 + drivers/android/Makefile| 1 + drivers/android/binder.c|

[PATCH v3 1/1] binder: transaction latency tracking for user build

2020-04-30 Thread Frankie Chang
module In addition, moving all structs to header file makes module more extendable, and make all these strcuts to be defined in the same file. Signed-off-by: Frankie Chang --- drivers/android/Kconfig |8 + drivers/android/Makefile|1 + drivers/android

binder: transaction latency tracking for user build

2020-04-30 Thread Frankie Chang
Frankie Chang (1): binder: transaction latency tracking for user build drivers/android/Kconfig |8 + drivers/android/Makefile|1 + drivers/android/binder.c| 408 +- drivers/android/binder_internal.h

Re: [PATCH v2 1/1] binder: transaction latency tracking for user build

2020-04-29 Thread Frankie Chang
On Wed, 2020-04-15 at 15:25 -0700, Todd Kjos wrote: > On Tue, Apr 14, 2020 at 10:38 PM Frankie Chang > wrote: > > > > Record start/end timestamp to binder transaction. > > s/timestamp to/timestamps for/ > > > When transaction is completed or transaction