Re: [PATCH 02/11] procfs: Don't cache a pid in the root inode.

2012-11-20 Thread Gao feng
e complicated > code. Now that we don't need the struct pid, just remove it. > > Signed-off-by: Eric W. Biederman > --- Acked-by: Gao feng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH review 0/6] mount namespace container enhancements

2012-11-19 Thread Gao feng
于 2012年11月19日 18:48, Eric W. Biederman 写道: > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > mntns-v53 I think you mean mntns-v73 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More major

Re: [PATCH 05/11] pidns: Make the pidns proc mount/umount logic obvious.

2012-11-19 Thread Gao feng
locking the entire world waiting for the unnecessary > rcu_barrier in deactivate_locked_super. > > In the process of making the code clear and obvious this fixes a bug > reported by Gao feng where we would leak a > mount of proc during clone(CLONE_NEWPID|CLONE_NEWNET) if copy_pid_ns > succeeded and co

[PATCH] pidns: remove the useless function is_container_init

2012-11-19 Thread Gao feng
since commit 1cdcbec1a3372c0c49c59d292e708fd07b509f18, is_container_init has no used for a long time. just remove it. Signed-off-by: Gao feng --- include/linux/sched.h |6 -- kernel/pid.c | 15 --- 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a

Re: [PATCH 09/11] pidns: Add setns support

2012-11-19 Thread Gao feng
于 2012年11月17日 00:35, Eric W. Biederman 写道: > From: "Eric W. Biederman" > > - Pid namespaces are designed to be inescapable so verify that the > passed in pid namespace is a child of the currently active > pid namespace or the currently active pid namespace itself. > > Allowing the currentl

Re: [PATCH] namespace:unmount pid_namespace's proc_mnt when copy_net_ns failed

2012-11-02 Thread Gao feng
于 2012年11月02日 16:54, Eric W. Biederman 写道: > Gao feng writes: > >> 于 2012年11月02日 15:02, Eric W. Biederman 写道: >>> Gao feng writes: >>> >>>> we should call pid_ns_release_proc to unmount pid_namespace's >>>> proc_mnt when copy_net_ns fa

Re: [PATCH] namespace:unmount pid_namespace's proc_mnt when copy_net_ns failed

2012-11-02 Thread Gao feng
于 2012年11月02日 15:02, Eric W. Biederman 写道: > Gao feng writes: > >> we should call pid_ns_release_proc to unmount pid_namespace's >> proc_mnt when copy_net_ns failed in function create_new_namespaces. >> >> otherwise,the proc_mnt will not be freed and because

[PATCH] namespace:unmount pid_namespace's proc_mnt when copy_net_ns failed

2012-11-01 Thread Gao feng
er be released too. Signed-off-by: Gao feng --- kernel/nsproxy.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c index b576f7f..d536480 100644 --- a/kernel/nsproxy.c +++ b/kernel/nsproxy.c @@ -99,8 +99,11 @@ static struct ns

Re: [PATCH] net, cgroup: Fix boot failure due to iteration of uninitialized list

2012-07-22 Thread Gao feng
于 2012年07月20日 00:27, Srivatsa S. Bhat 写道: > After commit ef209f15 (net: cgroup: fix access the unallocated memory in > netprio cgroup), boot fails with the following NULL pointer dereference: > > Initializing cgroup subsys devices > Initializing cgroup subsys freezer > Initializing cgroup subsys n

[PATCH v4] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-12 Thread Gao feng
>priomap_len < max_len, this will make sure array size of dev->map->priomap always bigger than any prioidx. 3. add a function write_update_netdev_table to make codes clear. Change From v2: 1. protect extend_netdev_table by RTNL. 2. when extend_netdev_table failed,call dev_put to red

Re: [PATCH v3] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-11 Thread Gao feng
于 2012年07月11日 20:11, Neil Horman 写道: > On Wed, Jul 11, 2012 at 04:30:06PM +0800, Gao feng wrote: >> there are some out of bound accesses in netprio cgroup. >> >> now before accessing the dev->priomap.priomap array,we only check >> if the dev->priomap exist

[PATCH v3] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-11 Thread Gao feng
v_table, so when new_priomap is allocated failed,write_priomap will stop to access the priomap,and return -ENOMEM back to the userspace to tell the user what happend. Change From v2: 1. protect extend_netdev_table by RTNL. 2. when extend_netdev_table failed,call dev_put to reduce device's re

Re: [PATCH v2] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-10 Thread Gao feng
于 2012年07月10日 19:08, Eric Dumazet 写道: > On Tue, 2012-07-10 at 13:05 +0200, Eric Dumazet wrote: >> On Tue, 2012-07-10 at 18:44 +0800, Gao feng wrote: >>> there are some out of bound accesses in netprio cgroup. >> >>> - update_netdev_tables(); >>>

[PATCH v2] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-10 Thread Gao feng
v_table, so when new_priomap is allocated failed,write_priomap will stop to access the priomap,and return -ENOMEM back to the userspace to tell the user what happend. Signed-off-by: Gao feng Cc: Neil Horman Cc: Eric Dumazet --- net/core/netprio_cgroup.c | 50 +++---

Re: [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-10 Thread Gao feng
于 2012年07月10日 17:15, Eric Dumazet 写道: > On Tue, 2012-07-10 at 16:53 +0800, Gao feng wrote: >>> Hi Gao >>> >>> Is it still needed to call update_netdev_tables() from write_priomap() ? >>> >> >> Yes, I think it's needed,because read_priomap wi

Re: [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-10 Thread Gao feng
> Hi Gao > > Is it still needed to call update_netdev_tables() from write_priomap() ? > Yes, I think it's needed,because read_priomap will show all of the net devices, But we may add the netdev after create a netprio cgroup, so the new added netdev's priomap will not be allocated. if we don't

Re: [PATCH] net: cgroup: fix out of bounds accesses

2012-07-09 Thread Gao feng
于 2012年07月10日 05:51, David Miller 写道: > From: Gao feng > Date: Mon, 09 Jul 2012 16:15:29 +0800 > >> 于 2012年07月09日 15:45, Eric Dumazet 写道: >>> From: Eric Dumazet >>> >>> dev->priomap is allocated by extend_netdev_table() called from >>>

[PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-09 Thread Gao feng
rite_priomap will stop to access the priomap,and return -ENOMEM back to the userspace to tell the user what happend. Signed-off-by: Gao feng Cc: Neil Horman Cc: Eric Dumazet --- net/core/netprio_cgroup.c | 43 +-- 1 files changed, 29 insertions(+),

Re: [PATCH] net: cgroup: fix out of bounds accesses

2012-07-09 Thread Gao feng
out of bounds > accesses in cgrp_destroy(), read_priomap() & skb_update_prio() > > With help from Gao Feng > > Signed-off-by: Eric Dumazet > Cc: Neil Horman > Cc: Gao feng > --- > net/core/dev.c|8 ++-- > net/core/netprio_cgroup.c |4 ++--

Re: [PATCH v2] cgroup: fix panic in netprio_cgroup

2012-07-08 Thread Gao feng
于 2012年07月09日 03:50, Eric Dumazet 写道: > On Thu, 2012-07-05 at 17:28 +0800, Gao feng wrote: >> we set max_prioidx to the first zero bit index of prioidx_map in >> function get_prioidx. >> >> So when we delete the low index netprio cgroup and adding a new >> netprio

<    1   2   3