Hi Bin,
On 5/19/2014 9:24 PM, Bin Liu wrote:
Hi,
On Mon, May 19, 2014 at 8:39 AM, George Cherian george.cher...@ti.com wrote:
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions
system sleep.
George Cherian (6):
usb: dwc3: dwc3-omap: Remove x_major calculation from revision
register
usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset() function
usb: dwc3: dwc3-omap: Add dwc3_omap_set_utmi_mode() function
usb: dwc3: dwc3-omap: Add dwc3_omap_extcon_register function
[c00a9e5c]
(SyS_delete_module+0x10c/0x198)
[c00a9e5c] (SyS_delete_module) from [c000e5e0] (ret_fast_syscall+0x0/0x48)
Code: e1a04000 e59f0068 eb14505e e5943010 (e5932018)
---[ end trace 7e2a8746ff4fc811 ]---
Segmentation fault
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb
The dwc3 wrapper driver should not be fiddling with the core interrupts.
Disabling the core interrupts in prepare stops xhci from proper operation.
So remove disable/enable of core interrupts from prepare/complete.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3
Move map offset to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
Signed-off-by: George Cherian george.cher...@ti.com
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19
Hi Bin,
On 5/15/2014 8:49 PM, Bin Liu wrote:
George,
On Thu, May 15, 2014 at 1:28 AM, George Cherian george.cher...@ti.com wrote:
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 9:34 AM, Bin Liu binml...@gmail.com wrote:
George,
On Wed, May 14, 2014 at 12
)
Enable sw babble control properly (Patch #6)
v2 - v3 : Modify musb_platform_reset() to return zero on success.
George Cherian (6):
usb: musb: core: Handle Babble condition only in HOST mode
usb: musb: core: Convert babble recover work to delayed work
usb: musb: dsps: Call
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 2
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 37
-howto.txt
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index eff3c5c..8920b80
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 9:34 AM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 12:37 AM, George Cherian wrote:
On 5/14/2014 12:07 AM, Bin Liu wrote:
Hi,
On Tue, May 13, 2014 at 8:24 AM, George Cherian
wrote:
Hi Daniel,
On 5/13
Hi Tony,
On 5/15/2014 3:20 AM, Tony Lindgren wrote:
* George Cherian [140508 23:34]:
Re arrange the USB dt for AM33xx to take it a bit closer
to the hardware configuration.
The USBSS is designed as follows
USB control Module 0x44e10_0620
USBSS 0x4740_
USB0
Hi Tony,
On 5/15/2014 3:20 AM, Tony Lindgren wrote:
* George Cherian george.cher...@ti.com [140508 23:34]:
Re arrange the USB dt for AM33xx to take it a bit closer
to the hardware configuration.
The USBSS is designed as follows
USB control Module 0x44e10_0620
USBSS
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 9:34 AM, Bin Liu binml...@gmail.com wrote:
George,
On Wed, May 14, 2014 at 12:37 AM, George Cherian george.cher...@ti.com wrote:
On 5/14/2014 12:07 AM, Bin Liu wrote:
Hi,
On Tue, May 13, 2014 at 8:24 AM, George
On 5/13/2014 9:20 PM, Felipe Balbi wrote:
Hi,
On Thu, May 08, 2014 at 03:03:07PM +0530, George Cherian wrote:
Enabling the core interrupts in complete is too late for XHCI, and stops
xhci from proper operation. So remove prepare and complete and disable/enable
isn't this a bug in xhci ? I
On 5/13/2014 9:20 PM, Felipe Balbi wrote:
Hi,
On Thu, May 08, 2014 at 03:03:07PM +0530, George Cherian wrote:
Enabling the core interrupts in complete is too late for XHCI, and stops
xhci from proper operation. So remove prepare and complete and disable/enable
isn't this a bug in xhci ? I
On 5/13/2014 9:32 PM, Felipe Balbi wrote:
Hi,
On Thu, May 08, 2014 at 03:03:03PM +0530, George Cherian wrote:
Calculate the wrapper register offsets in a seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3
On 5/14/2014 12:07 AM, Bin Liu wrote:
Hi,
On Tue, May 13, 2014 at 8:24 AM, George Cherian wrote:
Hi Daniel,
On 5/13/2014 6:44 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 02:57 PM, George Cherian wrote:
I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL
reg.
can
Hi Daniel,
On 5/13/2014 6:44 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 02:57 PM, George Cherian wrote:
I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL reg.
can you try with the following patch.
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb
On 5/13/2014 5:50 PM, Daniel Mack wrote:
On 05/13/2014 01:57 PM, George Cherian wrote:
On 5/13/2014 3:16 PM, Daniel Mack wrote:
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation
On 5/13/2014 3:16 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation of
silicon version is done by checking the BABBLE_CTL register.
For newer silicon
-howto.txt
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 61da471..dcadc62 100644
--- a/drivers
ol()
Patch 5 -> Enable sw babble control for newer silicon
v2 -> v3 : Modify musb_platform_reset() to return zero on success.
v1 -> v2 : Fixed the issue with Patch 5. In v1 it was not calling
sw_babble_control().
George Cherian (5):
usb: musb: core: Convert babble re
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 34
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 34
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10
sw babble control for newer silicon
v2 - v3 : Modify musb_platform_reset() to return zero on success.
v1 - v2 : Fixed the issue with Patch 5. In v1 it was not calling
sw_babble_control().
George Cherian (5):
usb: musb: core: Convert babble recover work to delayed work
usb
-howto.txt
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 61da471..dcadc62
On 5/13/2014 3:16 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation of
silicon version is done by checking the BABBLE_CTL register.
For newer silicon
On 5/13/2014 5:50 PM, Daniel Mack wrote:
On 05/13/2014 01:57 PM, George Cherian wrote:
On 5/13/2014 3:16 PM, Daniel Mack wrote:
On 05/13/2014 10:31 AM, George Cherian wrote:
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation
Hi Daniel,
On 5/13/2014 6:44 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 02:57 PM, George Cherian wrote:
I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL reg.
can you try with the following patch.
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb
On 5/14/2014 12:07 AM, Bin Liu wrote:
Hi,
On Tue, May 13, 2014 at 8:24 AM, George Cherian george.cher...@ti.com wrote:
Hi Daniel,
On 5/13/2014 6:44 PM, Daniel Mack wrote:
Hi George,
On 05/13/2014 02:57 PM, George Cherian wrote:
I never enabled the MUSB_BABBLE_SW_SESSION_CTRL
On 5/13/2014 9:32 PM, Felipe Balbi wrote:
Hi,
On Thu, May 08, 2014 at 03:03:03PM +0530, George Cherian wrote:
Calculate the wrapper register offsets in a seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 -> v2 Address review comments.
v2 -> v3 Remove a stale commit comment.
George Cherian (3):
driver net: cpsw: Convert pr_*() to dev_*()
Convert all pr_*() calls to dev_*() calls.
No functional changes.
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/cpsw.c | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/ti
Convert the lone pr_err() to dev_err() call.
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers/net/ethernet/ti/davinci_mdio.c
Convert kzalloc() to devm_kzalloc().
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/davinci_cpdma.c | 35 +++--
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c
b/drivers
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 - v2 Address review comments.
v2 - v3 Remove a stale commit comment.
George Cherian (3):
driver net: cpsw: Convert pr_*() to dev_*() calls
net
Convert all pr_*() calls to dev_*() calls.
No functional changes.
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/cpsw.c | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff
Convert the lone pr_err() to dev_err() call.
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers
Convert kzalloc() to devm_kzalloc().
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/davinci_cpdma.c | 35 +++--
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/drivers/net/ethernet
: {
0x44e10_0620
}
usb0: {
0x4740_1000
0x4740_1400
}
usb0_phy:{
0x4740_1300
}
usb1:{
0x4740_1800
0x4740_1c00
}
usb1_phy: {
0x4740_1b00
}
cppi41dma: {
0x4740_2000
0x4740_3000
0x4740_4000
}
}
Signed-off-by: George Cherian
---
arch
: {
0x44e10_0620
}
usb0: {
0x4740_1000
0x4740_1400
}
usb0_phy:{
0x4740_1300
}
usb1:{
0x4740_1800
0x4740_1c00
}
usb1_phy: {
0x4740_1b00
}
cppi41dma: {
0x4740_2000
0x4740_3000
0x4740_4000
}
}
Signed-off-by: George Cherian george.cher
On 5/8/2014 10:20 PM, Yuval Mintz wrote:
Also, Convert kzalloc to devm_kzalloc.
Looks like you should remove this part of the comment.
Ah... Missed to update the commit log after rebasing patch to net-next.
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet
AM335x MUSB supports both PIO and DMA mode. When DMA mode is
selected users need to explicitly enable the DMA driver. To avoid the
extra configuration select the DMA driver if DMA mode is set for AM335x MUSB.
Signed-off-by: George Cherian
---
drivers/usb/musb/Kconfig | 1 +
1 file changed, 1
On 5/8/2014 3:17 PM, Daniel Mack wrote:
Hi Geroge,
On 05/08/2014 11:35 AM, George Cherian wrote:
-static inline void musb_platform_reset(struct musb *musb)
+static inline int musb_platform_reset(struct musb *musb)
{
- if (musb->ops->reset)
- musb->ops-&g
Convert all pr_*() calls to dev_*() calls.
No functional changes.
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/cpsw.c | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/ti
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 -> v2 Address review comments.
George Cherian (3):
driver net: cpsw: Convert pr_*() to dev_*() calls
net: davinci_mdio: Convert pr_
Convert the lone pr_err() to dev_err() call.
Also, Convert kzalloc to devm_kzalloc.
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b
Convert kzalloc() to devm_kzalloc().
Signed-off-by: George Cherian
Reviewed-by: Felipe Balbi
---
drivers/net/ethernet/ti/davinci_cpdma.c | 35 +++--
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c
b/drivers
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c
The series does some refactoring on dwc3_probe()
Patch 1-3 - reduce the size of dwc3_probe()
Patch 4 - Fix the crash on dwc3_omap removal
Patch 5 - Addresses the issue of xhci hang while resuming from system sleep.
George Cherian (5):
usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 61da471..dcadc62 100644
--- a/drivers/usb
ol()
Patch 5 -> Enable sw babble control for newer silicon
v1 -> v2 : Fixed the issue with Patch 5. In v1 it was not calling
sw_babble_control().
George Cherian (5):
usb: musb: core: Convert babble recover work to delayed work
usb: musb: dsps: Call usb_phy(_shut
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10 ++
drivers/usb/musb
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian
---
drivers/usb/musb/musb_dsps.c | 34
7e2a8746ff4fc811 ]---
Segmentation fault
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 0b9b1d8..82b20d8f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/drivers
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git
Enabling the core interrupts in complete is too late for XHCI, and stops
xhci from proper operation. So remove prepare and complete and disable/enable
interrupts in suspend/resume
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 20 ++--
1 file changed, 2
Calculate the wrapper register offsets in a seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/dwc3-omap.c | 80
1 file changed, 44 insertions(+), 36 deletions(-)
diff
Enabling the core interrupts in complete is too late for XHCI, and stops
xhci from proper operation. So remove prepare and complete and disable/enable
interrupts in suspend/resume
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 20 ++--
1
Calculate the wrapper register offsets in a seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 80
1 file changed, 44 insertions(+), 36
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions
[c00a9e5c]
(SyS_delete_module+0x10c/0x198)
[c00a9e5c] (SyS_delete_module) from [c000e5e0] (ret_fast_syscall+0x0/0x48)
Code: e1a04000 e59f0068 eb14505e e5943010 (e5932018)
---[ end trace 7e2a8746ff4fc811 ]---
Segmentation fault
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 15 ---
drivers/usb/musb/musb_core.h | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 61da471..dcadc62 100644
sw babble control for newer silicon
v1 - v2 : Fixed the issue with Patch 5. In v1 it was not calling
sw_babble_control().
George Cherian (5):
usb: musb: core: Convert babble recover work to delayed work
usb: musb: dsps: Call usb_phy(_shutdown/_init) during
resetting the IP block. In preperation to add that support
its better to have a rest_done return for musb_platform_reset().
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 38 +-
drivers/usb/musb/musb_core.h | 10
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 34
The series does some refactoring on dwc3_probe()
Patch 1-3 - reduce the size of dwc3_probe()
Patch 4 - Fix the crash on dwc3_omap removal
Patch 5 - Addresses the issue of xhci hang while resuming from system sleep.
George Cherian (5):
usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb
Convert the lone pr_err() to dev_err() call.
Also, Convert kzalloc to devm_kzalloc.
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Convert kzalloc() to devm_kzalloc().
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/davinci_cpdma.c | 35 +++--
1 file changed, 12 insertions(+), 23 deletions(-)
diff --git a/drivers/net/ethernet
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 - v2 Address review comments.
George Cherian (3):
driver net: cpsw: Convert pr_*() to dev_*() calls
net: davinci_mdio: Convert pr_err
Convert all pr_*() calls to dev_*() calls.
No functional changes.
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba...@ti.com
---
drivers/net/ethernet/ti/cpsw.c | 50 +-
1 file changed, 25 insertions(+), 25 deletions(-)
diff
On 5/8/2014 3:17 PM, Daniel Mack wrote:
Hi Geroge,
On 05/08/2014 11:35 AM, George Cherian wrote:
-static inline void musb_platform_reset(struct musb *musb)
+static inline int musb_platform_reset(struct musb *musb)
{
- if (musb-ops-reset)
- musb-ops-reset(musb
AM335x MUSB supports both PIO and DMA mode. When DMA mode is
selected users need to explicitly enable the DMA driver. To avoid the
extra configuration select the DMA driver if DMA mode is set for AM335x MUSB.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/Kconfig | 1
On 5/8/2014 10:20 PM, Yuval Mintz wrote:
Also, Convert kzalloc to devm_kzalloc.
Looks like you should remove this part of the comment.
Ah... Missed to update the commit log after rebasing patch to net-next.
Signed-off-by: George Cherian george.cher...@ti.com
Reviewed-by: Felipe Balbi ba
Hi,
Please ignore this patch.
It actually doesnot call sw_babble_ control() at all.
It should have.
Will post a fixed version.
On 5/7/2014 7:39 PM, George Cherian wrote:
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed
Hi,
Please ignore this patch.
It actually doesnot call sw_babble_ control() at all.
It should have.
Will post a fixed version.
On 5/7/2014 7:39 PM, George Cherian wrote:
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed
Hi David,
On 5/5/2014 9:57 AM, George Cherian wrote:
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 -> v2 Address review comments.
George Cherian (3):
driver net: cpsw: Convert
Hi David,
On 5/5/2014 9:57 AM, George Cherian wrote:
This series does some minimal cleanups.
-Conversion of pr_*() to dev_*()
-Convert kzalloc to devm_kzalloc.
No functional changes.
v1 - v2 Address review comments.
George Cherian (3):
driver net: cpsw: Convert pr_
CPTS refclk name is hardcoded, which makes it fail in case of DRA7x
Remove the hardcoded clock name for CPTS refclk and get the same from DT.
Signed-off-by: George Cherian
---
drivers/net/ethernet/ti/cpts.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers
Add CPSW fck and CPTS clock and clock names
Signed-off-by: George Cherian
---
arch/arm/boot/dts/am33xx.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9770e35..d1e2b36 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b
Add CPSW fck and CPTS clock and clock names for AM4372
Signed-off-by: George Cherian
---
arch/arm/boot/dts/am4372.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 36d523a..c2779f6 100644
--- a/arch/arm/boot/dts/am4372
or running slower than expected!
By selecting dpll_core_m5_ck as the clocksource fixes this issue.
In AM335x dpll_core_m5_ck is the default clocksource.
Signed-off-by: George Cherian
---
drivers/clk/ti/clk-43xx.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/clk/ti/clk
501 - 600 of 1006 matches
Mail list logo
