Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:58:58PM +0100, Gianluca Anzolin wrote: > On Mon, Dec 16, 2013 at 09:27:20PM +0100, Gianluca Anzolin wrote: > > On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: > > > On Mon, Dec 16, 2013 at 02:34:12PM -0500,

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:27:20PM +0100, Gianluca Anzolin wrote: > On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: > > On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: > > > > > > This solution is acceptable to me, but I think

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: > On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: > > > > This solution is acceptable to me, but I think the comment should briefly > > explain why this fix is necessary, and the changel

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: > > This solution is acceptable to me, but I think the comment should briefly > explain why this fix is necessary, and the changelog should explain why in > detail. > > Perhaps with a fixme comment that rfcomm_tty_install() should

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: This solution is acceptable to me, but I think the comment should briefly explain why this fix is necessary, and the changelog should explain why in detail. Perhaps with a fixme comment that rfcomm_tty_install() should just

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: This solution is acceptable to me, but I think the comment should briefly explain why this fix is necessary, and the changelog should explain why in detail

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:27:20PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: This solution is acceptable to me, but I think the comment should briefly explain why

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-16 Thread Gianluca Anzolin
On Mon, Dec 16, 2013 at 09:58:58PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 09:27:20PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 09:20:44PM +0100, Gianluca Anzolin wrote: On Mon, Dec 16, 2013 at 02:34:12PM -0500, Peter Hurley wrote: This solution

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-15 Thread Gianluca Anzolin
On Sun, Dec 15, 2013 at 09:03:35AM -0500, Peter Hurley wrote: > On 12/15/2013 06:24 AM, Gianluca Anzolin wrote: > >On Fri, Dec 13, 2013 at 12:35:26AM +0100, Alexander Holler wrote: > >>Am 12.12.2013 21:36, schrieb Peter Hurley: > >> > >>>>What curre

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-15 Thread Gianluca Anzolin
On Fri, Dec 13, 2013 at 12:35:26AM +0100, Alexander Holler wrote: > Am 12.12.2013 21:36, schrieb Peter Hurley: > > >> What currently happens is that when one kills rfcomm (and any other > >> terminal which might use that tty), the entry in /dev doesn't > >> disappear. That means the same call to

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-15 Thread Gianluca Anzolin
On Fri, Dec 13, 2013 at 12:35:26AM +0100, Alexander Holler wrote: Am 12.12.2013 21:36, schrieb Peter Hurley: What currently happens is that when one kills rfcomm (and any other terminal which might use that tty), the entry in /dev doesn't disappear. That means the same call to refcomm

Re: [REGRESSION] rfcomm (userland) broken by commit 29cd718b

2013-12-15 Thread Gianluca Anzolin
On Sun, Dec 15, 2013 at 09:03:35AM -0500, Peter Hurley wrote: On 12/15/2013 06:24 AM, Gianluca Anzolin wrote: On Fri, Dec 13, 2013 at 12:35:26AM +0100, Alexander Holler wrote: Am 12.12.2013 21:36, schrieb Peter Hurley: What currently happens is that when one kills rfcomm (and any other

Re: [PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-25 Thread Gianluca Anzolin
On Thu, Jul 25, 2013 at 10:14:36AM +0200, Gianluca Anzolin wrote: > On Thu, Jul 25, 2013 at 08:26:45AM +0200, Jiri Slaby wrote: > > On 07/25/2013 07:26 AM, Gianluca Anzolin wrote: > > > The function tty_port_tty_hangup() could leak a reference to the > > > tty_struct:

Re: [PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-25 Thread Gianluca Anzolin
On Thu, Jul 25, 2013 at 08:26:45AM +0200, Jiri Slaby wrote: > On 07/25/2013 07:26 AM, Gianluca Anzolin wrote: > > The function tty_port_tty_hangup() could leak a reference to the tty_struct: > > > > struct tty_struct *tty = tty_port_tty_get(port); >

Re: [PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-25 Thread Gianluca Anzolin
On Thu, Jul 25, 2013 at 08:26:45AM +0200, Jiri Slaby wrote: On 07/25/2013 07:26 AM, Gianluca Anzolin wrote: The function tty_port_tty_hangup() could leak a reference to the tty_struct: struct tty_struct *tty = tty_port_tty_get(port); if (tty (!check_clocal

Re: [PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-25 Thread Gianluca Anzolin
On Thu, Jul 25, 2013 at 10:14:36AM +0200, Gianluca Anzolin wrote: On Thu, Jul 25, 2013 at 08:26:45AM +0200, Jiri Slaby wrote: On 07/25/2013 07:26 AM, Gianluca Anzolin wrote: The function tty_port_tty_hangup() could leak a reference to the tty_struct: struct tty_struct *tty

[PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-24 Thread Gianluca Anzolin
!= NULL and the second condition is false we never call tty_kref_put and the reference is leaked. Fix by always calling tty_kref_put() which accepts a NULL argument. The patch fixes a regression introduced by commit aa27a094. Acked-by: Gustavo Padovan Signed-off-by: Gianluca Anzolin --- drivers/tty/tty_po

[PATCH] tty_port: Fix refcounting leak in tty_port_tty_hangup()

2013-07-24 Thread Gianluca Anzolin
condition is false we never call tty_kref_put and the reference is leaked. Fix by always calling tty_kref_put() which accepts a NULL argument. The patch fixes a regression introduced by commit aa27a094. Acked-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Signed-off-by: Gianluca Anzolin

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Gianluca Anzolin
, 2013 at 10:35:35AM +0200, Gianluca Anzolin wrote: > Hello, > > In linux 3.10 in the file drivers/tty/tty_port.c the function > tty_port_tty_hangup may leak a tty reference: > > struct tty_struct *tty = tty_port_tty_get(port); > > if (tty &&

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Gianluca Anzolin
, 2013 at 10:35:35AM +0200, Gianluca Anzolin wrote: Hello, In linux 3.10 in the file drivers/tty/tty_port.c the function tty_port_tty_hangup may leak a tty reference: struct tty_struct *tty = tty_port_tty_get(port); if (tty (!check_clocal || !C_CLOCAL(tty

[PATCH] Fix refcount leak in tty_port.c

2013-07-09 Thread Gianluca Anzolin
_put(tty); } If tty != NULL and the second condition is false we never call tty_kref_put and the reference is leaked. Fix by nesting two if statements. Signed-off-by: Gianluca Anzolin diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 121aeb9..2198f7d 100644 --- a/dri

[PATCH] Fix refcount leak in tty_port.c

2013-07-09 Thread Gianluca Anzolin
); } If tty != NULL and the second condition is false we never call tty_kref_put and the reference is leaked. Fix by nesting two if statements. Signed-off-by: Gianluca Anzolin gianl...@sottospazio.it diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 121aeb9..2198f7d 100644

Odd size of Shared Memory

2001-06-15 Thread Gianluca Anzolin
nel bug to me, but it didn't hurt, my PC is working without problems Gianluca Anzolin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Odd size of Shared Memory

2001-06-15 Thread Gianluca Anzolin
bug to me, but it didn't hurt, my PC is working without problems Gianluca Anzolin - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

OOPS with 2.4.2-ac12

2001-03-08 Thread Gianluca Anzolin
Hello, I've been experiencing since 2.4.2-ac5 (I'm not sure about this) some oops on one of my PCs: it's a Pentium Classic 166, 84 MB of RAM, kernel 2.4.2-ac12. It works as a gateway (doing NAT) between my LAN and internet. I use a ISDN card (Hisax HFC-PCI) and a NE2000 compatible nic (ne.c). I

OOPS with 2.4.2-ac12

2001-03-08 Thread Gianluca Anzolin
Hello, I've been experiencing since 2.4.2-ac5 (I'm not sure about this) some oops on one of my PCs: it's a Pentium Classic 166, 84 MB of RAM, kernel 2.4.2-ac12. It works as a gateway (doing NAT) between my LAN and internet. I use a ISDN card (Hisax HFC-PCI) and a NE2000 compatible nic (ne.c). I

NE2000 problem

2001-03-05 Thread Gianluca Anzolin
Hello, I'm experiencing a problem with an old NE2000 card. I use the ne.c driver provided with 2.4.x kernels. (I'm using 2.4.2-ac11) The problem is that I can ping the card (with any packet size) but if I try ssh it doesn't work, the same for other programs which use TCP. So

NE2000 problem

2001-03-05 Thread Gianluca Anzolin
Hello, I'm experiencing a problem with an old NE2000 card. I use the ne.c driver provided with 2.4.x kernels. (I'm using 2.4.2-ac11) The problem is that I can ping the card (with any packet size) but if I try ssh it doesn't work, the same for other programs which use TCP. So

Re: KERNEL BUG: console not working in linux

2000-11-28 Thread Gianluca Anzolin
|No, the problem is the utterly braindamaged way the motherboard chose to |enable/disable it (*especially* if it's PCI... sheech, port 92h isn't |exactly something new in that timeframe.) | |What PC/motherboard is this, anyway? It's an olivetti, but maybe they bought the mainboard elsewhere I

Re: KERNEL BUG: console not working in linux

2000-11-28 Thread Gianluca Anzolin
|No, the problem is the utterly braindamaged way the motherboard chose to |enable/disable it (*especially* if it's PCI... sheech, port 92h isn't |exactly something new in that timeframe.) | |What PC/motherboard is this, anyway? It's an olivetti, but maybe they bought the mainboard elsewhere I

Re: KERNEL BUG: console not working in linux

2000-11-27 Thread Gianluca Anzolin
Il giorno Mon, Nov 27, 2000 at 11:08:10AM -0800, H. Peter Anvin scrisse: |Yes, it can. Unfortunately, some "legacy-free" PCs apparently are |starting to take the tack that the KBC is legacy. Therefore, the use |of port 92h is mandatory on those systems. | |Port 92h dates back to at the very

Re: KERNEL BUG: console not working in linux

2000-11-27 Thread Gianluca Anzolin
Problem solved I had to bypass the following instructions in arch/i386/boot/setup.S # # You must preserve the other bits here. Otherwise embarrasing # things # like laptops powering off on boot happen. Corrected version by # Kira # Brown from Linux 2.2 #

Re: KERNEL BUG: console not working in linux

2000-11-27 Thread Gianluca Anzolin
Problem solved I had to bypass the following instructions in arch/i386/boot/setup.S # # You must preserve the other bits here. Otherwise embarrasing # things # like laptops powering off on boot happen. Corrected version by # Kira # Brown from Linux 2.2 #

Re: KERNEL BUG: console not working in linux

2000-11-27 Thread Gianluca Anzolin
Il giorno Mon, Nov 27, 2000 at 11:08:10AM -0800, H. Peter Anvin scrisse: |Yes, it can. Unfortunately, some "legacy-free" PCs apparently are |starting to take the tack that the KBC is legacy. Therefore, the use |of port 92h is mandatory on those systems. | |Port 92h dates back to at the very

KERNEL BUG: console not working in linux

2000-11-26 Thread Gianluca Anzolin
Hello sorry if I'm mailing this twice, but there is a kernel bug in linux 2.2 and linux 2.4. Linux 2.0 is not affected. I tested also FreeBSD, OpenBSD, Windows 95 and DOS and they all work. The problem is that linux doesn't find the video card: after lilo has loaded the kernel

XMMS not working on 2.4.0-test11-pre7

2000-11-19 Thread Gianluca Anzolin
it seems there has been a change in the format of the /proc/cpuinfo file: infact 'flags: ' became 'features: ' This change broke xmms and could broke any other program which relies on /proc/cpuinfo... I hope the problem will be solved (in the kernel or in every other program which uses

XMMS not working on 2.4.0-test11-pre7

2000-11-19 Thread Gianluca Anzolin
it seems there has been a change in the format of the /proc/cpuinfo file: infact 'flags: ' became 'features: ' This change broke xmms and could broke any other program which relies on /proc/cpuinfo... I hope the problem will be solved (in the kernel or in every other program which uses