[tip:sched/core] sched: Remove redundant assignment to "rt_rq" in update_curr_rt(...)

2014-06-05 Thread tip-bot for Giedrius Rekasius
Commit-ID: 0b07939cbfdd05bed0c5ec01b8b25493e6ecd34c Gitweb: http://git.kernel.org/tip/0b07939cbfdd05bed0c5ec01b8b25493e6ecd34c Author: Giedrius Rekasius AuthorDate: Sun, 25 May 2014 15:23:31 +0100 Committer: Ingo Molnar CommitDate: Thu, 5 Jun 2014 11:52:34 +0200 sched: Remove

[tip:sched/core] sched: Remove redundant assignment to rt_rq in update_curr_rt(...)

2014-06-05 Thread tip-bot for Giedrius Rekasius
Commit-ID: 0b07939cbfdd05bed0c5ec01b8b25493e6ecd34c Gitweb: http://git.kernel.org/tip/0b07939cbfdd05bed0c5ec01b8b25493e6ecd34c Author: Giedrius Rekasius giedrius.rekas...@gmail.com AuthorDate: Sun, 25 May 2014 15:23:31 +0100 Committer: Ingo Molnar mi...@kernel.org CommitDate: Thu, 5 Jun

[PATCH] perf/x86/uncore: Remove unnecessary assignment to "box" in uncore_pci_remove(...)

2014-05-29 Thread Giedrius Rekasius
Local variable "box" gets assigned correct value when it is initialized. There is no need to assign the same value again. Variable declarations were reshuffled for better readability. Signed-off-by: Giedrius Rekasius --- Original patch was amended for better readability based on fee

[PATCH] perf/x86/uncore: Remove unnecessary assignment to box in uncore_pci_remove(...)

2014-05-29 Thread Giedrius Rekasius
Local variable box gets assigned correct value when it is initialized. There is no need to assign the same value again. Variable declarations were reshuffled for better readability. Signed-off-by: Giedrius Rekasius giedrius.rekas...@gmail.com --- Original patch was amended for better readability

Re: [PATCH] perf/x86/uncore: Remove unnecessary assignment to "box" in uncore_pci_remove(...)

2014-05-28 Thread Giedrius Rekasius
On Wed, May 28, 2014 at 12:16:04PM +0200, walter harms wrote: > > > Am 28.05.2014 11:11, schrieb Giedrius Rekasius: > > Local variable "box" gets assigned correct value when it is initialized. > > There is no need to assign the same value again. > >

[PATCH] perf/x86/uncore: Remove unnecessary assignment to "box" in uncore_pci_remove(...)

2014-05-28 Thread Giedrius Rekasius
Local variable "box" gets assigned correct value when it is initialized. There is no need to assign the same value again. Signed-off-by: Giedrius Rekasius --- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/

[PATCH] perf/x86/uncore: Remove unnecessary assignment to box in uncore_pci_remove(...)

2014-05-28 Thread Giedrius Rekasius
Local variable box gets assigned correct value when it is initialized. There is no need to assign the same value again. Signed-off-by: Giedrius Rekasius giedrius.rekas...@gmail.com --- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86

Re: [PATCH] perf/x86/uncore: Remove unnecessary assignment to box in uncore_pci_remove(...)

2014-05-28 Thread Giedrius Rekasius
On Wed, May 28, 2014 at 12:16:04PM +0200, walter harms wrote: Am 28.05.2014 11:11, schrieb Giedrius Rekasius: Local variable box gets assigned correct value when it is initialized. There is no need to assign the same value again. Signed-off-by: Giedrius Rekasius giedrius.rekas

[PATCH] sched: remove redundant assignment to "rt_rq" in update_curr_rt(...)

2014-05-25 Thread Giedrius Rekasius
ng used. Signed-off-by: Giedrius Rekasius --- kernel/sched/rt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index bd2267a..7e0ea78 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -885,7 +885,6 @@ static void update_c

[PATCH] sched: remove redundant assignment to rt_rq in update_curr_rt(...)

2014-05-25 Thread Giedrius Rekasius
Variable rt_rq is used only in block for_each_sched_rt_entity so the value assigned to it at the beginning of the update_curr_rt(...) gets overwritten without ever being read. Remove redundant assignment and move variable declaration to the block in which it is being used. Signed-off-by: Giedrius

[PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
From: Giedrius Rekasius Remove local variable "stored" from ext4_readdir(...). This variable gets initialized but is never used inside the function. Signed-off-by: Giedrius Rekasius --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/

Re: [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
On Wed, May 21, 2014 at 04:51:30PM +0300, Dan Carpenter wrote: > Better, but still not quite right. Read paragraph 2 from > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt > > Try applying this patch with `git am`, then review the log. It

Re: [PATCH] ext4: remove unused local variable "store" from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
On Tue, May 20, 2014 at 11:08:27PM +0300, Dan Carpenter wrote: > On Tue, May 20, 2014 at 03:41:13PM +0100, Giedrius Rekasius wrote: > > From: Giedrius Rekasius > > > > Remove unused local variable "store" from ext4_readdir(...) > > > > Local variable

Re: [PATCH] ext4: remove unused local variable store from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
On Tue, May 20, 2014 at 11:08:27PM +0300, Dan Carpenter wrote: On Tue, May 20, 2014 at 03:41:13PM +0100, Giedrius Rekasius wrote: From: Giedrius Rekasius giedrius.rekas...@gmail.com Remove unused local variable store from ext4_readdir(...) Local variable stored is initialized however

Re: [PATCH] ext4: remove unused local variable store from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
On Wed, May 21, 2014 at 04:51:30PM +0300, Dan Carpenter wrote: Better, but still not quite right. Read paragraph 2 from https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt Try applying this patch with `git am`, then review the log. It has

[PATCH] ext4: remove unused local variable stored from ext4_readdir(...)

2014-05-21 Thread Giedrius Rekasius
From: Giedrius Rekasius giedrius.rekas...@gmail.com Remove local variable stored from ext4_readdir(...). This variable gets initialized but is never used inside the function. Signed-off-by: Giedrius Rekasius giedrius.rekas...@gmail.com --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion

[PATCH] ext4: remove unused local variable "store" from ext4_readdir(...)

2014-05-20 Thread Giedrius Rekasius
From: Giedrius Rekasius Remove unused local variable "store" from ext4_readdir(...) Local variable "stored" is initialized however never used inside the function. Signed-off-by: Giedrius Rekasius --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH] ext4: remove unused local variable store from ext4_readdir(...)

2014-05-20 Thread Giedrius Rekasius
From: Giedrius Rekasius giedrius.rekas...@gmail.com Remove unused local variable store from ext4_readdir(...) Local variable stored is initialized however never used inside the function. Signed-off-by: Giedrius Rekasius giedrius.rekas...@gmail.com --- fs/ext4/dir.c | 3 +-- 1 file changed, 1