Re: [PATCH 4.4 234/268] enic: enable rq before updating rq descriptors

2018-06-17 Thread Govindarajulu Varadarajan (gvaradar)
On Mon, 2018-06-18 at 00:06 +0100, Ben Hutchings wrote: > On Mon, 2018-05-28 at 12:03 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Govindarajulu Varada

Re: [PATCH 4.4 234/268] enic: enable rq before updating rq descriptors

2018-06-17 Thread Govindarajulu Varadarajan (gvaradar)
On Mon, 2018-06-18 at 00:06 +0100, Ben Hutchings wrote: > On Mon, 2018-05-28 at 12:03 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Govindarajulu Varada

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-10-02 Thread Govindarajulu Varadarajan
On Sat, 30 Sep 2017, Sinan Kaya wrote: On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: This patch does a pci_bus_walk and adds all the devices to a list. After unlocking (up_read) _bus_sem, we go through the list and call err_handler of the devices with devic_lock() held. This way, we

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-10-02 Thread Govindarajulu Varadarajan
On Sat, 30 Sep 2017, Sinan Kaya wrote: On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: This patch does a pci_bus_walk and adds all the devices to a list. After unlocking (up_read) _bus_sem, we go through the list and call err_handler of the devices with devic_lock() held. This way, we

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-10-02 Thread Govindarajulu Varadarajan
On Sun, 1 Oct 2017, Christoph Hellwig wrote: +struct aer_device_list { + struct device *dev; + struct hlist_node node; +}; + extern struct bus_type pcie_port_bus_type; void aer_isr(struct work_struct *work); void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-10-02 Thread Govindarajulu Varadarajan
On Sun, 1 Oct 2017, Christoph Hellwig wrote: +struct aer_device_list { + struct device *dev; + struct hlist_node node; +}; + extern struct bus_type pcie_port_bus_type; void aer_isr(struct work_struct *work); void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);

Re: [PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-30 Thread Govindarajulu Varadarajan
On Fri, 29 Sep 2017, Bjorn Helgaas wrote: On Thu, Sep 28, 2017 at 04:51:46PM -0700, Govindarajulu Varadarajan wrote: On Thu, 28 Sep 2017, Peter Zijlstra wrote: On Wed, Sep 27, 2017 at 02:42:20PM -0700, Govindarajulu Varadarajan wrote: Make MAX_LOCK_DEPTH configurable. It is set to 48 right

Re: [PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-30 Thread Govindarajulu Varadarajan
On Fri, 29 Sep 2017, Bjorn Helgaas wrote: On Thu, Sep 28, 2017 at 04:51:46PM -0700, Govindarajulu Varadarajan wrote: On Thu, 28 Sep 2017, Peter Zijlstra wrote: On Wed, Sep 27, 2017 at 02:42:20PM -0700, Govindarajulu Varadarajan wrote: Make MAX_LOCK_DEPTH configurable. It is set to 48 right

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-30 Thread Govindarajulu Varadarajan
On Fri, 29 Sep 2017, Sinan Kaya wrote: On 9/28/2017 7:46 PM, Govindarajulu Varadarajan wrote: How about releasing the device_lock here on CPU0?> pci_device_add() is called by driver's pci probe function. device_lock(dev) should be held before calling pci driver probe function. I

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-30 Thread Govindarajulu Varadarajan
On Fri, 29 Sep 2017, Sinan Kaya wrote: On 9/28/2017 7:46 PM, Govindarajulu Varadarajan wrote: How about releasing the device_lock here on CPU0?> pci_device_add() is called by driver's pci probe function. device_lock(dev) should be held before calling pci driver probe function. I

[PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-09-29 Thread Govindarajulu Varadarajan
_locks+0x3d/0x1a0 [ 114.012972] 2 locks held by systemd-udevd/492: [ 114.066148] #0: (>mutex){}, at: [] __driver_attach+0x55/0x140 [ 114.165107] #1: (>mutex){}, at: [] __driver_attach+0x72/0x140 [ 114.281879] = Signed-off-by: Govindarajulu

[PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-09-29 Thread Govindarajulu Varadarajan
_locks+0x3d/0x1a0 [ 114.012972] 2 locks held by systemd-udevd/492: [ 114.066148] #0: (>mutex){}, at: [] __driver_attach+0x55/0x140 [ 114.165107] #1: (>mutex){}, at: [] __driver_attach+0x72/0x140 [ 114.281879] = Signed-off-by: Govindarajulu Va

Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Sinan Kaya wrote: On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *), + void *userdata); pci_walk_bus_locked would be a better name as you are assuming that caller

Re: [PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Sinan Kaya wrote: On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: +void __pci_walk_bus(struct pci_bus *top, int (*cb)(struct pci_dev *, void *), + void *userdata); pci_walk_bus_locked would be a better name as you are assuming that caller

Re: [PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Peter Zijlstra wrote: On Wed, Sep 27, 2017 at 02:42:20PM -0700, Govindarajulu Varadarajan wrote: Make MAX_LOCK_DEPTH configurable. It is set to 48 right now. Number of VFs under a PCI pf bus can exceed 48 and this disables lockdep. lockdep currently allows max of 63

Re: [PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Peter Zijlstra wrote: On Wed, Sep 27, 2017 at 02:42:20PM -0700, Govindarajulu Varadarajan wrote: Make MAX_LOCK_DEPTH configurable. It is set to 48 right now. Number of VFs under a PCI pf bus can exceed 48 and this disables lockdep. lockdep currently allows max of 63

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Sinan Kaya wrote: On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: CPU0CPU1 - __driver_attach() device_lock(>mutex) <--- device mutex lock here driver_probe_

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Sinan Kaya wrote: On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: CPU0CPU1 - __driver_attach() device_lock(>mutex) <--- device mutex lock here driver_probe_

[PATCH 2/4] pci: code refactor pci_bus_lock/unlock/trylock

2017-09-27 Thread Govindarajulu Varadarajan
Introduce __pci_bus_trylock and __pci_bus_unlock with lock and unlock cb functions as arguments. User can pass on what they want to lock in pci_dev. Signed-off-by: Govindarajulu Varadarajan <gvara...@cisco.com> --- drivers/pci/pci.c | 38 +++--- include

[PATCH 2/4] pci: code refactor pci_bus_lock/unlock/trylock

2017-09-27 Thread Govindarajulu Varadarajan
Introduce __pci_bus_trylock and __pci_bus_unlock with lock and unlock cb functions as arguments. User can pass on what they want to lock in pci_dev. Signed-off-by: Govindarajulu Varadarajan --- drivers/pci/pci.c | 38 +++--- include/linux/pci.h | 16

[PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-27 Thread Govindarajulu Varadarajan
ll_locks+0x3d/0x1a0 [ 114.012972] 2 locks held by systemd-udevd/492: [ 114.066148] #0: (>mutex){}, at: [] __driver_attach+0x55/0x140 [ 114.165107] #1: (>mutex){}, at: [] __driver_attach+0x72/0x140 [ 114.281879] = Si

[PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-27 Thread Govindarajulu Varadarajan
ll_locks+0x3d/0x1a0 [ 114.012972] 2 locks held by systemd-udevd/492: [ 114.066148] #0: (>mutex){}, at: [] __driver_attach+0x55/0x140 [ 114.165107] #1: (>mutex){}, at: [] __driver_attach+0x72/0x140 [ 114.281879] = Signed-off-by: Govindarajulu Varadarajan

[PATCH 0/4] pci aer: fix deadlock in do_recovery

2017-09-27 Thread Govindarajulu Varadarajan
. Patch 4 extends this 63, max supported by lockdep. Govindarajulu Varadarajan (4): pci: introduce __pci_walk_bus for caller with pci_bus_sem held pci: code refactor pci_bus_lock/unlock/trylock pci aer: fix deadlock in do_recovery lockdep: make MAX_LOCK_DEPTH configurable fr

[PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-27 Thread Govindarajulu Varadarajan
Make MAX_LOCK_DEPTH configurable. It is set to 48 right now. Number of VFs under a PCI pf bus can exceed 48 and this disables lockdep. lockdep currently allows max of 63 held_locks. Signed-off-by: Govindarajulu Varadarajan <gvara...@cisco.com> --- fs/configfs/inode.c | 2 +- include

[PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held

2017-09-27 Thread Govindarajulu Varadarajan
Move pci_bus_sem down/up out of pci_walk_bus and rename it to __pci_walk_bus. Caller who already hold pci_bus_sem can call __pci_walk_bus. Signed-off-by: Govindarajulu Varadarajan <gvara...@cisco.com> --- drivers/pci/bus.c | 13 +++-- include/linux/pci.h | 2 ++ 2 files chang

[PATCH 0/4] pci aer: fix deadlock in do_recovery

2017-09-27 Thread Govindarajulu Varadarajan
. Patch 4 extends this 63, max supported by lockdep. Govindarajulu Varadarajan (4): pci: introduce __pci_walk_bus for caller with pci_bus_sem held pci: code refactor pci_bus_lock/unlock/trylock pci aer: fix deadlock in do_recovery lockdep: make MAX_LOCK_DEPTH configurable fr

[PATCH 4/4] lockdep: make MAX_LOCK_DEPTH configurable from Kconfig

2017-09-27 Thread Govindarajulu Varadarajan
Make MAX_LOCK_DEPTH configurable. It is set to 48 right now. Number of VFs under a PCI pf bus can exceed 48 and this disables lockdep. lockdep currently allows max of 63 held_locks. Signed-off-by: Govindarajulu Varadarajan --- fs/configfs/inode.c | 2 +- include/linux/sched.h| 3

[PATCH 1/4] pci: introduce __pci_walk_bus for caller with pci_bus_sem held

2017-09-27 Thread Govindarajulu Varadarajan
Move pci_bus_sem down/up out of pci_walk_bus and rename it to __pci_walk_bus. Caller who already hold pci_bus_sem can call __pci_walk_bus. Signed-off-by: Govindarajulu Varadarajan --- drivers/pci/bus.c | 13 +++-- include/linux/pci.h | 2 ++ 2 files changed, 13 insertions(+), 2

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Josef Bacik wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: Hi all I am seeing the following crash on my btrfs filesystem with nfs export. If I disable the nfs share and reboot, I do not hit the crash. Look like the crash happens on btrfs with nfs export

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Chris Mason wrote: On 05/19/2015 09:54 AM, Piotr Szymaniak wrote: On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: 2286--->BUG_ON(!PageLocked(page)); [ 166.769868] BTRFS info (device sdf): no c

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Piotr Szymaniak wrote: On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: 2286--->BUG_ON(!PageLocked(page)); [ 166.769868] BTRFS info (device sdf): no csum found for inode 1154 start 43192

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Josef Bacik wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: Hi all I am seeing the following crash on my btrfs filesystem with nfs export. If I disable the nfs share and reboot, I do not hit the crash. Look like the crash happens on btrfs with nfs export

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Piotr Szymaniak wrote: On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: 2286---BUG_ON(!PageLocked(page)); [ 166.769868] BTRFS info (device sdf): no csum found for inode 1154 start 43192320

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-21 Thread Govindarajulu Varadarajan
On Tue, 19 May 2015, Chris Mason wrote: On 05/19/2015 09:54 AM, Piotr Szymaniak wrote: On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: 2286---BUG_ON(!PageLocked(page)); [ 166.769868] BTRFS info (device sdf): no csum

btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Govindarajulu Varadarajan
Hi all I am seeing the following crash on my btrfs filesystem with nfs export. If I disable the nfs share and reboot, I do not hit the crash. Look like the crash happens on btrfs with nfs export. Is this a known issue? Has anyone else faced this? Let me know if you need more information.

btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Govindarajulu Varadarajan
Hi all I am seeing the following crash on my btrfs filesystem with nfs export. If I disable the nfs share and reboot, I do not hit the crash. Look like the crash happens on btrfs with nfs export. Is this a known issue? Has anyone else faced this? Let me know if you need more information.

Re: [net-next PATCH v2 3/3] drivers: net: cpsw: Add support for multicast/broadcast rate limit

2014-07-09 Thread Govindarajulu Varadarajan
On Wed, 9 Jul 2014, Mugunthan V N wrote: Add support for multicast/broadcast rate limit feature via ethtool coalesce. Signed-off-by: Mugunthan V N --- drivers/net/ethernet/ti/cpsw.c | 80 -- 1 file changed, 78 insertions(+), 2 deletions(-) diff --git

Re: [net-next PATCH v2 3/3] drivers: net: cpsw: Add support for multicast/broadcast rate limit

2014-07-09 Thread Govindarajulu Varadarajan
On Wed, 9 Jul 2014, Mugunthan V N wrote: Add support for multicast/broadcast rate limit feature via ethtool coalesce. Signed-off-by: Mugunthan V N mugunthan...@ti.com --- drivers/net/ethernet/ti/cpsw.c | 80 -- 1 file changed, 78 insertions(+), 2

Re: [PATCH 10/22] enic: Use pci_zalloc_consistent

2014-06-26 Thread Govindarajulu Varadarajan
On Mon, 23 Jun 2014, Joe Perches wrote: Remove the now unnecessary memset too. Signed-off-by: Joe Perches Looks good, thanks Acked-by: Govindarajulu Varadarajan <_gov...@gmx.com> --- drivers/net/ethernet/cisco/enic/vnic_dev.c | 8 +++- 1 file changed, 3 insertions(+), 5 del

Re: [PATCH 10/22] enic: Use pci_zalloc_consistent

2014-06-26 Thread Govindarajulu Varadarajan
On Mon, 23 Jun 2014, Joe Perches wrote: Remove the now unnecessary memset too. Signed-off-by: Joe Perches j...@perches.com Looks good, thanks Acked-by: Govindarajulu Varadarajan _gov...@gmx.com --- drivers/net/ethernet/cisco/enic/vnic_dev.c | 8 +++- 1 file changed, 3 insertions(+), 5

Re: randconfig build error with next-20140522, in drivers/net/ethernet/cisco/enic/enic_main.c

2014-05-22 Thread Govindarajulu Varadarajan
On Thu, 22 May 2014, Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `enic_poll_msix': enic_main.c:(.text+0x48710a): undefined reference to `__udivdi3' make: *** [vmlinux] Error 1 Looks like 64 bit divide issue. Will look into it.

Re: randconfig build error with next-20140522, in drivers/net/ethernet/cisco/enic/enic_main.c

2014-05-22 Thread Govindarajulu Varadarajan
On Thu, 22 May 2014, Jim Davis wrote: Building with the attached random configuration file, drivers/built-in.o: In function `enic_poll_msix': enic_main.c:(.text+0x48710a): undefined reference to `__udivdi3' make: *** [vmlinux] Error 1 Looks like 64 bit divide issue. Will look into it.

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-13 Thread Govindarajulu Varadarajan
te frequently. I do not see the problem after applying this patch. Thanks Tested-by: Govindarajulu Varadarajan Reported-by: Sasha Levin Signed-off-by: Mike Galbraith --- kernel/sched/fair.c | 13 +++-- kernel/sched/sched.h |9 + 2 files changed, 16 insertions(+), 6 delet

Re: [tip:sched/core] sched/numa: Move task_numa_free() to __put_task_struct()

2014-04-13 Thread Govindarajulu Varadarajan
not see the problem after applying this patch. Thanks Tested-by: Govindarajulu Varadarajan govindx...@gmail.com Reported-by: Sasha Levin sasha.le...@oracle.com Signed-off-by: Mike Galbraith bitbuc...@online.de --- kernel/sched/fair.c | 13 +++-- kernel/sched/sched.h |9 + 2

Re: [PATCH net-next 10/35] enic: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Govindarajulu Varadarajan
good, thanks Acked-by: Govindarajulu Varadarajan Signed-off-by: Alexander Gordeev Cc: Christian Benvenuti Cc: Sujith Sankar Cc: Govindarajulu Varadarajan Cc: Neel Patel Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/net/ethernet/cisco/enic/enic_main.c |6

Re: [PATCH net-next 10/35] enic: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Govindarajulu Varadarajan
good, thanks Acked-by: Govindarajulu Varadarajan govindarajul...@gmail.com Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Christian Benvenuti be...@cisco.com Cc: Sujith Sankar ssuj...@cisco.com Cc: Govindarajulu Varadarajan govindarajul...@gmail.com Cc: Neel Patel neepa...@cisco.com

Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare

2013-12-30 Thread Govindarajulu Varadarajan
On Mon, 30 Dec 2013, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Christian Benvenuti Cc: Sujith Sankar Cc: Govindarajulu Varadarajan Cc: Neel Patel Cc: Nishank Trivedi Signed-off-by: Ding Tianhong --- drivers/net/ethernet/cisco/enic

Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare

2013-12-30 Thread Govindarajulu Varadarajan
On Mon, 30 Dec 2013, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Christian Benvenuti be...@cisco.com Cc: Sujith Sankar ssuj...@cisco.com Cc: Govindarajulu Varadarajan govindarajul...@gmail.com Cc: Neel Patel neepa...@cisco.com Cc: Nishank Trivedi

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread Govindarajulu Varadarajan
Hi Dave Did you have a chance to look at this? Let me know how you want me to fix this. //govind On Mon, 11 Nov 2013, Govindarajulu Varadarajan wrote: On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread Govindarajulu Varadarajan
Hi Dave Did you have a chance to look at this? Let me know how you want me to fix this. //govind On Mon, 11 Nov 2013, Govindarajulu Varadarajan wrote: On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-11 Thread Govindarajulu Varadarajan
On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) } #ifdef XMT_VIA_SKB - if(p->tmd_skb[p->t

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-11 Thread Govindarajulu Varadarajan
On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) } #ifdef XMT_VIA_SKB - if(p-tmd_skb[p

[PATCH net-next 07/13] driver: staging: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 3 +-- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 3 +-- drivers/staging/rtl8188eu/core

[PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/amd/ni65.c | 6 ++ drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 -- drivers/net/ethernet

[PATCH net-next 12/13] driver: net: fix space before '(' and remove extra variable

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 +--- drivers/net/usb/usbnet.c| 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 6bd90f2..80dcfd9

[PATCH net-next 11/13] driver: usb: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/usb/gadget/u_ether.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget

[PATCH net-next 08/13] driver: isdn: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/isdn/gigaset/ser-gigaset.c | 3 +-- drivers/isdn/hisax/hfc_usb.c | 6 ++ drivers/isdn/hisax/icc.c | 6 ++ drivers/isdn

[PATCH net-next 10/13] driver: infiniband: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 06/13] driver: net: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/amd/lance.c | 9 +++-- drivers/net/ethernet/atheros/alx/main.c | 6 ++ drivers/net

[PATCH net-next 13/13] scripts/checkpatch.pl: Add dev_kfree_skb*(NULL) check to checkpatch

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad50..e651b8a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3719,7 +3719,7 @@ sub

[PATCH net-next 09/13] driver: s390: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/s390/net/claw.c | 6 ++ drivers/s390/net/ctcm_mpc.c | 6 ++ drivers/s390/net/qeth_core_main.c | 6 ++ 3 files changed

[PATCH net-next 04/13] driver: staging: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/staging/slicoss/slicoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers

[PATCH net-next 05/13] driver: usb/gadget: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/usb/gadget/f_phonet.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb

[PATCH net-next 03/13] driver: atm: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/atm/eni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index b1955ba..78a4445 100644

[PATCH net-next 00/13] Protect dev_kfree_skb_irq from NULL and remove unnecessary NULL checks

2013-11-02 Thread Govindarajulu Varadarajan
either calls dev_kfree_skb_irq or dev_kfree_skb depending on where your code is running. dev_kfree_skb is NULL safe but dev_kfree_skb_irq is not. This patch fixes it. Govindarajulu Varadarajan (13): net: Check skb for NULL in dev_kfree_skb_irq driver: net: remove unnecessary skb NULL check before

[PATCH net-next 01/13] net: Check skb for NULL in dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 0054c8c..63bd44d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2146,7 +2146,7 @@ EXPORT_SYMBOL(__netif_schedule); void

[PATCH net-next 00/13] Protect dev_kfree_skb_irq from NULL and remove unnecessary NULL checks

2013-11-02 Thread Govindarajulu Varadarajan
either calls dev_kfree_skb_irq or dev_kfree_skb depending on where your code is running. dev_kfree_skb is NULL safe but dev_kfree_skb_irq is not. This patch fixes it. Govindarajulu Varadarajan (13): net: Check skb for NULL in dev_kfree_skb_irq driver: net: remove unnecessary skb NULL check before

[PATCH net-next 01/13] net: Check skb for NULL in dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 0054c8c..63bd44d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2146,7 +2146,7 @@ EXPORT_SYMBOL

[PATCH net-next 03/13] driver: atm: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/atm/eni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c

[PATCH net-next 09/13] driver: s390: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/s390/net/claw.c | 6 ++ drivers/s390/net/ctcm_mpc.c | 6 ++ drivers/s390/net/qeth_core_main.c

[PATCH net-next 04/13] driver: staging: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/staging/slicoss/slicoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/slicoss

[PATCH net-next 12/13] driver: net: fix space before '(' and remove extra variable

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 +--- drivers/net/usb/usbnet.c| 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3

[PATCH net-next 05/13] driver: usb/gadget: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/usb/gadget/f_phonet.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget

[PATCH net-next 11/13] driver: usb: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/usb/gadget/u_ether.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget

[PATCH net-next 08/13] driver: isdn: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/isdn/gigaset/ser-gigaset.c | 3 +-- drivers/isdn/hisax/hfc_usb.c | 6 ++ drivers/isdn/hisax/icc.c

[PATCH net-next 10/13] driver: infiniband: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c | 3 +-- 2 files changed, 3 insertions(+), 6

[PATCH net-next 06/13] driver: net: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/amd/lance.c | 9 +++-- drivers/net/ethernet/atheros/alx/main.c | 6

[PATCH net-next 13/13] scripts/checkpatch.pl: Add dev_kfree_skb*(NULL) check to checkpatch

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad50..e651b8a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl

[PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/amd/ni65.c | 6 ++ drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10

[PATCH net-next 07/13] driver: staging: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 3 +-- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 3

Re: [PATCH v2] WAN: Adding support for Infineon PEF2256 E1 chipset (FALC56)

2013-11-01 Thread Govindarajulu Varadarajan
On Fri, 1 Nov 2013, Christophe Leroy wrote: diff -urN a/drivers/net/wan/pef2256.c b/drivers/net/wan/pef2256.c [..] +static int pef2256_remove(struct platform_device *pdev) +{ + struct net_device *ndev = dev_get_drvdata(>dev); + struct pef2256_dev_priv *priv =

Re: [PATCH v2] WAN: Adding support for Infineon PEF2256 E1 chipset (FALC56)

2013-11-01 Thread Govindarajulu Varadarajan
On Fri, 1 Nov 2013, Christophe Leroy wrote: diff -urN a/drivers/net/wan/pef2256.c b/drivers/net/wan/pef2256.c [..] +static int pef2256_remove(struct platform_device *pdev) +{ + struct net_device *ndev = dev_get_drvdata(pdev-dev); + struct pef2256_dev_priv *priv =

Re: [PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA

2013-09-04 Thread Govindarajulu Varadarajan
Hi Dave The subject for this should be "driver/net: enic: Try DMA 64 first, then failover to DMA 32" The "32" got truncated, please add this while committing. Let me know if you want me to send another patch. thanks //govind On Wed, 4 Sep 2013, Govindarajulu Varadarajan

Re: [PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA

2013-09-04 Thread Govindarajulu Varadarajan
Hi Dave The subject for this should be driver/net: enic: Try DMA 64 first, then failover to DMA 32 The 32 got truncated, please add this while committing. Let me know if you want me to send another patch. thanks //govind On Wed, 4 Sep 2013, Govindarajulu Varadarajan wrote: In servers

[PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA

2013-09-03 Thread Govindarajulu Varadarajan
-by: Christian Benvenuti Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/cisco/enic/enic_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 93898ba..7b756cf9

[PATCH net-next 4/5] driver/net: enic: Exposing symbols for Cisco's low latency driver

2013-09-03 Thread Govindarajulu Varadarajan
This patch exposes symbols for usnic low latency driver that can be used to register and unregister vNics as well to traverse the resources on vNics. Signed-off-by: Upinder Malhi Signed-off-by: Nishank Trivedi Signed-off-by: Christian Benvenuti --- drivers/net/ethernet/cisco/enic/vnic_dev.c

[PATCH net-next 2/5] driver/net: enic: record q_number and rss_hash for skb

2013-09-03 Thread Govindarajulu Varadarajan
The following patch sets the skb->rxhash and skb->q_number. This is used by RPS and RFS. Kernel can make use of hw provided hash instead of calculating the hash. Signed-off-by: Govindarajulu Varadarajan Signed-off-by: Nishank Trivedi Signed-off-by: Christian Benvenuti --- drivers/net/et

[PATCH net-next 5/5] driver/net: enic: update enic maintainers and driver

2013-09-03 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan Signed-off-by: Sujith Sankar Signed-off-by: Nishank Trivedi Signed-off-by: Christian Benvenuti --- MAINTAINERS| 3 ++- drivers/net/ethernet/cisco/enic/enic.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[PATCH net-next 1/5] driver/net: enic: Add multi tx support for enic

2013-09-03 Thread Govindarajulu Varadarajan
The following patch adds multi tx support for enic. Signed-off-by: Nishank Trivedi Signed-off-by: Christian Benvenuti Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/cisco/enic/enic.h | 2 +- drivers/net/ethernet/cisco/enic/enic_main.c | 36

[PATCH net-next 0/5] driver/net: enic: enic driver updates

2013-09-03 Thread Govindarajulu Varadarajan
This series includes support for multi-tx, rss_hash, RPS, RFS, DMA64, export symbols for cisco low latency driver and update the driver version and driver maintainers. Govindarajulu Varadarajan (5): driver/net: enic: Add multi tx support for enic driver/net: enic: record q_number

[PATCH net-next 0/5] driver/net: enic: enic driver updates

2013-09-03 Thread Govindarajulu Varadarajan
This series includes support for multi-tx, rss_hash, RPS, RFS, DMA64, export symbols for cisco low latency driver and update the driver version and driver maintainers. Govindarajulu Varadarajan (5): driver/net: enic: Add multi tx support for enic driver/net: enic: record q_number

[PATCH net-next 1/5] driver/net: enic: Add multi tx support for enic

2013-09-03 Thread Govindarajulu Varadarajan
The following patch adds multi tx support for enic. Signed-off-by: Nishank Trivedi nistr...@cisco.com Signed-off-by: Christian Benvenuti be...@cisco.com Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/cisco/enic/enic.h | 2 +- drivers/net

[PATCH net-next 5/5] driver/net: enic: update enic maintainers and driver

2013-09-03 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com Signed-off-by: Sujith Sankar ssuj...@cisco.com Signed-off-by: Nishank Trivedi nistr...@cisco.com Signed-off-by: Christian Benvenuti be...@cisco.com --- MAINTAINERS| 3 ++- drivers/net/ethernet/cisco

[PATCH net-next 4/5] driver/net: enic: Exposing symbols for Cisco's low latency driver

2013-09-03 Thread Govindarajulu Varadarajan
This patch exposes symbols for usnic low latency driver that can be used to register and unregister vNics as well to traverse the resources on vNics. Signed-off-by: Upinder Malhi uma...@cisco.com Signed-off-by: Nishank Trivedi nistr...@cisco.com Signed-off-by: Christian Benvenuti be...@cisco.com

[PATCH net-next 2/5] driver/net: enic: record q_number and rss_hash for skb

2013-09-03 Thread Govindarajulu Varadarajan
The following patch sets the skb-rxhash and skb-q_number. This is used by RPS and RFS. Kernel can make use of hw provided hash instead of calculating the hash. Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com Signed-off-by: Nishank Trivedi nistr...@cisco.com Signed-off

[PATCH net-next 3/5] driver/net: enic: Try DMA 64 first, then failover to DMA

2013-09-03 Thread Govindarajulu Varadarajan
Signed-off-by: Christian Benvenuti be...@cisco.com Signed-off-by: Govindarajulu Varadarajan govindarajul...@gmail.com --- drivers/net/ethernet/cisco/enic/enic_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net