[PATCH] of/unittest: Fix of_platform_depopulate test case

2015-03-28 Thread Grant Likely
a .release() method (which is good). This stops the test code from being a bad example of abusing the device model. Signed-off-by: Grant Likely Cc: Frank Rowand Cc: Pantelis Antoniou Cc: Pawel Moll --- (I've already got this commit in my tree queued up after the patch that exposes the bug, which i

Re: [PATCH v3 3/3] Documentation: update the of_unittest.txt

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:20:00 + , Wang Long wrote: > Since the directory "drivers/of/testcase-data" is renamed > to "drivers/of/unittest-data". so we should update the path > in the of_selftest.txt. > > When the kernel is built with OF_UNITTEST enabled, the output > dtb is testcases.dtb

Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt

2015-03-28 Thread Grant Likely
On Tue, 10 Mar 2015 09:50:58 -0500 , Rob Herring wrote: > On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring wrote: > > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long wrote: > >> Since the directory "drivers/of/testcase-data" is renamed > >> to "drivers/of/unittest-data". so we should update the path >

Re: [PATCH v3 1/3] of/unittest: replace 'selftest' with 'unittest'

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:19:58 + , Wang Long wrote: > This patch just replace the string 'selftest' with 'unittest' > in OF unittest and data and binding file. > > I have tested it successfully on ARM. > > Signed-off-by: Gaurav Minocha > Signed-off-by: Wang Long Unfortunately, this is

Re: [Patch 1/5] dt: unittest: early return from test skips tests

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 23:57:40 -0700 , Frank Rowand wrote: > From: Frank Rowand > > Fix bugs pointed out by checkpatch. > > Mis-coding of two if statements caused early return from function. > > Number of tests completed increased from 102 to 107. > Number of tests failed increased from 0 to

Re: [Patch] dt: OF_UNITTEST make dependency broken

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 12:21:46 -0700 , Frank Rowand wrote: > From: Frank Rowand > > If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to > be incremented, even if there are not source changes. This is caused by > a lack of dependency tracking and checking for >

[PATCH] of/unittest: Fix of_platform_depopulate test case

2015-03-28 Thread Grant Likely
(which is good). This stops the test code from being a bad example of abusing the device model. Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Frank Rowand frank.row...@sonymobile.com Cc: Pantelis Antoniou pantelis.anton...@konsulko.com Cc: Pawel Moll pawel.m...@arm.com --- (I've already

Re: [PATCH v3 3/3] Documentation: update the of_unittest.txt

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:20:00 + , Wang Long long.wangl...@huawei.com wrote: Since the directory drivers/of/testcase-data is renamed to drivers/of/unittest-data. so we should update the path in the of_selftest.txt. When the kernel is built with OF_UNITTEST enabled, the output dtb is

Re: [PATCH v3 2/3] Documentation: rename of_selftest.txt to of_unittest.txt

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:19:59 + , Wang Long long.wangl...@huawei.com wrote: Since the test of the devicetree's OF api use unittest as its name. so we should rename of_selftest.txt to of_unittest.txt. Signed-off-by: Wang Long long.wangl...@huawei.com Applied, thanks. g. ---

Re: [Patch 0/5] dt: unittest: fix breakage and warnings

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 22:25:51 -0700 , Frank Rowand frowand.l...@gmail.com wrote: Running checkpatch on early versions of my patchset to fix the devicetree make dependency issues exposed a large number of warnings, including some that are actual bugs.

Re: [PATCH v3 1/3] of/unittest: replace 'selftest' with 'unittest'

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:19:58 + , Wang Long long.wangl...@huawei.com wrote: This patch just replace the string 'selftest' with 'unittest' in OF unittest and data and binding file. I have tested it successfully on ARM. Signed-off-by: Gaurav Minocha gaurav.minocha...@gmail.com

Re: [Patch 1/5] dt: unittest: early return from test skips tests

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 23:57:40 -0700 , Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com Fix bugs pointed out by checkpatch. Mis-coding of two if statements caused early return from function. Number of tests completed increased from 102 to 107.

Re: [Patch] dt: OF_UNITTEST make dependency broken

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 12:21:46 -0700 , Frank Rowand frowand.l...@gmail.com wrote: From: Frank Rowand frank.row...@sonymobile.com If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to be incremented, even if there are not source changes. This is caused by a lack of

Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt

2015-03-28 Thread Grant Likely
On Tue, 10 Mar 2015 09:50:58 -0500 , Rob Herring robherri...@gmail.com wrote: On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring robherri...@gmail.com wrote: On Sun, Mar 8, 2015 at 9:35 PM, Wang Long long.wangl...@huawei.com wrote: Since the directory drivers/of/testcase-data is renamed to

Re: [PATCH 1/2] of: base: add function to get highest id of an alias stem

2015-03-28 Thread Grant Likely
On Wed, 18 Mar 2015 13:46:31 +0100 , Wolfram Sang w...@the-dreams.de wrote: On Thu, Mar 12, 2015 at 05:17:58PM +0100, Wolfram Sang wrote: I2C supports adding adapters using either a dynamic or fixed id. The latter is provided by aliases in the DT case. To prevent id collisions of those two

Re: [PATCH v2 0/5] Update the OF unittest and some small fix

2015-03-28 Thread Grant Likely
On Tue, 24 Mar 2015 23:43:43 -0500 , Rob Herring robherri...@gmail.com wrote: On Wed, Mar 11, 2015 at 3:36 AM, Wang Long long.wangl...@huawei.com wrote: This series patches do some small fixes in drivers/of/unittest.c, and update the Documenttion. At last, replace selftest with unittest

Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

2015-03-28 Thread Grant Likely
On Wed, 25 Mar 2015 11:38:43 + , Will Deacon will.dea...@arm.com wrote: On Wed, Mar 25, 2015 at 11:54:25AM +, Rafael J. Wysocki wrote: On Wednesday, March 25, 2015 11:24:11 AM Will Deacon wrote: On Tue, Mar 24, 2015 at 10:02:53PM +, Grant Likely wrote: On Thu, 19 Mar 2015 19

Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST

2015-03-25 Thread Grant Likely
On Fri, 20 Mar 2015 08:32:12 -0500 , Rob Herring wrote: > On Fri, Mar 20, 2015 at 7:25 AM, Grant Likely wrote: > > On Fri, 23 Jan 2015 17:10:04 +0100 > > , Geert Uytterhoeven > > wrote: > >> Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and a

Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

2015-03-25 Thread Grant Likely
On Thu, 19 Mar 2015 19:39:27 + , Will Deacon wrote: > On Thu, Mar 19, 2015 at 10:17:27AM +, Lorenzo Pieralisi wrote: > > On Thu, Mar 19, 2015 at 04:09:33AM +, Hanjun Guo wrote: > > > On 2015/3/19 3:05, Will Deacon wrote: > > > > On Wed, Mar 11, 2015 at 12:39:26PM +, Hanjun Guo

Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST

2015-03-25 Thread Grant Likely
On Fri, 20 Mar 2015 08:32:12 -0500 , Rob Herring robherri...@gmail.com wrote: On Fri, Mar 20, 2015 at 7:25 AM, Grant Likely grant.lik...@linaro.org wrote: On Fri, 23 Jan 2015 17:10:04 +0100 , Geert Uytterhoeven geert+rene...@glider.be wrote: Currently OF_DYNAMIC and OF_OVERLAY

Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

2015-03-25 Thread Grant Likely
On Thu, 19 Mar 2015 19:39:27 + , Will Deacon will.dea...@arm.com wrote: On Thu, Mar 19, 2015 at 10:17:27AM +, Lorenzo Pieralisi wrote: On Thu, Mar 19, 2015 at 04:09:33AM +, Hanjun Guo wrote: On 2015/3/19 3:05, Will Deacon wrote: On Wed, Mar 11, 2015 at 12:39:26PM +,

Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST

2015-03-20 Thread Grant Likely
On Fri, 23 Jan 2015 17:10:04 +0100 , Geert Uytterhoeven wrote: > Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and are > selected automatically only when needed. > > Allow them to be enabled manually to improve device tree unit test > coverage. > > Signed-off-by: Geert

Re: [PATCH] of: Empty node & property flag accessors when !OF

2015-03-20 Thread Grant Likely
On Thu, 22 Jan 2015 17:13:51 -0600 , Rob Herring wrote: > +Wolfram > > On Wed, Jan 21, 2015 at 11:05 AM, Pantelis Antoniou > wrote: > > Introduce empty node and property flag accessors when CONFIG_OF is not > > defined. > > This allows us to use them without ifdef'ing them in places where it >

Re: [PATCH] dma-mapping: fix size when of_dma_get_range() fails

2015-03-20 Thread Grant Likely
On Thu, Mar 19, 2015 at 7:25 PM, Grant Likely wrote: > On Wed, 24 Dec 2014 16:56:50 -0500 > , Murali Karicheri > wrote: >> When call to of_dma_get_range() fails, the code currently set size >> to dev->coherent_dma_mask instead of dev->coherent_dma_mask + 1. F

Re: [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add

2015-03-20 Thread Grant Likely
On Thu, 22 Jan 2015 15:49:59 -0600 , Suman Anna wrote: > Hi Grant, > > On 01/13/2015 05:04 PM, Suman Anna wrote: > > On 01/13/2015 04:00 PM, Rob Herring wrote: > >> On Tue, Jan 13, 2015 at 3:25 PM, Suman Anna wrote: > >>> Hi Rob, > >>> > >>> On 01/13/2015 02:38 PM, Rob Herring wrote: > On

Re: [PATCH] dma-mapping: fix size when of_dma_get_range() fails

2015-03-20 Thread Grant Likely
On Wed, 24 Dec 2014 16:56:50 -0500 , Murali Karicheri wrote: > When call to of_dma_get_range() fails, the code currently set size > to dev->coherent_dma_mask instead of dev->coherent_dma_mask + 1. Fix this > to make the code consistent with the case when size is obtained from > dma-range

Re: [PATCH] dma-mapping: fix size when of_dma_get_range() fails

2015-03-20 Thread Grant Likely
On Wed, 24 Dec 2014 16:56:50 -0500 , Murali Karicheri m-kariche...@ti.com wrote: When call to of_dma_get_range() fails, the code currently set size to dev-coherent_dma_mask instead of dev-coherent_dma_mask + 1. Fix this to make the code consistent with the case when size is obtained from

Re: [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add

2015-03-20 Thread Grant Likely
On Thu, 22 Jan 2015 15:49:59 -0600 , Suman Anna s-a...@ti.com wrote: Hi Grant, On 01/13/2015 05:04 PM, Suman Anna wrote: On 01/13/2015 04:00 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 3:25 PM, Suman Anna s-a...@ti.com wrote: Hi Rob, On 01/13/2015 02:38 PM, Rob Herring wrote:

Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST

2015-03-20 Thread Grant Likely
On Fri, 23 Jan 2015 17:10:04 +0100 , Geert Uytterhoeven geert+rene...@glider.be wrote: Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and are selected automatically only when needed. Allow them to be enabled manually to improve device tree unit test coverage.

Re: [PATCH] dma-mapping: fix size when of_dma_get_range() fails

2015-03-20 Thread Grant Likely
On Thu, Mar 19, 2015 at 7:25 PM, Grant Likely grant.lik...@linaro.org wrote: On Wed, 24 Dec 2014 16:56:50 -0500 , Murali Karicheri m-kariche...@ti.com wrote: When call to of_dma_get_range() fails, the code currently set size to dev-coherent_dma_mask instead of dev-coherent_dma_mask + 1. Fix

Re: [PATCH] of: Empty node property flag accessors when !OF

2015-03-20 Thread Grant Likely
On Thu, 22 Jan 2015 17:13:51 -0600 , Rob Herring robherri...@gmail.com wrote: +Wolfram On Wed, Jan 21, 2015 at 11:05 AM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Introduce empty node and property flag accessors when CONFIG_OF is not defined. This allows us to use them

Re: [PATCH v10 16/21] irqchip: Add GICv2 specific ACPI boot support

2015-03-14 Thread Grant Likely
n 2015/3/12 7:11, Jason Cooper wrote: >> >>> Hey Grant, >> >>> >> >>> On Wed, Mar 11, 2015 at 06:04:50PM +, Grant Likely wrote: >> >>>> On 11 Mar 2015 12:42, "Hanjun Guo" wrote: >> [...] >> >>>>>

Re: [PATCH v10 16/21] irqchip: Add GICv2 specific ACPI boot support

2015-03-14 Thread Grant Likely
: Hey Grant, On Wed, Mar 11, 2015 at 06:04:50PM +, Grant Likely wrote: On 11 Mar 2015 12:42, Hanjun Guo hanjun@linaro.org wrote: [...] diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c index 0fe2f71..afd1af3 100644 --- a/drivers/irqchip/irqchip.c +++ b/drivers

Re: [PATCH v9 19/21] ARM64 / ACPI: Enable ARM64 in Kconfig

2015-03-07 Thread Grant Likely
lement it on ARM64 in the future. > > CC: Rafael J. Wysocki > CC: Catalin Marinas > CC: Will Deacon > Reviewed-by: Grant Likely > Tested-by: Suravee Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Te

Re: [PATCH v9 18/21] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64

2015-03-07 Thread Grant Likely
Catalin Marinas > CC: Will Deacon > Reviewed-by: Grant Likely > Tested-by: Suravee Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > S

Re: [PATCH v9 17/21] clocksource / arch_timer: Parse GTDT to initialize arch timer

2015-03-07 Thread Grant Likely
t; Tested-by: Suravee Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Hanjun Guo Reviewed-by: Grant Likely > --- > arch/arm

Re: [PATCH v9 16/21] irqchip: Add GICv2 specific ACPI boot support

2015-03-07 Thread Grant Likely
> Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Tomasz Nowicki > Signed-off-by: Hanjun Guo Reviewed-by: Grant Likely > --- > arch/arm64/include/asm/acpi.h

Re: [PATCH v9 15/21] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi

2015-03-07 Thread Grant Likely
: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Hanjun Guo Reviewed-by: Grant Likely > --- > arch/arm64/kernel/acpi.c | 73 > ++

Re: [PATCH v9 14/21] ACPI / processor: Make it possible to get CPU hardware ID via GICC

2015-03-07 Thread Grant Likely
e Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Hanjun Guo Reviewed-by: Grant Likely > --- > arch/arm64/include/asm

Re: [PATCH v9 13/21] ARM64 / ACPI: Parse MADT for SMP initialization

2015-03-07 Thread Grant Likely
ijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki Reviewed-by: Grant Likely > --- > arch/arm64/include/asm/acp

Re: [PATCH v9 13/21] ARM64 / ACPI: Parse MADT for SMP initialization

2015-03-07 Thread Grant Likely
...@cavium.com Signed-off-by: Hanjun Guo hanjun@linaro.org Signed-off-by: Tomasz Nowicki tomasz.nowi...@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acpi.h| 2 + arch/arm64/include/asm/cpu_ops.h | 1 + arch/arm64/include/asm/smp.h

Re: [PATCH v9 15/21] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi

2015-03-07 Thread Grant Likely
-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/kernel/acpi.c | 73 drivers/acpi/bus.c | 3 ++ include/linux/acpi.h | 1 + 3 files changed, 77 insertions(+) diff --git

Re: [PATCH v9 14/21] ACPI / processor: Make it possible to get CPU hardware ID via GICC

2015-03-07 Thread Grant Likely
...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acpi.h | 12 drivers/acpi/processor_core.c | 30 ++ 2 files changed, 42

Re: [PATCH v9 19/21] ARM64 / ACPI: Enable ARM64 in Kconfig

2015-03-07 Thread Grant Likely
|| IA64, and implement it on ARM64 in the future. CC: Rafael J. Wysocki r...@rjwysocki.net CC: Catalin Marinas catalin.mari...@arm.com CC: Will Deacon will.dea...@arm.com Reviewed-by: Grant Likely grant.lik...@linaro.org Tested-by: Suravee Suthikulpanit suravee.suthikulpa...@amd.com Tested

Re: [PATCH v9 16/21] irqchip: Add GICv2 specific ACPI boot support

2015-03-07 Thread Grant Likely
...@cavium.com Signed-off-by: Tomasz Nowicki tomasz.nowi...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acpi.h| 2 + arch/arm64/kernel/acpi.c | 25 + drivers/irqchip/irq-gic.c

Re: [PATCH v9 17/21] clocksource / arch_timer: Parse GTDT to initialize arch timer

2015-03-07 Thread Grant Likely
Tested-by: Robert Richter rrich...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/kernel/time.c | 7 ++ drivers/clocksource/arm_arch_timer.c | 132

Re: [PATCH v9 18/21] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64

2015-03-07 Thread Grant Likely
. CC: Catalin Marinas catalin.mari...@arm.com CC: Will Deacon will.dea...@arm.com Reviewed-by: Grant Likely grant.lik...@linaro.org Tested-by: Suravee Suthikulpanit suravee.suthikulpa...@amd.com Tested-by: Yijing Wang wangyij...@huawei.com Tested-by: Mark Langsdorf mlang...@redhat.com Tested

Re: [PATCH v9 11/21] ARM64 / ACPI: Get PSCI flags in FADT for PSCI init

2015-03-06 Thread Grant Likely
rf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Graeme Gregory > Signed-off-by: Tomasz Nowicki > Signed-off-by: Hanjun Guo Acked-by: Grant Likely > --- > arch/arm64/include/asm/acpi.h | 1

Re: [PATCH v9 12/21] ACPI / table: Print GIC information when MADT is parsed

2015-03-06 Thread Grant Likely
hikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Acked-by: Sudeep Holla > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki

Re: [PATCH v9 10/21] ARM64 / ACPI: If we chose to boot from acpi then disable FDT

2015-03-06 Thread Grant Likely
eme Gregory > Signed-off-by: Hanjun Guo Acked-by: Grant Likely > --- > arch/arm64/kernel/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 4f1a014..e8c7000 100644 > --- a/arch/a

Re: [PATCH v9 09/21] ARM64 / ACPI: Introduce early_param "acpi=" to enable/disable ACPI

2015-03-06 Thread Grant Likely
ption; the heuristic to decide this is whether > /chosen is the only node present at depth 1 > > CC: Catalin Marinas > CC: Will Deacon > CC: Rafael J. Wysocki > Signed-off-by: Al Stone > Signed-off-by: Graeme Gregory > Signed-off-by: Hanjun Guo > Signed-off-by: Ard Bie

Re: [PATCH v9 08/21] ARM64 / ACPI: Introduce PCI stub functions for ACPI

2015-03-06 Thread Grant Likely
t; CC: Liviu Dudau > CC: Catalin Marinas > CC: Will Deacon > Tested-by: Suravee Suthikulpanit > Tested-by: Yijing Wang > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-b

Re: [PATCH v9 07/21] ACPI / sleep: Introduce arm64 specific acpi_sleep.c

2015-03-06 Thread Grant Likely
On Wed, 25 Feb 2015 16:39:47 +0800 , Hanjun Guo wrote: > From: Graeme Gregory > > ACPI 5.1 does not currently support S states for ARM64 hardware but > ACPI code will call acpi_target_system_state() for device power > management, so introduce acpi_sleep.c to allow other drivers to function >

Re: [PATCH v9 06/21] ACPI: fix acpi_os_ioremap for arm64

2015-03-06 Thread Grant Likely
_cache() cannot be > used to map IO regions which don't support caching. So for arm64, use > ioremap() for non-RAM regions. > > CC: Rafael J Wysocki > CC: Catalin Marinas > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Mark Salter > Signed-off-

Re: [PATCH v9 05/21] ARM64 / ACPI: Get RSDP and ACPI boot-time tables

2015-03-06 Thread Grant Likely
> Tested-by: Timur Tabi > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Al Stone > Signed-off-by: Graeme Gregory > Signed-off-by: Tomasz Nowicki > Signed-off-by: Hanjun Guo Acked-by: Grant Likely > --- > arch/arm64/include/asm/acen

Re: [PATCH v9 04/21] ARM64: allow late use of early_ioremap

2015-03-06 Thread Grant Likely
later use of early_ioremap(). > > CC: Leif Lindholm > CC: Ard Biesheuvel > Tested-by: Suravee Suthikulpanit > Tested-by: Mark Langsdorf > Tested-by: Jon Masters > Tested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Mark Salter > Signed-off-b

Re: [PATCH v9 03/21] ACPI: add arm64 to the platforms that use ioremap

2015-03-06 Thread Grant Likely
ested-by: Robert Richter > Acked-by: Robert Richter > Signed-off-by: Al Stone > Signed-off-by: Graeme Gregory > Signed-off-by: Hanjun Guo LGTM. Reviewed-by: Grant Likely > --- > drivers/acpi/osl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > d

Re: [PATCH v9 02/21] ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID

2015-03-06 Thread Grant Likely
hj: reworked cpu physid map return codes] > Signed-off-by: Hanjun Guo Looks okay to me. Reviewed-by: Grant Likely > --- > arch/ia64/include/asm/acpi.h | 4 > arch/ia64/kernel/acpi.c | 2 +- > arch/x86/include/asm/acpi.h | 4 > arch/x86/kernel/acpi/boot.c

Re: [PATCH v9 01/21] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning

2015-03-06 Thread Grant Likely
but leave other structures unchanged. > > CC: Rafael J Wysocki > Signed-off-by: Hanjun Guo One nitpick below, but don't respin over this, and don't do a fixup. Acked-by: Grant Likely > --- > drivers/acpi/tables.c | 30 -- > 1 file changed, 16 i

Re: [PATCH v9 03/21] ACPI: add arm64 to the platforms that use ioremap

2015-03-06 Thread Grant Likely
Wysocki r...@rjwysocki.net Tested-by: Robert Richter rrich...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Al Stone al.st...@linaro.org Signed-off-by: Graeme Gregory graeme.greg...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org LGTM. Reviewed-by: Grant

Re: [PATCH v9 01/21] ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning

2015-03-06 Thread Grant Likely
structures unchanged. CC: Rafael J Wysocki r...@rjwysocki.net Signed-off-by: Hanjun Guo hanjun@linaro.org One nitpick below, but don't respin over this, and don't do a fixup. Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/acpi/tables.c | 30

Re: [PATCH v9 02/21] ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID

2015-03-06 Thread Grant Likely
Marinas catalin.mari...@arm.com [hj: reworked cpu physid map return codes] Signed-off-by: Hanjun Guo hanjun@linaro.org Looks okay to me. Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/ia64/include/asm/acpi.h | 4 arch/ia64/kernel/acpi.c | 2 +- arch/x86/include/asm

Re: [PATCH v9 04/21] ARM64: allow late use of early_ioremap

2015-03-06 Thread Grant Likely
rrich...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Mark Salter msal...@redhat.com Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/fixmap.h | 3 +++ 1 file changed, 3 insertions

Re: [PATCH v9 08/21] ARM64 / ACPI: Introduce PCI stub functions for ACPI

2015-03-06 Thread Grant Likely
-by: Timur Tabi ti...@codeaurora.org Tested-by: Robert Richter rrich...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/pci.h | 6 ++ arch/arm64/kernel

Re: [PATCH v9 11/21] ARM64 / ACPI: Get PSCI flags in FADT for PSCI init

2015-03-06 Thread Grant Likely
Gregory graeme.greg...@linaro.org Signed-off-by: Tomasz Nowicki tomasz.nowi...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acpi.h | 15 + arch/arm64/include/asm/psci.h | 3 +- arch/arm64/kernel

Re: [PATCH v9 12/21] ACPI / table: Print GIC information when MADT is parsed

2015-03-06 Thread Grant Likely
-by: Sudeep Holla sudeep.ho...@arm.com Signed-off-by: Hanjun Guo hanjun@linaro.org Signed-off-by: Tomasz Nowicki tomasz.nowi...@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/acpi/tables.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [PATCH v9 06/21] ACPI: fix acpi_os_ioremap for arm64

2015-03-06 Thread Grant Likely
...@cavium.com Signed-off-by: Mark Salter msal...@redhat.com Signed-off-by: Hanjun Guo hanjun@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acpi.h | 13 + include/acpi/acpi_io.h| 4 2 files changed, 17 insertions

Re: [PATCH v9 07/21] ACPI / sleep: Introduce arm64 specific acpi_sleep.c

2015-03-06 Thread Grant Likely
On Wed, 25 Feb 2015 16:39:47 +0800 , Hanjun Guo hanjun@linaro.org wrote: From: Graeme Gregory graeme.greg...@linaro.org ACPI 5.1 does not currently support S states for ARM64 hardware but ACPI code will call acpi_target_system_state() for device power management, so introduce

Re: [PATCH v9 09/21] ARM64 / ACPI: Introduce early_param acpi= to enable/disable ACPI

2015-03-06 Thread Grant Likely
graeme.greg...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- Documentation/kernel-parameters.txt | 3 ++- arch/arm64/include/asm/acpi.h | 7 + arch/arm64/kernel/acpi.c

Re: [PATCH v9 05/21] ARM64 / ACPI: Get RSDP and ACPI boot-time tables

2015-03-06 Thread Grant Likely
...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- arch/arm64/include/asm/acenv.h | 18 arch/arm64/include/asm/acpi.h | 45 ++ arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/acpi.c | 101

Re: [PATCH v9 10/21] ARM64 / ACPI: If we chose to boot from acpi then disable FDT

2015-03-06 Thread Grant Likely
...@redhat.com Tested-by: Timur Tabi ti...@codeaurora.org Tested-by: Robert Richter rrich...@cavium.com Acked-by: Robert Richter rrich...@cavium.com Signed-off-by: Graeme Gregory graeme.greg...@linaro.org Signed-off-by: Hanjun Guo hanjun@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org

Re: [PATCH] dtc: Use quotes to include header files

2015-01-29 Thread Grant Likely
On Tue, 16 Dec 2014 15:13:24 +1300 , Chris Packham wrote: > Currently in arch and driver code that needs early access to the > flattened device tree it is necessary to add specific CFLAGS so that > when scripts/dtc/libfdt/libfdt.h is included the C preprocessor is able > to locate the libfdt

Re: [PATCH] dtc: Use quotes to include header files

2015-01-29 Thread Grant Likely
On Tue, 16 Dec 2014 15:13:24 +1300 , Chris Packham chris.pack...@alliedtelesis.co.nz wrote: Currently in arch and driver code that needs early access to the flattened device tree it is necessary to add specific CFLAGS so that when scripts/dtc/libfdt/libfdt.h is included the C preprocessor is

Re: [Patch v2 0/2] firmware: dmi-sysfs: add SMBIOS entry point area raw attribute

2015-01-27 Thread Grant Likely
On Mon, 26 Jan 2015 15:28:36 +0200 , Ivan Khoronzhuk wrote: > Some utils, like dmidecode and smbios, needs to access SMBIOS entry > table area in order to get information like SMBIOS version, size, etc. > Currently it's done via /dev/mem. But for situation when /dev/mem > usage is disabled, the

Re: [PATCH v7 13/17] ARM64 / ACPI: Add GICv2 specific ACPI boot support

2015-01-27 Thread Grant Likely
On Fri, Jan 16, 2015 at 2:37 PM, Marc Zyngier wrote: @@ -78,6 +79,10 @@ void __init set_handle_irq(void (*handle_irq)(struct pt_regs *)) void __init init_IRQ(void) { irqchip_init(); + + if (!handle_arch_irq) + acpi_gic_init(); + >>>

Re: [PATCH v7 13/17] ARM64 / ACPI: Add GICv2 specific ACPI boot support

2015-01-27 Thread Grant Likely
On Fri, Jan 16, 2015 at 2:37 PM, Marc Zyngier marc.zyng...@arm.com wrote: @@ -78,6 +79,10 @@ void __init set_handle_irq(void (*handle_irq)(struct pt_regs *)) void __init init_IRQ(void) { irqchip_init(); + + if (!handle_arch_irq) + acpi_gic_init(); + Why isn't this

Re: [Patch v2 0/2] firmware: dmi-sysfs: add SMBIOS entry point area raw attribute

2015-01-27 Thread Grant Likely
On Mon, 26 Jan 2015 15:28:36 +0200 , Ivan Khoronzhuk ivan.khoronz...@linaro.org wrote: Some utils, like dmidecode and smbios, needs to access SMBIOS entry table area in order to get information like SMBIOS version, size, etc. Currently it's done via /dev/mem. But for situation when /dev/mem

[PATCH] of/unittest: Remove obsolete code

2015-01-22 Thread Grant Likely
Commit 3ce04b4a9, "Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol" removes a bunch of code, but missed a few minor bits. Clean it up by removing the node removal cache and flag. Signed-off-by: Grant Likely Cc: Gaurav Minocha Cc: Rob Herring --- drivers/of/unitt

Re: [PATCH] of: Add missing of_node_put() in of_find_node_by_path()

2015-01-22 Thread Grant Likely
On Thu, Jan 22, 2015 at 4:14 PM, Grant Likely wrote: > On Wed, 14 Jan 2015 16:45:56 +0100 > , Geert Uytterhoeven > wrote: >> When traversing all nodes and moving to a new path component, the old >> one must be released by calling of_node_put(). Else the refcounts of

Re: [PATCH] of: Add missing of_node_put() in of_find_node_by_path()

2015-01-22 Thread Grant Likely
On Wed, 14 Jan 2015 16:45:56 +0100 , Geert Uytterhoeven wrote: > When traversing all nodes and moving to a new path component, the old > one must be released by calling of_node_put(). Else the refcounts of the > parent node(s) will not be decremented. > > Signed-off-by: Geert Uytterhoeven >

Re: [PATCH] of: Add missing of_node_put() in of_find_node_by_path()

2015-01-22 Thread Grant Likely
On Wed, 14 Jan 2015 16:45:56 +0100 , Geert Uytterhoeven geert+rene...@glider.be wrote: When traversing all nodes and moving to a new path component, the old one must be released by calling of_node_put(). Else the refcounts of the parent node(s) will not be decremented. Signed-off-by: Geert

Re: [PATCH] of: Add missing of_node_put() in of_find_node_by_path()

2015-01-22 Thread Grant Likely
On Thu, Jan 22, 2015 at 4:14 PM, Grant Likely grant.lik...@linaro.org wrote: On Wed, 14 Jan 2015 16:45:56 +0100 , Geert Uytterhoeven geert+rene...@glider.be wrote: When traversing all nodes and moving to a new path component, the old one must be released by calling of_node_put(). Else

[PATCH] of/unittest: Remove obsolete code

2015-01-22 Thread Grant Likely
Commit 3ce04b4a9, Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol removes a bunch of code, but missed a few minor bits. Clean it up by removing the node removal cache and flag. Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Gaurav Minocha gaurav.minocha...@gmail.com Cc: Rob

Re: [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI

2015-01-19 Thread Grant Likely
On Mon, 19 Jan 2015 13:51:45 + , Catalin Marinas wrote: > On Mon, Jan 19, 2015 at 11:55:32AM +, Ard Biesheuvel wrote: > > On 19 January 2015 at 11:42, Catalin Marinas > > wrote: > > > On Wed, Jan 14, 2015 at 03:04:52PM +, Hanjun Guo wrote: > > >> From: Al Stone > > >> > > >>

Re: [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for acpi and pass acpi=force to enable ACPI

2015-01-19 Thread Grant Likely
On Mon, 19 Jan 2015 13:51:45 + , Catalin Marinas catalin.mari...@arm.com wrote: On Mon, Jan 19, 2015 at 11:55:32AM +, Ard Biesheuvel wrote: On 19 January 2015 at 11:42, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Jan 14, 2015 at 03:04:52PM +, Hanjun Guo wrote:

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-16 Thread Grant Likely
On Thu, 15 Jan 2015 18:23:47 + , Catalin Marinas wrote: > Hi Grant, > > On Thu, Jan 15, 2015 at 04:26:20PM +0000, Grant Likely wrote: > > On Wed, Jan 14, 2015 at 3:04 PM, Hanjun Guo wrote: > > > This is the v7 of ACPI core patches for ARM64 based on ACPI 5.1

Re: [PATCH v7 13/17] ARM64 / ACPI: Add GICv2 specific ACPI boot support

2015-01-16 Thread Grant Likely
On Fri, Jan 16, 2015 at 11:15 AM, Marc Zyngier wrote: > On 14/01/15 15:05, Hanjun Guo wrote: >> From: Tomasz Nowicki >> >> ACPI kernel uses MADT table for proper GIC initialization. It needs to >> parse GIC related subtables, collect CPU interface and distributor >> addresses and call driver

Re: [PATCH v7 13/17] ARM64 / ACPI: Add GICv2 specific ACPI boot support

2015-01-16 Thread Grant Likely
On Fri, Jan 16, 2015 at 11:15 AM, Marc Zyngier marc.zyng...@arm.com wrote: On 14/01/15 15:05, Hanjun Guo wrote: From: Tomasz Nowicki tomasz.nowi...@linaro.org ACPI kernel uses MADT table for proper GIC initialization. It needs to parse GIC related subtables, collect CPU interface and

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-16 Thread Grant Likely
On Thu, 15 Jan 2015 18:23:47 + , Catalin Marinas catalin.mari...@arm.com wrote: Hi Grant, On Thu, Jan 15, 2015 at 04:26:20PM +, Grant Likely wrote: On Wed, Jan 14, 2015 at 3:04 PM, Hanjun Guo hanjun@linaro.org wrote: This is the v7 of ACPI core patches for ARM64 based on ACPI

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-15 Thread Grant Likely
On Wed, Jan 14, 2015 at 3:04 PM, Hanjun Guo wrote: > Hi, > > This is the v7 of ACPI core patches for ARM64 based on ACPI 5.1 Hi Catalin and Will, I'll get right to the point: Can we please have this series queued up for v3.20? I really think we've hit the point where it is more valuable to

Re: [Linaro-acpi] [PATCH v5 18/18] Documentation: ACPI for ARM64

2015-01-15 Thread Grant Likely
On Tue, Jan 6, 2015 at 1:59 PM, Arnd Bergmann wrote: > On Tuesday 06 January 2015 11:20:01 Catalin Marinas wrote: >> On Mon, Jan 05, 2015 at 08:16:30PM +, Arnd Bergmann wrote: >> > On Monday 05 January 2015 13:13:02 Catalin Marinas wrote: >> > > > since passing no DT tables to OS but >> > > >

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-15 Thread Grant Likely
On Wed, Jan 14, 2015 at 3:04 PM, Hanjun Guo hanjun@linaro.org wrote: Hi, This is the v7 of ACPI core patches for ARM64 based on ACPI 5.1 Hi Catalin and Will, I'll get right to the point: Can we please have this series queued up for v3.20? I really think we've hit the point where it is

Re: [Linaro-acpi] [PATCH v5 18/18] Documentation: ACPI for ARM64

2015-01-15 Thread Grant Likely
On Tue, Jan 6, 2015 at 1:59 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 06 January 2015 11:20:01 Catalin Marinas wrote: On Mon, Jan 05, 2015 at 08:16:30PM +, Arnd Bergmann wrote: On Monday 05 January 2015 13:13:02 Catalin Marinas wrote: since passing no DT tables to OS but

Re: [Linaro-acpi] [PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching

2015-01-14 Thread Grant Likely
ot require PCI support for ATA_ACPI, > this patch removes dependency in the driver/ata/Kconfig. > > Signed-off-by: Suravee Suthikulpanit Looks good to me. Reviewed-by: Grant Likely > --- > drivers/ata/Kconfig | 2 +- > drivers/ata/ahci_platform.c | 3 +++ > 2 fi

Re: [Linaro-acpi] [PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching

2015-01-14 Thread Grant Likely
in the driver/ata/Kconfig. Signed-off-by: Suravee Suthikulpanit suravee.suthikulpa...@amd.com Looks good to me. Reviewed-by: Grant Likely grant.lik...@linaro.org --- drivers/ata/Kconfig | 2 +- drivers/ata/ahci_platform.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] TTY: add support for "tty slave" devices.

2014-12-13 Thread Grant Likely
On Sat, Dec 13, 2014 at 5:46 PM, Sebastian Reichel wrote: > Hi, > > On Fri, Dec 12, 2014 at 11:59:20AM +0000, Grant Likely wrote: >> [...] >> > --- a/Documentation/devicetree/bindings/serial/of-serial.txt >> > +++ b/Documentation/devicetree/bindings/serial/o

Re: [PATCH 1/3] TTY: add support for tty slave devices.

2014-12-13 Thread Grant Likely
On Sat, Dec 13, 2014 at 5:46 PM, Sebastian Reichel s...@kernel.org wrote: Hi, On Fri, Dec 12, 2014 at 11:59:20AM +, Grant Likely wrote: [...] --- a/Documentation/devicetree/bindings/serial/of-serial.txt +++ b/Documentation/devicetree/bindings/serial/of-serial.txt @@ -39,6 +39,10

Re: [PATCH] staging:board: fix build errors and warnings

2014-12-12 Thread Grant Likely
On Tue, 9 Dec 2014 01:24:09 +0800 , Tsung-Han Lin wrote: > Add dummy implementation of 'of_find_all_nodes', > and remove the unnecessary 'of_can_translate_address', > which is already removed in commit > d9c6866be8a145e32da616d8dcbae806032d75b5 ("of: kill off > of_can_translate_address"), to

Re: [PATCH 2/3] TTY: add slave driver to power-on device via a regulator.

2014-12-12 Thread Grant Likely
On Fri, 12 Dec 2014 08:59:44 +1100 , NeilBrown wrote: > The regulator is identified in devicetree as 'vdd-supply' > > Signed-off-by: NeilBrown > --- > .../devicetree/bindings/serial/slave-reg.txt | 18 > drivers/tty/Kconfig|2 >

Re: [PATCH 3/3] TTY/slave: add driver for w2sg0004 GPS

2014-12-12 Thread Grant Likely
On Fri, 12 Dec 2014 08:59:44 +1100 , NeilBrown wrote: > This uart-attatched GPS device has a toggle which turns > both on and off. For reliable use we need to know what > start it is in. > > So it registers with the tty for recv events when the tty > is open, and optionally configures the RX

<    1   2   3   4   5   6   7   8   9   10   >