Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-16 Thread Greg Kroah-Hartman
erved_1[8]; > }; > } Note, such a thing would only be for the distros that want it, you can add support for this to the tool, but there is no need for any __kabi_reserved fields in mainline. > Here gendwarfksyms would see the __kabi_reserved prefix and only use > u8 [8] for the CRC

Re: [PATCH v3] init: staging: Fix missing warning/taint on builtin code

2024-07-10 Thread Greg Kroah-Hartman
s the commit _after_ this one that turns on the taint for the build :) anyway, nice work, I think it's almost there! greg k-h

Re: [PATCH] rust: add `module_params` macro

2024-07-09 Thread Greg KH
ernel development is done through emails, not calls :) If a submitter isn't willing to maintain the code they submit, then it should be rejected as maintance is the most important part. Sorry, greg k-h

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-04 Thread Greg Kroah-Hartman
On Thu, Jul 04, 2024 at 08:16:34PM +0900, Yunseong Kim wrote: > Hi Greg, Hi Jakub > > On 7/4/24 6:32 오후, Greg Kroah-Hartman wrote: > > On Wed, Jul 03, 2024 at 07:18:35PM -0700, Jakub Kicinski wrote: > >> On Wed, 3 Jul 2024 03:01:47 +0900 Yunseong Kim wrote: > >&

Re: [PATCH] tracing/net_sched: NULL pointer dereference in perf_trace_qdisc_reset()

2024-07-04 Thread Greg Kroah-Hartman
applied the patch, tested it again, and confirmed > > working fine. > > You're missing the customary "[ Upstream commit ]" > line, not sure Greg will pick this up. > Yeah, I missed this, needs to be very obvious what is happening here. I'll replace the version in the queues with this one now, thanks. greg k-h

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > > Hi folks, > > > > > > This series impleme

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
mainly > because of the existing support for C host tools that use elfutils > (e.g., objtool). That's cool, can the C code be switched to also use this? That way we only have one path/code for all of this? thanks, greg k-h

Re: [PATCH] nvdimm: make nd_class constant

2024-06-12 Thread Greg Kroah-Hartman
On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote: > Greg Kroah-Hartman wrote: > > Now that the driver core allows for struct class to be in read-only > > memory, we should make all 'class' structures declared at build time > > placing them into read-only memo

Re: [PATCH 05/14] tracefs: replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-11 Thread Greg KH
ed-by: Steven Rostedt (Google) > > > > Do we have a way to add a "Depends-on" tag so that anyone backporting this > > will know that it requires the change to whatever allowed that to happen? > > Looks like people use that tag, although no grep hits in Documentation, so > Cc'ing workflows@ and Thorsten. > > In this case it would be > > Depends-on: c9929f0e344a ("mm/slob: remove CONFIG_SLOB") Ick, no, use the documented way of handling this as described in the stable kernel rules file. thanks, greg k-h

[PATCH] nvdimm: make nd_class constant

2024-06-10 Thread Greg Kroah-Hartman
Cc: nvd...@lists.linux.dev Signed-off-by: Greg Kroah-Hartman --- drivers/nvdimm/bus.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index 508aed017ddc..101c425f3e8b 100644 --- a/drivers/nvdimm/bus.c +++ b

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-05-27 Thread Greg KH
verted that commit to 6.9.2 and now it only serves the trace but > the panic is gone. But I can live with it. Steven, should we revert that? Or is there some other change that we should take to resolve this? thanks, greg k-h

Re: [RFC PATCH v1 1/2] virt: memctl: control guest physical memory properties

2024-05-14 Thread Greg Kroah-Hartman
On Tue, May 14, 2024 at 06:21:57PM -0700, Yuanchu Xie wrote: > On Tue, May 14, 2024 at 9:06 AM Greg Kroah-Hartman > wrote: > > > > On Mon, May 13, 2024 at 07:03:00PM -0700, Yuanchu Xie wrote: > > > Memctl provides a way for the guest to control its physical memory &g

Re: [RFC PATCH v1 1/2] virt: memctl: control guest physical memory properties

2024-05-14 Thread Greg Kroah-Hartman
mctl_vmm_call); You export something that is never actually called, which implies that this is not tested at all (i.e. it is dead code.) Please remove. Also, why not EXPORT_SYMBOL_GPL()? (I have to ask, sorry.) thanks, greg k-h

Re: [RFC PATCH v1 1/2] virt: memctl: control guest physical memory properties

2024-05-14 Thread Greg Kroah-Hartman
esp; Endain-ness of all of this as it goes to the hardware, right? > + }; > + u32 command; > +}; > + > +struct memctl_percpu_channel { > + struct memctl_buf buf; > + u64 buf_phys_addr; > + u32 command; > +}; > + > +struct memctl { > + void __iomem *base_addr; > + /* cache the info call */ > + struct memctl_vmm_info memctl_vmm_info; > + struct memctl_percpu_channel __percpu *pcpu_channels; > +}; > + > +static DEFINE_RWLOCK(memctl_lock); > +static struct memctl *memctl __read_mostly; > + > +static void memctl_write_command(void __iomem *base_addr, u32 command) > +{ > + iowrite32(command, > + base_addr + offsetof(struct memctl_transport, command)); Yup, you write this to hardware, please use proper structures and types for that, otherwise you will have problems in the near future. thanks, greg k-h

Re: [PATCH 5.15,5.10,5.4,4.19 0/2] Fix warning when tracing with large filenames

2024-04-29 Thread Greg KH
_MAX is larger than PERF_MAX_TRACE_SIZE > (2048 before the patch), the warning will trigger. > > The fix was included in 5.16, so backporting to 5.15 and earlier LTS > kernels. Also included is a patch that better describes the attempted > allocation size. All now queued up, thanks. greg k-h

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-22 Thread Greg KH
On Mon, Apr 22, 2024 at 10:46:37PM +0100, Mauro Carvalho Chehab wrote: > Em Mon, 22 Apr 2024 15:25:18 -0400 > Konstantin Ryabitsev escreveu: > > > On Mon, Apr 22, 2024 at 05:49:29PM +0200, Thorsten Leemhuis wrote: > > > @Greg, BTW: should this be stable+noau

Re: [PATCH] Revert "tracing/trigger: Fix to return error if failed to alloc snapshot"

2024-04-19 Thread Greg Kroah-Hartman
onsider no functions a failure too. >*/ > if (!ret) { > ret = -ENOENT; > > Cc: sta...@kernel.org # 5.15, 5.10, 5.4, 4.19 > Signed-off-by: Siddh Raman Pant > --- > kernel/trace/trace_events_trigger.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Now queued up everywhere, thanks. greg k-h

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-18 Thread Greg KH
On Thu, Apr 18, 2024 at 09:04:53AM +0200, Thorsten Leemhuis wrote: > On 17.04.24 15:38, Greg KH wrote: > > On Wed, Apr 17, 2024 at 03:21:12PM +0200, Thorsten Leemhuis wrote: > >> On 17.04.24 14:52, Konstantin Ryabitsev wrote: > >>> On Wed, Apr 17, 2024 at 09:48:18AM

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
able-autosel: ignore > > [This fix requires a feature that is only present in mainline] > > > > This allows passing along structured information that can be parsed by > > automated tooling without putting it into the commit. > > That afaics makes them

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
t's the simpler and more explicit thing to do for those that do not want to have anything backported they do not explicitly mark as such (some subsystems do this already, like kvm and -mm and xfs, it's fine!). This all is here because of maintainers who do NOT want to do that. thanks, greg k-h

Re: Please create the email alias do-not-apply-to-sta...@kernel.org -> /dev/null

2024-04-17 Thread Greg KH
way? If I need to file a > ticket somewhere or some ack from a higher authority, just let me know! I approve this message :) thanks, greg k-h

[PATCH 6.8 114/172] fs/proc: remove redundant comments from /proc/bootconfig

2024-04-15 Thread Greg Kroah-Hartman
mment to /proc/bootconfig") Signed-off-by: Zhenhua Huang Signed-off-by: Paul E. McKenney Cc: Cc: Cc: sta...@vger.kernel.org Acked-by: Masami Hiramatsu (Google) Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Greg Kroah-Hartman --- fs/proc/bootconfig.c | 12 ++-- 1 file c

Re: [PATCH] [v4] module: don't ignore sysfs_create_link() failures

2024-04-11 Thread Greg Kroah-Hartman
p ignoring -EEXIST > > errors. > > > > Fixes: e17e0f51aeea ("Driver core: show drivers in /sys/module/") > > Reviewed-by: Greg Kroah-Hartman > > Reviewed-by: Luis Chamberlain Oh right, I should apply this, sorry about that, will go do that now...

Re: [PATCH] [v3] module: don't ignore sysfs_create_link() failures

2024-04-05 Thread Greg Kroah-Hartman
rly unwind and return the error code to the > caller. My reading of the original code was that it tries to > not fail when the links already exist, so keep ignoring -EEXIST > errors. > > Cc: Luis Chamberlain > Cc: linux-modu...@vger.kernel.org > Cc: Greg Kroah-Hartman >

Re: [PATCH] [v2] module: don't ignore sysfs_create_link() failures

2024-03-23 Thread Greg Kroah-Hartman
rly unwind and return the error code to the > caller. My reading of the original code was that it tries to > not fail when the links already exist, so keep ignoring -EEXIST > errors. > > Cc: Luis Chamberlain > Cc: linux-modu...@vger.kernel.org > Cc: Greg Kroah-Hartman >

Re: [PATCH] module: silence warning about unused 'no_warn' variable

2024-03-22 Thread Greg Kroah-Hartman
o void to prevent this check as well. > > Cc: Luis Chamberlain > Cc: linux-modu...@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Fixes: e17e0f51aeea ("Driver core: show drivers in /sys/module/") > See-also: 4a7fb6363f2d ("add __

Re: [PATCH v6.1.y-v4.19.y] vhost: use kzalloc() instead of kmalloc() followed by memset()

2024-02-13 Thread Greg KH
t Red Hat and CVEs, they know how to let us know about stuff like this, but no. Hopefully, someday soon, they will soon not be allowed to do this anymore. {sigh} Now queued up, thanks. greg k-h

Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2024-02-07 Thread Greg Kroah-Hartman
On Wed, Feb 07, 2024 at 12:20:00AM +0100, Luca Weiss wrote: > On Tue Jan 2, 2024 at 2:53 PM CET, Greg Kroah-Hartman wrote: > > On Tue, Jan 02, 2024 at 02:43:24PM +0100, Luca Weiss wrote: > > > On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > > > > On T

Re: [PATCH] device-dax: make dax_bus_type const

2024-02-05 Thread Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 01:07:11PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the dax_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. >

Re: [PATCH] nvdimm: make nvdimm_bus_type const

2024-02-05 Thread Greg Kroah-Hartman
. > > Cc: Greg Kroah-Hartman > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Ricardo B. Marliere Reviewed-by: Greg Kroah-Hartman

Re: [PATCH] rpmsg: core: make rpmsg_bus const

2024-02-05 Thread Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 05:32:05PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the rpmsg_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. >

Re: [PATCH] vdpa: make vdpa_bus const

2024-02-05 Thread Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 05:50:45PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the vdpa_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. >

Re: [PATCH] virtio: make virtio_bus const

2024-02-05 Thread Greg Kroah-Hartman
On Sun, Feb 04, 2024 at 05:52:51PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the virtio_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. >

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 01:08:23PM -0500, Steven Rostedt wrote: > On Thu, 1 Feb 2024 10:05:59 -0800 > Greg KH wrote: > > > > timerlat_fd = > > > open("/sys/kernel/tracing/osnoise/per_cpu/cpu0/timerlat_fd", 'r') > > > timerlat_fd.close(); &g

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 05:02:56PM +0100, Daniel Bristot de Oliveira wrote: > On 2/1/24 16:44, Greg KH wrote: > > On Thu, Feb 01, 2024 at 04:13:39PM +0100, Daniel Bristot de Oliveira wrote: > >> Currently, the timerlat's hrtimer is initialized at the first read of > >>

Re: [PATCH] tracing/timerlat: Move hrtimer_init to timerlat_fd open()

2024-02-01 Thread Greg KH
ng. What error exactly happens? Userspace, or the kernel crashes? thanks, greg k-h

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
data supplies[ANX7688_NUM_SUPPLIES]; > + struct power_supply *vbus_in_supply; > + struct notifier_block vbus_in_nb; > + int input_current_limit; // mA > +struct gpio_desc *gpio_enable; > +struct gpio_desc *gpio_reset; > +struct gpio_desc *gpio_cabledet; I'm stopping here, again, tabs, you know this :( greg k-h

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
go back and guess in the future, that isn't nice. thanks, greg k-h

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
On Wed, Jan 31, 2024 at 05:16:09PM +, John Garry wrote: > On 31/01/2024 16:22, Greg KH wrote: > > > before: > > > real0m53.591s > > > user1m1.842s > > > sys 0m9.161s > > > > > > after: > > > real0m37.481s &

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
also convert more UTS_RELEASE users to prove this is proper > approach. I like it, I also think that v4l2 includes this as well as all of those drivers seem to rebuild when this changes, does that not happen for you too? Anyway, if the firmware changes work, I'm all for this, thanks for taking it on! thanks, greg k-h

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-26 Thread Greg Kroah-Hartman
> to the > > dev_pm_domain_attach_list(). I decided not to, but please let me know if you > > prefer the other option. > > > > Note 3) > > For OPP integration, as a follow up I am striving to make the > > dev_pm_opp_attach_genpd() redundant. Instead I think we shoul

Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2024-01-02 Thread Greg Kroah-Hartman
On Tue, Jan 02, 2024 at 02:43:24PM +0100, Luca Weiss wrote: > On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote: > > On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote: > > > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > > > > On 21.1

Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger, fuel gauge)

2024-01-02 Thread Greg Kroah-Hartman
t; > >>> So from my POV qcm6490 makes more sense > > >> > > >> But yeah since it's likely that sc7280 firmware behaves the same as > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > > >> we change it later :) I'll send a v2 with those changes. > > > > > > Worst case we end up with sc7280 which has yet another slightly > > > different UCSI / PMIC GLINK implementation, but the compatible string > > > is already taken. > > > I still suppose that this should be a qcm6490-related string. > > Right, let's keep qcm then > > Ack from my side also. Thanks for the feedback! This doesn't apply to my tree, where should it be going through? thanks, greg k-h

Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers

2023-12-14 Thread Greg Kroah-Hartman
> > - return sprintf(buf, "%llu\n", size); > + return sprintf(buf, "%llu\n", dax_region_avail_size(dax_region)); sysfs_emit() everywhere please. But again, the issue is "why do you need a lock"? thanks, greg k-h

Re: [PATCH] driver core: Add a guard() definition for the device_lock()

2023-12-14 Thread Greg KH
ishal Verma > Cc: Ira Weiny > Cc: Peter Zijlstra > Cc: Greg Kroah-Hartman > Cc: Andrew Morton > Signed-off-by: Dan Williams > --- > Hi Greg, > > I wonder if you might include this change in v6.7-rc to ease some patch > sets alternately going through my tree and Andr

Re: [PATCH v5 4/4] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-14 Thread Greg Kroah-Hartman
of a dax region. > + > +What:/sys/bus/dax/devices/daxX.Y/memmap_on_memory > +Date: October, 2023 It's not October anymore :) thanks, greg k-h

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Tue, Nov 28, 2023 at 08:05:26AM +, Greg KH wrote: > On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > > > With regards to future directions that likely won't work for > > > > > > loosening it: > > &

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
el needs to be fixed up to support this > > properly, not just ignored like this patchset does. > I agree there is a divergence here, I tried to point it out so that it > wouldn't be > a surprise later. The .rmeta file itself (which is the only way we > could know that > the ABI act

Re: [ANNOUNCE] 5.10.201-rt98

2023-11-24 Thread Greg Kroah-Hartman
just an update to the new stable 5.10.201 > > version and no RT changes have been made. > > > > You can get this release via the git tree at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git > > > > branch: v5.10-rt > &g

Re: [REGRESSION] USB ports do not work after suspend/resume cycle with v6.6.2

2023-11-24 Thread Greg Kroah-Hartman
On Fri, Nov 24, 2023 at 01:59:24PM +0100, Vlastimil Babka wrote: > +Cc workflows > > On 11/24/23 12:43, Greg Kroah-Hartman wrote: > > On Thu, Nov 23, 2023 at 07:20:46PM +0100, Oleksandr Natalenko wrote: > >> Hello. > >> > >> Since v6.6.2 kernel release

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Thu, Nov 23, 2023 at 08:38:45PM +0900, Masahiro Yamada wrote: > On Thu, Nov 23, 2023 at 6:05 PM Greg KH wrote: > > > > On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > > > So, even if you enable CONFIG_MODVERSIONS, > > > > nothin

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
u to consider this useful? If not, can you help me understand > what level of precision would be required? What exactly does .rmeta have to do with the function signature? That's all you care about here. thanks, greg k-h

Re: [PATCH v2 2/5] modules: Refactor + kdoc elf_validity_cached_copy

2023-11-18 Thread Greg KH
Again, this needs to be broken into much smaller pieces before we can even review it. Would you want to review this? thanks, greg "think of the reviewers" k-h

Re: [PATCH v2 1/5] export_report: Rehabilitate script

2023-11-18 Thread Greg KH
a series. thanks, greg k-h

Re: stable-rc: 5.15 - all builds failed - ld.lld: error: undefined symbol: kallsyms_on_each_symbol

2023-11-02 Thread Greg Kroah-Hartman
On Wed, Nov 01, 2023 at 08:54:56PM +0530, Naresh Kamboju wrote: > Hi Greg, > > I see the following build warning / errors everywhere on stable-rc 5.15 > branch. > > ld.lld: error: undefined symbol: kallsyms_on_each_symbol > >>> referenced by trace_kpro

Re: [PATCH 04/10] staging: ks7010: remove unused ioctl handler

2023-10-09 Thread Greg Kroah-Hartman
; Signed-off-by: Arnd Bergmann Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-09 Thread Greg Kroah-Hartman
drivers/staging/rtl8192u/r8192U_core.c| 109 > 6 files changed, 729 deletions(-) Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 07/10] staging: rtl8723bs: remove dead code

2023-10-09 Thread Greg Kroah-Hartman
removed as well. > > Looking through the exported functions, I found a bunch more that have > no callers, so just drop all of those. > > Signed-off-by: Arnd Bergmann Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 06/10] staging: rtl8712: remove unused legacy ioctl handlers

2023-10-09 Thread Greg Kroah-Hartman
aging/rtl8712/os_intfs.c| 1 - > drivers/staging/rtl8712/osdep_intf.h | 2 - > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 124 -- > 3 files changed, 127 deletions(-) Reviewed-by: Greg Kroah-Hartman

[PATCH] testing: nvdimm: make struct class structures constant

2023-10-06 Thread Greg Kroah-Hartman
Signed-off-by: Greg Kroah-Hartman --- tools/testing/nvdimm/test/ndtest.c | 17 + tools/testing/nvdimm/test/nfit.c | 14 +++--- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c index

[PATCH] net: appletalk: remove cops support

2023-09-27 Thread Greg Kroah-Hartman
is cleared up. Reported-by: Prarit Bhargava Cc: Christoph Hellwig Cc: Vitaly Kuznetsov Cc: jsch...@samba.org Signed-off-by: Greg Kroah-Hartman --- .../device_drivers/appletalk/cops.rst | 80 -- .../device_drivers/appletalk/index.rst| 18 - .../networking/device_drivers/index.rst

Re: [PATCH 3/3] get_maintainer: add patch-only pattern matching type

2023-09-27 Thread Greg KH
On Wed, Sep 27, 2023 at 03:46:30PM +0900, Justin Stitt wrote: > On Wed, Sep 27, 2023 at 3:14 PM Greg KH wrote: > > > > On Wed, Sep 27, 2023 at 03:19:16AM +, Justin Stitt wrote: > > > Note that folks really shouldn't be using get_maintainer on tree files > >

Re: [PATCH 3/3] get_maintainer: add patch-only pattern matching type

2023-09-27 Thread Greg KH
m. So please don't take that valid use-case away from us. thanks, greg k-h

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread Greg KH
ser left. The best might be to indeed just > remove it and see if anyone screams, in which case we could bring it > back after doing the above. > We should just remove them for now, I have no objection to that at all. Want me to send the patch? thanks, greg k-h

Re: [PATCH] printk: add cpu id information to printk() output

2023-09-15 Thread Greg KH
operation, such as load > situation and CPU busy/idle status The cpu that is printing the log isn't the one that added the log message, so I think you will have incorrect data here, right? thanks, greg k-h

Re: [PATCH] printk: add cpu id information to printk() output

2023-09-15 Thread Greg KH
On Fri, Sep 15, 2023 at 03:40:34PM +0800, Enlin Mu wrote: > From: Enlin Mu > > Sometimes we want to print cpu id of printk() messages to consoles This is rejected every few years. What has changes from the previous times this was sent? And why can't you use trace_printk()? thanks, greg k-h

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-21 Thread Greg Kroah-Hartman
dead code elimination in the > CONFIG_PROVE_LOCKING=n case. > > Suggested-by: Peter Zijlstra > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Cc: Ingo Molnar > Cc: Will Deacon > Cc: Waiman Long > Cc: Boqun Feng > Cc: Alison Schofield > Cc: Vishal V

Re: [PATCH v3 7/8] device-core: Kill the lockdep_mutex

2022-04-21 Thread Greg Kroah-Hartman
Link: > https://lore.kernel.org/r/ylf0dewci8myl...@hirez.programming.kicks-ass.net [1] > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Suggested-by: Peter Zijlstra > Signed-off-by: Dan Williams YES! Acked-by: Greg Kroah-Hartman Nice work.

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:47:17PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:21 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:36:51PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:17 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
return -EINVAL; > + } > + ret = zynqmp_pm_afi(reg, val); > + if (ret < 0) { > + dev_err(>dev, "AFI register write error %d\n", > + ret); > + return ret; > + } > + } > + return 0; > +} Again, why does this have to be in the kernel? All it does is make a single call to the hardware based on some values read from the device tree. Can't you do this from userspace? thanks, greg k-h

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
+ the proper Bus-width values Please use tabs properly, you mix them above, checkpatch should have caught that. thanks, greg k-h

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
_CTRL_OFFSET); > + reg_val = readl(afi_fpga->membase + AFI_WRCHAN_CTRL_OFFSET); > + reg_val &= ~AFI_BUSWIDTH_MASK; > + writel(reg_val | afi_fpga->afi_width, > +afi_fpga->membase + AFI_WRCHAN_CTRL_OFFSET); > + > + return 0; > +} I do not understand, why is this driver needed at all? Why can't you do the above from userspace? All this does is write some values to the hardware at probe time, who needs this? thanks, greg k-h

Re: [Virtio-fs] [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode

2021-04-20 Thread Greg Kurz
t; explicity at the callsite itself. Easier to read code. > > This patch should not introduce any change of behavior. > > Suggested-by: Dan Williams > Signed-off-by: Vivek Goyal > --- Reviewed-by: Greg Kurz > fs/dax.c | 23 +-- > 1 file ch

Re: Re: [syzbot] INFO: rcu detected stall in tx

2021-04-20 Thread Greg Kroah-Hartman
de > according to usbtmc_read_bulk_cb() or > usb_skeleton.c. > @Dave: Do you have time? Otherwise I can do it. > @Greg: Is it urgent? No idea, but patches for known problems are always good to get completed as soon as possible :) thanks, greg k-h

Re: [PATCH 1/2] Revert "USB: serial: ch341: add new Product ID for CH341A"

2021-04-20 Thread Greg Kroah-Hartman
On Mon, Apr 19, 2021 at 09:25:19PM -0500, Frank Zago wrote: > From: frank zago > > The 0x5512 USB PID is for the I2C/GPIO/SPI interfaces. UART is still > present but only the TX and RX pins are available; DTS, DTR, ... are > used for other things. Remove the PID, and let a I2C driver bind to >

Re: [Virtio-fs] [PATCH v3 2/3] dax: Add a wakeup mode parameter to put_unlocked_entry()

2021-04-20 Thread Greg Kurz
s simple enough, so I'd simply drop it. This is minor though and it shouldn't prevent this fix to go forward. Reviewed-by: Greg Kurz > if (entry && !dax_is_conflict(entry)) > - dax_wake_entry(xas, entry, WAKE_NEXT); > + dax_wake_entry(xas, en

Re: [PATCH 5.10 043/103] net: tipc: Fix spelling errors in net/tipc module

2021-04-20 Thread Greg Kroah-Hartman
comments. Agreed, now dropped, thanks. greg k-h

Re: [PATCH 5.10 042/103] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Greg Kroah-Hartman
s done as a "research project" to see if they could mess with kernel maintainers and slip in pointless changes to the kernel. Not acceptable at all... greg k-h

Re: [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order

2021-04-20 Thread Greg KH
fer_release(fbinfo_crt); > > + kfree(info); > return 0; > } > > -- > 2.25.1 > There is no function change here at all, please stop it with pointless patches. greg k-h

Re: [PATCH] scsi: be2iscsi: Reset the address passed in beiscsi_iface_create_default

2021-04-20 Thread Greg KH
ll. Stop submitting patches that you know are invalid. Your experiment is not ethical, and not welcome or appreciated. greg k-h

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread Greg KH
ssible to have happen. Please stop submitting known-invalid patches. Your professor is playing around with the review process in order to achieve a paper in some strange and bizarre way. This is not ok, it is wasting our time, and we will have to report this, AGAIN, to your university... greg k-h

Re: [PATCH 5.10 042/103] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-20 Thread Greg Kroah-Hartman
On Mon, Apr 19, 2021 at 03:05:53PM +0200, Greg Kroah-Hartman wrote: > From: Aditya Pakki > > [ Upstream commit 0c85a7e87465f2d4cbc768e245f4f45b2f299b05 ] > > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing p

Re: [PATCH 00/13] [RFC] Rust support

2021-04-19 Thread Greg Kroah-Hartman
t funding and support to FIX the bugs that those tools test. Right now, the primary fixer of those findings are _INTERNS_ as that's all companies are willing to fund to fix this type of thing. And don't get me started on the inability for "executives" to fund other parts of Linux that they rely on, because they want "other companies" to do it instead. The tragedy-of-the-commons is a real threat to Linux, and always has been... thanks, greg k-h

[PATCH] virtiofs: propagate sync() to file server

2021-04-19 Thread Greg Kurz
l FUSE file server is an untrusted piece of software running in userspace, this is disabled by default. Only enable it with virtiofs for now since virtiofsd is supposedly trusted by the guest kernel. Reported-by: Robert Krawitz Signed-off-by: Greg Kurz --- Can be tested using the following custom QEMU with F

[PATCH 5.4 22/73] ASoC: fsl_esai: Fix TDM slot setup for I2S mode

2021-04-19 Thread Greg Kroah-Hartman
From: Alexander Shiyan [ Upstream commit e7a48c710defa0e0fef54d42b7d9e4ab596e2761 ] When using the driver in I2S TDM mode, the fsl_esai_startup() function rewrites the number of slots previously set by the fsl_esai_set_dai_tdm_slot() function to 2. To fix this, let's use the saved slot count

[PATCH 5.4 30/73] net: ieee802154: stop dump llsec devkeys for monitors

2021-04-19 Thread Greg Kroah-Hartman
From: Alexander Aring [ Upstream commit 080d1a57a94d93e70f84b7a360baa351388c574f ] This patch stops dumping llsec devkeys for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring Link:

[PATCH 5.4 60/73] ibmvnic: avoid calling napi_disable() twice

2021-04-19 Thread Greg Kroah-Hartman
ich checks if napi is disabled or not before calling napi_disable. Fixes: bfc32f297337 ("ibmvnic: Move resource initialization to its own routine") Suggested-by: Thomas Falcon Signed-off-by: Lijun Pan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net

[PATCH 5.4 68/73] r8169: fix performance regression related to PCIe max read request size

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 21b5f672fb2eb1366dedc4ac9d32431146b378d3 ] It turned out that on low performance systems the original change can cause lower tx performance. On a N3450-based mini-PC tx performance in iperf3 was reduced from 950Mbps to ~900Mbps. Therefore effectively

[PATCH 5.4 67/73] r8169: simplify setting PCI_EXP_DEVCTL_NOSNOOP_EN

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit e0bbe7cbb3c5ff72d680993edf89db2391e80d5d ] r8168b_0_hw_jumbo_enable() and r8168b_0_hw_jumbo_disable() both do the same and just set PCI_EXP_DEVCTL_NOSNOOP_EN. We can simplify the code by moving this setting for RTL8168B to rtl_hw_start_8168().

[PATCH 5.4 69/73] r8169: improve rtl_jumbo_config

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 9db0ac57bd3286fedcf43a86b29b847cea281cc7 ] Merge enabling and disabling jumbo packets to one function to make the code a little simpler. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH 5.4 43/73] dm verity fec: fix misaligned RS roots IO

2021-04-19 Thread Greg Kroah-Hartman
RS roots unaligned to block size") Cc: sta...@vger.kernel.org Signed-off-by: Jaegeuk Kim Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-verity-fec.c | 11 --- drivers/md/dm-verity-fec.h |1 + 2 files changed, 9 insertions(+), 3 deletions(-)

[PATCH 5.4 65/73] arm64: dts: allwinner: Fix SD card CD GPIO for SOPine systems

2021-04-19 Thread Greg Kroah-Hartman
From: Andre Przywara [ Upstream commit 3dd4ce4185df6798dcdcc3669bddb35899d7d5e1 ] Commit 941432d00768 ("arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card") enabled the card detect GPIO for the SOPine module, along the way with the Pine64-LTS, which share the same base .dtsi.

[PATCH 5.4 66/73] r8169: remove fiddling with the PCIe max read request size

2021-04-19 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 2df49d36549808a7357ad9f78b7a8e39516e7809 ] The attempt to improve performance by changing the PCIe max read request size was added in the vendor driver more than 10 years back and copied to r8169 driver. In the vendor driver this has been removed long

[PATCH 5.4 64/73] ARM: footbridge: fix PCI interrupt mapping

2021-04-19 Thread Greg Kroah-Hartman
From: Russell King [ Upstream commit 30e3b4f256b4e366a61658c294f6a21b8626dda7 ] Since commit 30fdfb929e82 ("PCI: Add a call to pci_assign_irq() in pci_device_probe()"), the PCI code will call the IRQ mapping function whenever a PCI driver is probed. If these are marked as __init, this causes an

[PATCH 5.4 63/73] gro: ensure frag0 meets IP header alignment

2021-04-19 Thread Greg Kroah-Hartman
son Wang Acked-by: Michael S. Tsirkin Tested-by: Guenter Roeck Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/dev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5406,7 +5406,8 @@ static void skb_gro_reset_

[PATCH 5.4 62/73] ibmvnic: remove duplicate napi_schedule call in open function

2021-04-19 Thread Greg Kroah-Hartman
t;) Signed-off-by: Lijun Pan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/ibm/ibmvnic.c |5 - 1 file changed, 5 deletions(-) --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1088,11 +1088,6 @@

[PATCH 5.4 73/73] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-19 Thread Greg Kroah-Hartman
ewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/mv88e6xxx/chip.c | 30 +- drivers/net/phy/marvell.c| 29 ++--- include/linux/marvell_phy.h |5 +++-- 3 files ch

[PATCH 5.4 61/73] ibmvnic: remove duplicate napi_schedule call in do_reset function

2021-04-19 Thread Greg Kroah-Hartman
et to call napi_schedule again at the end of the function though napi_schedule will neglect the request if napi is already scheduled. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Lijun Pan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman ---

[PATCH 5.4 72/73] ARM: 9071/1: uprobes: Dont hook on thumb instructions

2021-04-19 Thread Greg Kroah-Hartman
are not permanently undefined. Signed-off-by: Fredrik Strupe Cc: sta...@vger.kernel.org Fixes: c7edc9e326d5 ("ARM: add uprobes support") Signed-off-by: Russell King Signed-off-by: Greg Kroah-Hartman --- arch/arm/probes/uprobes/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

  1   2   3   4   5   6   7   8   9   10   >