Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 12:41:48PM +, Luis Henriques wrote: > Greg KH writes: > > > On Fri, Feb 12, 2021 at 12:05:14PM +, Luis Henriques wrote: > >> Greg KH writes: > >> > >> > On Fri, Feb 12, 2021 at 10:22:16AM +0200, Amir Goldstein wrote: &g

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 12:05:14PM +, Luis Henriques wrote: > Greg KH writes: > > > On Fri, Feb 12, 2021 at 10:22:16AM +0200, Amir Goldstein wrote: > >> On Fri, Feb 12, 2021 at 9:49 AM Greg KH wrote: > >> > > >> > On Fri, Feb 12, 20

Re: [GIT PULL] soundwire updates for v5.12-rc1

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:44:22PM +0530, Vinod Koul wrote: > Hello greg, > > Few more patches came in late and would be great to have in upcoming > merge window. Please pull to receive a fix for Intel laptops and support > for _no_pm in sdw regmap (acked by Mark) > > The following changes since

Re: [PATCH v5] tpm_tis: Add missing tpm_request/relinquish_locality() calls

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 12:06:00PM +0100, Lukasz Majczak wrote: > There are missing calls to tpm_request_locality() before the calls to > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > internally send commands to the tpm using tpm_tis_send_data() > which in turn, at the ve

Re: [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 12:29:49PM +0200, Mihai Carabas wrote: > ..snip > > > -}; > > > -module_platform_driver(pvpanic_mmio_driver); > > > diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig > > > new file mode 100644 > > > index ..0dce6ef > > > --- /dev/null > > > +++

Re: [PATCH v2 2/3] misc/pvpanic: add PCI driver

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 11:17:05AM +0200, Mihai Carabas wrote: > Add support for pvpanic PCI device added in qemu [1]. At probe time, obtain > the > address where to read/write pvpanic events and pass it to the generic handling > code. Will follow the same logic as pvpanic MMIO device driver. At r

Re: [PATCH v2 1/3] misc/pvpanic: split-up generic and platform dependent code

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 11:17:04AM +0200, Mihai Carabas wrote: > Split-up generic and platform dependent code in order to be able to re-use > generic event handling code in pvpanic PCI device driver in the next patch. > > The code from pvpanic.c was split in two new files: > - pvpanic-common.c: ge

Re: [PATCH v2 3/3] misc/pvpanic: add license

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 11:17:06AM +0200, Mihai Carabas wrote: > Add license to the newly created files in adding support for pvpanic PCI > device > driver. > > Signed-off-by: Mihai Carabas > --- > drivers/misc/pvpanic/Kconfig | 7 +++ > drivers/misc/pvpanic/Makefile | 7 +++ > drive

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 03:20:08PM +0530, Pritthijit Nath wrote: > Fixed the spelling of 'transfered' to 'transferred'. > > Signed-off-by: Pritthijit Nath > --- > Fixed the typo in the patch which was meant to fix that very typo. > Really sorry for last time. > Hope this does not have any othe

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:17, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > > > On 12-02-21, 13:48, Pritthijit Nath wrote: > > > > This change fixes a checkpatch CHECK sty

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > On 12-02-21, 13:48, Pritthijit Nath wrote: > > This change fixes a checkpatch CHECK style issue for "Alignment should match > > open parenthesis". > > > > Signed-off-by: Pritthijit Nath > > --- > > drivers/staging/greybus/hid.c | 4

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote: > On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote: > > Fixed the spelling of 'transfered' to 'transferred'. > > > > Signed-off-by: Pritthijit Nath > > --- > > drivers/staging/greybus/hid.c | 2 +- > > 1 file changed, 1

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 10:22:16AM +0200, Amir Goldstein wrote: > On Fri, Feb 12, 2021 at 9:49 AM Greg KH wrote: > > > > On Fri, Feb 12, 2021 at 12:44:00PM +0800, Nicolas Boichat wrote: > > > Filesystems such as procfs and sysfs generate their content at > > > run

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:20:17PM +0800, Nicolas Boichat wrote: > On Fri, Feb 12, 2021 at 3:46 PM Greg KH wrote: > > > > On Fri, Feb 12, 2021 at 12:44:00PM +0800, Nicolas Boichat wrote: > > > Filesystems such as procfs and sysfs generate their content at > > &g

Re: [GIT PULL v2] extcon next for v5.12

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:19:37PM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.12. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > Changes from v1: > - Add missing committer information > > Best Re

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 12:44:00PM +0800, Nicolas Boichat wrote: > Filesystems such as procfs and sysfs generate their content at > runtime. This implies the file sizes do not usually match the > amount of data that can be read from the file, and that seeking > may not work as intended. > > This w

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 08:16:15PM -0500, min.li...@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. > > The driver is developed to be only used by Renesas PTP Clock > Manager for L

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 08:16:15PM -0500, min.li...@renesas.com wrote: > +static int > +rsmu_open(struct inode *iptr, struct file *fptr) > +{ > + struct rsmu_cdev *rsmu; > + > + rsmu = container_of(iptr->i_cdev, struct rsmu_cdev, rsmu_cdev); > + if (!rsmu) > + return -EAGAIN

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:56:47AM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should > match open parenthesis". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/vt6656/rf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:32:51AM +0530, Pritthijit Nath wrote: > On 12/02/21 2:14 am, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote: > >> On 12/02/21 1:59 am, Greg KH wrote: > >>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Prit

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote: > On 12/02/21 1:59 am, Greg KH wrote: > > On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: > >> This change fixes a checkpatch CHECK style issue for "Alignment should > >> match ope

Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

2021-02-11 Thread Greg KH
On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote: > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepare() > function: > > wimax/i2400m/fw.c:194:36: warning: restricted __le32 degrades to integer > wimax/i2400m/fw.c:195:34: warning: invalid assignment: += > wimax/i2400m/fw

Re: [PATCH] staging: wimax: Fix some coding style problems

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 10:43:20PM +0530, Hemansh Agnihotri wrote: > This fixes checkpatch errors :- "else should follow close brace '}'", > "space required before the open parenthesis '('" and "spaces required > around that '?' (ctx:VxW)" in drivers/staging/wimax/i2400m/rx.c file. > > Signed-off-

Re: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > In addition the misspelling of "transferred" also has been fixed. When you say "also" or "in addition" in a changelog, that is a h

Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote: > This change fixes a checkpatch CHECK style issue for "Alignment should match > open parenthesis". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/vt6656/rf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v4] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 10:42:49AM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets a

Re: [PATCH v3] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 09:21:29AM -0700, Dave Jiang wrote: > > On 2/10/2021 11:54 PM, Greg KH wrote: > > On Wed, Feb 10, 2021 at 01:16:11PM -0700, Dave Jiang wrote: > > > When the auxiliary device code is built into the kernel, it can be > > > executed >

Re: [PATCH v2 0/3] coresight: Patches for v5.12 (part 2)

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 10:20:35AM -0700, Mathieu Poirier wrote: > Good morning, > > My previous submission had the wrong baseline and as such was missing a patch. > This set applies properly on [1]. Much better, thanks, now queued up. greg k-h

Re: [PATCH] staging: wlan-ng: Fix comments typos

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 05:55:18PM +0100, Mairo P. Rufus wrote: > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept >

Re: [PATCH] staging: wimax: Fix some coding style problems

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 09:45:53PM +0530, Hemansh Agnihotri wrote: > This fixes following warnings and errors as reported by checkpatch.pl: > 1) WARNING: Missing a blank line after declarations > 2) WARNING: Block comments use a trailing */ on a separate line > 3) ERROR: code inde

Re: [PATCH for 5.4] Fix unsynchronized access to sev members through svm_register_enc_region

2021-02-11 Thread Greg KH
On Mon, Feb 08, 2021 at 08:48:55AM -0800, Peter Gonda wrote: > commit 19a23da53932bc8011220bd8c410cb76012de004 upstream. > > Grab kvm->lock before pinning memory when registering an encrypted > region; sev_pin_memory() relies on kvm->lock being held to ensure > correctness when checking and updati

Re: [PATCH] clk: Mark fwnodes when their clock provider is added

2021-02-11 Thread Greg KH
On Wed, Feb 10, 2021 at 01:44:35PM +0200, Tudor Ambarus wrote: > This is a follow-up for: > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is > added/removed") > > The above commit updated the deprecated of_clk_add_provider(), > but missed to update the preferred of_clk_add_hw_

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-11 Thread Greg KH
On Wed, Feb 10, 2021 at 10:03:31PM -0500, min.li...@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. The > supported functons are: > > - set combomode > - get dpll's state > - get d

Re: [PATCH -next] staging: ks7010: Macros with complex values

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 03:23:24PM +0300, Fatih Yildirim wrote: > On Thu, Feb 11, 2021 at 12:10:44PM +0100, Greg KH wrote: > > On Thu, Feb 11, 2021 at 01:57:04PM +0300, Fatih YILDIRIM wrote: > > > On Thu, Feb 11, 2021 at 11:02:51AM +0100, Greg KH wrote: > > > > On T

Re: [PATCH -next] staging: ks7010: Macros with complex values

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 01:57:04PM +0300, Fatih YILDIRIM wrote: > On Thu, Feb 11, 2021 at 11:02:51AM +0100, Greg KH wrote: > > On Thu, Feb 11, 2021 at 12:22:39PM +0300, Fatih Yildirim wrote: > > > Fix for checkpatch.pl warning: > > > Macros with complex values should

Re: [PATCH -next] staging: ks7010: Macros with complex values

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 12:22:39PM +0300, Fatih Yildirim wrote: > Fix for checkpatch.pl warning: > Macros with complex values should be enclosed in parentheses. > > Signed-off-by: Fatih Yildirim > --- > drivers/staging/ks7010/ks_hostif.h | 24 > 1 file changed, 12 insert

Re: [PATCH 1/1] staging: greybus: Added do - while in multi statement macro

2021-02-11 Thread Greg KH
On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote: > This patch add fixes an checkpatch error for "Macros with multiple statements > should be enclosed in a do - while loop" > > Signed-off-by: Hemansh Agnihotri Any reason you didn't test-build your patch before sending it out? T

Re: [PATCH v3] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 01:16:11PM -0700, Dave Jiang wrote: > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("Auxiliary Bus"); > MODULE_AUTHOR("David Ertman "); As this code can not be built as a module, can you remove these lines as well? I don't think they do anything, and were never needed.

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 10:03:31PM -0500, min.li...@renesas.com wrote: > From: Min Li > > This driver supports 1588 related functions of ClockMatrix(TM) > and 82P33xxx families of timing and synchronization devices. The > supported functons are: > > - set combomode > - get dpll's state > - get d

Re: [PATCH v3] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 01:16:11PM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets a

Re: [PATCH] Macros with complex values should be enclosed in parentheses.

2021-02-10 Thread Greg KH
On Thu, Feb 11, 2021 at 09:25:43AM +0300, Fatih YILDIRIM wrote: > Signed-off-by: Fatih YILDIRIM > --- > Hi, > I have a coding style fix. > By the way, I'm following the Eudyptula Challenge Linux kernel tasks > and this is my first patch related to my task no 10. > I hope I'm doing it the right way

Re: [PATCH 1/1] Macros with multiple statements should be enclosed in a do - while loop.

2021-02-10 Thread Greg KH
On Thu, Feb 11, 2021 at 01:14:39AM +0300, Fatih YILDIRIM wrote: > Signed-off-by: Fatih YILDIRIM > --- > drivers/staging/greybus/loopback.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/loopback.c > b/drivers/staging/greybus/loopback.

Re: linux-next: build failure after merge of the driver-core tree

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 11:17:16AM -0800, Saravana Kannan wrote: > On Wed, Feb 10, 2021 at 11:06 AM Saravana Kannan wrote: > > > > On Wed, Feb 10, 2021 at 10:18 AM Greg KH wrote: > > > > > > On Wed, Feb 10, 2021 at 09:47:20PM +1100, Stephen Rothwell wrote: >

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 06:55:44PM +, Phillip Potter wrote: > On Wed, Feb 10, 2021 at 09:40:27PM +0300, Dan Carpenter wrote: > > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote: > > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. > > > > I'm pretty hip to checkpa

Re: linux-next: build failure after merge of the driver-core tree

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 09:47:20PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build (sparc64 > defconfig) failed like this: > > drivers/of/property.o: In function `parse_interrupts': > property.c:(.text+0x14e0): undefined reference to `of_i

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 05:34:38PM +, Phillip Potter wrote: > On Wed, Feb 10, 2021 at 06:12:54PM +0100, Greg KH wrote: > > On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote: > > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also > > > f

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 05:00:03PM +, Phillip Potter wrote: > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also > fix opening brace placements and trailing single statement layout within > RT_PRINT_DATA, as well as making newline character placement more > consistent and removi

Re: [PATCH 0/2] coresight: Patches for v5.12 (part 2)

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 06:10:34PM +0100, Greg KH wrote: > On Wed, Feb 10, 2021 at 09:36:08AM -0700, Mathieu Poirier wrote: > > Hi Greg, > > > > Please see if you can add these 2 patches to your 5.12 tally. No worries > > if you think it is too close to the merge win

Re: [PATCH 0/2] coresight: Patches for v5.12 (part 2)

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 09:36:08AM -0700, Mathieu Poirier wrote: > Hi Greg, > > Please see if you can add these 2 patches to your 5.12 tally. No worries > if you think it is too close to the merge window, I'll simply queue them > for the next one. > > Thanks, > Mathieu > > Leo Yan (1): > Docu

Re: [stable 4.4, 4.9, 4.14, 4.19 LTS] Missing fix "memcg: fix a crash in wb_workfn when a device disappears"

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 11:04:19AM -0500, Mathieu Desnoyers wrote: > Hi, > > While reconciling the lttng-modules writeback instrumentation with its > counterpart > within the upstream Linux kernel, I notice that the following commit > introduced in > 5.6 is present in stable branches 5.4 and 5.5

Re: [PATCH] staging: wlan-ng: Fix comments typos

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote: > Signed-off-by: Mairo Paul Rufus > --- > drivers/staging/wlan-ng/p80211netdev.c | 2 +- > drivers/staging/wlan-ng/prism2mib.c| 2 +- > drivers/staging/wlan-ng/prism2sta.c| 4 ++-- > 3 files changed, 4 insertions(+), 4 dele

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kmalloc. > > Signed-off-by: Amey Narkhede > --- > Changes in v3: > - Remove superfluous buf pointer > - Reduce s

Re: [PATCH stable 4.9] mm: memcontrol: fix NULL pointer crash in test_clear_page_writeback()

2021-02-10 Thread Greg KH
On Tue, Feb 09, 2021 at 04:19:46PM -0500, Johannes Weiner wrote: > On Tue, Feb 09, 2021 at 12:26:15PM -0800, Florian Fainelli wrote: > > From: Johannes Weiner > > > > commit 739f79fc9db1b38f96b5a5109b247a650fbebf6d upstream > > ... > > > This patch is present in a downstream Android tree: > >

Re: [PATCH] MAINTAINERS: replace my with email with replacements

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 01:01:16PM +0200, Alexandru Ardelean wrote: > This email will become inactive in a few weeks. > This change removes it from the MAINTAINERS file and adds the people that > will be responsible for the parts moving forward. > > Signed-off-by: Alexandru Ardelean > --- > MAIN

Re: [GIT PULL] phy: second round of fixes for v5.11

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 02:42:49PM +0530, Vinod Koul wrote: > On 09-02-21, 09:33, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:26:18PM +0530, Vinod Koul wrote: > > > Hello Greg, > > > > > > Please pull to receive few phy driver fixes for v5.11. >

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote: > On 21/02/10 09:06AM, Greg KH wrote: > > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote: > > > Stack allocated buffers cannot be used for DMA > > > on all architectures so allocate hci_packet

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Greg KH
On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote: > Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kzalloc(). > > Signed-off-by: Amey Narkhede > --- > Changes in v2: > - Fixed build warning > - Fixed memory leak

Re: [PATCH v3] mm: cma: support sysfs

2021-02-10 Thread Greg KH
On Tue, Feb 09, 2021 at 11:55:09PM -0800, Minchan Kim wrote: > Since CMA is getting used more widely, it's more important to > keep monitoring CMA statistics for system health since it's > directly related to user experience. > > This patch introduces sysfs statistics for CMA, in order to provide

Re: [PATCH v2] Drivers: staging: most: sound: Fixed styling issue.

2021-02-09 Thread Greg KH
On Wed, Feb 10, 2021 at 06:30:45AM +0530, Mukul Mehar wrote: > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > > Signed-off-by: Mukul Mehar > --- > Changes since v1: > - Fixed indentation. > --- > drivers/staging/most/sound/sound.c | 6 +++--- > 1 file

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 11:16:07PM -0800, John Hubbard wrote: > On 2/9/21 11:12 PM, Minchan Kim wrote: > ... > > > > Agreed. How about this for the warning part? > > > > > > > > + > > > > +/* > > > > + * note: kobj_type should provide a release function to free > > > > dynamically > > > > + * all

Re: [PATCH] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 12:01:06PM -0800, Dan Williams wrote: > On Tue, Feb 9, 2021 at 11:16 AM Greg KH wrote: > [..] > > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > > > index 8336535f1e11..53f93a506626 100644 > > > --- a/drivers/base/aux

Re: [PATCH v2] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 03:17:00PM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets a

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 01:13:17PM -0800, Minchan Kim wrote: > On Tue, Feb 09, 2021 at 12:11:20PM -0800, John Hubbard wrote: > > On 2/9/21 9:49 AM, Greg KH wrote: > > > > > That's fine if you want to add it to the parent. If so, then the > > > > > ko

Re: [PATCH] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 12:38:06PM -0700, Dave Jiang wrote: > > On 2/9/2021 12:14 PM, Greg KH wrote: > > On Tue, Feb 09, 2021 at 12:05:05PM -0700, Dave Jiang wrote: > > > When the auxiliary device code is built into the kernel, it can be > > > executed >

Re: [PATCH] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 12:05:05PM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets a

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-09 Thread Greg KH
On Wed, Feb 10, 2021 at 01:01:47AM +0530, ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > Stack allocated buffers cannot be used for DMA > on all architectures so allocate hci_packet buffer > using kzalloc(). > > Signed-off-by: Amey Narkhede > --- > drivers/staging/gdm724x/gdm_usb.c

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 07:55:59AM -0800, Minchan Kim wrote: > On Tue, Feb 09, 2021 at 07:56:30AM +0100, Greg KH wrote: > > On Mon, Feb 08, 2021 at 10:34:51PM -0800, John Hubbard wrote: > > > On 2/8/21 10:27 PM, John Hubbard wrote: > > > > On 2/8/21 10:13 PM, Greg K

Re: [PATCH] staging: gdm724x: Fix DMA from stack

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 08:24:15PM +0530, ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > Stack allocated buffers cannot be used for DMA > on all architectures so allocate usbdev buffer > using kmalloc(). > > Signed-off-by: Amey Narkhede > --- > drivers/staging/gdm724x/gdm_usb.c | 6

Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote: > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > > Signed-off-by: Mukul Mehar > --- > drivers/staging/most/sound/sound.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) >

Re: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-02-09 Thread Greg KH
On Wed, Jan 27, 2021 at 04:56:22PM -0600, Mike Ximing Chen wrote: > Add basic driver functionality (load, unload, probe, and remove callbacks) > for the DLB driver. > > Add documentation which describes in detail the hardware, the user > interface, device interrupts, and the driver's power-managem

Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 06:20:37PM +0530, Mukul Mehar wrote: > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > > Signed-off-by: Mukul Mehar > --- > drivers/staging/most/sound/sound.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [RFC PATCH v3 1/2] mempinfd: Add new syscall to provide memory pin

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 07:58:15PM +0800, Zhou Wang wrote: > On 2021/2/9 17:37, Greg KH wrote: > > On Tue, Feb 09, 2021 at 05:17:46PM +0800, Zhou Wang wrote: > >> On 2021/2/8 6:02, Andy Lutomirski wrote: > >>> > >>> > >>>> On Feb 7, 2021

Re: [PATCHv2] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0

2021-02-09 Thread Greg KH
On Thu, Jan 28, 2021 at 09:38:12AM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > aligns with the firmware settings. > > Cc: # 5.9+ > Fixes: 36847f9e3e56 ("firmware: correct reconfig flag and timeout

Re: DMA direct mapping fix for 5.4 and earlier stable branches

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 10:19:07AM +, obayashi.yoshim...@socionext.com wrote: > > How do you judge "mature"? > > My basic criteria are > * Function is exist, but bug fix is necessary: "mature" > * Function extension is necessary: "immature" > > > And again, if a feature isn't present in a

Re: [GIT PULL] extcon next for v5.12

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 07:49:59PM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.12. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > Best Regards, > Chanwoo Choi I see the following error in this rep

Re: [PATCH v3] drivers/misc/vmw_vmci: restrict too big queue size in

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 03:45:25PM +0600, Sabyrzhan Tasbolatov wrote: > > syzbot found WARNING in qp_broker_alloc[1] in qp_host_alloc_queue() > > when num_pages is 0x11, giving queue_size + queue_page_size > > bigger than KMALLOC_MAX_SIZE for kzalloc(), resulting order >= MAX_ORDER > > conditio

Re: [PATCH v2] drivers/misc/vmw_vmci: restrict too big queue size in

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 03:31:01PM +0600, Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in qp_broker_alloc[1] in qp_host_alloc_queue() > when num_pages is 0x11, giving queue_size + queue_page_size > bigger than KMALLOC_MAX_SIZE for kzalloc(), resulting order >= MAX_ORDER > condition. > >

Re: [RFC PATCH v3 1/2] mempinfd: Add new syscall to provide memory pin

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 05:17:46PM +0800, Zhou Wang wrote: > On 2021/2/8 6:02, Andy Lutomirski wrote: > > > > > >> On Feb 7, 2021, at 12:31 AM, Zhou Wang wrote: > >> > >> SVA(share virtual address) offers a way for device to share process > >> virtual > >> address space safely, which makes mor

Re: DMA direct mapping fix for 5.4 and earlier stable branches

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 09:05:40AM +, obayashi.yoshim...@socionext.com wrote: > > > As the drivers are currently under development and Socionext has > > > chosen 5.4 stable kernel for their development. So I will let > > > Obayashi-san answer this if it's possible for them to migrate to 5.10 >

Re: [PATCH] drivers/misc/vmw_vmci: restrict too big queue size in qp_host_alloc_queue

2021-02-09 Thread Greg KH
On Sat, Feb 06, 2021 at 11:34:09AM +0600, Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in qp_broker_alloc[1] in qp_host_alloc_queue() > when num_pages is 0x11, giving queue_size + queue_page_size > bigger than KMALLOC_MAX_SIZE for kzalloc(), resulting order >= MAX_ORDER > condition. > >

Re: [GIT PULL] phy: second round of fixes for v5.11

2021-02-09 Thread Greg KH
On Fri, Feb 05, 2021 at 05:26:18PM +0530, Vinod Koul wrote: > Hello Greg, > > Please pull to receive few phy driver fixes for v5.11. > Apologies for sending them bit late. > > The following changes since commit d092bd9110494de3372722b317510b3692f1b2fe: > > phy: mediatek: allow compile-testing

Re: [git pull] habanalabs second pull request for kernel 5.12

2021-02-09 Thread Greg KH
On Mon, Feb 08, 2021 at 06:30:22PM +0200, Oded Gabbay wrote: > Hi Greg, > > This is habanalabs second pull request for the merge window of > kernel 5.12. > It contains important fixes, especially in the firmware-related code. > Details are in the tag. > > Thanks, > Oded > > The following changes

Re: [GIT PULL]: Linux-phy updates for v5.12

2021-02-09 Thread Greg KH
On Sun, Feb 07, 2021 at 11:19:07PM +0530, Vinod Koul wrote: > Hello Greg, > > Please pull to receive Linus-phy updates for v5.12 > > The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: > > Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) > > are available in the Git reposit

Re: [GIT PULL]: soundwire: updates for v5.12-rc1

2021-02-09 Thread Greg KH
On Sun, Feb 07, 2021 at 11:06:01PM +0530, Vinod Koul wrote: > Hello Greg, > > Please pull to receive update for v5.12-rc1. This update includes new > no_pm IO routines and bunch of updates for intel & cadence drivers. > > The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e

Re: [PATCH v2] mm: cma: support sysfs

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 10:34:51PM -0800, John Hubbard wrote: > On 2/8/21 10:27 PM, John Hubbard wrote: > > On 2/8/21 10:13 PM, Greg KH wrote: > > > On Mon, Feb 08, 2021 at 05:57:17PM -0800, John Hubbard wrote: > > > > On 2/8/21 3:36 PM, Minchan Kim wrote: > >

Re: [PATCH]: drivers: staging: most: Fixed styling issue.

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 11:53:11AM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. Why is this still an attached fil

Re: [PATCH v2] mm: cma: support sysfs

2021-02-08 Thread Greg KH
This should not be a pointer. By making it a pointer, you've added a > > > bunch of pointless > > > extra code to the implementation. > > > > Originally, I went with the object lifetime with struct cma as you > > suggested to make code simple. However, Gr

Re: [PATCH] staging: hikey9xx: fix checkpatch error and warning

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 11:27:04AM +0530, Atul Gopinathan wrote: > Fix the following types of checkpatch error and warning: > > ERROR: code indent should use tabs where possible > WARNING: struct phy_ops should normally be const That is 2 different things, which means this should be 2 different p

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning, o

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 11:58:02PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > > This patch fixes a warning, o

Re: [PATCH]: checkpatch: Fixed styling issue

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:36:14PM +0530, Mukul Mehar wrote: > >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001 > From: Mukul Mehar > Date: Mon, 8 Feb 2021 01:03:06 +0530 > Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue. > Signed-off-by: Mukul Mehar > >

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-08 Thread Greg KH
On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > Hi Greg, > > On 2021/2/5 17:53, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > >> From: Junhao He > >> > >> Use subdir-ccflags-* instead of ccflags-* to in

Re: [PATCH] kbuild: simplify access to the kernel's version

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote: > Instead of storing the version in a single integer and having various > kernel (and userspace) code how it's constructed, export individual > (major, patchlevel, sublevel) components and simplify kernel code that > uses it. > > This sh

Re: [96e8740] [PATCH 2/2] Staging: wimax: i2400m: some readability improvements.

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 10:11:24PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Hello, developers! > Sorry for the late answer. As you know - i am a newbie and it is my first > kernel patch. > After reading kernelnewbies.or, ./Documentation/process/ files and viewing > FOSDEM's vi

Re: [PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
; Signed-off-by: Phillip Potter > --- > > v2: Modified changelog to take account of feedback from Greg KH. > > drivers/staging/octeon/ethernet-mdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet-mdio.c >

Re: [PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 03:03:02PM +, Phillip Potter wrote: > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > to strscpy calls. As return values were not checked for these three > calls before, change should be safe as functionality is equivalent. > > Signed-off-by: Ph

Re: [PATCH] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:48:04PM +, Phillip Potter wrote: > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > to strscpy calls. Fixes a style warning. Is it really safe to do this type of conversion here? If so, you need to provide evidence of it in the changelog, oth

Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 07:39:28PM +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta >

Re: [PATCH v3] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:29:12PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

Re: [PATCH v2] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:16:58PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

<    3   4   5   6   7   8   9   10   11   12   >